react-native-fast-image 8.18.0 → 8.18.2

package/README.md

@@ -91,21 +91,6 @@ const YourImage = () => (
 
 - [Are you using Glide already using an AppGlideModule?](docs/app-glide-module.md) (you might have problems if you don't read this)
 
-## Are you using Proguard?
-
-If you use Proguard you will need to add these lines to `android/app/proguard-rules.pro`:
-
-```
--keep public class com.dylanvann.fastimage.* {*;}
--keep public class com.dylanvann.fastimage.** {*;}
--keep public class * implements com.bumptech.glide.module.GlideModule
--keep public class * extends com.bumptech.glide.module.AppGlideModule
--keep public enum com.bumptech.glide.load.ImageHeaderParser$** {
-  **[] $VALUES;
-  public *;
-}
-```
-
 ## Properties
 
 ### `source?: object`

package/android/build.gradle

@@ -35,6 +35,8 @@ android {
         targetSdkVersion safeExtGet('targetSdkVersion', 28)
         versionCode 1
         versionName "1.0"
+        // Applied to the app's release build, so apps don't need to add them.
+        consumerProguardFiles 'consumer-rules.pro'
     }
     sourceSets {
         main {
@@ -68,6 +70,7 @@ repositories {
     mavenCentral()
 }
 
+// When changing the default, revisit the Glide rules in consumer-rules.pro.
 def glideVersion = safeExtGet('glideVersion', '4.12.0')
 
 dependencies {

package/android/consumer-rules.pro

@@ -0,0 +1,43 @@
+# ProGuard/R8 rules for apps that use FastImage: the Android Gradle plugin
+# applies them to the app's release build (consumerProguardFiles in
+# build.gradle), so apps don't need to copy them.
+
+# FastImage's classes: its view manager, native module, Glide modules and
+# events.
+-keep public class com.dylanvann.fastimage.* {*;}
+-keep public class com.dylanvann.fastimage.** {*;}
+
+# The Glide rules below cover what Glide's own rules (its library's
+# proguard-rules.txt) didn't at the version FastImage uses by default
+# (glideVersion in build.gradle, 4.12.0) and older ones apps may pick. When
+# updating Glide, revisit which are still needed: whether Glide's rules now
+# keep modules' constructors, and whether its integrations still register
+# old-style modules in their manifests (the OkHttp integration's
+# OkHttpGlideModule still did in 5.0.9).
+
+# Glide's modules and their constructors: FastImage's, the one Glide
+# generates from them, and old-style modules Glide finds in the app's manifest
+# and creates by reflection (e.g. its OkHttp integration's OkHttpGlideModule,
+# which FastImage uses). R8's full mode (the default from the Android Gradle
+# plugin 8.0) removes a constructor a rule doesn't name, and Glide then
+# crashes when it starts ("Unable to instantiate GlideModule implementation").
+-keep public class * implements com.bumptech.glide.module.GlideModule {
+  <init>();
+}
+-keep public class * extends com.bumptech.glide.module.AppGlideModule {
+  <init>(...);
+}
+
+# Glide's image header types.
+-keep public enum com.bumptech.glide.load.ImageHeaderParser$** {
+  **[] $VALUES;
+  public *;
+}
+
+# React Native's event dispatcher, which FastImage looks up by name
+# (FastImageEvents), so it still compiles against React Native 0.60-0.62,
+# which don't have it. R8 would rename it, and on the New Architecture every
+# event (onLoad, onError, ...) would then be dropped.
+-keep class com.facebook.react.uimanager.UIManagerHelper {
+  public static *** getEventDispatcherForReactTag(com.facebook.react.bridge.ReactContext, int);
+}

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "react-native-fast-image",
-    "version": "8.18.0",
+    "version": "8.18.2",
     "description": "🚩 FastImage, performant React Native image component.",
     "keywords": [
         "cache",
@@ -24,6 +24,7 @@
     "typings": "dist/index.d.ts",
     "files": [
         "android/build.gradle",
+        "android/consumer-rules.pro",
         "android/src/main",
         "ios/FastImage",
         "ios/FastImage.xcodeproj/project.pbxproj",