react-native-fast-image 10.8.1 → 10.8.2

package/android/src/main/java/com/fastimage/FastImageEvents.java

@@ -1,5 +1,8 @@
 package com.fastimage;
 
+import android.os.Handler;
+import android.os.Looper;
+
 import com.facebook.react.bridge.Arguments;
 import com.facebook.react.bridge.ReactContext;
 import com.facebook.react.bridge.WritableMap;
@@ -15,6 +18,8 @@ final class FastImageEvents {
     static final int ERROR = 1 << 3;
     static final int LOAD_END = 1 << 4;
 
+    private static final Handler MAIN = new Handler(Looper.getMainLooper());
+
     private FastImageEvents() {
     }
 
@@ -57,8 +62,21 @@ final class FastImageEvents {
         send(view, FastImageRequestListener.REACT_ON_LOAD_END_EVENT, event);
     }
 
-    // Only the events JS has a handler for: most images have none.
+    // Only the events JS has a handler for: most images have none. Posted to
+    // the main thread rather than dispatched here: this is called from Glide's
+    // onResourceReady and onLoadFailed, and EventDispatcher calls its listeners
+    // inline. Reanimated's listener flushes pending mount items, which can
+    // drop this view, and the drop clears the request inside its own
+    // callback, which Glide doesn't allow (it throws). One Handler keeps the
+    // events in order.
     static void send(FastImageViewWithUrl view, String name, WritableMap data) {
+        if (!view.handles(bit(name))) return;
+        MAIN.post(() -> dispatch(view, name, data));
+    }
+
+    // Dispatches the event now: for callers on the main thread outside Glide's
+    // callbacks (e.g. progress, which is posted already).
+    static void dispatch(FastImageViewWithUrl view, String name, WritableMap data) {
         if (!view.handles(bit(name))) return;
         ReactContext context = FastImageViewManager.getReactContext(view.getContext());
         if (context == null) return;

package/android/src/main/java/com/fastimage/FastImageViewManager.java

@@ -555,7 +555,7 @@ class FastImageViewManager extends SimpleViewManager<FastImageViewWithUrl>
             // Downloads only report a known length (see FastImageSharedDownloads).
             event.putDouble("progress", Math.min(1.0, Math.max(0.0, (double) loaded / total)));
             try {
-                FastImageEvents.send(view, REACT_ON_PROGRESS_EVENT, event);
+                FastImageEvents.dispatch(view, REACT_ON_PROGRESS_EVENT, event);
             } catch (RuntimeException e) {
                 // E.g. the view's React instance is gone: progress isn't worth
                 // crashing the app for.

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "react-native-fast-image",
-    "version": "10.8.1",
+    "version": "10.8.2",
     "description": "FastImage, performant React Native image component.",
     "keywords": [
         "cache",