react-native-external-keyboard 0.8.0 → 0.8.1

package/README.md

@@ -506,6 +506,37 @@ The map of aliases is provided below: <br />
 `KeyboardFocusView` -> `KeyboardExtendedView` <br />
 `ExternalKeyboardView` -> `KeyboardExtendedBaseView` <br />
 
+# Migration 0.7.x to 0.8.0
+
+React and React Native packages have been updated in `react-native-external-keyboard@0.8.0`.
+
+Unfortunately, the latest React Native versions (0.83.x and 0.84.x) have different types compared to previous versions, and the Pressable as well as KeyboardExtendedPressable props could be incompatible with local types because they have static TypeScript declarations based on the React Native 0.83.4 dependency.
+
+In some cases, you may experience the following TypeScript problem:
+<img width="759" height="81" alt="image" src="https://github.com/user-attachments/assets/d47992ce-d3df-473b-bd96-5f2ba53ab889" />
+
+
+It can be resolved by using a HOC, as it provides dynamic typing.
+```tsx
+const KeyboardPressable = withKeyboardFocus(Pressable)
+
+export const K = (props: PressableProps) => {
+  return <KeyboardPressable {...props} />;
+}
+```
+
+As well, it could be resolved by component redeclaration:
+```ts
+export {};
+
+declare module 'react-native-external-keyboard' {
+    import type { PressableProps, ViewProps } from 'react-native';
+    import type { WithKeyboardFocusDeclaration } from 'react-native-external-keyboard/lib/typescript/src/types/WithKeyboardFocus';
+
+    export const Pressable: WithKeyboardFocusDeclaration<PressableProps, ViewProps['style']>
+    export const KeyboardExtendedPressable: WithKeyboardFocusDeclaration<PressableProps, ViewProps['style']>
+}
+```
 
 # API
 ToDo

package/ios/Views/RNCEKVExternalKeyboardView/Helpers/RNCEKVFabricEventHelper/RNCEKVFabricEventHelper.mm

@@ -21,7 +21,8 @@ using namespace facebook::react;
 + (void)onKeyDownPressEventEmmiter:(NSDictionary*) dictionary withEmitter:(facebook::react::SharedViewEventEmitter) _eventEmitter {
     if (_eventEmitter) {
         auto viewEventEmitter = std::static_pointer_cast<ExternalKeyboardViewEventEmitter const>(_eventEmitter);
-        
+
+        NSString* unicodeChar = [dictionary valueForKey:@"unicodeChar"];
         facebook::react::ExternalKeyboardViewEventEmitter::OnKeyDownPress data = {
             .keyCode = [[dictionary valueForKey:@"keyCode"] intValue],
             .isLongPress = [[dictionary valueForKey:@"isLongPress"] boolValue],
@@ -31,7 +32,7 @@ using namespace facebook::react;
             .isCapsLockOn = [[dictionary valueForKey:@"isCapsLockOn"] boolValue],
             .hasNoModifiers = [[dictionary valueForKey:@"hasNoModifiers"] boolValue],
             .unicode = [[dictionary valueForKey:@"unicode"] intValue],
-            .unicodeChar = [[[dictionary valueForKey:@"unicodeChar"] stringValue] UTF8String],
+            .unicodeChar = [unicodeChar UTF8String],
         };
         viewEventEmitter->onKeyDownPress(data);
     };
@@ -40,7 +41,8 @@ using namespace facebook::react;
 + (void)onKeyUpPressEventEmmiter:(NSDictionary*) dictionary withEmitter:(facebook::react::SharedViewEventEmitter) _eventEmitter {
     if (_eventEmitter) {
         auto viewEventEmitter = std::static_pointer_cast<ExternalKeyboardViewEventEmitter const>(_eventEmitter);
-        
+
+        NSString* unicodeChar = [dictionary valueForKey:@"unicodeChar"];
         facebook::react::ExternalKeyboardViewEventEmitter::OnKeyUpPress data = {
             .keyCode = [[dictionary valueForKey:@"keyCode"] intValue],
             .isLongPress = [[dictionary valueForKey:@"isLongPress"] boolValue],
@@ -50,7 +52,7 @@ using namespace facebook::react;
             .isCapsLockOn = [[dictionary valueForKey:@"isCapsLockOn"] boolValue],
             .hasNoModifiers = [[dictionary valueForKey:@"hasNoModifiers"] boolValue],
             .unicode = [[dictionary valueForKey:@"unicode"] intValue],
-            .unicodeChar = [[[dictionary valueForKey:@"unicodeChar"] stringValue] UTF8String],
+            .unicodeChar = [unicodeChar UTF8String],
         };
         viewEventEmitter->onKeyUpPress(data);
     };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-native-external-keyboard",
-  "version": "0.8.0",
+  "version": "0.8.1",
   "description": "Toolkit for improving physical keyboard support in React Native",
   "main": "lib/commonjs/index",
   "module": "lib/module/index",