react-native-external-keyboard 0.7.0 → 0.7.2

package/README.md

@@ -22,7 +22,7 @@ iOS | Android
 
 | iOS | Android |
 | :-- | :-- |
-| <img src="/.github/images/rnek-focus-lock-ios.gif" height="500" /> |  <img src="/.github/images/rnek-focus-lock-ios.gif" height="500" />  |
+| <img src="/.github/images/rnek-focus-lock-ios.gif" height="500" /> |  <img src="/.github/images/rnek-focus-lock-android.gif" height="500" />  |
 
 > A new type of focus lock functionality has been introduced, featuring two new components: `Focus.Frame` and `Focus.Trap`. These components help manage and lock focus within specific areas of the screen.
 

package/android/src/main/java/com/externalkeyboard/views/ExternalKeyboardView/ExternalKeyboardView.java

@@ -154,20 +154,20 @@ public class ExternalKeyboardView extends ReactViewGroup {
 
     if (direction == FOCUS_FORWARD && orderForward != null) {
       View nextView = this.focusOrderDelegate.getLink(orderForward);
-      if (nextView != null) {
+      if (isValidLinkedFocusTarget(nextView)) {
         return nextView;
       }
     }
 
     if (direction == FOCUS_BACKWARD && orderBackward != null) {
       View prevView = this.focusOrderDelegate.getLink(orderBackward);
-      if (prevView != null) {
+      if (isValidLinkedFocusTarget(prevView)) {
         return prevView;
       }
     }
 
-    if(ReactNativeVersionChecker.isReactNative80OrLater()) {
-      if(orderGroup != null && orderIndex != null && (direction == FOCUS_FORWARD || direction == FOCUS_BACKWARD)){
+    if (ReactNativeVersionChecker.isReactNative80OrLater()) {
+      if (orderGroup != null && orderIndex != null && (direction == FOCUS_FORWARD || direction == FOCUS_BACKWARD)) {
         return FocusFinder.getInstance().findNextFocus((ViewGroup) this.getParent(), focused, direction);
       }
     }
@@ -292,6 +292,22 @@ public class ExternalKeyboardView extends ReactViewGroup {
     return focusableView != null ? focusableView : this;
   }
 
+  private boolean isValidLinkedFocusTarget(View target) {
+    if (target == null || !target.isAttachedToWindow() || !this.isAttachedToWindow()) {
+      return false;
+    }
+
+    if (target.getWindowToken() == null || this.getWindowToken() == null) {
+      return false;
+    }
+
+    if (target.getWindowToken() != this.getWindowToken()) {
+      return false;
+    }
+
+    return target.getRootView() == this.getRootView();
+  }
+
   public void setCanBeFocused(boolean canBeFocused) {
     int descendantFocusability = canBeFocused ? ViewGroup.FOCUS_BEFORE_DESCENDANTS : ViewGroup.FOCUS_BLOCK_DESCENDANTS;
     this.setDescendantFocusability(descendantFocusability);

package/ios/Views/RNCEKVExternalKeyboardView/Helpers/RNCEKVFabricEventHelper/RNCEKVFabricEventHelper.mm

@@ -21,7 +21,8 @@ using namespace facebook::react;
 + (void)onKeyDownPressEventEmmiter:(NSDictionary*) dictionary withEmitter:(facebook::react::SharedViewEventEmitter) _eventEmitter {
     if (_eventEmitter) {
         auto viewEventEmitter = std::static_pointer_cast<ExternalKeyboardViewEventEmitter const>(_eventEmitter);
-        
+
+        NSString* unicodeChar = [dictionary valueForKey:@"unicodeChar"];
         facebook::react::ExternalKeyboardViewEventEmitter::OnKeyDownPress data = {
             .keyCode = [[dictionary valueForKey:@"keyCode"] intValue],
             .isLongPress = [[dictionary valueForKey:@"isLongPress"] boolValue],
@@ -31,7 +32,7 @@ using namespace facebook::react;
             .isCapsLockOn = [[dictionary valueForKey:@"isCapsLockOn"] boolValue],
             .hasNoModifiers = [[dictionary valueForKey:@"hasNoModifiers"] boolValue],
             .unicode = [[dictionary valueForKey:@"unicode"] intValue],
-            .unicodeChar = [[[dictionary valueForKey:@"unicodeChar"] stringValue] UTF8String],
+            .unicodeChar = [unicodeChar UTF8String],
         };
         viewEventEmitter->onKeyDownPress(data);
     };
@@ -40,7 +41,8 @@ using namespace facebook::react;
 + (void)onKeyUpPressEventEmmiter:(NSDictionary*) dictionary withEmitter:(facebook::react::SharedViewEventEmitter) _eventEmitter {
     if (_eventEmitter) {
         auto viewEventEmitter = std::static_pointer_cast<ExternalKeyboardViewEventEmitter const>(_eventEmitter);
-        
+
+        NSString* unicodeChar = [dictionary valueForKey:@"unicodeChar"];
         facebook::react::ExternalKeyboardViewEventEmitter::OnKeyUpPress data = {
             .keyCode = [[dictionary valueForKey:@"keyCode"] intValue],
             .isLongPress = [[dictionary valueForKey:@"isLongPress"] boolValue],
@@ -50,7 +52,7 @@ using namespace facebook::react;
             .isCapsLockOn = [[dictionary valueForKey:@"isCapsLockOn"] boolValue],
             .hasNoModifiers = [[dictionary valueForKey:@"hasNoModifiers"] boolValue],
             .unicode = [[dictionary valueForKey:@"unicode"] intValue],
-            .unicodeChar = [[[dictionary valueForKey:@"unicodeChar"] stringValue] UTF8String],
+            .unicodeChar = [unicodeChar UTF8String],
         };
         viewEventEmitter->onKeyUpPress(data);
     };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-native-external-keyboard",
-  "version": "0.7.0",
+  "version": "0.7.2",
   "description": "Toolkit for improving physical keyboard support in React Native",
   "main": "lib/commonjs/index",
   "module": "lib/module/index",