react-native-enriched-markdown-scaffold 0.7.4-scaffold.4 → 0.7.4-scaffold.5

package/android/src/main/java/com/swmansion/enriched/markdown/spans/LineHeightSpan.kt

@@ -1,6 +1,8 @@
 package com.swmansion.enriched.markdown.spans
 
 import android.graphics.Paint
+import android.text.Spanned
+import android.text.style.ReplacementSpan
 import kotlin.math.ceil
 import kotlin.math.floor
 import android.text.style.LineHeightSpan as AndroidLineHeightSpan
@@ -18,10 +20,34 @@ class LineHeightSpan(
     v: Int,
     fm: Paint.FontMetricsInt?,
   ) {
-    if (fm == null) return
+    if (fm == null || lineHeight <= 0) return
 
     val leading = lineHeight - ((-fm.ascent) + fm.descent)
+
+    // A ReplacementSpan on this line — inline math, or the placeholder MeasurementStore
+    // swaps in to measure it off the main thread — reports its own metrics from getSize().
+    // Shrinking those back down to the configured line height cuts the line box below what
+    // the span actually draws, and can drive descent negative so the next line starts above
+    // this one's baseline. Those lines are expanded only, never compressed; every other line
+    // keeps the exact clamp it had before. The lookup only runs on the rare negative-leading
+    // path, so the common case stays allocation-free.
+    if (leading <= 0 && hasSelfMeasuringSpan(text, start, end)) return
+
     fm.ascent -= ceil(leading / 2.0f).toInt()
     fm.descent += floor(leading / 2.0f).toInt()
   }
+
+  /**
+   * Images are excluded on purpose. Block images already keep this span off their range via
+   * `applyLineHeightSkippingImages`, and inline ones never touch the metrics at all, so
+   * letting them through here would change image layout instead of math layout.
+   */
+  private fun hasSelfMeasuringSpan(
+    text: CharSequence?,
+    start: Int,
+    end: Int,
+  ): Boolean {
+    val spanned = text as? Spanned ?: return false
+    return spanned.getSpans(start, end, ReplacementSpan::class.java).any { it !is ImageSpan }
+  }
 }

package/ios/renderer/ListItemRenderer.m

@@ -109,15 +109,18 @@ NSString *const TaskIndexAttribute = @"TaskIndex";
                     style.firstLineHeadIndent = totalIndent;
                     style.headIndent = totalIndent;
 
-                    if (lineHeightConfig > 0) {
-                      style.minimumLineHeight = lineHeightConfig;
-                      style.maximumLineHeight = lineHeightConfig;
-                    }
-
                     NSMutableDictionary *attributesToApply = [metadata mutableCopy];
                     attributesToApply[NSParagraphStyleAttributeName] = style;
 
                     [output addAttributes:attributesToApply range:range];
+
+                    // Line height goes through the shared helper so list items get the same math
+                    // carve-out as paragraphs. Setting maximumLineHeight here directly would clamp
+                    // the line fragment below the height an inline math attachment draws at, and the
+                    // overflow paints over the neighbouring lines. applyLineHeight reads back the
+                    // paragraph style we just applied, so the indents above survive, and it
+                    // early-returns on a non-positive line height like the old guard did.
+                    applyLineHeight(output, range, lineHeightConfig);
                   }];
 
   if (isTask && isChecked) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-native-enriched-markdown-scaffold",
-  "version": "0.7.4-scaffold.4",
+  "version": "0.7.4-scaffold.5",
   "description": "Markdown Text component for React Native",
   "main": "./lib/module/index",
   "module": "./lib/module/index",