react-native-drum-picker 0.1.2 → 0.1.4

package/CHANGELOG.md

@@ -9,6 +9,18 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 _No changes yet._
 
+## [0.1.4] - 2026-05-22
+
+### Fixed
+
+- Fixed a crash during screen unmount/navigation by avoiding unsafe RecyclerView cleanup in `onDetachedFromWindow` (`adapter = null`, `clearOnScrollListeners`, SnapHelper detach during react-native-screens transitions).
+- Prevented `onChange` events from dispatching after the view is detached.
+- Fixed Android Kotlin compilation on React Native 0.81+ by dispatching Fabric events with `UIManagerType.FABRIC`.
+
+### Documentation
+
+- Added compatibility and troubleshooting notes for React Native 0.81+, Expo SDK 54, Expo Go, and navigation crashes.
+
 ## [0.1.2] - 2026-05-22
 
 ### Fixed
@@ -51,7 +63,8 @@ First release on [npm](https://www.npmjs.com/package/react-native-drum-picker).
 
 Initial GitHub release. See [v0.0.1](https://github.com/scrollDynasty/react-native-drum-picker/releases/tag/v0.0.1).
 
-[Unreleased]: https://github.com/scrollDynasty/react-native-drum-picker/compare/v0.1.2...HEAD
+[Unreleased]: https://github.com/scrollDynasty/react-native-drum-picker/compare/v0.1.4...HEAD
+[0.1.4]: https://github.com/scrollDynasty/react-native-drum-picker/releases/tag/v0.1.4
 [0.1.2]: https://github.com/scrollDynasty/react-native-drum-picker/releases/tag/v0.1.2
 [0.1.1]: https://github.com/scrollDynasty/react-native-drum-picker/releases/tag/v0.1.1
 [0.1.0]: https://github.com/scrollDynasty/react-native-drum-picker/compare/v0.0.1...v0.1.0

package/README.md

@@ -60,6 +60,30 @@ npx react-native run-android
 
 Requires **React Native 0.76+** with the **New Architecture** enabled.
 
+## Compatibility
+
+| Environment | Status |
+|-------------|--------|
+| React Native New Architecture | **Required** |
+| Fabric | **Required** |
+| Android | Supported |
+| iOS | Not supported yet |
+| Expo SDK 54 | Supported via **prebuild** / development build |
+| React Native 0.81+ | Supported |
+| Expo Go | **Not supported** (native module) |
+
+This package is an **Android Fabric View** library. New Architecture must be enabled (`newArchEnabled: true` in Expo, or equivalent in bare React Native).
+
+Recommended: **React Native >= 0.76**. Use a **development build** or `expo run:android` after `expo prebuild` — not Expo Go.
+
+### React Native 0.81+ event dispatch
+
+If Android Kotlin compile fails with:
+
+`No value passed for parameter 'uiManagerType'`
+
+upgrade to a release that dispatches Fabric events with `UIManagerType.FABRIC` (0.1.3+).
+
 ## Basic usage
 
 ```tsx
@@ -225,6 +249,29 @@ Use an **odd** `visibleItemCount` (e.g. `5`) for a symmetric wheel.
 | Empty or white picker | Enable New Architecture; set explicit `width` / `height` in `style` |
 | Props not applied | Rebuild app after native changes; run `yarn build` in the library before packing |
 | iOS | Not supported — Android only |
+| Expo Go | Use prebuild + dev build; this library is not in Expo Go |
+| RN 0.81 `uiManagerType` compile error | Upgrade to 0.1.3+ |
+| Crash when leaving a screen | Upgrade to 0.1.4+ (safe `onDetachedFromWindow` with react-native-screens) |
+
+### Android build fails in Expo / React Native 0.81+
+
+```sh
+cd android
+./gradlew clean
+```
+
+Windows:
+
+```sh
+cd android
+.\gradlew clean
+```
+
+Then rebuild the native app (`npx expo run:android` or `npx react-native run-android`).
+
+### Crash when leaving a screen
+
+If the app crashes when navigating away from a screen with `DrumPicker` (especially with `react-native-screens` transitions), upgrade to **0.1.4+**, which avoids unsafe RecyclerView cleanup during `onDetachedFromWindow`.
 
 **New Architecture:** This library is a Fabric view. Ensure New Architecture is enabled in your app (required for RN 0.76+).
 

package/android/src/main/java/com/drumpicker/DrumPickerView.kt

@@ -13,6 +13,7 @@ import com.facebook.react.bridge.ReadableArray
 import com.facebook.react.bridge.ReadableType
 import com.facebook.react.bridge.ReactContext
 import com.facebook.react.uimanager.UIManagerHelper
+import com.facebook.react.uimanager.common.UIManagerType
 import com.facebook.react.uimanager.events.EventDispatcher
 import kotlin.math.abs
 
@@ -47,13 +48,14 @@ class DrumPickerView @JvmOverloads constructor(
   private var selectionIndicatorHeightPx = dpToPx(selectionIndicatorHeightDp)
   private var lastEmittedIndex = -1
   private var suppressChangeEvent = false
-  private var isDetached = false
+  private var isAttachedToWindow = false
+  private var isDisposed = false
   private var styleUpdatePosted = false
 
   private val styleUpdateRunnable =
     Runnable {
       styleUpdatePosted = false
-      if (!isDetached) {
+      if (isLifecycleActive()) {
         updateVisibleItemStyles()
       }
     }
@@ -61,14 +63,14 @@ class DrumPickerView @JvmOverloads constructor(
   private val scrollListener =
     object : RecyclerView.OnScrollListener() {
       override fun onScrolled(recyclerView: RecyclerView, dx: Int, dy: Int) {
-        if (isDetached) {
+        if (!isLifecycleActive()) {
           return
         }
         scheduleVisibleItemStyleUpdate()
       }
 
       override fun onScrollStateChanged(recyclerView: RecyclerView, newState: Int) {
-        if (isDetached) {
+        if (!isLifecycleActive()) {
           return
         }
         when (newState) {
@@ -241,25 +243,27 @@ class DrumPickerView @JvmOverloads constructor(
 
   override fun onAttachedToWindow() {
     super.onAttachedToWindow()
-    isDetached = false
-    if (recyclerView.adapter == null) {
-      recyclerView.adapter = adapter
-    }
-    snapHelper.attachToRecyclerView(recyclerView)
+    isAttachedToWindow = true
+    isDisposed = false
+    recyclerView.removeOnScrollListener(scrollListener)
     recyclerView.addOnScrollListener(scrollListener)
   }
 
   override fun onDetachedFromWindow() {
-    isDetached = true
-    recyclerView.removeCallbacks(styleUpdateRunnable)
+    isAttachedToWindow = false
+    isDisposed = true
     styleUpdatePosted = false
+    recyclerView.removeCallbacks(styleUpdateRunnable)
     removeCallbacks(null)
-    recyclerView.clearOnScrollListeners()
-    snapHelper.attachToRecyclerView(null)
-    recyclerView.adapter = null
+    recyclerView.removeCallbacks(null)
+    recyclerView.removeOnScrollListener(scrollListener)
+    // Do not null adapter or detach SnapHelper here — react-native-screens may
+    // detach during transitions while RecyclerView is still laying out/scrolling.
     super.onDetachedFromWindow()
   }
 
+  private fun isLifecycleActive(): Boolean = isAttachedToWindow && !isDisposed
+
   fun setSelectedIndex(index: Int) {
     if (items.isEmpty()) {
       selectedIndex = index.coerceAtLeast(0)
@@ -388,7 +392,7 @@ class DrumPickerView @JvmOverloads constructor(
   }
 
   private fun scrollToSelectedIndex(animated: Boolean, emit: Boolean) {
-    if (isDetached || items.isEmpty()) {
+    if (!isLifecycleActive() || items.isEmpty()) {
       return
     }
     suppressChangeEvent = !emit
@@ -400,7 +404,7 @@ class DrumPickerView @JvmOverloads constructor(
 
     layoutManager.scrollToPositionWithOffset(index, 0)
     recyclerView.post {
-      if (isDetached) {
+      if (!isLifecycleActive()) {
         return@post
       }
       updateVisibleItemStyles()
@@ -414,11 +418,11 @@ class DrumPickerView @JvmOverloads constructor(
   }
 
   private fun runWhenAttached(block: () -> Unit) {
-    if (isDetached) {
+    if (!isLifecycleActive()) {
       return
     }
     post {
-      if (isDetached) {
+      if (!isLifecycleActive()) {
         return@post
       }
       block()
@@ -426,7 +430,7 @@ class DrumPickerView @JvmOverloads constructor(
   }
 
   private fun updateCenterFromSnap() {
-    if (isDetached || items.isEmpty()) {
+    if (!isLifecycleActive() || items.isEmpty()) {
       return
     }
     val centerIndex = findSnapCenterIndex()
@@ -448,7 +452,7 @@ class DrumPickerView @JvmOverloads constructor(
   }
 
   private fun scheduleVisibleItemStyleUpdate() {
-    if (styleUpdatePosted || isDetached) {
+    if (styleUpdatePosted || !isLifecycleActive()) {
       return
     }
     styleUpdatePosted = true
@@ -466,7 +470,7 @@ class DrumPickerView @JvmOverloads constructor(
   }
 
   private fun updateVisibleItemStyles() {
-    if (isDetached || recyclerView.height == 0 || itemHeightPx <= 0) {
+    if (!isLifecycleActive() || recyclerView.height == 0 || itemHeightPx <= 0) {
       return
     }
 
@@ -483,7 +487,7 @@ class DrumPickerView @JvmOverloads constructor(
   }
 
   private fun maybeEmitChange(index: Int) {
-    if (isDetached || suppressChangeEvent || items.isEmpty()) {
+    if (!isLifecycleActive() || suppressChangeEvent || items.isEmpty()) {
       return
     }
     if (index < 0 || index >= items.size) {
@@ -499,7 +503,12 @@ class DrumPickerView @JvmOverloads constructor(
     selectedIndex = clamped
 
     val reactContext = context as? ReactContext ?: return
-    val dispatcher: EventDispatcher? = UIManagerHelper.getEventDispatcher(reactContext)
+    if (!reactContext.hasActiveReactInstance()) {
+      return
+    }
+    // Fabric-only: RN 0.81+ requires uiManagerType when resolving the event dispatcher.
+    val dispatcher: EventDispatcher? =
+      UIManagerHelper.getEventDispatcher(reactContext, UIManagerType.FABRIC)
     dispatcher?.dispatchEvent(
       DrumPickerChangeEvent(
         UIManagerHelper.getSurfaceId(reactContext),

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-native-drum-picker",
-  "version": "0.1.2",
+  "version": "0.1.4",
   "description": "Android-native iOS-style drum/wheel picker for React Native (Fabric)",
   "main": "./lib/module/index.js",
   "module": "./lib/module/index.js",
@@ -101,8 +101,8 @@
     "typescript": "^6.0.2"
   },
   "peerDependencies": {
-    "react": ">=18.0.0",
-    "react-native": ">=0.76.0"
+    "react": "*",
+    "react-native": ">=0.76"
   },
   "workspaces": [
     "example"