react-native-debug-toolkit 3.3.2 → 3.3.4

package/ios/DebugToolkitDevConnect.mm

@@ -1,87 +1,187 @@
+#import "DebugToolkitDevConnect.h"
+
 #import <Foundation/Foundation.h>
+#import <UIKit/UIKit.h>
 #import <React/RCTBridge.h>
 #import <React/RCTBundleManager.h>
 #import <React/RCTBridgeModule.h>
 #import <React/RCTBundleURLProvider.h>
-#import <React/RCTDefines.h>
 #import <React/RCTReloadCommand.h>
 #import <objc/runtime.h>
 #include <ifaddrs.h>
 #include <arpa/inet.h>
 #include <net/if.h>
 
-static NSString *const DebugToolkitBundleRoot = @"index";
-static NSString *const kDevConnectMetroHost = @"_devconnect_metro_host";
-static NSString *const kDevConnectDiagLog = @"_devconnect_diag_log";
+// Debug-only Metro host switching — zero host-app native changes required.
+//
+// RN/Expo Debug templates call jsBundleURLForBundleRoot:fallbackURLProvider:, which consults
+// -packagerServerHostPort (guessPackagerHost on simulator when Metro is running). We only hook
+// jsBundleURLForBundleRoot:fallbackURLProvider: so no DevConnect host starts from main.jsbundle.
+// Persisted DevConnect hosts still flow through RCTBundleURLProvider, preserving RN's reachability
+// and fallback behavior when a saved Metro host is stale.
+//
+// Optional: host apps may call DebugToolkitMetroBundleURL() from bundleURL() for explicit control.
+
+static NSString *const kBundleRoot = @"index";
+// Expo prebuild templates pass this to jsBundleURLForBundleRoot: in Debug (see expo/expo#21643).
+static NSString *const kExpoVirtualMetroEntry = @".expo/.virtual-metro-entry";
+static NSString *const kMetroHostKey = @"_devconnect_metro_host";
+
+static BOOL gBundleRootHookInstalled = NO;
+
+static NSURL *(*gOrigJsBundleURLForBundleRootWithFallback)(id, SEL, NSString *, NSURL * _Nonnull (^)(void));
 
-// Forward-declared so appendDiag can reference them before the definitions below.
-static IMP original_sourceURLForBridge;
-static BOOL swizzleInvoked;
+static BOOL DevConnectEmbeddedFirstHooksActive(void)
+{
+  return gBundleRootHookInstalled;
+}
 
-static void appendDiag(NSString *stage, NSString *detail)
+static NSURL *DebugToolkitEmbeddedBundleURL(void)
 {
-  NSString *msg = [NSString stringWithFormat:@"[%@] %@ | installed=%@ invoked=%@",
-                   stage, detail,
-                   original_sourceURLForBridge ? @"YES" : @"NO",
-                   swizzleInvoked ? @"YES" : @"NO"];
-  NSMutableArray *log = [[[NSUserDefaults standardUserDefaults] arrayForKey:kDevConnectDiagLog] mutableCopy]
-                        ?: [NSMutableArray new];
-  [log addObject:msg];
-  if (log.count > 30) [log removeObjectAtIndex:0];
-  [[NSUserDefaults standardUserDefaults] setObject:[log copy] forKey:kDevConnectDiagLog];
-  [[NSUserDefaults standardUserDefaults] synchronize];
-  NSLog(@"[DevConnect] diag: %@", msg);
+  return [[NSBundle mainBundle] URLForResource:@"main" withExtension:@"jsbundle"];
 }
 
-#pragma mark - AppDelegate Swizzling
+static NSString *DevConnectPersistedMetroHost(void)
+{
+  return [[NSUserDefaults standardUserDefaults] stringForKey:kMetroHostKey];
+}
 
-static NSURL *devconnect_sourceURLForBridge(id self, SEL _cmd, RCTBridge *bridge)
+static void DevConnectSetPersistedMetroHost(NSString *_Nullable hostPort)
 {
-  swizzleInvoked = YES;
-  NSString *metroHost = [[NSUserDefaults standardUserDefaults] stringForKey:kDevConnectMetroHost];
-  if (metroHost.length > 0) {
-    NSString *urlStr = [NSString stringWithFormat:
-        @"http://%@/%@.bundle?platform=ios&dev=true&minify=false&lazy=true", metroHost, DebugToolkitBundleRoot];
-    NSURL *url = [NSURL URLWithString:urlStr];
-    appendDiag(@"swizzle-called", [NSString stringWithFormat:@"host=%@ url=%@", metroHost, url]);
-    return url;
+  NSUserDefaults *defaults = [NSUserDefaults standardUserDefaults];
+  if (hostPort.length > 0) {
+    [defaults setObject:hostPort forKey:kMetroHostKey];
+  } else {
+    [defaults removeObjectForKey:kMetroHostKey];
   }
-  if (original_sourceURLForBridge) {
-    return ((NSURL *(*)(id, SEL, RCTBridge *))original_sourceURLForBridge)(self, _cmd, bridge);
+  [defaults synchronize];
+}
+
+static void DebugToolkitPrepareBundleSourceIfNeeded(void)
+{
+  // Touch sharedSettings so RCTBundleURLProvider is linked before hook install retries.
+  RCTBundleURLProvider *settings = [RCTBundleURLProvider sharedSettings];
+  if (DevConnectPersistedMetroHost().length > 0) {
+    return;
   }
-  return nil;
+  [settings resetToDefaults];
+}
+
+static BOOL DevConnectIsExpoProject(void)
+{
+  static dispatch_once_t onceToken;
+  static BOOL isExpo = NO;
+  dispatch_once(&onceToken, ^{
+    // Heuristic: matches common Expo prebuild / dev-client binaries.
+    isExpo = NSClassFromString(@"EXAppDelegateWrapper") != nil
+          || [[NSBundle mainBundle] objectForInfoDictionaryKey:@"EXUpdatesURL"] != nil
+          || [[NSBundle mainBundle] objectForInfoDictionaryKey:@"EXPO_RUNTIME_VERSION"] != nil;
+  });
+  return isExpo;
+}
+
+/// Bundle root Metro expects when DevConnect steers the packager (index for plain RN, virtual entry for Expo).
+static NSString *DevConnectMetroBundleRoot(void)
+{
+  return DevConnectIsExpoProject() ? kExpoVirtualMetroEntry : kBundleRoot;
+}
+
+static NSURL *DevConnectMetroURLForPersistedHost(void)
+{
+  NSString *host = DevConnectPersistedMetroHost();
+  if (host.length == 0) {
+    return nil;
+  }
+  RCTBundleURLProvider *settings = [RCTBundleURLProvider sharedSettings];
+  settings.jsLocation = host;
+  return [settings jsBundleURLForBundleRoot:DevConnectMetroBundleRoot()];
+}
+
+/// Primary hook: return embedded main.jsbundle before RN/Expo tries Metro / virtual-metro-entry.
+static NSURL *replacement_jsBundleURLForBundleRoot_fallback(
+    id self, SEL _cmd, NSString *bundleRoot, NSURL * _Nonnull (^fallbackURLProvider)(void))
+{
+  if (DevConnectPersistedMetroHost().length == 0) {
+    NSURL *embedded = DebugToolkitEmbeddedBundleURL();
+    if (embedded) {
+      NSLog(@"[DevConnect] cold start → embedded bundle (root=%@)", bundleRoot);
+      return embedded;
+    }
+    NSLog(@"[DevConnect] no embedded main.jsbundle — falling back to Metro (root=%@)", bundleRoot);
+  }
+
+  if (gOrigJsBundleURLForBundleRootWithFallback) {
+    return gOrigJsBundleURLForBundleRootWithFallback(self, _cmd, bundleRoot, fallbackURLProvider);
+  }
+  return fallbackURLProvider ? fallbackURLProvider() : nil;
 }
 
-static void swizzleSourceURLForBridge(Class targetClass, NSString *stage)
+static void DebugToolkitInstallBundleRootHook(Class cls)
 {
-  if (!targetClass) {
-    appendDiag(stage, @"class=nil");
+  if (gBundleRootHookInstalled) {
     return;
   }
-  NSString *className = NSStringFromClass(targetClass);
-  SEL selector = @selector(sourceURLForBridge:);
-  Method method = class_getInstanceMethod(targetClass, selector);
+  SEL selector = @selector(jsBundleURLForBundleRoot:fallbackURLProvider:);
+  Method method = class_getInstanceMethod(cls, selector);
   if (!method) {
-    appendDiag(stage, [NSString stringWithFormat:@"class=%@ method=NOT_FOUND", className]);
+    NSLog(@"[DevConnect] jsBundleURLForBundleRoot:fallbackURLProvider: not found");
+    return;
+  }
+  IMP replacement = (IMP)replacement_jsBundleURLForBundleRoot_fallback;
+  gOrigJsBundleURLForBundleRootWithFallback =
+      (NSURL * (*)(id, SEL, NSString *, NSURL * _Nonnull (^)(void)))method_getImplementation(method);
+  if ((IMP)gOrigJsBundleURLForBundleRootWithFallback == replacement) {
+    gBundleRootHookInstalled = YES;
     return;
   }
-  if (original_sourceURLForBridge) {
-    appendDiag(stage, [NSString stringWithFormat:@"class=%@ already_swizzled", className]);
+  method_setImplementation(method, replacement);
+  gBundleRootHookInstalled = YES;
+}
+
+static void DebugToolkitInstallAllHooks(void)
+{
+  if (gBundleRootHookInstalled) {
     return;
   }
-  // class_addMethod ensures the replacement lands on targetClass even when the method
-  // is inherited — avoids modifying the parent class's IMP for all subclasses.
-  IMP origIMP = method_getImplementation(method);
-  const char *types = method_getTypeEncoding(method);
-  BOOL added = class_addMethod(targetClass, selector, (IMP)devconnect_sourceURLForBridge, types);
-  if (!added) {
-    // Method already exists directly on targetClass; replace in place.
-    method_setImplementation(method, (IMP)devconnect_sourceURLForBridge);
+
+  Class cls = NSClassFromString(@"RCTBundleURLProvider");
+  if (!cls) {
+    NSLog(@"[DevConnect] RCTBundleURLProvider not loaded — hooks will retry");
+    return;
   }
-  original_sourceURLForBridge = origIMP;
-  appendDiag(stage, [NSString stringWithFormat:@"class=%@ added=%@ SUCCESS", className, added ? @"YES" : @"NO"]);
+
+  DebugToolkitInstallBundleRootHook(cls);
+
+  static BOOL didLogOutcome = NO;
+  if (!didLogOutcome) {
+    didLogOutcome = YES;
+    if (DevConnectEmbeddedFirstHooksActive()) {
+      NSLog(@"[DevConnect] embedded-first hook active");
+    } else {
+      NSLog(@"[DevConnect] embedded-first hooks FAILED — rebuild / check React linkage");
+    }
+  }
+}
+
+NSURL *DebugToolkitMetroBundleURL(void)
+{
+  return DevConnectMetroURLForPersistedHost();
 }
 
+// RCT_EXPORT_MODULE defines +load for module registration — use a separate class for hooks.
+@interface DebugToolkitDevConnectBootstrap : NSObject
+@end
+
+@implementation DebugToolkitDevConnectBootstrap
+
++ (void)load
+{
+  DebugToolkitPrepareBundleSourceIfNeeded();
+  DebugToolkitInstallAllHooks();
+}
+
+@end
+
 #pragma mark - Module
 
 @interface DebugToolkitDevConnect : NSObject <RCTBridgeModule>
@@ -94,63 +194,64 @@ RCT_EXPORT_MODULE(DebugToolkitDevConnect)
 @synthesize bridge = _bridge;
 @synthesize bundleManager = _bundleManager;
 
-__attribute__((constructor))
-static void devconnect_swizzle_init(void)
-{
-  swizzleSourceURLForBridge(NSClassFromString(@"AppDelegate"), @"constructor");
-}
-
 - (instancetype)init
 {
   if ((self = [super init])) {
-    if (!original_sourceURLForBridge) {
-      Class delegateClass = object_getClass([UIApplication sharedApplication].delegate);
-      swizzleSourceURLForBridge(delegateClass, @"init");
-    }
+    DebugToolkitInstallAllHooks();
   }
   return self;
 }
 
-+ (BOOL)requiresMainQueueSetup
-{
-  return NO;
-}
++ (BOOL)requiresMainQueueSetup { return NO; }
+- (dispatch_queue_t)methodQueue { return dispatch_get_main_queue(); }
 
-- (dispatch_queue_t)methodQueue
+#pragma mark - Bundle Manager Resolution
+
+- (RCTBundleManager *)resolveBundleManager
 {
-  return dispatch_get_main_queue();
+  if (_bundleManager) return _bundleManager;
+  if (_bridge) return [_bridge moduleForClass:[RCTBundleManager class]];
+  return nil;
 }
 
-#pragma mark - Bundle Manager Resolution
+#pragma mark - Host Parsing
 
-- (RCTBundleManager *)resolveBundleManager
+- (NSString *)normalizeHostPort:(NSString *)hostPort
 {
-  if (_bundleManager) {
-    return _bundleManager;
-  }
-  if (_bridge) {
-    return [_bridge moduleForClass:[RCTBundleManager class]];
+  NSRange sep = [hostPort rangeOfString:@":" options:NSBackwardsSearch];
+  NSString *host = sep.location == NSNotFound ? hostPort : [hostPort substringToIndex:sep.location];
+  NSString *portStr = sep.location == NSNotFound ? @"" : [hostPort substringFromIndex:sep.location + 1];
+
+  NSNumberFormatter *formatter = [NSNumberFormatter new];
+  formatter.numberStyle = NSNumberFormatterDecimalStyle;
+  NSNumber *parsed = [formatter numberFromString:portStr];
+  int port;
+  if (parsed && parsed.intValue > 0 && parsed.intValue <= 65535) {
+    port = parsed.intValue;
+  } else {
+#ifdef RCT_METRO_PORT
+    port = RCT_METRO_PORT;
+#else
+    port = 8081;
+#endif
   }
-  return nil;
+  return [NSString stringWithFormat:@"%@:%d", host, port];
 }
 
-#pragma mark - Exported Methods
+#pragma mark - Reload helper
 
-RCT_EXPORT_METHOD(getMetroHost:(RCTPromiseResolveBlock)resolve
-                  rejecter:(__unused RCTPromiseRejectBlock)reject)
+- (void)reloadWithBundleURL:(NSURL *)bundleURL reason:(NSString *)reason
 {
-  @try {
-    // kDevConnectMetroHost is written by applyMetroHost and survives restart in both Debug+Release.
-    // jsLocation is only meaningful in Debug (bypassed in Release); use it as a fallback only.
-    NSString *persisted = [[NSUserDefaults standardUserDefaults] stringForKey:kDevConnectMetroHost];
-    NSString *jsLocation = [RCTBundleURLProvider sharedSettings].jsLocation;
-    NSString *host = persisted.length > 0 ? persisted : jsLocation;
-    resolve(host ?: [NSNull null]);
-  } @catch (NSException *exception) {
-    reject(@"native_error", exception.reason, nil);
+  if (bundleURL) {
+    RCTBundleManager *bm = [self resolveBundleManager];
+    if (bm) bm.bundleURL = bundleURL;
+    RCTReloadCommandSetBundleURL(bundleURL);
   }
+  RCTTriggerReloadCommandListeners(reason);
 }
 
+#pragma mark - Exported Methods
+
 RCT_EXPORT_METHOD(applyMetroHost:(NSString *)hostPort
                   resolver:(RCTPromiseResolveBlock)resolve
                   rejecter:(RCTPromiseRejectBlock)reject)
@@ -160,71 +261,24 @@ RCT_EXPORT_METHOD(applyMetroHost:(NSString *)hostPort
       reject(@"invalid_host", @"Metro host cannot be empty.", nil);
       return;
     }
+    NSString *normalized = [self normalizeHostPort:hostPort];
 
-    RCTBundleURLProvider *settings = [RCTBundleURLProvider sharedSettings];
-
-    // Parse host and port
-    NSRange separator = [hostPort rangeOfString:@":" options:NSBackwardsSearch];
-    NSString *host = separator.location == NSNotFound
-        ? hostPort
-        : [hostPort substringToIndex:separator.location];
-    NSString *port = separator.location == NSNotFound
-        ? @""
-        : [hostPort substringFromIndex:separator.location + 1];
-
-    if (host.length == 0 && port.length == 0) {
-      [self resetMetroHost:resolve rejecter:reject];
-      return;
-    }
-
-    NSNumberFormatter *formatter = [NSNumberFormatter new];
-    formatter.numberStyle = NSNumberFormatterDecimalStyle;
-    NSNumber *portNumber = [formatter numberFromString:port];
-    if (portNumber == nil) {
-#ifdef RCT_METRO_PORT
-      portNumber = [NSNumber numberWithInt:RCT_METRO_PORT];
-#else
-      portNumber = [NSNumber numberWithInt:8081];
-#endif
-    }
-
-    NSString *normalizedHostPort = [NSString stringWithFormat:@"%@:%d", host, portNumber.intValue];
-
-    // Persist for AppDelegate swizzle (Release mode + restart)
-    [[NSUserDefaults standardUserDefaults] setObject:normalizedHostPort forKey:kDevConnectMetroHost];
-    [[NSUserDefaults standardUserDefaults] synchronize];
-
-    // Also set jsLocation (Debug mode + hot reload)
-    settings.jsLocation = normalizedHostPort;
+    DevConnectSetPersistedMetroHost(normalized);
 
-    // Try hot reload via bundleManager (works in Debug)
-    NSURL *bundleURL = nil;
-    if (DebugToolkitBundleRoot.length > 0) {
-      bundleURL = [settings jsBundleURLForBundleRoot:DebugToolkitBundleRoot];
-    }
-    RCTBundleManager *bm = [self resolveBundleManager];
-    if (bm) {
-      bm.bundleURL = bundleURL;
-    }
-#ifdef RCTReloadCommandSetBundleURL
-    else if (bundleURL) {
-      RCTReloadCommandSetBundleURL(bundleURL);
-    }
-#endif
-
-    NSLog(@"[DevConnect] applyMetroHost: %@ | bm=%@ | bridge=%@ | url=%@",
-          normalizedHostPort, bm ? @"YES" : @"nil", _bridge ? @"YES" : @"nil", bundleURL);
-
-    RCTTriggerReloadCommandListeners(@"Dev menu - apply changes");
-
-    NSMutableDictionary *result = [@{@"hostPort" : normalizedHostPort} mutableCopy];
-    if (bm && bm.bundleURL.absoluteString) {
-      result[@"bundleURL"] = bm.bundleURL.absoluteString;
-    }
-    resolve(result);
-  } @catch (NSException *exception) {
-    NSLog(@"[DevConnect] applyMetroHost EXCEPTION: %@", exception.reason);
-    reject(@"native_error", exception.reason, nil);
+    RCTBundleURLProvider *settings = [RCTBundleURLProvider sharedSettings];
+    settings.jsLocation = normalized;
+    NSURL *bundleURL = [settings jsBundleURLForBundleRoot:DevConnectMetroBundleRoot()];
+
+    [self reloadWithBundleURL:bundleURL reason:@"Dev menu - apply changes"];
+
+    NSLog(@"[DevConnect] applyMetroHost host=%@ url=%@", normalized, bundleURL);
+    resolve(@{
+      @"hostPort": normalized,
+      @"bundleURL": bundleURL.absoluteString ?: [NSNull null],
+    });
+  } @catch (NSException *e) {
+    NSLog(@"[DevConnect] applyMetroHost EXCEPTION: %@", e.reason);
+    reject(@"native_error", e.reason ?: @"unknown", nil);
   }
 }
 
@@ -232,48 +286,55 @@ RCT_EXPORT_METHOD(resetMetroHost:(RCTPromiseResolveBlock)resolve
                   rejecter:(__unused RCTPromiseRejectBlock)reject)
 {
   @try {
-    // Clear stored Metro host
-    [[NSUserDefaults standardUserDefaults] removeObjectForKey:kDevConnectMetroHost];
-    [[NSUserDefaults standardUserDefaults] synchronize];
+    DevConnectSetPersistedMetroHost(nil);
 
-    // Reset RN settings
     RCTBundleURLProvider *settings = [RCTBundleURLProvider sharedSettings];
     [settings resetToDefaults];
-    NSURL *bundleURL = [settings jsBundleURLForFallbackExtension:nil];
 
-    RCTBundleManager *bm = [self resolveBundleManager];
-    if (bm) {
-      bm.bundleURL = bundleURL;
+    NSURL *embedded = DebugToolkitEmbeddedBundleURL();
+    if (!embedded) {
+      embedded = [settings jsBundleURLForFallbackExtension:nil];
     }
 
-    NSLog(@"[DevConnect] resetMetroHost | bm=%@ | url=%@", bm ? @"YES" : @"nil", bundleURL);
-    RCTTriggerReloadCommandListeners(@"Dev menu - reset to default");
+    [self reloadWithBundleURL:embedded reason:@"Dev menu - reset to default"];
+
+    NSLog(@"[DevConnect] resetMetroHost url=%@", embedded);
     resolve([NSNull null]);
-  } @catch (NSException *exception) {
-    NSLog(@"[DevConnect] resetMetroHost EXCEPTION: %@", exception.reason);
-    reject(@"native_error", exception.reason, nil);
+  } @catch (NSException *e) {
+    NSLog(@"[DevConnect] resetMetroHost EXCEPTION: %@", e.reason);
+    reject(@"native_error", e.reason ?: @"unknown", nil);
   }
 }
 
-RCT_EXPORT_METHOD(getDiagnostics:(RCTPromiseResolveBlock)resolve
+RCT_EXPORT_METHOD(getMetroHost:(RCTPromiseResolveBlock)resolve
                   rejecter:(__unused RCTPromiseRejectBlock)reject)
 {
-  NSArray *log = [[NSUserDefaults standardUserDefaults] arrayForKey:kDevConnectDiagLog] ?: @[];
-  NSString *metroHost = [[NSUserDefaults standardUserDefaults] stringForKey:kDevConnectMetroHost];
-  resolve(@{
-    @"log": log,
-    @"swizzleInstalled": @(original_sourceURLForBridge != NULL),
-    @"swizzleInvoked": @(swizzleInvoked),
-    @"persistedMetroHost": metroHost ?: [NSNull null],
-  });
+  NSString *host = DevConnectPersistedMetroHost();
+  resolve(host.length > 0 ? host : [NSNull null]);
 }
 
-RCT_EXPORT_METHOD(clearDiagnostics:(RCTPromiseResolveBlock)resolve
+RCT_EXPORT_METHOD(getDiagnostics:(RCTPromiseResolveBlock)resolve
                   rejecter:(__unused RCTPromiseRejectBlock)reject)
 {
-  [[NSUserDefaults standardUserDefaults] removeObjectForKey:kDevConnectDiagLog];
-  [[NSUserDefaults standardUserDefaults] synchronize];
-  resolve([NSNull null]);
+  Class realDelegate = object_getClass([UIApplication sharedApplication].delegate);
+  NSString *delegateName = realDelegate ? NSStringFromClass(realDelegate) : @"unknown";
+  NSString *persisted = DevConnectPersistedMetroHost();
+
+#if DEBUG
+  BOOL isDebug = YES;
+#else
+  BOOL isDebug = NO;
+#endif
+
+  resolve(@{
+    @"persistedMetroHost": persisted.length > 0 ? persisted : [NSNull null],
+    @"appDelegateClass": delegateName,
+    @"isDebugBuild": @(isDebug),
+    @"hasEmbeddedBundle": @(DebugToolkitEmbeddedBundleURL() != nil),
+    @"embeddedFirstHookInstalled": @(DevConnectEmbeddedFirstHooksActive()),
+    @"packagerHookInstalled": @NO,
+    @"bundleRootHookInstalled": @(gBundleRootHookInstalled),
+  });
 }
 
 RCT_EXPORT_METHOD(getPreference:(NSString *)key
@@ -283,8 +344,8 @@ RCT_EXPORT_METHOD(getPreference:(NSString *)key
   @try {
     NSString *value = [[NSUserDefaults standardUserDefaults] stringForKey:key];
     resolve(value ?: [NSNull null]);
-  } @catch (NSException *exception) {
-    reject(@"native_error", exception.reason, nil);
+  } @catch (NSException *e) {
+    reject(@"native_error", e.reason ?: @"unknown", nil);
   }
 }
 
@@ -297,8 +358,8 @@ RCT_EXPORT_METHOD(setPreference:(NSString *)key
     [[NSUserDefaults standardUserDefaults] setObject:value forKey:key];
     [[NSUserDefaults standardUserDefaults] synchronize];
     resolve([NSNull null]);
-  } @catch (NSException *exception) {
-    reject(@"native_error", exception.reason, nil);
+  } @catch (NSException *e) {
+    reject(@"native_error", e.reason ?: @"unknown", nil);
   }
 }
 
@@ -317,40 +378,27 @@ RCT_EXPORT_METHOD(getLocalIp:(RCTPromiseResolveBlock)resolve
 {
   @try {
     struct ifaddrs *interfaces = NULL;
-    if (getifaddrs(&interfaces) == 0) {
-      struct ifaddrs *iface = interfaces;
-      while (iface != NULL) {
-        if (iface->ifa_addr != NULL && iface->ifa_addr->sa_family == AF_INET && !(iface->ifa_flags & IFF_LOOPBACK)) {
-          if (strcmp(iface->ifa_name, "en0") == 0) {
-            char addrStr[INET_ADDRSTRLEN];
-            struct sockaddr_in *sin = (struct sockaddr_in *)iface->ifa_addr;
-            inet_ntop(AF_INET, &sin->sin_addr, addrStr, sizeof(addrStr));
-            NSString *ip = [NSString stringWithUTF8String:addrStr];
-            freeifaddrs(interfaces);
-            resolve(ip);
-            return;
-          }
-        }
-        iface = iface->ifa_next;
-      }
-      iface = interfaces;
-      while (iface != NULL) {
-        if (iface->ifa_addr != NULL && iface->ifa_addr->sa_family == AF_INET && !(iface->ifa_flags & IFF_LOOPBACK)) {
-          char addrStr[INET_ADDRSTRLEN];
-          struct sockaddr_in *sin = (struct sockaddr_in *)iface->ifa_addr;
-          inet_ntop(AF_INET, &sin->sin_addr, addrStr, sizeof(addrStr));
-          NSString *ip = [NSString stringWithUTF8String:addrStr];
-          freeifaddrs(interfaces);
-          resolve(ip);
-          return;
-        }
-        iface = iface->ifa_next;
-      }
+    if (getifaddrs(&interfaces) != 0) {
+      resolve([NSNull null]);
+      return;
+    }
+
+    NSString *preferred = nil;
+    NSString *fallback = nil;
+    for (struct ifaddrs *iface = interfaces; iface != NULL; iface = iface->ifa_next) {
+      if (!iface->ifa_addr || iface->ifa_addr->sa_family != AF_INET) continue;
+      if (iface->ifa_flags & IFF_LOOPBACK) continue;
+      char addrStr[INET_ADDRSTRLEN];
+      struct sockaddr_in *sin = (struct sockaddr_in *)iface->ifa_addr;
+      inet_ntop(AF_INET, &sin->sin_addr, addrStr, sizeof(addrStr));
+      NSString *ip = [NSString stringWithUTF8String:addrStr];
+      if (strcmp(iface->ifa_name, "en0") == 0) { preferred = ip; break; }
+      if (!fallback) fallback = ip;
     }
     freeifaddrs(interfaces);
-    resolve([NSNull null]);
-  } @catch (NSException *exception) {
-    reject(@"native_error", exception.reason, nil);
+    resolve(preferred ?: fallback ?: [NSNull null]);
+  } @catch (NSException *e) {
+    reject(@"native_error", e.reason ?: @"unknown", nil);
   }
 }