react-native-credentials-manager 0.8.0 → 0.8.2

package/android/src/newarch/java/com/credentialsmanager/CredentialsManagerModule.kt

@@ -6,6 +6,7 @@ import androidx.credentials.exceptions.GetCredentialException
 import androidx.credentials.exceptions.NoCredentialException
 import com.credentialsmanager.handlers.CredentialHandler
 import com.credentialsmanager.handlers.ErrorHandler
+import com.facebook.react.bridge.Arguments
 import com.facebook.react.bridge.Promise
 import com.facebook.react.bridge.ReactApplicationContext
 import com.facebook.react.bridge.ReadableArray
@@ -68,11 +69,11 @@ class CredentialsManagerModule(
         credentialHandler.createPassword(username, password)
         
         // Create success response
-        val result = mapOf(
-          "type" to "password",
-          "username" to username,
-          "success" to true
-        )
+        val result = Arguments.createMap().apply {
+          putString("type", "password")
+          putString("username", username)
+          putBoolean("success", true)
+        }
         promise.resolve(result)
       } catch (e: CreateCredentialException) {
         ErrorHandler.handleCredentialError(e)

package/android/src/oldarch/java/com/credentialsmanager/CredentialsManagerModule.kt

@@ -6,6 +6,7 @@ import androidx.credentials.exceptions.GetCredentialException
 import androidx.credentials.exceptions.NoCredentialException
 import com.credentialsmanager.handlers.CredentialHandler
 import com.credentialsmanager.handlers.ErrorHandler
+import com.facebook.react.bridge.Arguments
 import com.facebook.react.bridge.Promise
 import com.facebook.react.bridge.ReactApplicationContext
 import com.facebook.react.bridge.ReactContextBaseJavaModule
@@ -74,11 +75,11 @@ class CredentialsManagerModule(
         credentialHandler.createPassword(username, password)
         
         // Create success response
-        val result = mapOf(
-          "type" to "password",
-          "username" to username,
-          "success" to true
-        )
+        val result = Arguments.createMap().apply {
+          putString("type", "password")
+          putString("username", username)
+          putBoolean("success", true)
+        }
         promise.resolve(result)
       } catch (e: CreateCredentialException) {
         ErrorHandler.handleCredentialError(e)

package/app.plugin.js

@@ -1,22 +1,23 @@
 // set Info.plist values
 import configPlugin from '@expo/config-plugins';
 
-const {createRunOncePlugin, withEntitlementsPlist, withInfoPlist} = configPlugin
+const { createRunOncePlugin, withEntitlementsPlist, withInfoPlist } =
+  configPlugin;
 
 const withAllowMixedLocalizations = function (config) {
-  return withInfoPlist(config, function (config) {
-    config.modResults.CFBundleAllowMixedLocalizations =
-      config.modResults.CFBundleAllowMixedLocalizations ?? true;
+  return withInfoPlist(config, function (modConfig) {
+    modConfig.modResults.CFBundleAllowMixedLocalizations =
+      modConfig.modResults.CFBundleAllowMixedLocalizations ?? true;
 
-    return config;
+    return modConfig;
   });
 };
 
 const withDefaultAppleSignIn = function (config) {
   config = withAllowMixedLocalizations(config);
-  return withEntitlementsPlist(config, function (config) {
-    config.modResults['com.apple.developer.applesignin'] = ['Default'];
-    return config;
+  return withEntitlementsPlist(config, function (modConfig) {
+    modConfig.modResults['com.apple.developer.applesignin'] = ['Default'];
+    return modConfig;
   });
 };
 

package/ios/CredentialsManager.mm

@@ -118,6 +118,8 @@ preferImmediatelyAvailableCredentials:(BOOL)preferImmediatelyAvailableCredential
        resolve:(RCTPromiseResolveBlock)resolve
         reject:(RCTPromiseRejectBlock)reject {
     
+    id passkeyParams = params.passkeys();
+    
     dispatch_async(dispatch_get_main_queue(), ^{
         self.currentResolve = resolve;
         self.currentReject = reject;
@@ -126,8 +128,6 @@ preferImmediatelyAvailableCredentials:(BOOL)preferImmediatelyAvailableCredential
         
         for (NSString *option in options) {
             if ([option isEqualToString:@"passkeys"]) {
-                // Extract passkeys parameters from the params object
-                id passkeyParams = params.passkeys();
                 if (!passkeyParams || ![passkeyParams isKindOfClass:[NSDictionary class]]) {
                     RCTLogError(@"Missing or invalid passkeys parameters");
                     continue;
@@ -167,11 +167,9 @@ preferImmediatelyAvailableCredentials:(BOOL)preferImmediatelyAvailableCredential
                 ASAuthorizationPasswordRequest *passwordRequest = [passwordProvider createRequest];
                 [authRequests addObject:passwordRequest];
             } else if ([option isEqualToString:@"apple-signin"]) {
-                // Apple Sign In is supported by Authentication Services
                 ASAuthorizationAppleIDProvider *appleIDProvider = [[ASAuthorizationAppleIDProvider alloc] init];
                 ASAuthorizationAppleIDRequest *appleIDRequest = [appleIDProvider createRequest];
                 
-                // Default scopes - always use these
                 NSArray<ASAuthorizationScope> *defaultScopes = @[ASAuthorizationScopeFullName, ASAuthorizationScopeEmail];
                 appleIDRequest.requestedScopes = defaultScopes;
                 
@@ -202,7 +200,6 @@ preferImmediatelyAvailableCredentials:(BOOL)preferImmediatelyAvailableCredential
                  resolve:(RCTPromiseResolveBlock)resolve
                   reject:(RCTPromiseRejectBlock)reject {
     // Google Sign In is not part of Apple's Authentication Services framework
-    // This should be handled at the JavaScript layer for cross-platform compatibility
     reject(@"UNSUPPORTED_OPERATION", @"Google Sign In is not available on iOS. Use Apple Sign In instead.", nil);
 }
 
@@ -214,11 +211,9 @@ preferImmediatelyAvailableCredentials:(BOOL)preferImmediatelyAvailableCredential
         self.currentResolve = resolve;
         self.currentReject = reject;
         
-        // Apple Sign In is officially supported by Authentication Services framework
         ASAuthorizationAppleIDProvider *appleIDProvider = [[ASAuthorizationAppleIDProvider alloc] init];
         ASAuthorizationAppleIDRequest *appleIDRequest = [appleIDProvider createRequest];
         
-        // Always use the default scopes
         appleIDRequest.requestedScopes = @[ASAuthorizationScopeFullName, ASAuthorizationScopeEmail];
         
         ASAuthorizationController *authController = [[ASAuthorizationController alloc] initWithAuthorizationRequests:@[appleIDRequest]];

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-native-credentials-manager",
-  "version": "0.8.0",
+  "version": "0.8.2",
   "description": "A React Native library that implements the Credential Manager API for Android. This library allows you to manage passwords and passkeys in your React Native applications.",
   "source": "./src/index.tsx",
   "main": "./lib/commonjs/index.js",
@@ -126,10 +126,13 @@
   "release-it": {
     "git": {
       "commitMessage": "chore: release ${version}",
-      "tagName": "v${version}"
+      "tagName": "v${version}",
+      "requireCommits": true,
+      "requireCommitsFail": false
     },
     "npm": {
-      "publish": true
+      "publish": true,
+      "skipChecks": true
     },
     "github": {
       "release": true