react-native-bundle-discovery 2.2.0-rc.3 → 2.3.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-native-bundle-discovery",
-  "version": "2.2.0-rc.3",
+  "version": "2.3.0",
   "main": "index.js",
   "repository": "git@github.com:retyui/react-native-bundle-discovery.git",
   "author": "David <4661784+retyui@users.noreply.github.com>",

package/webpack.js

@@ -15,7 +15,7 @@ class BundleDiscoveryPlugin {
   constructor({ filename, options, enabled } = {}) {
     this.options = options;
     this.filename = filename || "metro-stats.json";
-    this.enabled = enabled || true;
+    this.enabled = enabled ?? true;
   }
 
   extractSizesFromJsBundle(statAsset, options) {
@@ -51,6 +51,7 @@ class BundleDiscoveryPlugin {
       const statsJson = this.formatStat(
         json,
         // Parse JS bundle to extract modules sizes
+        // WANR: The stats asset list can contain multiple emitted files and is not guaranteed to put the JavaScript bundle first (and can be empty after a failed compilation)
         this.extractSizesFromJsBundle(json.assets[0], compiler.options),
         compiler.options,
       );
@@ -90,6 +91,7 @@ class BundleDiscoveryPlugin {
     if (parts.length < 2) {
       return null;
     }
+    // WARN: Won't work with `pnpm's nested layout`
     const packagePath = parts[1].split(path.sep).filter(Boolean);
     if (packagePath.length === 0) {
       return null;
@@ -160,6 +162,10 @@ class BundleDiscoveryPlugin {
   }
 
   formatStat(statsJson, bundleModules, compilerOptions) {
+    const modulesDeps = this.buildImportsMapFromReasons(
+      statsJson,
+      compilerOptions,
+    );
     return {
       date: statsJson.builtAt || Date.now(),
       entryPoint: this.getEntryFile(statsJson, compilerOptions.context),
@@ -176,6 +182,9 @@ class BundleDiscoveryPlugin {
       modules: statsJson.modules
         .map((mdl) => {
           if (mdl.type === "runtime modules") {
+            if (!bundleModules) {
+              return null;
+            }
             const sourceAndOutput = {
               code: bundleModules.runtimeSrc ?? "",
               lineCount: bundleModules.runtimeSrc?.split("\n").length ?? 0,
@@ -184,8 +193,9 @@ class BundleDiscoveryPlugin {
                 "utf-8",
               ),
             };
+
             return {
-              path: "__prelude__",
+              path: "runtime modules", // Can we rename it?
               source: sourceAndOutput,
               output: sourceAndOutput,
               dependencies: [],
@@ -196,26 +206,64 @@ class BundleDiscoveryPlugin {
             path: mdl.nameForCondition,
             source: this.readSource(mdl.nameForCondition),
             output: this.getModuleOutput(mdl, bundleModules),
-            dependencies:
-              mdl.reasons
-                ?.filter((r) => r.type !== "entry")
-                .map((reason) => {
-                  return {
-                    absolutePath: path.isAbsolute(reason.resolvedModule)
-                      ? reason.resolvedModule
-                      : path.resolve(
-                          compilerOptions.context,
-                          reason.resolvedModule,
-                        ),
-                    name: reason.userRequest,
-                  };
-                }) ?? [],
+            dependencies: modulesDeps.get(mdl.nameForCondition) ?? [],
           };
         })
         .filter((e) => e !== null),
       packages: this.getPackages(statsJson),
     };
   }
+
+  buildImportsMapFromReasons(statsJson, compilerOptions) {
+    const modules = Array.isArray(statsJson?.modules) ? statsJson.modules : [];
+    const importsMap = new Map();
+
+    const getAbs = (p) => {
+      if (!p || typeof p !== "string") return null;
+      if (path.isAbsolute(p)) return p;
+      return compilerOptions?.context
+        ? path.resolve(compilerOptions?.context, p)
+        : p;
+    };
+
+    const getModulePath = (m) =>
+      m?.path || m?.nameForCondition || m?.identifier || null;
+
+    for (const depModule of modules) {
+      const depAbsolutePath = getAbs(getModulePath(depModule));
+      if (!depAbsolutePath) continue;
+
+      const reasons = Array.isArray(depModule.reasons) ? depModule.reasons : [];
+      for (const reason of reasons) {
+        if (reason?.type === "entry") continue;
+
+        // importer (who imports current dep module)
+        const importerPath = getAbs(
+          reason?.modulePath ||
+            reason?.moduleNameForCondition ||
+            reason?.resolvedModule ||
+            reason?.moduleIdentifier,
+        );
+        if (!importerPath) continue;
+
+        if (!importsMap.has(importerPath)) {
+          importsMap.set(importerPath, []);
+        }
+
+        const deps = importsMap.get(importerPath);
+
+        // uniq by absolutePath
+        if (!deps.some((d) => d.absolutePath === depAbsolutePath)) {
+          deps.push({
+            absolutePath: depAbsolutePath,
+            name: reason?.userRequest || "",
+          });
+        }
+      }
+    }
+
+    return importsMap;
+  }
 }
 
 module.exports = { BundleDiscoveryPlugin };