react-native-bootsplash 4.1.2 → 4.1.3

package/README.md

@@ -132,6 +132,17 @@ yarn react-native generate-bootsplash assets/bootsplash_logo_original.png \
   --flavor=main
 ```
 
+#### Using an SVG
+
+You might want to use SVG as input file. For that, you can install a CLI tool to convert your logo first:
+
+```bash
+$ brew install librsvg # available on macOS
+$ rsvg-convert -w 3000 bootsplash_logo.svg bootsplash_logo.png # create a large PNG with generous leeway for 4x Android xxxhdpi devices
+$ react-native generate-bootsplash bootsplash_logo.png
+$ rm bootsplash_logo.png # optionally, clean up the PNG
+```
+
 ![](https://raw.githubusercontent.com/zoontek/react-native-bootsplash/master/docs/cli_tool.png?raw=true)
 
 This tool relies on the naming conventions that are used in the `/example` project and will therefore create the following files:
@@ -316,8 +327,6 @@ RNBootSplash.hide(); // immediate
 RNBootSplash.hide({ fade: true }); // fade
 ```
 
----
-
 ### getVisibilityStatus()
 
 #### Method type
@@ -360,7 +369,25 @@ function App() {
 
 **🤙 A more complex example is available in the [`/example` folder](example).**
 
-### Testing with Jest
+## Using React Navigation
+
+If you are using React Navigation, you can hide the splash screen once the navigation container and all children have finished mounting by using the `onReady` function.
+
+```js
+import React from "react";
+import { NavigationContainer } from "@react-navigation/native";
+import RNBootSplash from "react-native-bootsplash";
+
+function App() {
+  return (
+    <NavigationContainer onReady={() => RNBootSplash.hide()}>
+      {/* content */}
+    </NavigationContainer>
+  );
+}
+```
+
+## Testing with Jest
 
 Testing code which uses this library requires some setup since we need to mock the native methods.
 
@@ -383,24 +410,6 @@ After that, we need to add the setup file in the jest config. You can add it und
 }
 ```
 
-### Using React Navigation
-
-If you are using React Navigation, you can hide the splash screen once the navigation container and all children have finished mounting by using the `onReady` function.
-
-```js
-import React from "react";
-import { NavigationContainer } from "@react-navigation/native";
-import RNBootSplash from "react-native-bootsplash";
-
-function App() {
-  return (
-    <NavigationContainer onReady={() => RNBootSplash.hide()}>
-      {/* content */}
-    </NavigationContainer>
-  );
-}
-```
-
 ## 🕵️‍♂️ Comparison with [react-native-splash-screen](https://github.com/crazycodeboy/react-native-splash-screen)
 
 - If `react-native-splash-screen` encourages you to display an image over your application, `react-native-bootsplash` way-to-go is to design your launch screen using platforms tools.

package/android/src/main/java/com/zoontek/rnbootsplash/RNBootSplashModule.java

@@ -12,7 +12,6 @@ import androidx.core.splashscreen.SplashScreen;
 import androidx.core.splashscreen.SplashScreenViewProvider;
 
 import com.facebook.common.logging.FLog;
-import com.facebook.react.bridge.LifecycleEventListener;
 import com.facebook.react.bridge.Promise;
 import com.facebook.react.bridge.ReactApplicationContext;
 import com.facebook.react.bridge.ReactContextBaseJavaModule;
@@ -25,7 +24,7 @@ import java.util.Timer;
 import java.util.TimerTask;
 
 @ReactModule(name = RNBootSplashModule.NAME)
-public class RNBootSplashModule extends ReactContextBaseJavaModule implements LifecycleEventListener {
+public class RNBootSplashModule extends ReactContextBaseJavaModule {
 
   public static final String NAME = "RNBootSplash";
   private static final int ANIMATION_DURATION = 220;
@@ -39,15 +38,13 @@ public class RNBootSplashModule extends ReactContextBaseJavaModule implements Li
   @Nullable
   private static SplashScreen mSplashScreen = null;
 
-  private static final RNBootSplashQueue<RNBootSplashTask> mTaskQueue = new RNBootSplashQueue<>();
+  private static final RNBootSplashQueue<Promise> mPromiseQueue = new RNBootSplashQueue<>();
   private static Status mStatus = Status.HIDDEN;
-  private static boolean mIsAppInForeground = true;
   private static boolean mShouldFade = false;
   private static boolean mShouldKeepOnScreen = true;
 
   public RNBootSplashModule(ReactApplicationContext reactContext) {
     super(reactContext);
-    reactContext.addLifecycleEventListener(this);
   }
 
   @Override
@@ -96,95 +93,66 @@ public class RNBootSplashModule extends ReactContextBaseJavaModule implements Li
     });
   }
 
-  @Override
-  public void onHostDestroy() {
-    mIsAppInForeground = false;
-  }
-
-  @Override
-  public void onHostPause() {
-    mIsAppInForeground = false;
-  }
-
-  @Override
-  public void onHostResume() {
-    mIsAppInForeground = true;
-    shiftNextTask();
-  }
+  private void clearPromiseQueue() {
+    while (!mPromiseQueue.isEmpty()) {
+      Promise promise = mPromiseQueue.shift();
 
-  private void shiftNextTask() {
-    if (mStatus != Status.TRANSITIONING && mIsAppInForeground) {
-      RNBootSplashTask task = mTaskQueue.shift();
-
-      if (task != null) {
-        hideWithTask(task);
-      }
+      if (promise != null)
+        promise.resolve(true);
     }
   }
 
-  private void waitAndRetry() {
-    final Timer timer = new Timer();
-
-    timer.schedule(new TimerTask() {
-      @Override
-      public void run() {
-        shiftNextTask();
-        timer.cancel();
-      }
-    }, 250);
-  }
-
-  private void hideWithTask(final RNBootSplashTask task) {
-    final Activity activity = getReactApplicationContext().getCurrentActivity();
-    final boolean fade = task.getFade();
-    final Promise promise = task.getPromise();
-
+  private void hideAndResolveAll(final boolean fade) {
     if (mSplashScreen == null || mStatus == Status.HIDDEN) {
-      promise.resolve(true);
-      shiftNextTask();
+      clearPromiseQueue();
       return;
     }
 
     UiThreadUtil.runOnUiThread(new Runnable() {
       @Override
       public void run() {
+        final Activity activity = getReactApplicationContext().getCurrentActivity();
+
         if (activity == null || activity.isFinishing()) {
-          waitAndRetry(); // Wait for activity to be ready
-          return;
-        }
+          // Wait for activity to be ready
+          final Timer timer = new Timer();
 
-        if (fade) {
-          mStatus = Status.TRANSITIONING;
-        }
+          timer.schedule(new TimerTask() {
+            @Override
+            public void run() {
+              hideAndResolveAll(fade);
+              timer.cancel();
+            }
+          }, 250);
+        } else {
+          if (fade) {
+            mStatus = Status.TRANSITIONING;
+          }
 
-        mShouldFade = fade;
-        mShouldKeepOnScreen = false;
+          mShouldFade = fade;
+          mShouldKeepOnScreen = false;
 
-        final Timer timer = new Timer();
+          final Timer timer = new Timer();
 
-        // We cannot rely on setOnExitAnimationListener
-        // See https://issuetracker.google.com/issues/197906327
-        timer.schedule(new TimerTask() {
-          @Override
-          public void run() {
-            mStatus = Status.HIDDEN;
-            timer.cancel();
-            promise.resolve(true);
-            shiftNextTask();
-          }
-        }, ANIMATION_DURATION);
+          // We cannot rely on setOnExitAnimationListener
+          // See https://issuetracker.google.com/issues/197906327
+          timer.schedule(new TimerTask() {
+            @Override
+            public void run() {
+              mStatus = Status.HIDDEN;
+              timer.cancel();
+              clearPromiseQueue();
+            }
+          }, ANIMATION_DURATION);
+        }
       }
     });
   }
 
   @ReactMethod
   public void hide(final boolean fade, final Promise promise) {
-    if (mSplashScreen == null || mStatus == Status.HIDDEN) {
-      promise.resolve(true);
-    } else {
-      mTaskQueue.push(new RNBootSplashTask(fade, promise));
-      shiftNextTask();
-    }
+    mPromiseQueue.push(promise);
+    hideAndResolveAll(fade);
   }
 
   @ReactMethod

package/ios/RNBootSplash.h

@@ -1,16 +1,6 @@
 #import <React/RCTBridgeModule.h>
 #import <React/RCTRootView.h>
 
-@interface RNBootSplashTask : NSObject
-
-@property (nonatomic, readonly) BOOL fade;
-@property (nonatomic, readonly, strong) RCTPromiseResolveBlock _Nonnull resolve;
-
-- (instancetype _Nonnull)initWithFade:(BOOL)fade
-                             resolver:(RCTPromiseResolveBlock _Nonnull)resolve;
-
-@end
-
 @interface RNBootSplash : NSObject <RCTBridgeModule>
 
 + (void)initWithStoryboard:(NSString * _Nonnull)storyboardName

package/ios/RNBootSplash.m

@@ -3,24 +3,9 @@
 #import <React/RCTBridge.h>
 #import <React/RCTUtils.h>
 
-static NSMutableArray<RNBootSplashTask *> *_taskQueue = nil;
+static NSMutableArray<RCTPromiseResolveBlock> *_resolverQueue = nil;
 static RCTRootView *_rootView = nil;
 static bool _isTransitioning = false;
-static bool _shouldPreventInit = false;
-
-@implementation RNBootSplashTask
-
-- (instancetype)initWithFade:(BOOL)fade
-                    resolver:(RCTPromiseResolveBlock _Nonnull)resolve {
-  if (self = [super init]) {
-    _fade = fade;
-    _resolve = resolve;
-  }
-
-  return self;
-}
-
-@end
 
 @implementation RNBootSplash
 
@@ -48,13 +33,13 @@ RCT_EXPORT_MODULE();
   UIStoryboard *storyboard = [UIStoryboard storyboardWithName:storyboardName bundle:nil];
   UIView *loadingView = [[storyboard instantiateInitialViewController] view];
 
-  if (_shouldPreventInit)
-    return;
+  if (_resolverQueue != nil)
+    return; // hide has already been called, abort init
 
   [_rootView setLoadingView:loadingView];
 
   [[NSNotificationCenter defaultCenter] addObserver:self
-                                           selector:@selector(onJavaScriptDidLoad:)
+                                           selector:@selector(onJavaScriptDidLoad)
                                                name:RCTJavaScriptDidLoadNotification
                                              object:nil];
 
@@ -62,21 +47,10 @@ RCT_EXPORT_MODULE();
                                            selector:@selector(onJavaScriptDidFailToLoad)
                                                name:RCTJavaScriptDidFailToLoadNotification
                                              object:nil];
-
-  [[NSNotificationCenter defaultCenter] addObserver:self
-                                           selector:@selector(shiftNextTask)
-                                               name:UIApplicationDidBecomeActiveNotification
-                                             object:nil];
 }
 
-+ (void)onJavaScriptDidLoad:(NSNotification *)notification {
-  [[NSNotificationCenter defaultCenter] removeObserver:self
-                                                  name:RCTJavaScriptDidLoadNotification
-                                                object:nil];
-
-  [[NSNotificationCenter defaultCenter] removeObserver:self
-                                                  name:RCTJavaScriptDidFailToLoadNotification
-                                                object:nil];
++ (void)onJavaScriptDidLoad {
+  [[NSNotificationCenter defaultCenter] removeObserver:self];
 }
 
 + (void)onJavaScriptDidFailToLoad {
@@ -91,39 +65,36 @@ RCT_EXPORT_MODULE();
 + (void)removeLoadingView {
   if (![self isHidden]) {
     _rootView.loadingView.hidden = YES;
+
     [_rootView.loadingView removeFromSuperview];
     _rootView.loadingView = nil;
   }
 }
 
-+ (void)ensureTaskQueue {
-  if (_taskQueue == nil)
-    _taskQueue = [[NSMutableArray alloc] init];
-}
-
-+ (void)shiftNextTask {
-  [self ensureTaskQueue];
+- (void)clearResolverQueue {
+  while ([_resolverQueue count] > 0) {
+    RCTPromiseResolveBlock resolve = [_resolverQueue objectAtIndex:0];
+    [_resolverQueue removeObjectAtIndex:0];
 
-  if ([_taskQueue count] > 0 &&
-      !_isTransitioning &&
-      [[UIApplication sharedApplication] applicationState] != UIApplicationStateBackground) {
-    RNBootSplashTask *task = [_taskQueue objectAtIndex:0];
-    [_taskQueue removeObjectAtIndex:0];
-
-    [self hideWithTask:task];
+    resolve(@(true));
   }
 }
 
-+ (void)hideWithTask:(RNBootSplashTask *)task {
-  if ([self isHidden]) {
-    task.resolve(@(true));
-    return [self shiftNextTask];
-  }
+RCT_REMAP_METHOD(hide,
+                 hideWithFade:(BOOL)fade
+                 resolver:(RCTPromiseResolveBlock)resolve
+                 rejecter:(RCTPromiseRejectBlock)reject) {
+  if (_resolverQueue == nil)
+    _resolverQueue = [[NSMutableArray alloc] init];
+
+  [_resolverQueue addObject:resolve];
 
-  if (!task.fade) {
-    [self removeLoadingView];
-    task.resolve(@(true));
-    return [self shiftNextTask];
+  if ([RNBootSplash isHidden] || RCTRunningInAppExtension())
+    return [self clearResolverQueue];
+
+  if (!fade) {
+    [RNBootSplash removeLoadingView];
+    return [self clearResolverQueue];
   }
 
   dispatch_async(dispatch_get_main_queue(), ^{
@@ -139,31 +110,13 @@ RCT_EXPORT_MODULE();
       [_rootView.loadingView removeFromSuperview];
       _rootView.loadingView = nil;
 
-      task.resolve(@(true));
       _isTransitioning = false;
 
-      return [self shiftNextTask];
+      return [self clearResolverQueue];
     }];
   });
 }
 
-RCT_REMAP_METHOD(hide,
-                 hideWithFade:(BOOL)fade
-                 resolver:(RCTPromiseResolveBlock)resolve
-                 rejecter:(RCTPromiseRejectBlock)reject) {
-  _shouldPreventInit = true;
-
-  if ([RNBootSplash isHidden] || RCTRunningInAppExtension())
-    return resolve(@(true));
-
-  RNBootSplashTask *task = [[RNBootSplashTask alloc] initWithFade:fade
-                                                         resolver:resolve];
-
-  [RNBootSplash ensureTaskQueue];
-  [_taskQueue addObject:task];
-  [RNBootSplash shiftNextTask];
-}
-
 RCT_REMAP_METHOD(getVisibilityStatus,
                  getVisibilityStatusWithResolver:(RCTPromiseResolveBlock)resolve
                  rejecter:(RCTPromiseRejectBlock)reject) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-native-bootsplash",
-  "version": "4.1.2",
+  "version": "4.1.3",
   "license": "MIT",
   "description": "Display a bootsplash on your app starts. Hide it when you want.",
   "author": "Mathieu Acthernoene <zoontek@gmail.com>",

package/android/src/main/java/com/zoontek/rnbootsplash/RNBootSplashTask.java

@@ -1,25 +0,0 @@
-package com.zoontek.rnbootsplash;
-
-import androidx.annotation.NonNull;
-
-import com.facebook.react.bridge.Promise;
-
-public class RNBootSplashTask {
-
-  private final boolean mFade;
-  @NonNull private final Promise mPromise;
-
-  public RNBootSplashTask(final boolean fade, @NonNull final Promise promise) {
-    mFade = fade;
-    mPromise = promise;
-  }
-
-  public boolean getFade() {
-    return mFade;
-  }
-
-  @NonNull
-  public Promise getPromise() {
-    return mPromise;
-  }
-}