react-native-ble-manager 10.0.0 → 10.0.2

package/README.md

@@ -301,7 +301,7 @@ BleManager.startNotification(
 
 ### startNotificationUseBuffer(peripheralId, serviceUUID, characteristicUUID, buffer) [Android only]
 
-Start the notification on the specified characteristic, you need to call `retrieveServices` method before. The buffer will collect a number or messages from the server and then emit once the buffer count it reached. Helpful to reducing the number or js bridge crossings when a characteristic is sending a lot of messages.
+Start the notification on the specified characteristic, you need to call `retrieveServices` method before. The buffer collect messages until the buffer of messages bytes reaches the limit defined with the `buffer` argument and then emit all the collected data. Helpful to reducing the number or js bridge crossings when a characteristic is sending a lot of messages.
 Returns a `Promise` object.
 
 **Arguments**
@@ -309,7 +309,7 @@ Returns a `Promise` object.
 - `peripheralId` - `String` - the id/mac address of the peripheral.
 - `serviceUUID` - `String` - the UUID of the service.
 - `characteristicUUID` - `String` - the UUID of the characteristic.
-- `buffer` - `Integer` - a number of message to buffer prior to emit for the characteristic.
+- `buffer` - `Integer` - the capacity of the buffer (bytes) stored before emitting the data for the characteristic.
 
 **Examples**
 

package/android/src/main/java/it/innove/NotifyBufferContainer.java

@@ -3,30 +3,34 @@ package it.innove;
 import java.nio.ByteBuffer;
 
 public class NotifyBufferContainer {
-    public final Integer maxBufferSize;
-    private Integer bufferCount;
     public ByteBuffer items;
 
-    public NotifyBufferContainer(Integer size) {
-        this.maxBufferSize = size;
-        this.resetBuffer();
+    public NotifyBufferContainer(int size) {
+        this.items = ByteBuffer.allocate(size);
     }
     public void resetBuffer(){
-        this.bufferCount = 0;
-        this.items = ByteBuffer.allocate(this.maxBufferSize);
+        this.items.clear();
     }
-    public void put(byte[] value){
-        this.bufferCount += value.length;
-        if (this.items.remaining() < value.length) {
-            return;
+    public byte[] put(byte[] value){
+        int restLength = value.length - this.items.remaining();
+        byte[] toInsert = null;
+        byte[] rest = null;
+        if (restLength < 0) {
+            rest = new byte[restLength];
+            toInsert = new byte[value.length - restLength];
+            System.arraycopy(value, 0, toInsert, 0, toInsert.length);
+            System.arraycopy(value, toInsert.length, rest, restLength, rest.length);
+        } else {
+            toInsert = value;
         }
-        this.items.put(value);
+        this.items.put(toInsert);
+        return rest;
     }
     public boolean isBufferFull(){
-        return this.bufferCount >= this.maxBufferSize;
+        return this.items.remaining() == 0;
     }
-    public Integer size() {
-        return this.bufferCount;
+    public int size() {
+        return this.items.limit();
     }
     @Override 
     protected void finalize() throws Throwable {