react-native-background-geolocation 4.4.1 → 4.4.2

package/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Change Log
 
+## 4.4.2 — 2021-10-29
+* [Fixed][Android] Android 12 behaviour changes mean that foreground-services remain running.  When an Android app is terminated, the app process does not terminate (since the foreground-service is active) and `RNBackgroundGeolocationModule` remains in memory.  Given that, the plugin cannot rely on registering its event-listeners in the `RNBackgroundGeolocationModule` constructor, but must perform that task when `.ready()` is called.  This also requires resetting `mReady = false` when the `MainActivity` is destroyed, so that the next time `.ready()` is called, the event-listeners are re-registered.
+* [Fixed][Android] When `.ready()` is called __`reset: false`__, the `success` callback was not invoked with the current `State`.  This bug was introduced in previous `v4.4.1`.
+
 ## 4.4.1 — 2021-10-29
 * [Added] Added a `Subscription` interface to Typescript API.  Added helpful docs to Subscription for new event-handler subscriptions.
 

package/android/src/main/java/com/transistorsoft/rnbackgroundgeolocation/RNBackgroundGeolocationModule.java

@@ -90,13 +90,14 @@ public class RNBackgroundGeolocationModule extends ReactContextBaseJavaModule im
 
     public RNBackgroundGeolocationModule(ReactApplicationContext reactContext) {
         super(reactContext);
+        reactContext.addLifecycleEventListener(this);
 
         TSConfig config = TSConfig.getInstance(getReactApplicationContext());
         config.useCLLocationAccuracy(true);
 
         config.updateWithBuilder()
-            .setHeadlessJobService(getClass().getPackage().getName() + "." + JOB_SERVICE_CLASS)
-            .commit();
+                .setHeadlessJobService(getClass().getPackage().getName() + "." + JOB_SERVICE_CLASS)
+                .commit();
 
         // These are the only events which can be subscribed to.
         mEvents.add(BackgroundGeolocation.EVENT_LOCATION);
@@ -113,9 +114,18 @@ public class RNBackgroundGeolocationModule extends ReactContextBaseJavaModule im
         mEvents.add(BackgroundGeolocation.EVENT_ENABLEDCHANGE);
         mEvents.add(BackgroundGeolocation.EVENT_NOTIFICATIONACTION);
         mEvents.add(TSAuthorization.NAME);
+    }
 
-        reactContext.addLifecycleEventListener(this);
+    @Override
+    public void initialize() {
+        // do nothing
+    }
+    @Override
+    public String getName() {
+        return "RNBackgroundGeolocation";
+    }
 
+    private void registerEvents() {
         BackgroundGeolocation adapter = getAdapter();
         adapter.onLocation(new LocationCallback());
         adapter.onMotionChange(new MotionChangeCallback());
@@ -133,16 +143,6 @@ public class RNBackgroundGeolocationModule extends ReactContextBaseJavaModule im
         HttpService.getInstance(getReactApplicationContext()).onAuthorization(new AuthorizationCallback());
     }
 
-    @Override
-    public void initialize() {
-        // do nothing
-    }
-    @Override
-    public String getName() {
-        return "RNBackgroundGeolocation";
-    }
-
-
     /**
      * location event callback
      */
@@ -340,6 +340,7 @@ public class RNBackgroundGeolocationModule extends ReactContextBaseJavaModule im
     @Override
     public void onHostDestroy() {
         mInitialized = false;
+        mReady = false;
         removeAllListeners();
         getAdapter().onActivityDestroy();
     }
@@ -374,10 +375,13 @@ public class RNBackgroundGeolocationModule extends ReactContextBaseJavaModule im
                 setConfig(params, success, failure);
             } else {
                 TSLog.logger.warn(TSLog.warn("#ready already called.  Ignored config since reset: false"));
+                success.invoke(getState());
             }
             return;
         }
         mReady = true;
+        registerEvents();
+
         if (config.isFirstBoot()) {
             config.updateWithJSONObject(mapToJson(setHeadlessJobService(params)));
         } else {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-native-background-geolocation",
-  "version": "4.4.1",
+  "version": "4.4.2",
   "description": "The most sophisticated cross-platform background location-tracking & geofencing module with battery-conscious motion-detection intelligence",
   "scripts": {
     "test": "echo \"Error: no test specified\" && exit 1"