react-native-audio-browser 0.2.0-next.52 → 0.2.0-next.54

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (329) hide show
  1. package/android/src/cast/java/com/audiobrowser/cast/CastSupport.kt +8 -10
  2. package/android/src/main/java/com/audiobrowser/AudioBrowser.kt +96 -243
  3. package/android/src/main/java/com/audiobrowser/AudioBrowserLifecycleModule.kt +8 -12
  4. package/android/src/main/java/com/audiobrowser/AudioBrowserPackage.kt +1 -3
  5. package/android/src/main/java/com/audiobrowser/Callbacks.kt +1 -10
  6. package/android/src/main/java/com/audiobrowser/ForegroundStart.kt +13 -18
  7. package/android/src/main/java/com/audiobrowser/HeadlessTaskService.kt +3 -7
  8. package/android/src/main/java/com/audiobrowser/RemoteOutputs.kt +8 -10
  9. package/android/src/main/java/com/audiobrowser/Service.kt +20 -61
  10. package/android/src/main/java/com/audiobrowser/ServiceBinding.kt +9 -17
  11. package/android/src/main/java/com/audiobrowser/browser/ArtworkResolutionRegistry.kt +10 -9
  12. package/android/src/main/java/com/audiobrowser/browser/BrowseArtworkRegistry.kt +11 -8
  13. package/android/src/main/java/com/audiobrowser/browser/BrowserManager.kt +117 -448
  14. package/android/src/main/java/com/audiobrowser/browser/BrowserUrlResolution.kt +21 -60
  15. package/android/src/main/java/com/audiobrowser/browser/InertStyleDiagnostic.kt +20 -80
  16. package/android/src/main/java/com/audiobrowser/browser/JsonArtwork.kt +6 -10
  17. package/android/src/main/java/com/audiobrowser/browser/JsonModels.kt +7 -24
  18. package/android/src/main/java/com/audiobrowser/browser/RouteMatch.kt +2 -4
  19. package/android/src/main/java/com/audiobrowser/browser/SectionScope.kt +13 -31
  20. package/android/src/main/java/com/audiobrowser/browser/SimpleRouter.kt +12 -40
  21. package/android/src/main/java/com/audiobrowser/browser/StyleResolver.kt +15 -26
  22. package/android/src/main/java/com/audiobrowser/browser/TrackLoadHandler.kt +5 -15
  23. package/android/src/main/java/com/audiobrowser/extension/EnumExtensions.kt +1 -0
  24. package/android/src/main/java/com/audiobrowser/extension/NumberExt.kt +2 -0
  25. package/android/src/main/java/com/audiobrowser/extension/ResolvedTrackExt.kt +4 -8
  26. package/android/src/main/java/com/audiobrowser/extension/TappedTrack.kt +4 -6
  27. package/android/src/main/java/com/audiobrowser/extension/TrackIdentity.kt +3 -7
  28. package/android/src/main/java/com/audiobrowser/http/HttpClient.kt +13 -22
  29. package/android/src/main/java/com/audiobrowser/http/RequestConfigBuilder.kt +17 -38
  30. package/android/src/main/java/com/audiobrowser/model/IcyTitle.kt +5 -6
  31. package/android/src/main/java/com/audiobrowser/model/PlaybackMetadata.kt +4 -9
  32. package/android/src/main/java/com/audiobrowser/model/PlayerSetupOptions.kt +18 -29
  33. package/android/src/main/java/com/audiobrowser/model/PlayerUpdateOptions.kt +6 -16
  34. package/android/src/main/java/com/audiobrowser/player/AutomaticBufferManager.kt +15 -45
  35. package/android/src/main/java/com/audiobrowser/player/CapabilityControls.kt +23 -59
  36. package/android/src/main/java/com/audiobrowser/player/CrossOriginHeaderStripper.kt +14 -26
  37. package/android/src/main/java/com/audiobrowser/player/DynamicLoadControl.kt +15 -43
  38. package/android/src/main/java/com/audiobrowser/player/EnginePlayback.kt +4 -4
  39. package/android/src/main/java/com/audiobrowser/player/EqualizerController.kt +15 -21
  40. package/android/src/main/java/com/audiobrowser/player/InterceptingPlayer.kt +14 -31
  41. package/android/src/main/java/com/audiobrowser/player/LocalEngine.kt +8 -8
  42. package/android/src/main/java/com/audiobrowser/player/MediaFactory.kt +16 -27
  43. package/android/src/main/java/com/audiobrowser/player/MediaSessionCallback.kt +119 -237
  44. package/android/src/main/java/com/audiobrowser/player/MediaSessionCommandManager.kt +48 -145
  45. package/android/src/main/java/com/audiobrowser/player/NowPlayingUpdater.kt +39 -100
  46. package/android/src/main/java/com/audiobrowser/player/PlaybackErrorClassifier.kt +16 -26
  47. package/android/src/main/java/com/audiobrowser/player/PlaybackStateMachine.kt +22 -28
  48. package/android/src/main/java/com/audiobrowser/player/PlaybackStateStore.kt +28 -64
  49. package/android/src/main/java/com/audiobrowser/player/PlaybackTimer.kt +8 -4
  50. package/android/src/main/java/com/audiobrowser/player/Player.kt +117 -405
  51. package/android/src/main/java/com/audiobrowser/player/PlayerCapabilitiesExt.kt +1 -1
  52. package/android/src/main/java/com/audiobrowser/player/PlayerEngineFactory.kt +11 -19
  53. package/android/src/main/java/com/audiobrowser/player/PlayerListener.kt +30 -96
  54. package/android/src/main/java/com/audiobrowser/player/RetryLoadErrorHandlingPolicy.kt +39 -95
  55. package/android/src/main/java/com/audiobrowser/player/ShuffleOrderLedBy.kt +7 -13
  56. package/android/src/main/java/com/audiobrowser/player/SleepTimer.kt +13 -30
  57. package/android/src/main/java/com/audiobrowser/player/SleepTimerManager.kt +7 -11
  58. package/android/src/main/java/com/audiobrowser/player/StuckRecoveryPolicy.kt +9 -22
  59. package/android/src/main/java/com/audiobrowser/player/TransformingDataSource.kt +22 -54
  60. package/android/src/main/java/com/audiobrowser/player/VolumeFader.kt +8 -15
  61. package/android/src/main/java/com/audiobrowser/remote/RemoteItem.kt +9 -8
  62. package/android/src/main/java/com/audiobrowser/remote/RemoteOutputsController.kt +13 -10
  63. package/android/src/main/java/com/audiobrowser/remote/RemotePlayback.kt +8 -8
  64. package/android/src/main/java/com/audiobrowser/remote/RemoteQueue.kt +12 -5
  65. package/android/src/main/java/com/audiobrowser/remote/RemoteSwitchingPlayer.kt +35 -49
  66. package/android/src/main/java/com/audiobrowser/sonos/DeviceDescriptionParser.kt +11 -19
  67. package/android/src/main/java/com/audiobrowser/sonos/DidlLite.kt +2 -2
  68. package/android/src/main/java/com/audiobrowser/sonos/SoapClient.kt +6 -6
  69. package/android/src/main/java/com/audiobrowser/sonos/SoapEnvelopes.kt +8 -9
  70. package/android/src/main/java/com/audiobrowser/sonos/SoapResponseParser.kt +11 -18
  71. package/android/src/main/java/com/audiobrowser/sonos/SonosDiscoverer.kt +10 -10
  72. package/android/src/main/java/com/audiobrowser/sonos/SonosOutputs.kt +10 -10
  73. package/android/src/main/java/com/audiobrowser/sonos/SonosPlayer.kt +21 -33
  74. package/android/src/main/java/com/audiobrowser/sonos/SonosRemote.kt +4 -6
  75. package/android/src/main/java/com/audiobrowser/sonos/SonosRouteProviderService.kt +9 -10
  76. package/android/src/main/java/com/audiobrowser/sonos/SonosStreamUri.kt +7 -7
  77. package/android/src/main/java/com/audiobrowser/sonos/SonosTransport.kt +5 -4
  78. package/android/src/main/java/com/audiobrowser/sonos/SsdpDiscovery.kt +8 -3
  79. package/android/src/main/java/com/audiobrowser/sonos/SsdpMessages.kt +4 -6
  80. package/android/src/main/java/com/audiobrowser/sonos/ZoneGroupState.kt +13 -11
  81. package/android/src/main/java/com/audiobrowser/tls/AiaCertChaser.kt +34 -71
  82. package/android/src/main/java/com/audiobrowser/tls/AiaChasingExtendedTrustManager.kt +20 -37
  83. package/android/src/main/java/com/audiobrowser/tls/AiaChasingTrustManager.kt +18 -27
  84. package/android/src/main/java/com/audiobrowser/tls/AiaTls.kt +14 -29
  85. package/android/src/main/java/com/audiobrowser/tls/CachingCertificateFetcher.kt +68 -133
  86. package/android/src/main/java/com/audiobrowser/util/ArtworkContentProvider.kt +10 -22
  87. package/android/src/main/java/com/audiobrowser/util/ArtworkRoutes.kt +6 -6
  88. package/android/src/main/java/com/audiobrowser/util/ArtworkUris.kt +4 -3
  89. package/android/src/main/java/com/audiobrowser/util/ArtworkVariant.kt +2 -13
  90. package/android/src/main/java/com/audiobrowser/util/Automotive.kt +2 -4
  91. package/android/src/main/java/com/audiobrowser/util/BatteryOptimizationHelper.kt +3 -9
  92. package/android/src/main/java/com/audiobrowser/util/BatteryWarningStore.kt +4 -14
  93. package/android/src/main/java/com/audiobrowser/util/BrowserPathHelper.kt +21 -85
  94. package/android/src/main/java/com/audiobrowser/util/CoilArtworkLoader.kt +7 -7
  95. package/android/src/main/java/com/audiobrowser/util/CoilArtworkLoaderHolder.kt +5 -8
  96. package/android/src/main/java/com/audiobrowser/util/CoilBitmapLoader.kt +8 -24
  97. package/android/src/main/java/com/audiobrowser/util/EqualizerManager.kt +7 -39
  98. package/android/src/main/java/com/audiobrowser/util/MediaExtrasBuilder.kt +10 -14
  99. package/android/src/main/java/com/audiobrowser/util/MetadataAdapter.kt +5 -9
  100. package/android/src/main/java/com/audiobrowser/util/NetworkConnectivityMonitor.kt +5 -9
  101. package/android/src/main/java/com/audiobrowser/util/OutputMonitor.kt +21 -50
  102. package/android/src/main/java/com/audiobrowser/util/OutputSwitcher.kt +7 -20
  103. package/android/src/main/java/com/audiobrowser/util/PlayingStateFactory.kt +3 -5
  104. package/android/src/main/java/com/audiobrowser/util/RatingFavorites.kt +4 -5
  105. package/android/src/main/java/com/audiobrowser/util/StyleWire.kt +5 -5
  106. package/android/src/main/java/com/audiobrowser/util/SvgArtworkRenderer.kt +5 -9
  107. package/android/src/main/java/com/audiobrowser/util/SystemVolumeMonitor.kt +6 -9
  108. package/android/src/main/java/com/audiobrowser/util/TrackFactory.kt +25 -47
  109. package/android/src/nocast/java/com/audiobrowser/cast/CastSupport.kt +0 -2
  110. package/android/src/test/java/com/audiobrowser/ForegroundStartTest.kt +1 -2
  111. package/android/src/test/java/com/audiobrowser/LegacyRatingTest.kt +3 -3
  112. package/android/src/test/java/com/audiobrowser/ServiceBindingTest.kt +0 -13
  113. package/android/src/test/java/com/audiobrowser/ServiceTaskRemovedTest.kt +2 -3
  114. package/android/src/test/java/com/audiobrowser/TestFixtures.kt +5 -14
  115. package/android/src/test/java/com/audiobrowser/browser/BrowseArtworkRegistryTest.kt +1 -1
  116. package/android/src/test/java/com/audiobrowser/browser/BrowserManagerBuildApiRequestTest.kt +2 -8
  117. package/android/src/test/java/com/audiobrowser/browser/BrowserManagerFavoritesTest.kt +2 -12
  118. package/android/src/test/java/com/audiobrowser/browser/BrowserManagerLayerResolutionTest.kt +5 -28
  119. package/android/src/test/java/com/audiobrowser/browser/BrowserManagerTest.kt +11 -43
  120. package/android/src/test/java/com/audiobrowser/browser/BrowserUrlResolutionTest.kt +4 -13
  121. package/android/src/test/java/com/audiobrowser/browser/InertStyleDiagnosticTest.kt +2 -11
  122. package/android/src/test/java/com/audiobrowser/browser/JsonArtworkTest.kt +0 -2
  123. package/android/src/test/java/com/audiobrowser/browser/JsonStyleTest.kt +3 -8
  124. package/android/src/test/java/com/audiobrowser/browser/SectionScopeTest.kt +2 -14
  125. package/android/src/test/java/com/audiobrowser/browser/SimpleRouterTest.kt +1 -5
  126. package/android/src/test/java/com/audiobrowser/browser/StyleResolverTest.kt +2 -13
  127. package/android/src/test/java/com/audiobrowser/extension/TappedTrackTest.kt +1 -7
  128. package/android/src/test/java/com/audiobrowser/extension/TrackIdentityTest.kt +0 -5
  129. package/android/src/test/java/com/audiobrowser/http/RequestConfigBuilderTest.kt +8 -16
  130. package/android/src/test/java/com/audiobrowser/model/IcyTitleTest.kt +1 -1
  131. package/android/src/test/java/com/audiobrowser/player/BrowseTilesTest.kt +12 -29
  132. package/android/src/test/java/com/audiobrowser/player/CapabilityControlsTest.kt +3 -12
  133. package/android/src/test/java/com/audiobrowser/player/CrossOriginHeaderStripperTest.kt +0 -7
  134. package/android/src/test/java/com/audiobrowser/player/DynamicLoadControlTest.kt +0 -1
  135. package/android/src/test/java/com/audiobrowser/player/EqualizerControllerTest.kt +0 -9
  136. package/android/src/test/java/com/audiobrowser/player/LiveSeekCommandTest.kt +1 -2
  137. package/android/src/test/java/com/audiobrowser/player/MediaSessionSlotMappingTest.kt +0 -9
  138. package/android/src/test/java/com/audiobrowser/player/NowPlayingUpdaterTest.kt +15 -22
  139. package/android/src/test/java/com/audiobrowser/player/PlaybackErrorClassifierTest.kt +1 -24
  140. package/android/src/test/java/com/audiobrowser/player/PlaybackStateMachineTest.kt +0 -20
  141. package/android/src/test/java/com/audiobrowser/player/PlaybackStateStoreTrackJsonTest.kt +1 -6
  142. package/android/src/test/java/com/audiobrowser/player/PlaybackTimerTest.kt +2 -4
  143. package/android/src/test/java/com/audiobrowser/player/PlayerCastTest.kt +16 -2
  144. package/android/src/test/java/com/audiobrowser/player/PlayerEngineFactoryTest.kt +0 -3
  145. package/android/src/test/java/com/audiobrowser/player/PlayerInvalidTrackTest.kt +0 -1
  146. package/android/src/test/java/com/audiobrowser/player/PlayerSetupTest.kt +3 -2
  147. package/android/src/test/java/com/audiobrowser/player/PlayerSonosTest.kt +26 -4
  148. package/android/src/test/java/com/audiobrowser/player/PlayerSuppressionTest.kt +5 -7
  149. package/android/src/test/java/com/audiobrowser/player/RetryLoadErrorHandlingPolicyTest.kt +4 -35
  150. package/android/src/test/java/com/audiobrowser/player/SessionErrorMaskTest.kt +0 -5
  151. package/android/src/test/java/com/audiobrowser/player/ShuffleOrderLedByTest.kt +1 -8
  152. package/android/src/test/java/com/audiobrowser/player/StandardSkipTest.kt +4 -6
  153. package/android/src/test/java/com/audiobrowser/player/StuckRecoveryPolicyTest.kt +11 -11
  154. package/android/src/test/java/com/audiobrowser/player/TransformingDataSourceTest.kt +2 -23
  155. package/android/src/test/java/com/audiobrowser/remote/FakeRemote.kt +15 -11
  156. package/android/src/test/java/com/audiobrowser/remote/RemoteSwitchingPlayerTest.kt +112 -1
  157. package/android/src/test/java/com/audiobrowser/sonos/DeviceDescriptionParserTest.kt +1 -3
  158. package/android/src/test/java/com/audiobrowser/sonos/DidlLiteTest.kt +0 -1
  159. package/android/src/test/java/com/audiobrowser/sonos/SoapClientTest.kt +0 -3
  160. package/android/src/test/java/com/audiobrowser/sonos/SoapEnvelopesTest.kt +0 -1
  161. package/android/src/test/java/com/audiobrowser/sonos/SoapResponseParserTest.kt +0 -1
  162. package/android/src/test/java/com/audiobrowser/sonos/SonosDiscovererTest.kt +2 -0
  163. package/android/src/test/java/com/audiobrowser/sonos/SonosPlayerTest.kt +0 -1
  164. package/android/src/test/java/com/audiobrowser/sonos/SonosRemoteTest.kt +1 -1
  165. package/android/src/test/java/com/audiobrowser/sonos/SonosRoutesTest.kt +2 -0
  166. package/android/src/test/java/com/audiobrowser/sonos/SonosTransportTest.kt +2 -6
  167. package/android/src/test/java/com/audiobrowser/sonos/SsdpMessagesTest.kt +0 -2
  168. package/android/src/test/java/com/audiobrowser/tls/AiaCertChaserTest.kt +13 -37
  169. package/android/src/test/java/com/audiobrowser/tls/AiaChasingTrustManagerTest.kt +10 -24
  170. package/android/src/test/java/com/audiobrowser/tls/CachingCertificateFetcherCallSiteTest.kt +15 -39
  171. package/android/src/test/java/com/audiobrowser/tls/CachingCertificateFetcherTest.kt +4 -10
  172. package/android/src/test/java/com/audiobrowser/util/ArtworkContentProviderTest.kt +2 -11
  173. package/android/src/test/java/com/audiobrowser/util/ArtworkUrisTest.kt +0 -1
  174. package/android/src/test/java/com/audiobrowser/util/BrowserPathHelperTest.kt +0 -4
  175. package/android/src/test/java/com/audiobrowser/util/CoilArtworkLoaderHolderTest.kt +1 -1
  176. package/android/src/test/java/com/audiobrowser/util/CoilArtworkLoaderTest.kt +0 -5
  177. package/android/src/test/java/com/audiobrowser/util/FakeImageLoader.kt +2 -2
  178. package/android/src/test/java/com/audiobrowser/util/MediaExtrasBuilderTest.kt +4 -12
  179. package/android/src/test/java/com/audiobrowser/util/OutputMonitorTest.kt +1 -1
  180. package/android/src/test/java/com/audiobrowser/util/PlayingStateFactoryTest.kt +0 -4
  181. package/android/src/test/java/com/audiobrowser/util/TrackFactoryBrowseTest.kt +1 -1
  182. package/android/src/test/java/com/audiobrowser/util/TrackFactoryMediaIdTest.kt +4 -6
  183. package/android/src/testCast/java/com/audiobrowser/cast/CastEndsTest.kt +1 -1
  184. package/android/src/testCast/java/com/audiobrowser/cast/SendingMediaItemConverterTest.kt +1 -0
  185. package/ios/AVPlayerEngine.swift +13 -21
  186. package/ios/AVPlayerEngineCallbacks.swift +2 -4
  187. package/ios/Browser/BrowseGate.swift +7 -8
  188. package/ios/Browser/BrowserConfig.swift +19 -34
  189. package/ios/Browser/BrowserError.swift +0 -1
  190. package/ios/Browser/BrowserManager.swift +29 -75
  191. package/ios/Browser/BrowserPathHelper.swift +13 -93
  192. package/ios/Browser/FavoriteSet.swift +7 -10
  193. package/ios/Browser/InertStyleDiagnostic.swift +17 -82
  194. package/ios/Browser/JsonModels.swift +11 -51
  195. package/ios/Browser/NavigationErrorState.swift +3 -2
  196. package/ios/Browser/PageResolver.swift +13 -23
  197. package/ios/Browser/RequestLayer.swift +16 -20
  198. package/ios/Browser/RequestPipeline.swift +33 -43
  199. package/ios/Browser/SearchDrillIn.swift +7 -13
  200. package/ios/Browser/SectionScope.swift +14 -26
  201. package/ios/Browser/SimpleRouter.swift +8 -15
  202. package/ios/Browser/StyleResolver.swift +12 -29
  203. package/ios/Browser/TabBarEntries.swift +6 -11
  204. package/ios/Browser/TrackIdTemplate.swift +6 -14
  205. package/ios/CarPlay/CPInterfaceController+Safe.swift +19 -28
  206. package/ios/CarPlay/CarPlayArtworkResolver.swift +5 -9
  207. package/ios/CarPlay/CarPlayController.swift +4 -4
  208. package/ios/CarPlay/CarPlayImageLoader.swift +11 -26
  209. package/ios/CarPlay/CarPlayListItemFactory.swift +30 -80
  210. package/ios/CarPlay/CarPlayNowPlayingManager.swift +19 -54
  211. package/ios/CarPlay/CarPlaySession+Navigator.swift +10 -10
  212. package/ios/CarPlay/CarPlaySession+PageLoader.swift +6 -5
  213. package/ios/CarPlay/CarPlaySession+Refresher.swift +2 -2
  214. package/ios/CarPlay/CarPlaySession+TabBar.swift +19 -26
  215. package/ios/CarPlay/CarPlaySession.swift +13 -17
  216. package/ios/CarPlay/CarPlayTemplates.swift +6 -7
  217. package/ios/CarPlay/IntentHandlers.swift +3 -5
  218. package/ios/CarPlay/MediaIntentCriteria.swift +15 -29
  219. package/ios/CarPlay/MediaIntentHandler.swift +4 -7
  220. package/ios/CarPlay/MediaIntentPlayback.swift +9 -8
  221. package/ios/CarPlay/NowPlayingButtonRules.swift +3 -4
  222. package/ios/CarPlay/SectionPresentation.swift +18 -28
  223. package/ios/CarPlay/TopTemplateReplacer.swift +8 -9
  224. package/ios/Extension/Capability+RemoteCommand.swift +3 -3
  225. package/ios/Extension/ChapterMetadata+AVFoundation.swift +2 -5
  226. package/ios/Extension/CxxVectorConformances.swift +4 -16
  227. package/ios/Extension/NavigationError+Conversion.swift +4 -7
  228. package/ios/Extension/PlayerCapabilities+Favorite.swift +0 -1
  229. package/ios/Extension/RequestConfig+Copying.swift +2 -6
  230. package/ios/Extension/ResolvedTrack+Copying.swift +2 -8
  231. package/ios/Extension/SearchParams+Query.swift +4 -4
  232. package/ios/Extension/Section+Copying.swift +3 -6
  233. package/ios/Extension/String+IcyCharset.swift +5 -5
  234. package/ios/Extension/TimedMetadata+AVFoundation.swift +6 -12
  235. package/ios/Extension/Track+AVPlayer.swift +1 -2
  236. package/ios/Extension/Track+Copying.swift +2 -8
  237. package/ios/Extension/Track+Identity.swift +4 -9
  238. package/ios/Extension/TrackMetadata+AVFoundation.swift +10 -13
  239. package/ios/Extension/UIApplication+ActiveScene.swift +6 -14
  240. package/ios/Extension/Variant+Artwork.swift +8 -22
  241. package/ios/Http/HttpClient.swift +3 -3
  242. package/ios/HybridAudioBrowser+Browser.swift +10 -16
  243. package/ios/HybridAudioBrowser+Options.swift +6 -9
  244. package/ios/HybridAudioBrowser+Player.swift +8 -16
  245. package/ios/HybridAudioBrowser+PlayerCallbacks.swift +4 -5
  246. package/ios/HybridAudioBrowser+Stubs.swift +5 -7
  247. package/ios/HybridAudioBrowser.swift +54 -79
  248. package/ios/Model/NitroTypeStubs.swift +15 -22
  249. package/ios/Model/PlayerUpdateOptions.swift +6 -21
  250. package/ios/Model/RemoteCommand.swift +2 -2
  251. package/ios/Model/TrackPlayerError.swift +9 -22
  252. package/ios/NowPlayingInfo/NowPlayingInfoController.swift +21 -40
  253. package/ios/NowPlayingInfo/SilentAudioPrimer.swift +10 -16
  254. package/ios/Observer/ItemObserver.swift +7 -5
  255. package/ios/Observer/PlayerObserver.swift +5 -5
  256. package/ios/PlaybackEvent.swift +2 -2
  257. package/ios/Player/AirPlayStallJudgement.swift +7 -9
  258. package/ios/Player/AudioSessionController.swift +14 -15
  259. package/ios/Player/DeferredSeek.swift +2 -2
  260. package/ios/Player/EndOfTrackJudgement.swift +6 -13
  261. package/ios/Player/ErrorStatus.swift +8 -7
  262. package/ios/Player/MediaLoader.swift +20 -24
  263. package/ios/Player/NowPlayingLines.swift +1 -4
  264. package/ios/Player/NowPlayingUpdater.swift +35 -61
  265. package/ios/Player/PersistedPlaybackState.swift +1 -2
  266. package/ios/Player/PlaybackFailure.swift +20 -24
  267. package/ios/Player/PlaybackPersistence.swift +5 -6
  268. package/ios/Player/PlaybackStateMachine.swift +8 -11
  269. package/ios/Player/PlaybackTimer.swift +8 -11
  270. package/ios/Player/Player.swift +6 -13
  271. package/ios/Player/PlayerEngine.swift +20 -20
  272. package/ios/Player/PlayerStatusTypes.swift +1 -2
  273. package/ios/Player/QueueManager.swift +23 -67
  274. package/ios/Player/RetryLoop.swift +39 -50
  275. package/ios/Player/ShuffleOrder.swift +17 -57
  276. package/ios/Player/SleepTimerManager.swift +13 -28
  277. package/ios/Player/VolumeFader.swift +16 -16
  278. package/ios/RemoteCommand/RemoteCommandCallbacks.swift +6 -16
  279. package/ios/RemoteCommand/RemoteCommandController.swift +8 -10
  280. package/ios/Tests/AirPlayStallJudgementTests.swift +4 -4
  281. package/ios/Tests/BrowserPathHelperTests.swift +3 -6
  282. package/ios/Tests/DeferredSeekTests.swift +1 -3
  283. package/ios/Tests/EmitterTests.swift +0 -1
  284. package/ios/Tests/EndOfTrackJudgementTests.swift +1 -6
  285. package/ios/Tests/FavoriteSetTests.swift +1 -0
  286. package/ios/Tests/GenerationMemoTests.swift +2 -2
  287. package/ios/Tests/InertStyleDiagnosticTests.swift +4 -10
  288. package/ios/Tests/JsonModelsTests.swift +5 -12
  289. package/ios/Tests/LRUCacheTests.swift +1 -5
  290. package/ios/Tests/MediaIntentCriteriaTests.swift +2 -7
  291. package/ios/Tests/MediaLoaderTests.swift +3 -12
  292. package/ios/Tests/ObserverTests.swift +3 -3
  293. package/ios/Tests/PlaybackErrorTests.swift +7 -9
  294. package/ios/Tests/PlaybackFailureTests.swift +9 -17
  295. package/ios/Tests/PlaybackPersistenceTests.swift +1 -0
  296. package/ios/Tests/PlaybackStateMachineTests.swift +1 -16
  297. package/ios/Tests/PlaybackTimerTests.swift +2 -3
  298. package/ios/Tests/PlayerPolicyTests.swift +10 -26
  299. package/ios/Tests/PlayerTests.swift +53 -88
  300. package/ios/Tests/PlayingStateTests.swift +0 -1
  301. package/ios/Tests/QueueManagerTests.swift +30 -80
  302. package/ios/Tests/RemoteCommandControllerTests.swift +5 -13
  303. package/ios/Tests/ResolvedTrackCopyingTests.swift +0 -2
  304. package/ios/Tests/RetryLoopTests.swift +12 -35
  305. package/ios/Tests/SearchDrillInTests.swift +4 -5
  306. package/ios/Tests/SectionPresentationTests.swift +3 -16
  307. package/ios/Tests/SectionScopeTests.swift +3 -6
  308. package/ios/Tests/SimpleRouterTests.swift +1 -5
  309. package/ios/Tests/SleepTimerManagerTests.swift +8 -11
  310. package/ios/Tests/StyleResolverTests.swift +4 -13
  311. package/ios/Tests/Support/ManualSleepTimerScheduler.swift +3 -8
  312. package/ios/Tests/Support/TestTypes.swift +5 -15
  313. package/ios/Tests/TabBarEntriesTests.swift +0 -2
  314. package/ios/Tests/TimedMetadataAVFoundationTests.swift +2 -3
  315. package/ios/Tests/TopTemplateReplacerTests.swift +1 -1
  316. package/ios/Tests/TrackIdTemplateTests.swift +2 -6
  317. package/ios/Tests/TrackMetadataAVFoundationTests.swift +1 -4
  318. package/ios/Tests/TrackSelectorTests.swift +3 -15
  319. package/ios/TrackSelector.swift +13 -25
  320. package/ios/Util/ArtworkFreshness.swift +6 -6
  321. package/ios/Util/ArtworkImageFetcher.swift +19 -20
  322. package/ios/Util/ConcurrentMap.swift +2 -2
  323. package/ios/Util/Emitter.swift +8 -13
  324. package/ios/Util/NetworkMonitor.swift +4 -6
  325. package/ios/Util/OutputPicker.swift +1 -1
  326. package/ios/Util/ReadyValue.swift +3 -2
  327. package/ios/Util/SFSymbolRenderer.swift +17 -30
  328. package/ios/Util/SVGProcessor.swift +5 -9
  329. package/package.json +1 -1
@@ -2,42 +2,32 @@
2
2
  import NitroModules
3
3
  #endif
4
4
 
5
- /// The callbacks `RemoteCommandController` invokes when the system delivers a
6
- /// remote command (lock screen, Control Center, CarPlay, headset).
7
- ///
8
- /// Its own protocol so the controller depends only on what it calls.
9
- /// `AVPlayerEngineCallbacks` extends it, so conformers implement both at once.
5
+ /// What `RemoteCommandController` calls when the system delivers a remote command (lock
6
+ /// screen, Control Center, CarPlay, headset). `AVPlayerEngineCallbacks` extends it, so the
7
+ /// controller depends only on these.
10
8
  @MainActor protocol RemoteCommandCallbacks: AnyObject {
11
- /// Called when play is triggered remotely.
12
9
  func remotePlay()
13
10
 
14
- /// Called when pause is triggered remotely.
15
11
  func remotePause()
16
12
 
17
- /// Called when stop is triggered remotely.
18
13
  func remoteStop()
19
14
 
20
- /// Called when next is triggered remotely.
21
15
  func remoteNext()
22
16
 
23
- /// Called when previous is triggered remotely.
24
17
  func remotePrevious()
25
18
 
26
- /// Called when jump forward is triggered remotely.
19
+ /// `interval` in seconds.
27
20
  func remoteJumpForward(interval: Double)
28
21
 
29
- /// Called when jump backward is triggered remotely.
22
+ /// `interval` in seconds.
30
23
  func remoteJumpBackward(interval: Double)
31
24
 
32
- /// Called when seek is triggered remotely.
25
+ /// `position` in seconds.
33
26
  func remoteSeek(position: Double)
34
27
 
35
- /// Called when repeat mode change is triggered remotely (CarPlay/lock screen).
36
28
  func remoteChangeRepeatMode(mode: RepeatMode)
37
29
 
38
- /// Called when shuffle mode change is triggered remotely (CarPlay/lock screen).
39
30
  func remoteChangeShuffleMode(enabled: Bool)
40
31
 
41
- /// Called when playback rate change is triggered remotely (CarPlay/lock screen).
42
32
  func remoteChangePlaybackRate(rate: Float)
43
33
  }
@@ -3,7 +3,6 @@ import MediaPlayer
3
3
  import os.log
4
4
 
5
5
  extension RepeatMode {
6
- /// Convert to MPRepeatType for MPRemoteCommandCenter sync
7
6
  var mpRepeatType: MPRepeatType {
8
7
  switch self {
9
8
  case .off: .off
@@ -12,7 +11,6 @@ extension RepeatMode {
12
11
  }
13
12
  }
14
13
 
15
- /// Create from MPRepeatType
16
14
  init(from mpRepeatType: MPRepeatType) {
17
15
  switch mpRepeatType {
18
16
  case .off: self = .off
@@ -24,7 +22,6 @@ extension RepeatMode {
24
22
  }
25
23
 
26
24
  extension Bool {
27
- /// Convert to MPShuffleType for MPRemoteCommandCenter sync
28
25
  var mpShuffleType: MPShuffleType {
29
26
  self ? .items : .off
30
27
  }
@@ -44,11 +41,11 @@ final class RemoteCommandController {
44
41
  private var backwardJumpInterval: Double = 15
45
42
  private var playbackRates: [Double] = []
46
43
 
47
- /// Whether the queue has a next / previous track; read whenever those commands are enabled.
44
+ /// Whether the queue has a next / previous track; read whenever those commands are enabled
45
+ /// and by `refreshSkipAvailability`.
48
46
  var skipAvailability: @MainActor () -> (canNext: Bool, canPrevious: Bool) = { (true, true) }
49
47
 
50
- /// The shuffle/repeat display state, kept so it survives a switch to a new command center,
51
- /// which starts with both off.
48
+ // Kept to restore on a new command center, which starts with shuffle and repeat off.
52
49
  private var shuffleEnabled = false
53
50
  private var repeatMode: RepeatMode = .off
54
51
 
@@ -60,7 +57,7 @@ final class RemoteCommandController {
60
57
  self.callbacks = callbacks
61
58
  }
62
59
 
63
- /// Moves the enabled commands and their state to `newCenter`: the linked
60
+ /// Moves the enabled commands and shuffle/repeat state to `newCenter`. A linked
64
61
  /// `MPNowPlayingSession` has its own command center, which replaces the shared one.
65
62
  func switchCommandCenter(_ newCenter: MPRemoteCommandCenter) {
66
63
  guard newCenter !== center else { return }
@@ -73,8 +70,8 @@ final class RemoteCommandController {
73
70
  logger.info("Switched command center, re-enabled \(commands.count) commands")
74
71
  }
75
72
 
76
- /// Enables exactly `commands`, disabling any enabled command they no longer include. The skip
77
- /// commands offer their interval, the rate command `playbackRates`.
73
+ /// Enables exactly `commands`, disabling any enabled command not among them. Intervals are
74
+ /// in seconds.
78
75
  func enable(
79
76
  commands: Set<RemoteCommand>,
80
77
  forwardJumpInterval: Double = 15,
@@ -104,7 +101,7 @@ final class RemoteCommandController {
104
101
  center.changeShuffleModeCommand.currentShuffleType = enabled.mpShuffleType
105
102
  }
106
103
 
107
- /// Greys out next/previous when `skipAvailability` says the queue has nowhere to skip.
104
+ /// Re-reads `skipAvailability`; call it when the queue changes.
108
105
  func refreshSkipAvailability() {
109
106
  let (canNext, canPrevious) = skipAvailability()
110
107
  if enabledCommands.contains(.next) { center.nextTrackCommand.isEnabled = canNext }
@@ -138,6 +135,7 @@ final class RemoteCommandController {
138
135
  default: break
139
136
  }
140
137
  let mpCommand = mpCommand(for: command)
138
+ // `nil` removes every target, so re-enabling an enabled command does not stack handlers.
141
139
  mpCommand.removeTarget(nil)
142
140
  mpCommand.addTarget { [weak self] event in
143
141
  self?.handle(event, for: command) ?? .commandFailed
@@ -4,9 +4,9 @@ import Testing
4
4
 
5
5
  @Suite("AirPlayStallJudgement")
6
6
  struct AirPlayStallJudgementTests {
7
- /// The exact transition Pocket Casts recovers from: over AirPlay, AVPlayer
8
- /// drops .waitingToPlayAtSpecifiedRate(.noItemToPlay) → .paused while still
9
- /// meant to play. That, and only that, should nudge.
7
+ /// The defaults are the one transition that nudges: over AirPlay, AVPlayer drops
8
+ /// from .waitingToPlayAtSpecifiedRate(.noItemToPlay) to .paused while still meant
9
+ /// to play. Each test below breaks one condition of it.
10
10
  private func judge(
11
11
  previous: PlayerTimeControlStatus? = .waitingToPlayAtSpecifiedRate,
12
12
  current: PlayerTimeControlStatus = .paused,
@@ -46,7 +46,7 @@ struct AirPlayStallJudgementTests {
46
46
  }
47
47
 
48
48
  @Test func reasonNotNoItemToPlay_doesNotNudge() {
49
- // A normal stall (.toMinimizeStalls etc.) landing in paused isn't the bug.
49
+ // An ordinary stall (.toMinimizeStalls etc.) that ends in .paused is not the AirPlay drop.
50
50
  #expect(!judge(reasonWasNoItemToPlay: false).shouldNudge)
51
51
  }
52
52
  }
@@ -30,9 +30,7 @@ import Testing
30
30
  }
31
31
 
32
32
  @Test func buildUrlEmptyPathReturnsBaseWithoutTrailingSlash() {
33
- // An endpoint whose baseUrl already includes the full path (e.g. search,
34
- // `https://host/api/search`) passes an empty path — the base IS the URL, and
35
- // must not gain a dangling trailing slash.
33
+ // An endpoint whose baseUrl is already the whole URL (e.g. search) passes an empty path.
36
34
  let result = BrowserPathHelper.buildUrl(baseUrl: "http://example.com/api/search", path: "")
37
35
  #expect(result == "http://example.com/api/search")
38
36
  }
@@ -87,9 +85,7 @@ import Testing
87
85
  }
88
86
 
89
87
  @Test func buildRoundTripsSrcWithQueryParams() {
90
- // A src carrying its own query string (signed CDN URL) must survive the
91
- // build → extract/strip round-trip: an unescaped `&` splits the src into
92
- // stray query params, truncating the trackId and polluting the parent path.
88
+ // An unescaped `&` in the src would split it into stray query params of the parent path.
93
89
  let src = "https://cdn.example.com/stream.mp3?token=abc&exp=1699999999"
94
90
  let url = BrowserPathHelper.build(parentPath: "/library", trackId: src)
95
91
  #expect(BrowserPathHelper.extractTrackId(url) == src)
@@ -181,6 +177,7 @@ import Testing
181
177
  // MARK: - stampingContextualPaths
182
178
 
183
179
  @Test func stampsPlayableOnlyTracksWithTheirFlatPagePosition() throws {
180
+ // The index counts every track, the one with a path too; the trackId is the id, else the src.
184
181
  let sections = [
185
182
  Section(children: [Track(path: "/a", title: "A"), Track(src: "one.mp3", title: "One")]),
186
183
  Section(children: [Track(id: "two", src: "two.mp3", title: "Two")]),
@@ -39,8 +39,6 @@ struct DeferredSeekTests {
39
39
  #expect(seek.target == 15)
40
40
  }
41
41
 
42
- /// A target captured while a seek is in flight is issued when that seek lands, and only its
43
- /// own landing makes the load ready.
44
42
  @Test func aCaptureInFlightIsReissuedOnLanding() {
45
43
  var seek = DeferredSeek()
46
44
  seek.capture(10)
@@ -52,7 +50,7 @@ struct DeferredSeekTests {
52
50
  #expect(seek.land() == .done)
53
51
  }
54
52
 
55
- /// A seek issued while playing, not deferred, lands as nothing to do.
53
+ /// A seek issued while playing is never deferred, so its landing has nothing to do.
56
54
  @Test func aLandingWithNothingInFlightIsNone() {
57
55
  var seek = DeferredSeek()
58
56
  #expect(seek.land() == .none)
@@ -37,7 +37,6 @@ struct EmitTests {
37
37
  @Test func noCrashWithZeroListeners() {
38
38
  let emitter = Emitter<Int>()
39
39
  emitter.emit(99)
40
- // reaching here without crash is the assertion
41
40
  }
42
41
  }
43
42
 
@@ -4,30 +4,25 @@ import Testing
4
4
 
5
5
  @Suite("EndOfTrackJudgement")
6
6
  struct EndOfTrackJudgementTests {
7
- // Live streams are infinite — an end-of-item is always a dropped connection,
8
- // never a real end, regardless of the reported position/duration.
9
7
  @Test func live_isAlwaysStalled() {
10
8
  #expect(EndOfTrackJudgement(isLive: true, currentTime: 0, duration: 0).outcome == .stalled)
11
9
  #expect(EndOfTrackJudgement(isLive: true, currentTime: 100, duration: 100).outcome == .stalled)
12
10
  #expect(EndOfTrackJudgement(isLive: true, currentTime: 5, duration: .nan).outcome == .stalled)
13
11
  }
14
12
 
15
- // On-demand reaching the end is a genuine finish.
16
13
  @Test func onDemand_atEnd_isEnded() {
17
14
  #expect(EndOfTrackJudgement(isLive: false, currentTime: 300, duration: 300).outcome == .ended)
18
15
  }
19
16
 
20
- // Within the 5% tail still counts as a real finish (decoder rarely lands exactly).
17
+ // The position at a genuine end rarely lands exactly on the duration.
21
18
  @Test func onDemand_withinFivePercentOfEnd_isEnded() {
22
19
  #expect(EndOfTrackJudgement(isLive: false, currentTime: 291, duration: 300).outcome == .ended)
23
20
  }
24
21
 
25
- // More than 5% short of the end → a mid-stream stall reported as EOF.
26
22
  @Test func onDemand_wellShortOfEnd_isStalled() {
27
23
  #expect(EndOfTrackJudgement(isLive: false, currentTime: 120, duration: 300).outcome == .stalled)
28
24
  }
29
25
 
30
- // Unknown/indefinite duration can't be validated — trust the notification.
31
26
  @Test func onDemand_indefiniteDuration_isEnded() {
32
27
  #expect(EndOfTrackJudgement(isLive: false, currentTime: 0, duration: .nan).outcome == .ended)
33
28
  #expect(EndOfTrackJudgement(isLive: false, currentTime: 0, duration: 0).outcome == .ended)
@@ -21,6 +21,7 @@ struct FavoriteSetTests {
21
21
  #expect(set.hydrate(Track(src: "a")).favorited == true)
22
22
  #expect(set.hydrate(Track(src: "b")).favorited == false)
23
23
  #expect(set.hydrate(Track(id: "stable", src: "x")).favorited == true)
24
+ // An id, when present, is the identity, so the src no longer matches.
24
25
  #expect(set.hydrate(Track(id: "other", src: "a")).favorited == false)
25
26
  }
26
27
 
@@ -29,8 +29,8 @@ struct GenerationMemoTests {
29
29
  }
30
30
  }
31
31
 
32
- /// Yields until `count` runs have started, recording an issue rather than hanging when they
33
- /// never do.
32
+ /// Yields until `count` runs have started; when they never do, records an issue and releases
33
+ /// the waiters so the test fails rather than hangs.
34
34
  func waitForRuns(_ count: Int, sourceLocation: SourceLocation = #_sourceLocation) async {
35
35
  for _ in 0 ..< 1000 where runs < count {
36
36
  await Task.yield()
@@ -2,10 +2,8 @@ import Testing
2
2
 
3
3
  @testable import AudioBrowserTestable
4
4
 
5
- // The dev diagnostic for declarations that can never render (ADR 0011): the
6
- // recovery for the compile-time invalid-combination errors the block model
7
- // deliberately gave up. Structural inertness only — a surface that can't draw
8
- // a property it understands is intended usage, never a finding.
5
+ // The diagnostic reports structural inertness only (ADR 0011): a surface that cannot draw a
6
+ // property it understands is intended usage, never a finding.
9
7
 
10
8
  @Suite("InertStyleDiagnostic")
11
9
  struct InertStyleDiagnosticTests {
@@ -40,8 +38,6 @@ struct InertStyleDiagnosticTests {
40
38
  }
41
39
 
42
40
  @Test func aSectionInheritsThePagesGridDisplay() {
43
- // `display` resolves by scope override, so the page's grid makes the
44
- // section's `gridWrap` live without the section restating it.
45
41
  let found = findings(
46
42
  [Section(style: SectionStyle(gridWrap: false), children: [])],
47
43
  page: SectionStyle(display: .grid),
@@ -134,7 +130,6 @@ struct InertStyleDiagnosticTests {
134
130
  // MARK: - The page block
135
131
 
136
132
  @Test func aPageDeclarationLiveInOneSectionIsNotReported() {
137
- // Card tint reaches both sections; one renders cards. Live is live.
138
133
  let found = findings(
139
134
  [
140
135
  Section(style: SectionStyle(gridTile: .card, display: .grid), children: []),
@@ -159,9 +154,8 @@ struct InertStyleDiagnosticTests {
159
154
  }
160
155
 
161
156
  @Test func aSectionOverrideShadowsThePageValue() {
162
- // Every section declares its own tint, so the page's is never resolved —
163
- // shadowed, not inert; the diagnostic reports what can't render, not what
164
- // isn't reached.
157
+ // The page tint is shadowed, not inert: the diagnostic reports what cannot render, not what
158
+ // is never reached.
165
159
  let found = findings(
166
160
  [Section(style: SectionStyle(gridTile: .card, display: .grid, cardTint: "#000"), children: [])],
167
161
  page: SectionStyle(cardTint: "#1e3a8a"),
@@ -37,8 +37,7 @@ struct JsonTrackArtworkTests {
37
37
  }
38
38
 
39
39
  @Test func decodesAPairNestedInChildren() throws {
40
- // The shape that shipped broken: a container decodes its children eagerly,
41
- // so one unparseable row rejected the whole page rather than losing an image.
40
+ // A container decodes its children eagerly, so a child the decoder rejects fails the whole page.
42
41
  let json = """
43
42
  { "path": "/favorites", "title": "Favorites", "children": [
44
43
  { "title": "Playlist", "artwork": { "light": "https://e.example/l.png", "dark": "https://e.example/d.png" } }
@@ -85,8 +84,7 @@ struct JsonStyleTests {
85
84
  }
86
85
 
87
86
  @Test func staleStringStyleDecodesAsNoDeclaration() throws {
88
- // The retired string vocabulary must never kill the page (tolerant
89
- // decoding, ADR 0011) — it decodes as an empty block.
87
+ // The retired string vocabulary (ADR 0011) decodes as no block rather than failing the page.
90
88
  let json = Data(
91
89
  """
92
90
  {"path":"/home","title":"Home","style":"rail","children":[
@@ -104,8 +102,8 @@ struct JsonStyleTests {
104
102
  {"title":"X","style":{"display":"carousel","artworkRendering":"embossed","gridWrap":"yes"}}
105
103
  """.utf8)
106
104
  let track = try JSONDecoder().decode(JsonTrack.self, from: json).toNitro()
107
- // All-unknown declarations collapse to "no block" — one shape for "no
108
- // declaration" on every platform.
105
+ // All-unknown declarations collapse to no block, the one shape for "no declaration" on every
106
+ // platform.
109
107
  #expect(track.style == nil)
110
108
  }
111
109
 
@@ -128,8 +126,7 @@ struct JsonStyleTests {
128
126
  }
129
127
 
130
128
  @Test func accessorySymbolNoneIsAValueNotEmptiness() throws {
131
- // The inheritance-escape sentinel must survive the wire — collapsing it
132
- // to "no declaration" would let the section value flow back in.
129
+ // "none" escapes inheritance; read as no declaration, it would let the section's symbol back in.
133
130
  let json = Data(
134
131
  """
135
132
  {"title":"X","style":{"accessorySymbol":"none"}}
@@ -188,7 +185,6 @@ struct JsonStyleTests {
188
185
  }
189
186
 
190
187
  @Test func styleAndDisabledSurviveThePersistenceRoundTrip() throws {
191
- // Restored queues keep their visible fidelity across process death.
192
188
  let original = JsonTrack(
193
189
  title: "X", src: "s",
194
190
  style: JsonStyle(
@@ -204,8 +200,6 @@ struct JsonStyleTests {
204
200
  }
205
201
 
206
202
  @Test func liveBlockSnapshotsAllItemProperties() throws {
207
- // The persistence snapshot (JsonStyle from a live TrackStyle) must not
208
- // drop the newer item properties.
209
203
  let snapshot = JsonStyle(
210
204
  TrackStyle(
211
205
  display: nil, artworkRendering: .stencil,
@@ -222,7 +216,6 @@ struct JsonStyleTests {
222
216
 
223
217
  @Suite("JsonTrack persistence")
224
218
  struct JsonTrackPersistenceTests {
225
- /// The snapshot a resume restores keeps every field a track persists.
226
219
  @Test func aTrackSurvivesTheRoundTripThroughItsSnapshot() throws {
227
220
  let track = Track(
228
221
  id: "t1", path: "/station/1", src: "https://example.com/a.mp3",
@@ -6,7 +6,6 @@ import Testing
6
6
  @Suite("LRUCache")
7
7
  @MainActor
8
8
  struct LRUCacheTests {
9
- /// A class so the tests can observe release through a weak reference.
10
9
  private final class Box {
11
10
  let id: Int
12
11
  init(_ id: Int) { self.id = id }
@@ -24,7 +23,6 @@ struct LRUCacheTests {
24
23
  #expect(cache.count == 2)
25
24
  }
26
25
 
27
- /// A read is a use: it must move the entry off the eviction end.
28
26
  @Test func readingPromotesAnEntry() {
29
27
  let cache = LRUCache<String, Int>(maxSize: 2)
30
28
  cache.set("a", value: 1)
@@ -50,13 +48,13 @@ struct LRUCacheTests {
50
48
  #expect(cache.count == 2)
51
49
  }
52
50
 
53
- /// Clearing releases every value the cache held (#96).
54
51
  @Test func clearReleasesEveryNode() {
55
52
  let cache = LRUCache<String, Box>(maxSize: 10)
56
53
  weak var first: Box?
57
54
  weak var middle: Box?
58
55
  weak var last: Box?
59
56
 
57
+ // The scope ends the test's own references, so only the cache keeps the boxes alive.
60
58
  do {
61
59
  let a = Box(1), b = Box(2), c = Box(3)
62
60
  (first, middle, last) = (a, b, c)
@@ -75,7 +73,6 @@ struct LRUCacheTests {
75
73
  #expect(cache.count == 0)
76
74
  }
77
75
 
78
- /// So does dropping the cache itself.
79
76
  @Test func droppingTheCacheReleasesEveryNode() {
80
77
  weak var first: Box?
81
78
  weak var last: Box?
@@ -93,7 +90,6 @@ struct LRUCacheTests {
93
90
  #expect(last == nil)
94
91
  }
95
92
 
96
- /// And evicting an entry releases its value.
97
93
  @Test func evictionReleasesTheEvictedNode() {
98
94
  let cache = LRUCache<String, Box>(maxSize: 1)
99
95
  weak var evicted: Box?
@@ -10,6 +10,7 @@ private func criteria(
10
10
  mediaTypeMode: String? = nil,
11
11
  reference: MediaIntentCriteria.Reference = .unknown,
12
12
  hasMediaType: Bool = false,
13
+ // A query names the app on a whole-word subset match either way, so "Acme" matches.
13
14
  appName: String? = "Acme Radio",
14
15
  ) -> MediaIntentCriteria {
15
16
  MediaIntentCriteria(
@@ -31,14 +32,12 @@ struct MediaIntentCriteriaTests {
31
32
  #expect(c.isResume)
32
33
  }
33
34
 
34
- // currentlyPlaying always resumes — "play this" makes the active track play.
35
35
  @Test func currentlyPlaying_isResume() {
36
36
  #expect(criteria(reference: .currentlyPlaying).isResume)
37
- // even with a stray query/filter, "play this" is a resume
37
+ // A query and filters that would otherwise search do not override it.
38
38
  #expect(criteria(mediaName: "jazz", genreNames: ["jazz"], reference: .currentlyPlaying, hasMediaType: true).isResume)
39
39
  }
40
40
 
41
- // .my always searches — "play my favorites" goes to the consumer, never resume.
42
41
  @Test func my_isNotResume() {
43
42
  #expect(!criteria(reference: .my).isResume)
44
43
  let namesApp = criteria(mediaName: "Acme", reference: .my)
@@ -68,7 +67,6 @@ struct MediaIntentCriteriaTests {
68
67
  #expect(!criteria(mediaName: "jazz").isResume)
69
68
  }
70
69
 
71
- // An empty genre name is still a genre filter: the fact is that genres were given.
72
70
  @Test func emptyGenreName_isStillAGenreFilter() {
73
71
  let c = criteria(genreNames: [""])
74
72
  #expect(c.genre == "")
@@ -109,7 +107,6 @@ struct MediaIntentCriteriaFromTests {
109
107
 
110
108
  // MARK: mode comes ONLY from mediaTypeMode (no field-derivation)
111
109
 
112
- // "Play jazz" → genre is a FILTER, not a mode. mode stays nil; genre set.
113
110
  @Test func genre_isFilterNotMode() {
114
111
  let c = criteria(genreNames: ["jazz"], hasMediaType: true)
115
112
  #expect(c.query == "jazz")
@@ -141,7 +138,6 @@ struct MediaIntentCriteriaFromTests {
141
138
  #expect(!c.query.isEmpty)
142
139
  }
143
140
 
144
- // A vertical mediaType DOES set the mode, and travels with its filters.
145
141
  @Test func song_viaMediaTypeMode_setsTitle() {
146
142
  let c = criteria(mediaName: "Billie Jean", mediaTypeMode: "song")
147
143
  #expect(c.query == "Billie Jean")
@@ -158,7 +154,6 @@ struct MediaIntentCriteriaFromTests {
158
154
  #expect(c.title == nil)
159
155
  }
160
156
 
161
- // "Play jazz station" → vertical wins as mode; genre rides as a filter.
162
157
  @Test func station_withGenreFilter() {
163
158
  let c = criteria(genreNames: ["jazz"], mediaTypeMode: "station", hasMediaType: true)
164
159
  #expect(c.searchMode == "station")
@@ -23,7 +23,7 @@ private final class MediaLoaderSpy {
23
23
  }
24
24
  }
25
25
 
26
- /// Resolves and loads `src`, returning once the resolved URL is handed to the asset load.
26
+ /// Returns once the resolved URL is handed to the asset load, not once the asset has loaded.
27
27
  @MainActor
28
28
  private func load(_ loader: MediaLoader, _ src: String) async {
29
29
  loader.resolveAndLoad(src: src)
@@ -122,22 +122,17 @@ struct ResolveAndLoadTests {
122
122
  var callCount = 0
123
123
  let (loader, _) = makeLoader { src, _ in
124
124
  callCount += 1
125
- // Simulate slow resolution
126
125
  try? await Task.sleep(for: .milliseconds(100))
127
126
  return MediaResolvedUrl(url: src, headers: nil, userAgent: nil)
128
127
  }
129
128
 
130
- // Start first resolve
131
129
  loader.resolveAndLoad(src: "https://example.com/first.mp3")
132
- // Immediately start second — should cancel first
133
130
  loader.resolveAndLoad(src: "https://example.com/second.mp3")
134
131
 
135
- // Await the surviving task; the cancelled one bailed before its resolver.
136
132
  await loader.mediaResolverTask?.value
137
133
 
138
- // Only the second resolver should have run (first was cancelled before calling resolver)
134
+ // Both calls run before either task starts, so the first is cancelled before its resolver.
139
135
  #expect(callCount == 1)
140
- // The asset should be from the second call
141
136
  #expect(loader.asset?.url.absoluteString == "https://example.com/second.mp3")
142
137
  }
143
138
  }
@@ -153,8 +148,7 @@ struct CancelAllTests {
153
148
  return MediaResolvedUrl(url: src, headers: nil, userAgent: nil)
154
149
  }
155
150
  loader.resolveAndLoad(src: "https://example.com/audio.mp3")
156
- // cancelAll() drops the handle, so grab it first to await the point where
157
- // the callback would have fired.
151
+ // cancelAll() drops the handle, so take it first to await where the callback would fire.
158
152
  let resolve = loader.mediaResolverTask
159
153
  loader.cancelAll()
160
154
  await resolve?.value
@@ -179,7 +173,6 @@ struct ClearAssetTests {
179
173
 
180
174
  @Test func noopWhenAssetIsNil() {
181
175
  let (loader, _) = makeLoader()
182
- // Should not crash
183
176
  loader.clearAsset()
184
177
  #expect(loader.asset == nil)
185
178
  }
@@ -194,7 +187,6 @@ struct AsyncLoadingTests {
194
187
  let (loader, spy) = makeLoader()
195
188
  await load(loader, "file:///nonexistent/path.mp3")
196
189
 
197
- // Poll for delegate callback — asset loading is async
198
190
  for _ in 0 ..< 50 {
199
191
  if !spy.retryableErrors.isEmpty || !spy.playbackErrors.isEmpty || !spy.preparedItems.isEmpty {
200
192
  break
@@ -202,7 +194,6 @@ struct AsyncLoadingTests {
202
194
  try? await Task.sleep(for: .milliseconds(100))
203
195
  }
204
196
 
205
- // AVFoundation will fail deterministically for a non-existent local file
206
197
  let hasError = !spy.retryableErrors.isEmpty || spy.unplayableCount > 0
207
198
  #expect(hasError, "expected a retryable error or unplayable callback for non-existent file")
208
199
  }
@@ -6,7 +6,6 @@ import Testing
6
6
  @MainActor
7
7
  @Suite("PlayerObserver")
8
8
  struct PlayerObserverTests {
9
- /// An AVPlayer retains its time observers, so one left registered outlives the observer (#96).
10
9
  @Test func invalidatingRemovesTheBoundaryObserver() {
11
10
  let observer = PlayerObserver(player: AVPlayer()) { _ in }
12
11
  #expect(observer.boundaryObserverToken != nil)
@@ -25,6 +24,7 @@ struct PlayerObserverTests {
25
24
  late.invalidate()
26
25
  await drain()
27
26
  #expect(events.isEmpty)
27
+ // Keeps the first observer alive until its delivery has been checked.
28
28
  _ = observer
29
29
  }
30
30
  }
@@ -42,18 +42,18 @@ struct ItemObserverTests {
42
42
  let observer = ItemObserver(item: item) { events.append($0) }
43
43
  NotificationCenter.default.post(name: .AVPlayerItemPlaybackStalled, object: item)
44
44
  NotificationCenter.default.post(name: .AVPlayerItemDidPlayToEndTime, object: item)
45
+ // Another item's notification is not delivered.
45
46
  NotificationCenter.default.post(name: .AVPlayerItemPlaybackStalled, object: makeItem())
46
47
  await drain()
47
48
  #expect(events.map(label) == ["stalled", "playedToEnd"])
48
49
  observer.invalidate()
49
50
  }
50
51
 
51
- /// A notification posted off the main thread hops to it; one landing after the switch to the
52
- /// next item belongs to the old item and is dropped.
53
52
  @Test func dropsADeliveryThatLandsAfterInvalidate() async {
54
53
  let item = makeItem()
55
54
  var events: [ItemObserver.Event] = []
56
55
  let observer = ItemObserver(item: item) { events.append($0) }
56
+ // Delivery hops to the main actor in a Task, so it lands after this invalidate.
57
57
  NotificationCenter.default.post(name: .AVPlayerItemFailedToPlayToEndTime, object: item)
58
58
  observer.invalidate()
59
59
  await drain()
@@ -8,13 +8,12 @@ import Testing
8
8
  @MainActor
9
9
  struct PlaybackErrorKindTests {
10
10
  @Test func httpStatus_mapsToKind() {
11
- // Not parameterized: the generated Nitro enum is not Sendable, so it
12
- // cannot cross a `@Test(arguments:)` isolation boundary.
11
+ // Not parameterized: the generated Nitro enum is not Sendable, so it cannot cross a
12
+ // `@Test(arguments:)` isolation boundary.
13
13
  let expectations: [(Int, PlaybackErrorKind)] = [
14
- // Ordering: these must not be swallowed by the 400...499 arm.
14
+ // Must not be swallowed by the 400...499 arm.
15
15
  (404, .notFound),
16
16
  (410, .notFound),
17
- // Range edges.
18
17
  (400, .rejected),
19
18
  (499, .rejected),
20
19
  (500, .serverError),
@@ -46,8 +45,8 @@ struct PlaybackErrorNitroCodeTests {
46
45
  #expect(TrackPlayerError.PlaybackError.playbackStalled.toNitroError().statusCode == nil)
47
46
  }
48
47
 
49
- /// `retrying` is nil — not false — on a terminal payload, so JS consumers
50
- /// see the field only while it means something.
48
+ /// `retrying` is nil, not false, on a terminal payload, so JS sees the field only while it means
49
+ /// something.
51
50
  @Test func retryingFlag_isNilUnlessSet() {
52
51
  #expect(TrackPlayerError.PlaybackError.hostUnreachable.toNitroError().retrying == nil)
53
52
  #expect(
@@ -55,9 +54,8 @@ struct PlaybackErrorNitroCodeTests {
55
54
  )
56
55
  }
57
56
 
58
- /// `code` is an untyped wire contract: nothing on either side of the bridge
59
- /// catches a typo, and telemetry groups issues by it. Worth an exhaustive
60
- /// table even though `kind` is what the UI branches on.
57
+ /// `code` is an untyped wire contract that telemetry groups issues by; nothing on either side of
58
+ /// the bridge catches a typo.
61
59
  @Test func codes_areStable() {
62
60
  let expectations: [(TrackPlayerError.PlaybackError, String)] = [
63
61
  (.failedToLoadKeyValue, "failed-to-load"),