react-native-audio-browser 0.2.0-next.27 → 0.2.0-next.28

package/android/src/main/java/com/audiobrowser/ServiceBinding.kt

@@ -19,18 +19,22 @@ internal class ServiceBinding(private val context: Context) {
   var isBound: Boolean = false
     private set
 
+  @Volatile private var bindSucceeded: Boolean = false
+
   /**
-   * Binds if not already bound, and returns whether a binding is held afterwards. A second call
-   * while bound is a no-op: Android would otherwise count the extra bind and expect a matching
+   * Binds if not already bound, and returns whether the service will connect: what
+   * [Context.bindService] returned for the binding held. A second call while bound is a no-op that
+   * returns the same answer: Android would otherwise count the extra bind and expect a matching
    * unbind.
    */
   fun bind(intent: Intent, connection: ServiceConnection): Boolean {
-    if (isBound) return true
+    if (isBound) return bindSucceeded
     // Marked bound whatever the result: Android registers the connection before it asks the
     // ActivityManager, so a false return still leaves one to release — "regardless of the return
     // value, you should later call unbindService()".
     isBound = true
-    return context.bindService(intent, connection, Context.BIND_AUTO_CREATE)
+    bindSucceeded = context.bindService(intent, connection, Context.BIND_AUTO_CREATE)
+    return bindSucceeded
   }
 
   /**

package/android/src/test/java/com/audiobrowser/ServiceBindingTest.kt

@@ -74,6 +74,19 @@ class ServiceBindingTest {
     assertEquals(1, shadowOf(app).unboundServiceConnections.size)
   }
 
+  /**
+   * setupPlayer binds after the auto-bind at construction already has. If that first bind failed,
+   * the service never connects, so setup must hear false and reject rather than wait for it.
+   */
+  @Test
+  fun bindingAgainAfterAFailedBindReportsTheFailure() {
+    val binding = ServiceBinding(app)
+    shadowOf(app).declareActionUnbindable("unbindable")
+
+    assertFalse(binding.bind(Intent("unbindable"), connection))
+    assertFalse(binding.bind(Intent("unbindable"), connection))
+  }
+
   @Test
   fun unbindIsIdempotent() {
     val binding = ServiceBinding(app)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-native-audio-browser",
-  "version": "0.2.0-next.27",
+  "version": "0.2.0-next.28",
   "description": "react-native-audio-browser is a react native package built with Nitro",
   "keywords": [
     "react-native",