react-native-audio-api 0.7.1-nightly-968a0e5-20250812 → 0.7.1

package/common/cpp/audioapi/HostObjects/AudioBufferHostObject.h

@@ -1,13 +1,14 @@
 #pragma once
 
-#include <audioapi/jsi/JsiHostObject.h>
-#include <audioapi/jsi/AudioArrayBuffer.h>
 #include <audioapi/core/sources/AudioBuffer.h>
+#include <audioapi/jsi/AudioArrayBuffer.h>
+#include <audioapi/jsi/JsiHostObject.h>
 
 #include <jsi/jsi.h>
+#include <cstddef>
 #include <memory>
+#include <utility>
 #include <vector>
-#include <cstddef>
 
 namespace audioapi {
 using namespace facebook;
@@ -30,9 +31,22 @@ class AudioBufferHostObject : public JsiHostObject {
         JSI_EXPORT_FUNCTION(AudioBufferHostObject, copyFromChannel),
         JSI_EXPORT_FUNCTION(AudioBufferHostObject, copyToChannel));
   }
+  AudioBufferHostObject(const AudioBufferHostObject &) = delete;
+  AudioBufferHostObject &operator=(const AudioBufferHostObject &) = delete;
+  AudioBufferHostObject(AudioBufferHostObject &&other) noexcept
+      : JsiHostObject(std::move(other)),
+        audioBuffer_(std::move(other.audioBuffer_)) {}
+  AudioBufferHostObject &operator=(AudioBufferHostObject &&other) noexcept {
+    if (this != &other) {
+      JsiHostObject::operator=(std::move(other));
+      audioBuffer_ = std::move(other.audioBuffer_);
+    }
+    return *this;
+  }
 
   [[nodiscard]] size_t getSizeInBytes() const {
-    return audioBuffer_->getLength() * audioBuffer_->getNumberOfChannels() * sizeof(float);
+    return audioBuffer_->getLength() * audioBuffer_->getNumberOfChannels() *
+        sizeof(float);
   }
 
   JSI_PROPERTY_GETTER(sampleRate) {
@@ -53,23 +67,30 @@ class AudioBufferHostObject : public JsiHostObject {
 
   JSI_HOST_FUNCTION(getChannelData) {
     auto channel = static_cast<int>(args[0].getNumber());
-    auto channelData = reinterpret_cast<uint8_t *>(audioBuffer_->getChannelData(channel));
+    auto channelData =
+        reinterpret_cast<uint8_t *>(audioBuffer_->getChannelData(channel));
     auto length = static_cast<int>(audioBuffer_->getLength());
     auto size = static_cast<int>(length * sizeof(float));
 
     // reading or writing from this ArrayBuffer could cause a crash
     // if underlying channelData is deallocated
-    auto audioArrayBuffer = std::make_shared<AudioArrayBuffer>(channelData, size);
+    auto audioArrayBuffer =
+        std::make_shared<AudioArrayBuffer>(channelData, size);
     auto arrayBuffer = jsi::ArrayBuffer(runtime, audioArrayBuffer);
 
-    auto float32ArrayCtor = runtime.global().getPropertyAsFunction(runtime, "Float32Array");
-    auto float32Array = float32ArrayCtor.callAsConstructor(runtime, arrayBuffer).getObject(runtime);
+    auto float32ArrayCtor =
+        runtime.global().getPropertyAsFunction(runtime, "Float32Array");
+    auto float32Array = float32ArrayCtor.callAsConstructor(runtime, arrayBuffer)
+                            .getObject(runtime);
 
     return float32Array;
   }
 
   JSI_HOST_FUNCTION(copyFromChannel) {
-    auto arrayBuffer = args[0].getObject(runtime).getPropertyAsObject(runtime, "buffer").getArrayBuffer(runtime);
+    auto arrayBuffer = args[0]
+                           .getObject(runtime)
+                           .getPropertyAsObject(runtime, "buffer")
+                           .getArrayBuffer(runtime);
     auto destination = reinterpret_cast<float *>(arrayBuffer.data(runtime));
     auto length = static_cast<int>(arrayBuffer.size(runtime));
     auto channelNumber = static_cast<int>(args[1].getNumber());
@@ -82,14 +103,16 @@ class AudioBufferHostObject : public JsiHostObject {
   }
 
   JSI_HOST_FUNCTION(copyToChannel) {
-    auto arrayBuffer = args[0].getObject(runtime).getPropertyAsObject(runtime, "buffer").getArrayBuffer(runtime);
+    auto arrayBuffer = args[0]
+                           .getObject(runtime)
+                           .getPropertyAsObject(runtime, "buffer")
+                           .getArrayBuffer(runtime);
     auto source = reinterpret_cast<float *>(arrayBuffer.data(runtime));
     auto length = static_cast<int>(arrayBuffer.size(runtime));
     auto channelNumber = static_cast<int>(args[1].getNumber());
     auto startInChannel = static_cast<size_t>(args[2].getNumber());
 
-    audioBuffer_->copyToChannel(
-        source, length, channelNumber, startInChannel);
+    audioBuffer_->copyToChannel(source, length, channelNumber, startInChannel);
 
     return jsi::Value::undefined();
   }

package/common/cpp/audioapi/core/utils/AudioNodeManager.cpp

@@ -72,8 +72,10 @@ void AudioNodeManager::settlePendingConnections() {
       assert(to != nullptr);
       from->disconnectNode(to);
     } else {
-      for (auto &node : from->outputNodes_) {
-        from->disconnectNode(node);
+      for (auto it = from->outputNodes_.begin(); it != from->outputNodes_.end();) {
+        auto next = std::next(it);
+        from->disconnectNode(*it);
+        it = next;
       }
     }
   }

package/common/cpp/audioapi/jsi/JsiHostObject.cpp

@@ -1,7 +1,7 @@
 #include <audioapi/jsi/JsiHostObject.h>
 
 //  set this value to 1 in order to debug the construction/destruction
-#define JSI_DEBUG_ALLOCATIONS 1
+#define JSI_DEBUG_ALLOCATIONS 0
 
 namespace audioapi {
 
@@ -28,15 +28,43 @@ JsiHostObject::JsiHostObject() {
 #endif
 }
 
-JsiHostObject::~JsiHostObject() {
+JsiHostObject::JsiHostObject(JsiHostObject &&other) noexcept
+    : getters_(std::move(other.getters_)),
+      functions_(std::move(other.functions_)),
+      setters_(std::move(other.setters_)) {
+#if JSI_DEBUG_ALLOCATIONS
+  auto it = std::find(objects.begin(), objects.end(), &other);
+  if (it != objects.end()) {
+    objects.erase(it);
+  }
+  objects.push_back(this);
+#endif
+}
+
+JsiHostObject &JsiHostObject::operator=(JsiHostObject &&other) noexcept {
+  if (this != &other) {
+    getters_ = std::move(other.getters_);
+    functions_ = std::move(other.functions_);
+    setters_ = std::move(other.setters_);
+
 #if JSI_DEBUG_ALLOCATIONS
-  for (size_t i = 0; i < objects.size(); ++i) {
-    if (objects.at(i) == this) {
-      objects.erase(objects.begin() + i);
-      break;
+    auto it = std::find(objects.begin(), objects.end(), &other);
+    if (it != objects.end()) {
+      objects.erase(it);
     }
+    objects.push_back(this);
+#endif
+  }
+  return *this;
+}
+
+JsiHostObject::~JsiHostObject() {
+#if JSI_DEBUG_ALLOCATIONS
+  auto it = std::find(objects.begin(), objects.end(), this);
+  if (it != objects.end()) {
+    objects.erase(it);
+    objCounter--;
   }
-  objCounter--;
 #endif
 }
 

package/common/cpp/audioapi/jsi/JsiHostObject.h

@@ -10,11 +10,11 @@
 #include <utility>
 #include <vector>
 
-#define JSI_HOST_FUNCTION(NAME)  \
-  jsi::Value NAME(               \
-      jsi::Runtime &runtime,     \
+#define JSI_HOST_FUNCTION(NAME)    \
+  jsi::Value NAME(                 \
+      jsi::Runtime &runtime,       \
       const jsi::Value &thisValue, \
-      const jsi::Value *args,    \
+      const jsi::Value *args,      \
       size_t count)
 
 #define JSI_EXPORT_FUNCTION(CLASS, FUNCTION)                                \
@@ -48,6 +48,10 @@ using namespace facebook;
 class JsiHostObject : public jsi::HostObject {
  public:
   JsiHostObject();
+  JsiHostObject(const JsiHostObject &) = delete;
+  JsiHostObject &operator=(const JsiHostObject &) = delete;
+  JsiHostObject(JsiHostObject &&) noexcept;
+  JsiHostObject &operator=(JsiHostObject &&other) noexcept;
   ~JsiHostObject() override;
 
   std::vector<jsi::PropNameID> getPropertyNames(jsi::Runtime &rt) override;

package/ios/audioapi/ios/core/NativeAudioPlayer.m

@@ -35,11 +35,19 @@
 - (bool)start
 {
   NSLog(@"[AudioPlayer] start");
-
+  
   AudioEngine *audioEngine = [AudioEngine sharedInstance];
   assert(audioEngine != nil);
+  
+  // AudioEngine allows us to attach and connect nodes at runtime but with few limitations
+  // in this case if it is the first player and recorder started the engine we need to restart.
+  // It can be optimized by tracking if we haven't break rules of at runtime modifications from docs
+  // https://developer.apple.com/documentation/avfaudio/avaudioengine?language=objc
+  //
+  // Currently we are restarting because we do not see any significant performance issue and case when
+  // you will need to start and stop player very frequently
+  [audioEngine stopEngine];
   self.sourceNodeId = [audioEngine attachSourceNode:self.sourceNode format:self.format];
-
   return [audioEngine startIfNecessary];
 }
 
@@ -59,9 +67,8 @@
   NSLog(@"[AudioPlayer] resume");
   AudioEngine *audioEngine = [AudioEngine sharedInstance];
   assert(audioEngine != nil);
-  [audioEngine startEngine];
 
-  return [audioEngine startEngine];
+  return [audioEngine startIfNecessary];
 }
 
 - (void)suspend

package/ios/audioapi/ios/core/NativeAudioRecorder.m

@@ -100,6 +100,15 @@
 {
   AudioEngine *audioEngine = [AudioEngine sharedInstance];
   assert(audioEngine != nil);
+
+  // AudioEngine allows us to attach and connect nodes at runtime but with few limitations
+  // in this case if it is the first recorder node and player started the engine we need to restart.
+  // It can be optimized by tracking if we haven't break rules of at runtime modifications from docs
+  // https://developer.apple.com/documentation/avfaudio/avaudioengine?language=objc
+  //
+  // Currently we are restarting because we do not see any significant performance issue and case when
+  // you will need to start and stop recorder very frequently
+  [audioEngine stopEngine];
   [audioEngine attachInputNode:self.sinkNode];
   [audioEngine startIfNecessary];
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-native-audio-api",
-  "version": "0.7.1-nightly-968a0e5-20250812",
+  "version": "0.7.1",
   "description": "react-native-audio-api provides system for controlling audio in React Native environment compatible with Web Audio API specification",
   "bin": {
     "setup-rn-audio-api-web": "./scripts/setup-rn-audio-api-web.js"