react-native-audio-api 0.4.13 → 0.5.0-rc.1

package/android/src/main/java/com/swmansion/audioapi/AudioAPIModule.kt

@@ -13,10 +13,6 @@ class AudioAPIModule(
   reactContext: ReactApplicationContext,
 ) : NativeAudioAPIModuleSpec(reactContext) {
   companion object {
-    init {
-      System.loadLibrary("react-native-audio-api")
-    }
-
     const val NAME = NativeAudioAPIModuleSpec.NAME
   }
 
@@ -30,8 +26,13 @@ class AudioAPIModule(
   private external fun injectJSIBindings()
 
   init {
-    val jsCallInvokerHolder = reactContext.jsCallInvokerHolder as CallInvokerHolderImpl
-    mHybridData = initHybrid(reactContext.javaScriptContextHolder!!.get(), jsCallInvokerHolder)
+    try {
+      System.loadLibrary("react-native-audio-api")
+      val jsCallInvokerHolder = reactContext.jsCallInvokerHolder as CallInvokerHolderImpl
+      mHybridData = initHybrid(reactContext.javaScriptContextHolder!!.get(), jsCallInvokerHolder)
+    } catch (exception: UnsatisfiedLinkError) {
+      throw RuntimeException("Could not load native module AudioAPIModule", exception)
+    }
   }
 
   @ReactMethod(isBlockingSynchronousMethod = true)

package/android/src/main/java/com/swmansion/audioapi/AudioAPIPackage.kt

@@ -1,41 +1,42 @@
 package com.swmansion.audioapi
 
 import com.facebook.react.BaseReactPackage
-import com.facebook.react.ReactPackage
 import com.facebook.react.bridge.NativeModule
 import com.facebook.react.bridge.ReactApplicationContext
-import com.facebook.react.common.annotations.UnstableReactNativeAPI
 import com.facebook.react.module.annotations.ReactModuleList
 import com.facebook.react.module.model.ReactModuleInfo
 import com.facebook.react.module.model.ReactModuleInfoProvider
 
-@ReactModuleList(nativeModules = [AudioAPIModule::class])
-class AudioAPIPackage :
-  BaseReactPackage(),
-  ReactPackage {
-  @UnstableReactNativeAPI
+@ReactModuleList(
+  nativeModules = [
+    AudioAPIModule::class,
+  ],
+)
+class AudioAPIPackage : BaseReactPackage() {
   override fun getModule(
     name: String,
     reactContext: ReactApplicationContext,
-  ): NativeModule? =
+  ): NativeModule? {
     when (name) {
-      AudioAPIModule.NAME -> AudioAPIModule(reactContext)
-      else -> null
+      AudioAPIModule.NAME -> return AudioAPIModule(reactContext)
     }
+    return null
+  }
 
   override fun getReactModuleInfoProvider(): ReactModuleInfoProvider =
-    ReactModuleInfoProvider(
-      fun (): Map<String, ReactModuleInfo> =
-        mapOf(
-          AudioAPIModule.NAME to
-            ReactModuleInfo(
-              AudioAPIModule.NAME,
-              AudioAPIModule::class.java.simpleName,
-              _canOverrideExistingModule = true,
-              _needsEagerInit = false,
-              isCxxModule = false,
-              isTurboModule = BuildConfig.IS_NEW_ARCHITECTURE_ENABLED,
-            ),
-        ),
-    )
+    ReactModuleInfoProvider {
+      val moduleInfos: MutableMap<String, ReactModuleInfo> = HashMap()
+      val isTurboModule = BuildConfig.IS_NEW_ARCHITECTURE_ENABLED
+      moduleInfos[AudioAPIModule.NAME] =
+        ReactModuleInfo(
+          AudioAPIModule.NAME,
+          AudioAPIModule.NAME,
+          canOverrideExistingModule = true,
+          needsEagerInit = false,
+          hasConstants = true,
+          isCxxModule = false,
+          isTurboModule = isTurboModule,
+        )
+      moduleInfos
+    }
 }

package/common/cpp/audioapi/HostObjects/AnalyserNodeHostObject.h

@@ -73,71 +73,47 @@ class AnalyserNodeHostObject : public AudioNodeHostObject {
   }
 
   JSI_HOST_FUNCTION(getFloatFrequencyData) {
-    auto destination = args[0].getObject(runtime).asArray(runtime);
-    auto length = static_cast<int>(destination.getProperty(runtime, "length").asNumber());
-    auto data = new float[length];
+    auto arrayBuffer = args[0].getObject(runtime).getPropertyAsObject(runtime, "buffer").getArrayBuffer(runtime);
+    auto data = reinterpret_cast<float *>(arrayBuffer.data(runtime));
+    auto length = static_cast<int>(arrayBuffer.size(runtime));
 
     auto analyserNode = std::static_pointer_cast<AnalyserNode>(node_);
     analyserNode->getFloatFrequencyData(data, length);
 
-    for (int i = 0; i < length; i++) {
-      destination.setValueAtIndex(runtime, i, jsi::Value(data[i]));
-    }
-
-    delete[] data;
-
     return jsi::Value::undefined();
   }
 
   JSI_HOST_FUNCTION(getByteFrequencyData) {
-    auto destination = args[0].getObject(runtime).asArray(runtime);
-    auto length = static_cast<int>(destination.getProperty(runtime, "length").asNumber());
-    auto data = new uint8_t[length];
+    auto arrayBuffer = args[0].getObject(runtime).getPropertyAsObject(runtime, "buffer").getArrayBuffer(runtime);
+    auto data = arrayBuffer.data(runtime);
+    auto length = static_cast<int>(arrayBuffer.size(runtime));
 
     auto analyserNode = std::static_pointer_cast<AnalyserNode>(node_);
     analyserNode->getByteFrequencyData(data, length);
 
-    for (int i = 0; i < length; i++) {
-      destination.setValueAtIndex(runtime, i, jsi::Value(data[i]));
-    }
-
-    delete[] data;
-
     return jsi::Value::undefined();
   }
 
   JSI_HOST_FUNCTION(getFloatTimeDomainData) {
-      auto destination = args[0].getObject(runtime).asArray(runtime);
-      auto length = static_cast<int>(destination.getProperty(runtime, "length").asNumber());
-      auto data = new float[length];
-
-      auto analyserNode = std::static_pointer_cast<AnalyserNode>(node_);
-      analyserNode->getFloatTimeDomainData(data, length);
-
-    for (int i = 0; i < length; i++) {
-        destination.setValueAtIndex(runtime, i, jsi::Value(data[i]));
-    }
+    auto arrayBuffer = args[0].getObject(runtime).getPropertyAsObject(runtime, "buffer").getArrayBuffer(runtime);
+    auto data = reinterpret_cast<float *>(arrayBuffer.data(runtime));
+    auto length = static_cast<int>(arrayBuffer.size(runtime));
 
-    delete[] data;
+    auto analyserNode = std::static_pointer_cast<AnalyserNode>(node_);
+    analyserNode->getFloatTimeDomainData(data, length);
 
     return jsi::Value::undefined();
   }
 
   JSI_HOST_FUNCTION(getByteTimeDomainData) {
-      auto destination = args[0].getObject(runtime).asArray(runtime);
-      auto length = static_cast<int>(destination.getProperty(runtime, "length").asNumber());
-      auto data = new uint8_t[length];
-
-      auto analyserNode = std::static_pointer_cast<AnalyserNode>(node_);
-      analyserNode->getByteTimeDomainData(data, length);
-
-      for (int i = 0; i < length; i++) {
-          destination.setValueAtIndex(runtime, i, jsi::Value(data[i]));
-      }
+    auto arrayBuffer = args[0].getObject(runtime).getPropertyAsObject(runtime, "buffer").getArrayBuffer(runtime);
+    auto data = arrayBuffer.data(runtime);
+    auto length = static_cast<int>(arrayBuffer.size(runtime));
 
-      delete[] data;
+    auto analyserNode = std::static_pointer_cast<AnalyserNode>(node_);
+    analyserNode->getByteTimeDomainData(data, length);
 
-      return jsi::Value::undefined();
+    return jsi::Value::undefined();
   }
 
   JSI_PROPERTY_SETTER(fftSize) {

package/common/cpp/audioapi/HostObjects/AudioBufferHostObject.h

@@ -47,56 +47,46 @@ class AudioBufferHostObject : public JsiHostObject {
   }
 
   JSI_HOST_FUNCTION(getChannelData) {
-    int channel = static_cast<int>(args[0].getNumber());
-    float *channelData = audioBuffer_->getChannelData(channel);
+    auto channel = static_cast<int>(args[0].getNumber());
+    auto *channelData = audioBuffer_->getChannelData(channel);
+    auto length = static_cast<int>(audioBuffer_->getLength());
+    auto size = static_cast<int>(length * sizeof(float));
 
-    auto array = jsi::Array(runtime, audioBuffer_->getLength());
-    for (int i = 0; i < audioBuffer_->getLength(); i++) {
-      array.setValueAtIndex(runtime, i, jsi::Value(channelData[i]));
-    }
+    auto arrayBufferCtor = runtime.global().getPropertyAsFunction(runtime, "ArrayBuffer");
+    auto arrayBuffer = arrayBufferCtor.callAsConstructor(runtime, size).getObject(runtime).getArrayBuffer(runtime);
 
-    return array;
+    auto float32ArrayCtor = runtime.global().getPropertyAsFunction(runtime, "Float32Array");
+    auto float32Array = float32ArrayCtor.callAsConstructor(runtime, arrayBuffer).getObject(runtime);
+
+    auto data = reinterpret_cast<float *>(arrayBuffer.data(runtime));
+
+    memcpy(data, channelData, size);
+
+    return float32Array;
   }
 
   JSI_HOST_FUNCTION(copyFromChannel) {
-    auto destination = args[0].getObject(runtime).asArray(runtime);
-    auto destinationLength =
-        static_cast<size_t>(destination.getProperty(runtime, "length").asNumber());
+    auto arrayBuffer = args[0].getObject(runtime).getPropertyAsObject(runtime, "buffer").getArrayBuffer(runtime);
+    auto destination = reinterpret_cast<float *>(arrayBuffer.data(runtime));
+    auto length = static_cast<int>(arrayBuffer.size(runtime));
     auto channelNumber = static_cast<int>(args[1].getNumber());
     auto startInChannel = static_cast<size_t>(args[2].getNumber());
 
-    auto *destinationData = new float[destinationLength];
-
     audioBuffer_->copyFromChannel(
-        destinationData, destinationLength, channelNumber, startInChannel);
-
-    for (int i = 0; i < destinationLength; i++) {
-      destination.setValueAtIndex(runtime, i, jsi::Value(destinationData[i]));
-    }
-
-    delete[] destinationData;
+        destination, length, channelNumber, startInChannel);
 
     return jsi::Value::undefined();
   }
 
   JSI_HOST_FUNCTION(copyToChannel) {
-    auto source = args[0].getObject(runtime).asArray(runtime);
-    auto sourceLength =
-        static_cast<size_t>(source.getProperty(runtime, "length").asNumber());
+    auto arrayBuffer = args[0].getObject(runtime).getPropertyAsObject(runtime, "buffer").getArrayBuffer(runtime);
+    auto source = reinterpret_cast<float *>(arrayBuffer.data(runtime));
+    auto length = static_cast<int>(arrayBuffer.size(runtime));
     auto channelNumber = static_cast<int>(args[1].getNumber());
     auto startInChannel = static_cast<size_t>(args[2].getNumber());
 
-    auto *sourceData = new float[sourceLength];
-
-    for (int i = 0; i < sourceLength; i++) {
-      sourceData[i] =
-          static_cast<float>(source.getValueAtIndex(runtime, i).getNumber());
-    }
-
     audioBuffer_->copyToChannel(
-        sourceData, sourceLength, channelNumber, startInChannel);
-
-    delete[] sourceData;
+        source, length, channelNumber, startInChannel);
 
     return jsi::Value::undefined();
   }

package/common/cpp/audioapi/HostObjects/AudioBufferSourceNodeHostObject.h

@@ -24,15 +24,13 @@ class AudioBufferSourceNodeHostObject
         JSI_EXPORT_PROPERTY_GETTER(AudioBufferSourceNodeHostObject, loopStart),
         JSI_EXPORT_PROPERTY_GETTER(AudioBufferSourceNodeHostObject, loopEnd),
         JSI_EXPORT_PROPERTY_GETTER(AudioBufferSourceNodeHostObject, detune),
-        JSI_EXPORT_PROPERTY_GETTER(AudioBufferSourceNodeHostObject, playbackRate),
-        JSI_EXPORT_PROPERTY_GETTER(AudioBufferSourceNodeHostObject, timeStretch));
+        JSI_EXPORT_PROPERTY_GETTER(AudioBufferSourceNodeHostObject, playbackRate));
 
     addSetters(
         JSI_EXPORT_PROPERTY_SETTER(AudioBufferSourceNodeHostObject, loop),
         JSI_EXPORT_PROPERTY_SETTER(AudioBufferSourceNodeHostObject, buffer),
         JSI_EXPORT_PROPERTY_SETTER(AudioBufferSourceNodeHostObject, loopStart),
-        JSI_EXPORT_PROPERTY_SETTER(AudioBufferSourceNodeHostObject, loopEnd),
-        JSI_EXPORT_PROPERTY_SETTER(AudioBufferSourceNodeHostObject, timeStretch));
+        JSI_EXPORT_PROPERTY_SETTER(AudioBufferSourceNodeHostObject, loopEnd));
 
     // start method is overridden in this class
     functions_->erase("start");
@@ -92,13 +90,6 @@ class AudioBufferSourceNodeHostObject
     return jsi::Object::createFromHostObject(runtime, playbackRateHostObject);
   }
 
-  JSI_PROPERTY_GETTER(timeStretch) {
-    auto audioBufferSourceNode =
-            std::static_pointer_cast<AudioBufferSourceNode>(node_);
-    auto timeStretch = audioBufferSourceNode->getTimeStretchType();
-    return jsi::String::createFromUtf8(runtime, timeStretch);
-  }
-
   JSI_PROPERTY_SETTER(loop) {
     auto audioBufferSourceNode =
         std::static_pointer_cast<AudioBufferSourceNode>(node_);
@@ -130,12 +121,6 @@ class AudioBufferSourceNodeHostObject
     audioBufferSourceNode->setLoopEnd(value.getNumber());
   }
 
-  JSI_PROPERTY_SETTER(timeStretch) {
-    auto audioBufferSourceNode =
-        std::static_pointer_cast<AudioBufferSourceNode>(node_);
-    audioBufferSourceNode->setTimeStretchType(value.getString(runtime).utf8(runtime));
-  }
-
   JSI_HOST_FUNCTION(start) {
     auto when = args[0].getNumber();
     auto offset = args[1].getNumber();

package/common/cpp/audioapi/HostObjects/AudioContextHostObject.h

@@ -43,10 +43,15 @@ class AudioContextHostObject : public BaseAudioContextHostObject {
     auto promise = promiseVendor_->createPromise([this](std::shared_ptr<Promise> promise) {
       std::thread([this, promise = std::move(promise)]() {
           auto audioContext = std::static_pointer_cast<AudioContext>(context_);
-          audioContext->resume();
+          auto result = audioContext->resume();
+
+          if (!result) {
+            promise->reject("Failed to resume audio context, because it is already closed.");
+            return;
+          }
 
           promise->resolve([](jsi::Runtime &runtime) {
-              return jsi::Value::undefined();
+            return jsi::Value::undefined();
           });
       }).detach();
     });
@@ -58,10 +63,15 @@ class AudioContextHostObject : public BaseAudioContextHostObject {
     auto promise = promiseVendor_->createPromise([this](std::shared_ptr<Promise> promise) {
       std::thread([this, promise = std::move(promise)]() {
           auto audioContext = std::static_pointer_cast<AudioContext>(context_);
-          audioContext->suspend();
+          auto result = audioContext->suspend();
+
+          if (!result) {
+            promise->reject("Failed to resume audio context, because it is already closed.");
+            return;
+          }
 
           promise->resolve([](jsi::Runtime &runtime) {
-              return jsi::Value::undefined();
+            return jsi::Value::undefined();
           });
       }).detach();
     });

package/common/cpp/audioapi/HostObjects/AudioParamHostObject.h

@@ -79,16 +79,13 @@ class AudioParamHostObject : public JsiHostObject {
   }
 
   JSI_HOST_FUNCTION(setValueCurveAtTime) {
-    auto values = args[0].getObject(runtime).asArray(runtime);
-    auto length = static_cast<size_t>(values.length(runtime));
-    auto valuesData = new float[length];
-    for (size_t i = 0; i < values.length(runtime); i++) {
-      valuesData[i] =
-          static_cast<float>(values.getValueAtIndex(runtime, i).getNumber());
-    }
+    auto arrayBuffer = args[0].getObject(runtime).getPropertyAsObject(runtime, "buffer").getArrayBuffer(runtime);
+    auto values = reinterpret_cast<float *>(arrayBuffer.data(runtime));
+    auto length = static_cast<int>(arrayBuffer.size(runtime));
+
     double startTime = args[1].getNumber();
     double duration = args[2].getNumber();
-    param_->setValueCurveAtTime(valuesData, length, startTime, duration);
+    param_->setValueCurveAtTime(values, length, startTime, duration);
     return jsi::Value::undefined();
   }
 

package/common/cpp/audioapi/HostObjects/BaseAudioContextHostObject.h

@@ -95,7 +95,8 @@ class BaseAudioContextHostObject : public JsiHostObject {
   }
 
   JSI_HOST_FUNCTION(createBufferSource) {
-    auto bufferSource = context_->createBufferSource();
+    auto pitchCorrection = args[0].asBool();
+    auto bufferSource = context_->createBufferSource(pitchCorrection);
     auto bufferSourceHostObject =
         std::make_shared<AudioBufferSourceNodeHostObject>(bufferSource, callInvoker_);
     return jsi::Object::createFromHostObject(runtime, bufferSourceHostObject);
@@ -111,18 +112,21 @@ class BaseAudioContextHostObject : public JsiHostObject {
   }
 
   JSI_HOST_FUNCTION(createPeriodicWave) {
-    auto real = args[0].getObject(runtime).getArray(runtime);
-    auto imag = args[1].getObject(runtime).getArray(runtime);
+    auto arrayBufferReal = args[0].getObject(runtime).getPropertyAsObject(runtime, "buffer").getArrayBuffer(runtime);
+    auto real = reinterpret_cast<float *>(arrayBufferReal.data(runtime));
+    auto length = static_cast<int>(arrayBufferReal.size(runtime));
+
+    auto arrayBufferImag = args[1].getObject(runtime).getPropertyAsObject(runtime, "buffer").getArrayBuffer(runtime);
+    auto imag = reinterpret_cast<float *>(arrayBufferReal.data(runtime));
+
     auto disableNormalization = args[2].getBool();
-    auto length =
-        static_cast<int>(real.getProperty(runtime, "length").asNumber());
 
     auto complexData = std::vector<std::complex<float>>(length);
 
-    for (size_t i = 0; i < real.length(runtime); i++) {
+    for (size_t i = 0; i < length; i++) {
         complexData[i] = std::complex<float>(
-            static_cast<float>(real.getValueAtIndex(runtime, i).getNumber()),
-            static_cast<float>(imag.getValueAtIndex(runtime, i).getNumber()));
+            static_cast<float>(real[i]),
+            static_cast<float>(imag[i]));
     }
 
     auto periodicWave = context_->createPeriodicWave(
@@ -148,7 +152,7 @@ class BaseAudioContextHostObject : public JsiHostObject {
         auto audioBufferHostObject = std::make_shared<AudioBufferHostObject>(results);
 
         if (!results) {
-          promise->reject("Failed to decode audio data source");
+          promise->reject("Failed to decode audio data source.");
           return;
         }
 

package/common/cpp/audioapi/HostObjects/BiquadFilterNodeHostObject.h

@@ -64,30 +64,19 @@ class BiquadFilterNodeHostObject : public AudioNodeHostObject {
   }
 
   JSI_HOST_FUNCTION(getFrequencyResponse) {
-    auto frequencyArray = args[0].getObject(runtime).asArray(runtime);
-    auto magResponseOut = args[1].getObject(runtime).asArray(runtime);
-    auto phaseResponseOut = args[2].getObject(runtime).asArray(runtime);
+    auto arrayBufferFrequency = args[0].getObject(runtime).getPropertyAsObject(runtime, "buffer").getArrayBuffer(runtime);
+    auto frequencyArray = reinterpret_cast<float *>(arrayBufferFrequency.data(runtime));
+    auto length = static_cast<int>(arrayBufferFrequency.size(runtime));
 
-    std::vector<float> frequencyArrayVector(frequencyArray.length(runtime));
-    for (size_t i = 0; i < frequencyArray.length(runtime); i++) {
-      frequencyArrayVector[i] = static_cast<float>(
-          frequencyArray.getValueAtIndex(runtime, i).getNumber());
-    }
+    auto arrayBufferMag = args[1].getObject(runtime).getPropertyAsObject(runtime, "buffer").getArrayBuffer(runtime);
+    auto magResponseOut = reinterpret_cast<float *>(arrayBufferMag.data(runtime));
 
-    std::vector<float> magResponseOutVector(magResponseOut.length(runtime));
-    std::vector<float> phaseResponseOutVector(phaseResponseOut.length(runtime));
+    auto arrayBufferPhase = args[2].getObject(runtime).getPropertyAsObject(runtime, "buffer").getArrayBuffer(runtime);
+    auto phaseResponseOut = reinterpret_cast<float *>(arrayBufferPhase.data(runtime));
 
     auto biquadFilterNode = std::static_pointer_cast<BiquadFilterNode>(node_);
     biquadFilterNode->getFrequencyResponse(
-        frequencyArrayVector, magResponseOutVector, phaseResponseOutVector);
-
-    for (size_t i = 0; i < magResponseOutVector.size(); i++) {
-      magResponseOut.setValueAtIndex(runtime, i, magResponseOutVector[i]);
-    }
-
-    for (size_t i = 0; i < phaseResponseOutVector.size(); i++) {
-      phaseResponseOut.setValueAtIndex(runtime, i, phaseResponseOutVector[i]);
-    }
+        frequencyArray, magResponseOut, phaseResponseOut, length);
 
     return jsi::Value::undefined();
   }

package/common/cpp/audioapi/core/AudioContext.cpp

@@ -39,23 +39,33 @@ AudioContext::~AudioContext() {
   if (!isClosed()) {
     close();
   }
-
-  nodeManager_->cleanup();
 }
 
 void AudioContext::close() {
   state_ = ContextState::CLOSED;
   audioPlayer_->stop();
+
+  nodeManager_->cleanup();
 }
 
-void AudioContext::resume() {
+bool AudioContext::resume() {
+  if (isClosed()) {
+    return false;
+  }
+
   state_ = ContextState::RUNNING;
   audioPlayer_->resume();
+  return true;
 }
 
-void AudioContext::suspend() {
+bool AudioContext::suspend() {
+  if (isClosed()) {
+    return false;
+  }
+
   state_ = ContextState::SUSPENDED;
   audioPlayer_->suspend();
+  return true;
 }
 
 std::function<void(std::shared_ptr<AudioBus>, int)>

package/common/cpp/audioapi/core/AudioContext.h

@@ -19,8 +19,8 @@ class AudioContext : public BaseAudioContext {
   ~AudioContext() override;
 
   void close();
-  void resume();
-  void suspend();
+  bool resume();
+  bool suspend();
 
  private:
 #ifdef ANDROID

package/common/cpp/audioapi/core/BaseAudioContext.cpp

@@ -65,8 +65,10 @@ std::shared_ptr<BiquadFilterNode> BaseAudioContext::createBiquadFilter() {
   return biquadFilter;
 }
 
-std::shared_ptr<AudioBufferSourceNode> BaseAudioContext::createBufferSource() {
-  auto bufferSource = std::make_shared<AudioBufferSourceNode>(this);
+std::shared_ptr<AudioBufferSourceNode> BaseAudioContext::createBufferSource(
+    bool pitchCorrection) {
+  auto bufferSource =
+      std::make_shared<AudioBufferSourceNode>(this, pitchCorrection);
   nodeManager_->addNode(bufferSource);
   return bufferSource;
 }

package/common/cpp/audioapi/core/BaseAudioContext.h

@@ -42,7 +42,7 @@ class BaseAudioContext {
   std::shared_ptr<GainNode> createGain();
   std::shared_ptr<StereoPannerNode> createStereoPanner();
   std::shared_ptr<BiquadFilterNode> createBiquadFilter();
-  std::shared_ptr<AudioBufferSourceNode> createBufferSource();
+  std::shared_ptr<AudioBufferSourceNode> createBufferSource(bool pitchCorrection);
   static std::shared_ptr<AudioBuffer>
   createBuffer(int numberOfChannels, size_t length, float sampleRate);
   std::shared_ptr<PeriodicWave> createPeriodicWave(

package/common/cpp/audioapi/core/effects/BiquadFilterNode.cpp

@@ -57,20 +57,19 @@ std::shared_ptr<AudioParam> BiquadFilterNode::getGainParam() const {
 // angle of the frequency response
 
 void BiquadFilterNode::getFrequencyResponse(
-    const std::vector<float> &frequencyArray,
-    std::vector<float> &magResponseOutput,
-    std::vector<float> &phaseResponseOutput) {
+    const float *frequencyArray,
+    float *magResponseOutput,
+    float *phaseResponseOutput,
+    const int length) {
   applyFilter();
 
-  auto frequencyArraySize = frequencyArray.size();
-
   float b0 = b0_;
   float b1 = b1_;
   float b2 = b2_;
   float a1 = a1_;
   float a2 = a2_;
 
-  for (size_t i = 0; i < frequencyArraySize; i++) {
+  for (size_t i = 0; i < length; i++) {
     auto omega = PI * frequencyArray[i] / context_->getNyquistFrequency();
     auto z = std::complex<float>(cos(omega), sin(omega));
     auto response = ((b0 * z + b1) * z + b2) / ((z + a1) * z + a2);

package/common/cpp/audioapi/core/effects/BiquadFilterNode.h

@@ -27,9 +27,10 @@ class BiquadFilterNode : public AudioNode {
   [[nodiscard]] std::shared_ptr<AudioParam> getQParam() const;
   [[nodiscard]] std::shared_ptr<AudioParam> getGainParam() const;
   void getFrequencyResponse(
-      const std::vector<float> &frequencyArray,
-      std::vector<float> &magResponseOutput,
-      std::vector<float> &phaseResponseOutput);
+      const float *frequencyArray,
+      float *magResponseOutput,
+      float *phaseResponseOutput,
+      int length);
 
  protected:
   void processNode(const std::shared_ptr<AudioBus>& processingBus, int framesToProcess) override;

package/common/cpp/audioapi/core/sources/AudioBufferSourceNode.cpp

@@ -9,12 +9,14 @@
 
 namespace audioapi {
 
-AudioBufferSourceNode::AudioBufferSourceNode(BaseAudioContext *context)
+AudioBufferSourceNode::AudioBufferSourceNode(
+    BaseAudioContext *context,
+    bool pitchCorrection)
     : AudioScheduledSourceNode(context),
       loop_(false),
       loopStart_(0),
       loopEnd_(0),
-      timeStretchType_(TimeStretchType::LINEAR),
+      pitchCorrection_(pitchCorrection),
       vReadIndex_(0.0) {
   buffer_ = std::shared_ptr<AudioBuffer>(nullptr);
 
@@ -54,10 +56,6 @@ std::shared_ptr<AudioBuffer> AudioBufferSourceNode::getBuffer() const {
   return buffer_;
 }
 
-std::string AudioBufferSourceNode::getTimeStretchType() const {
-  return toString(timeStretchType_);
-}
-
 void AudioBufferSourceNode::setLoop(bool loop) {
   loop_ = loop;
 }
@@ -91,10 +89,6 @@ void AudioBufferSourceNode::setBuffer(
   loopEnd_ = buffer_->getDuration();
 }
 
-void AudioBufferSourceNode::setTimeStretchType(const std::string &type) {
-  timeStretchType_ = fromString(type);
-}
-
 void AudioBufferSourceNode::start(double when, double offset, double duration) {
   AudioScheduledSourceNode::start(when);
 
@@ -136,7 +130,7 @@ void AudioBufferSourceNode::processNode(
   size_t startOffset = 0;
   size_t offsetLength = 0;
 
-  if (timeStretchType_ == TimeStretchType::LINEAR) {
+  if (!pitchCorrection_) {
     auto computedPlaybackRate = getComputedPlaybackRateValue();
     updatePlaybackInfo(
         processingBus, framesToProcess, startOffset, offsetLength);