react-doctor 0.8.0 → 0.8.1-dev.1839566

package/dist/lsp.js

@@ -33092,7 +33092,7 @@ const SOCKET_FREE_USER_AGENT = "react-doctor-supply-chain";
 const FILE_LINT_CACHE_FILENAME = "file-lint-cache.json";
 const FILE_LINT_CACHE_MAX_FILE_COUNT = 5e4;
 const SIDECAR_LINT_CACHE_FILENAME = "sidecar-lint-cache.json";
-const CORE_PACKAGE_VERSION = "0.8.0";
+const CORE_PACKAGE_VERSION = "0.8.1";
 const DEAD_CODE_CACHE_FILENAME = "dead-code-cache.json";
 const DEAD_CODE_SUMMARY_CACHE_FILENAME = "dead-code-summaries.json";
 const SUPPLY_CHAIN_PLUGIN = "socket";
@@ -35207,6 +35207,9 @@ const SCRIPT_EXTENSION_FRAGMENT = "[cm]?[jt]sx?";
 const STORY_FILE_SUFFIX_PATTERN = new RegExp(`\\.(?:stories|story)\\.(?:${SCRIPT_EXTENSION_FRAGMENT})$`);
 const TEST_FILE_SUFFIX_PATTERN = new RegExp(`\\.(?:test|spec|fixture|fixtures)\\.(?:${SCRIPT_EXTENSION_FRAGMENT})$`);
 const TEST_FILE_DIRECTORY_PATTERN = /(?:^|\/)(?:__tests__|__test__|tests|test|__mocks__|cypress|e2e|playwright)\//;
+const AMBIGUOUS_TEST_ROUTE_DIRECTORY_PATTERN = /(?:^|\/)(?:tests|test)\//;
+const NEXT_APP_ROUTE_FILE_SUFFIX_PATTERN = /\/(?:default|error|forbidden|global-error|layout|loading|not-found|page|route|template|unauthorized)\.[cm]?[jt]sx?$/;
+const SCRIPT_FILE_SUFFIX_PATTERN = /\.[cm]?[jt]sx?$/;
 const FIXTURE_PROJECT_PATTERN = /\/(?:fixtures|__fixtures__)\//;
 const SOURCE_ROOT_PATTERN = /\/(?:src|app|lib|components|pages|features|modules|packages|apps|frontend|client)\//g;
 const stripAboveSourceRoot = (relativePath) => {
@@ -35217,6 +35220,14 @@ const stripAboveSourceRoot = (relativePath) => {
 	if (lastIdx >= 0) return relativePath.slice(lastIdx);
 	return relativePath.slice(fixtureMatch.index + fixtureMatch[0].length - 1);
 };
+const isFrameworkRouteBeforeAmbiguousTestDirectory = (relativePath) => {
+	const testDirectoryMatch = AMBIGUOUS_TEST_ROUTE_DIRECTORY_PATTERN.exec(relativePath);
+	if (testDirectoryMatch === null) return false;
+	let nearestRouteRoot;
+	for (const pathSegment of relativePath.slice(0, testDirectoryMatch.index).split("/")) if (pathSegment === "app" || pathSegment === "pages") nearestRouteRoot = pathSegment;
+	if (nearestRouteRoot === void 0) return false;
+	return nearestRouteRoot === "pages" ? SCRIPT_FILE_SUFFIX_PATTERN.test(relativePath) : NEXT_APP_ROUTE_FILE_SUFFIX_PATTERN.test(relativePath);
+};
 /**
 * Classifies where a file sits relative to shipped code. A finding in a
 * `.stories.tsx` or `.spec.ts` file never runs in front of users, so
@@ -35233,6 +35244,7 @@ const classifyFileContext = (relativePath) => {
 	if (STORY_FILE_SUFFIX_PATTERN.test(forwardSlashed)) return "story";
 	if (TEST_FILE_SUFFIX_PATTERN.test(forwardSlashed)) return "test";
 	const scoped = stripAboveSourceRoot(forwardSlashed);
+	if (isFrameworkRouteBeforeAmbiguousTestDirectory(scoped)) return "production";
 	return TEST_FILE_DIRECTORY_PATTERN.test(scoped) ? "test" : "production";
 };
 /**
@@ -36070,6 +36082,7 @@ const VALID_RULE_SEVERITIES = [
 	"warn",
 	"off"
 ];
+const VALID_INCLUDED_FILE_CONTEXTS = ["test", "story"];
 const KNOWN_CATEGORY_LABEL = DIAGNOSTIC_CATEGORY_BUCKETS.join(", ");
 const isDiagnosticCategoryBucket = (value) => DIAGNOSTIC_CATEGORY_BUCKETS.includes(value);
 const filterKnownCategories = (fieldName, categories) => categories.filter((category) => {
@@ -36104,6 +36117,7 @@ const SURFACE_CONTROL_FIELD_NAMES = [
 	"includeRules",
 	"excludeRules"
 ];
+const isIncludedFileContext = (value) => VALID_INCLUDED_FILE_CONTEXTS.some((fileContext) => fileContext === value);
 const SEVERITY_FIELD_NAMES = ["rules", "categories"];
 const isPlainObject$1 = (value) => typeof value === "object" && value !== null && !Array.isArray(value);
 const formatType = (value) => typeof value === "string" ? `"${value}"` : typeof value;
@@ -36138,6 +36152,15 @@ const validateSurfaceControls = (surface, rawControls) => {
 		return;
 	}
 	const validatedSurfaceControls = {};
+	if (rawControls.includeFileContexts !== void 0) {
+		const qualifiedName = `surfaces.${surface}.includeFileContexts`;
+		const result = validateStringArrayField(qualifiedName, rawControls.includeFileContexts);
+		if (result !== void 0) validatedSurfaceControls.includeFileContexts = result.filter((fileContext) => {
+			if (isIncludedFileContext(fileContext)) return true;
+			warnConfigIssue(`config field "${qualifiedName}" lists "${fileContext}", which is not a non-production file context (expected one of: ${VALID_INCLUDED_FILE_CONTEXTS.join(", ")}); ignoring the entry.`);
+			return false;
+		});
+	}
 	for (const fieldName of SURFACE_CONTROL_FIELD_NAMES) {
 		if (rawControls[fieldName] === void 0) continue;
 		const qualifiedName = `surfaces.${surface}.${fieldName}`;
@@ -38781,6 +38804,7 @@ const buildResolvedControls = (surface, userControls) => {
 	for (const tag of includeTags) excludeTags.delete(tag);
 	for (const tag of toStringSet(userControls?.excludeTags)) excludeTags.add(tag);
 	return {
+		includeFileContexts: toStringSet(userControls?.includeFileContexts),
 		includeTags,
 		excludeTags,
 		includeCategories: toStringSet(userControls?.includeCategories),
@@ -38796,7 +38820,7 @@ const isDiagnosticOnSurface = (diagnostic, surface, config) => {
 	if (resolved.includeRuleKeys.has(ruleKey)) return true;
 	if (resolved.includeCategories.has(category)) return true;
 	if (intersects(tags, resolved.includeTags)) return true;
-	if (diagnostic.fileContext !== void 0 && (surface === "score" || surface === "ciFailure")) return false;
+	if (diagnostic.fileContext !== void 0 && (surface === "score" || surface === "ciFailure") && !resolved.includeFileContexts.has(diagnostic.fileContext)) return false;
 	if (resolved.excludeRuleKeys.has(ruleKey)) return false;
 	if (resolved.excludeCategories.has(category)) return false;
 	if (intersects(tags, resolved.excludeTags)) return false;
@@ -39044,6 +39068,35 @@ const parseGithubViewerPermission = (stdout) => {
 	return /^[A-Z_]+$/.test(value) ? value.toLowerCase() : null;
 };
 const splitNullSeparated = (value) => value.split("\0").filter((entry) => entry.length > 0);
+const parseBaselineDiffPlan = (value) => {
+	const entries = splitNullSeparated(value);
+	const baseFiles = /* @__PURE__ */ new Set();
+	const headFiles = /* @__PURE__ */ new Set();
+	for (let entryIndex = 0; entryIndex < entries.length; entryIndex += 2) {
+		const status = entries[entryIndex];
+		const filePath = entries[entryIndex + 1];
+		if (status === void 0 || filePath === void 0 || status.length !== 1) return null;
+		if (status === "A") {
+			headFiles.add(filePath);
+			continue;
+		}
+		if (status === "D") {
+			baseFiles.add(filePath);
+			continue;
+		}
+		if (status === "M" || status === "T") {
+			baseFiles.add(filePath);
+			headFiles.add(filePath);
+			continue;
+		}
+		return null;
+	}
+	return {
+		baseFiles: [...baseFiles],
+		headFiles: [...headFiles],
+		untrackedFiles: []
+	};
+};
 const UNTRACKED_FILE_LAST_LINE = Number.MAX_SAFE_INTEGER;
 /**
 * `Git` wraps every `git`-via-subprocess call react-doctor makes
@@ -39246,6 +39299,45 @@ var Git = class Git extends Service()("react-doctor/Git") {
 			githubViewerPermission,
 			branchExists,
 			mergeBase,
+			baselineDiffPlan: (input) => {
+				if (!isSafeGitRevision(input.ref)) return succeed$2(null);
+				return gen(function* () {
+					const unmerged = yield* runGit(input.directory, [
+						"diff",
+						"--no-ext-diff",
+						"-z",
+						"--name-only",
+						"--diff-filter=U",
+						"--relative"
+					]);
+					if (unmerged.status !== 0 || unmerged.stdout.length > 0) return null;
+					const result = yield* runGit(input.directory, [
+						"diff",
+						"--no-ext-diff",
+						"--no-textconv",
+						"--no-renames",
+						"-z",
+						"--name-status",
+						"--relative",
+						input.ref
+					]);
+					if (result.status !== 0) return null;
+					const plan = parseBaselineDiffPlan(result.stdout);
+					if (plan === null) return null;
+					const untracked = yield* runGit(input.directory, [
+						"ls-files",
+						"--others",
+						"--exclude-standard",
+						"-z"
+					]);
+					if (untracked.status !== 0) return null;
+					return {
+						baseFiles: plan.baseFiles,
+						headFiles: plan.headFiles,
+						untrackedFiles: splitNullSeparated(untracked.stdout)
+					};
+				}).pipe(catch_$1(() => succeed$2(null)), withSpan("Git.baselineDiffPlan"));
+			},
 			diffSelection: ({ directory, explicitBaseBranch, includeUntracked = false }) => gen(function* () {
 				if (explicitBaseBranch !== void 0 && explicitBaseBranch.trim().length === 0) return yield* fail$4(new ReactDoctorError({ reason: new GitBaseBranchInvalid({ detail: "Diff base branch cannot be empty." }) }));
 				if (explicitBaseBranch !== void 0) {
@@ -39395,6 +39487,7 @@ var Git = class Git extends Service()("react-doctor/Git") {
 		githubViewerPermission: () => succeed$2(snapshot.githubViewerPermission ?? null),
 		branchExists: (_directory, branch) => succeed$2(snapshot.branchExists?.get(branch) ?? false),
 		mergeBase: ({ ref }) => succeed$2(snapshot.mergeBase?.get(ref) ?? null),
+		baselineDiffPlan: () => succeed$2(snapshot.baselineDiffPlan ?? null),
 		diffSelection: () => succeed$2(snapshot.diffSelection ?? null),
 		stagedFilePaths: () => succeed$2(snapshot.stagedFiles ?? []),
 		showStagedContent: (_directory, relativePath) => succeed$2(snapshot.stagedContent?.get(relativePath) ?? null),
@@ -43120,12 +43213,19 @@ const isPathInsideDirectory = (childAbsolutePath, parentAbsolutePath) => {
 */
 const materializeSourceTree = (input) => gen(function* () {
 	const materializedFiles = [];
+	const unmaterializedFiles = [];
 	const resolvedTempDirectory = path.resolve(input.tempDirectory);
 	for (const relativePath of input.files) {
 		const content = yield* input.readContent(relativePath).pipe(orElseSucceed(() => null));
-		if (content === null) continue;
+		if (content === null) {
+			unmaterializedFiles.push(relativePath);
+			continue;
+		}
 		const candidateTargetPath = path.resolve(resolvedTempDirectory, relativePath);
-		if (!isPathInsideDirectory(candidateTargetPath, resolvedTempDirectory)) continue;
+		if (!isPathInsideDirectory(candidateTargetPath, resolvedTempDirectory)) {
+			unmaterializedFiles.push(relativePath);
+			continue;
+		}
 		yield* sync(() => {
 			fs.mkdirSync(path.dirname(candidateTargetPath), { recursive: true });
 			fs.writeFileSync(candidateTargetPath, content);
@@ -43142,6 +43242,7 @@ const materializeSourceTree = (input) => gen(function* () {
 	return {
 		tempDirectory: input.tempDirectory,
 		materializedFiles,
+		unmaterializedFiles,
 		cleanup: () => {
 			try {
 				fs.rmSync(input.tempDirectory, {
@@ -43317,7 +43418,7 @@ const computeConfigFingerprint = (projectDirectory, version) => {
 /** Display name used in client-facing messages and progress titles. */
 const SERVER_DISPLAY_NAME = "React Doctor";
 /** Server version reported in `serverInfo`; injected at build, `dev` from source. */
-const SERVER_VERSION = "0.8.0";
+const SERVER_VERSION = "0.8.1";
 /** `Diagnostic.source` shown next to every published diagnostic. */
 const DIAGNOSTIC_SOURCE = "react-doctor";
 /**
@@ -45347,5 +45448,5 @@ const startLanguageServer = () => {
 };
 //#endregion
 export { startLanguageServer };
-!function(){try{var e="undefined"!=typeof window?window:"undefined"!=typeof global?global:"undefined"!=typeof globalThis?globalThis:"undefined"!=typeof self?self:{},n=(new e.Error).stack;n&&(e._sentryDebugIds=e._sentryDebugIds||{},e._sentryDebugIds[n]="9eca6678-56ba-5032-b04c-b1ed965dffb4")}catch(e){}}();
-//# debugId=9eca6678-56ba-5032-b04c-b1ed965dffb4
+!function(){try{var e="undefined"!=typeof window?window:"undefined"!=typeof global?global:"undefined"!=typeof globalThis?globalThis:"undefined"!=typeof self?self:{},n=(new e.Error).stack;n&&(e._sentryDebugIds=e._sentryDebugIds||{},e._sentryDebugIds[n]="4fa679df-c187-5989-bc8a-a96791a6f02c")}catch(e){}}();
+//# debugId=4fa679df-c187-5989-bc8a-a96791a6f02c

package/dist/skills/react-doctor/references/explain.md

@@ -51,6 +51,7 @@ Match the control to the intent — prefer the narrowest one:
 - **A whole area is unwanted** (e.g. all React Native rules) → `rules category "<Category>" off`.
 - **A behavioral family is noisy** (`design`, `test-noise`, `migration-hint`) → `rules ignore-tag <tag>`.
 - **Keep it locally but hide from PR comment / score / CI gate only** → do NOT disable. Edit `surfaces` in your config (`surfaces.prComment.excludeRules`, `surfaces.score.excludeTags`, `surfaces.ciFailure.excludeCategories`). The rule still shows in local `cli` output.
+- **Restore test or story findings to production health** → set `surfaces.score.includeFileContexts` or `surfaces.ciFailure.includeFileContexts` to `["test"]`, `["story"]`, or both. Other surface exclusions still apply.
 
 How the layers combine: `ignore.tags` disables every rule carrying that tag **before** linting, so a tagged rule stays off even if `rules`/`categories` set it to `warn`/`error` (a rule-level override cannot re-enable a tag-ignored rule). For rules that aren't tag-disabled, `rules` overrides `categories` overrides the rule's default. `surfaces` is visibility-only and never changes whether a rule runs.
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-doctor",
-  "version": "0.8.0",
+  "version": "0.8.1-dev.1839566",
   "description": "Your agent writes bad React. This catches it",
   "keywords": [
     "accessibility",
@@ -65,8 +65,8 @@
     "vscode-languageserver-textdocument": "^1.0.12",
     "vscode-uri": "^3.1.0",
     "yaml": "^2.9.0",
-    "deslop-js": "0.8.0",
-    "oxlint-plugin-react-doctor": "0.8.0"
+    "oxlint-plugin-react-doctor": "0.8.1-dev.1839566",
+    "deslop-js": "0.8.1"
   },
   "devDependencies": {
     "@types/babel__code-frame": "^7.27.0",
@@ -74,9 +74,9 @@
     "@xterm/headless": "^6.0.0",
     "commander": "^14.0.3",
     "ora": "^9.4.0",
-    "@react-doctor/api": "0.8.0",
-    "@react-doctor/core": "0.8.0",
-    "@react-doctor/language-server": "0.8.0"
+    "@react-doctor/core": "0.8.1",
+    "@react-doctor/api": "0.8.1",
+    "@react-doctor/language-server": "0.8.1"
   },
   "engines": {
     "node": "^20.19.0 || >=22.13.0"