react-doctor 0.1.5 → 0.1.6

package/dist/cli.js

@@ -39,10 +39,18 @@ const ADOPTABLE_LINT_CONFIG_FILENAMES = [".oxlintrc.json", ".eslintrc.json"];
 const OXLINT_NODE_REQUIREMENT = "^20.19.0 || >=22.12.0";
 const GIT_SHOW_MAX_BUFFER_BYTES = 10 * 1024 * 1024;
 const IGNORED_DIRECTORIES = new Set([
-	"node_modules",
-	"dist",
+	".git",
+	".next",
+	".nuxt",
+	".output",
+	".svelte-kit",
+	".turbo",
 	"build",
-	"coverage"
+	"coverage",
+	"dist",
+	"node_modules",
+	"out",
+	"storybook-static"
 ]);
 const CANONICAL_GITHUB_URL = "https://github.com/millionco/react-doctor";
 const SKILL_NAME = "react-doctor";
@@ -1455,36 +1463,58 @@ const hasReactDependency = (packageJson) => {
 	const allDependencies = collectAllDependencies(packageJson);
 	return Object.keys(allDependencies).some((packageName) => REACT_DEPENDENCY_NAMES.has(packageName));
 };
-const discoverReactSubprojects = (rootDirectory) => {
-	if (!fs.existsSync(rootDirectory) || !fs.statSync(rootDirectory).isDirectory()) return [];
+const toReactWorkspacePackages = (directories) => {
 	const packages = [];
-	const rootPackageJsonPath = path.join(rootDirectory, "package.json");
-	if (isFile(rootPackageJsonPath)) {
-		const rootPackageJson = readPackageJson(rootPackageJsonPath);
-		if (hasReactDependency(rootPackageJson)) {
-			const name = rootPackageJson.name ?? path.basename(rootDirectory);
-			packages.push({
-				name,
-				directory: rootDirectory
-			});
-		}
-	}
-	const entries = fs.readdirSync(rootDirectory, { withFileTypes: true });
-	for (const entry of entries) {
-		if (!entry.isDirectory() || entry.name.startsWith(".") || entry.name === "node_modules") continue;
-		const subdirectory = path.join(rootDirectory, entry.name);
-		const packageJsonPath = path.join(subdirectory, "package.json");
+	for (const directory of directories) {
+		const packageJsonPath = path.join(directory, "package.json");
 		if (!isFile(packageJsonPath)) continue;
 		const packageJson = readPackageJson(packageJsonPath);
 		if (!hasReactDependency(packageJson)) continue;
-		const name = packageJson.name ?? entry.name;
+		const name = packageJson.name ?? path.basename(directory);
 		packages.push({
 			name,
-			directory: subdirectory
+			directory
 		});
 	}
 	return packages;
 };
+const listManifestWorkspacePackages = (rootDirectory) => {
+	if (isFile(path.join(rootDirectory, "package.json"))) return listWorkspacePackages(rootDirectory);
+	const patterns = parsePnpmWorkspacePatterns(rootDirectory);
+	const nxPatterns = patterns.length > 0 ? [] : getNxWorkspaceDirectories(rootDirectory);
+	return toReactWorkspacePackages((patterns.length > 0 ? patterns : nxPatterns).flatMap((pattern) => resolveWorkspaceDirectories(rootDirectory, pattern)));
+};
+const discoverReactSubprojectsByFilesystem = (rootDirectory) => {
+	const packages = [];
+	const pendingDirectories = [rootDirectory];
+	while (pendingDirectories.length > 0) {
+		const currentDirectory = pendingDirectories.shift();
+		if (!currentDirectory) continue;
+		const packageJsonPath = path.join(currentDirectory, "package.json");
+		if (isFile(packageJsonPath)) {
+			const packageJson = readPackageJson(packageJsonPath);
+			if (hasReactDependency(packageJson)) {
+				const name = packageJson.name ?? path.basename(currentDirectory);
+				packages.push({
+					name,
+					directory: currentDirectory
+				});
+			}
+		}
+		const entries = fs.readdirSync(currentDirectory, { withFileTypes: true }).toSorted((firstEntry, secondEntry) => firstEntry.name.localeCompare(secondEntry.name));
+		for (const entry of entries) {
+			if (!entry.isDirectory() || entry.name.startsWith(".") || IGNORED_DIRECTORIES.has(entry.name)) continue;
+			pendingDirectories.push(path.join(currentDirectory, entry.name));
+		}
+	}
+	return packages;
+};
+const discoverReactSubprojects = (rootDirectory) => {
+	if (!fs.existsSync(rootDirectory) || !fs.statSync(rootDirectory).isDirectory()) return [];
+	const manifestPackages = listManifestWorkspacePackages(rootDirectory);
+	if (manifestPackages.length > 0) return manifestPackages;
+	return discoverReactSubprojectsByFilesystem(rootDirectory);
+};
 const listWorkspacePackages = (rootDirectory) => {
 	const packageJsonPath = path.join(rootDirectory, "package.json");
 	if (!isFile(packageJsonPath)) return [];
@@ -4252,7 +4282,7 @@ const promptProjectSelection = async (workspacePackages, rootDirectory) => {
 };
 //#endregion
 //#region src/cli.ts
-const VERSION = "0.1.5";
+const VERSION = "0.1.6";
 const VALID_FAIL_ON_LEVELS = new Set([
 	"error",
 	"warning",

package/dist/eslint-plugin.js

@@ -6946,7 +6946,7 @@ const ALL_RULES_AT_RECOMMENDED_SEVERITY = {
 const eslintPlugin = {
 	meta: {
 		name: PLUGIN_NAMESPACE,
-		version: "0.1.5"
+		version: "0.1.6"
 	},
 	rules: eslintShapedRules,
 	configs: {

package/dist/index.js

@@ -28,10 +28,18 @@ const KNIP_CONFIG_LOCATIONS = [
 ];
 const ADOPTABLE_LINT_CONFIG_FILENAMES = [".oxlintrc.json", ".eslintrc.json"];
 const IGNORED_DIRECTORIES = new Set([
-	"node_modules",
-	"dist",
+	".git",
+	".next",
+	".nuxt",
+	".output",
+	".svelte-kit",
+	".turbo",
 	"build",
-	"coverage"
+	"coverage",
+	"dist",
+	"node_modules",
+	"out",
+	"storybook-static"
 ]);
 const PROXY_OUTPUT_MAX_BYTES = 50 * 1024 * 1024;
 const buildNoReactDependencyError = (directory) => `No React dependency found in ${directory}/package.json. Add "react" to dependencies (or peerDependencies) and re-run.`;
@@ -969,36 +977,86 @@ const hasReactDependency = (packageJson) => {
 	const allDependencies = collectAllDependencies(packageJson);
 	return Object.keys(allDependencies).some((packageName) => REACT_DEPENDENCY_NAMES.has(packageName));
 };
-const discoverReactSubprojects = (rootDirectory) => {
-	if (!fs.existsSync(rootDirectory) || !fs.statSync(rootDirectory).isDirectory()) return [];
+const toReactWorkspacePackages = (directories) => {
 	const packages = [];
-	const rootPackageJsonPath = path.join(rootDirectory, "package.json");
-	if (isFile(rootPackageJsonPath)) {
-		const rootPackageJson = readPackageJson(rootPackageJsonPath);
-		if (hasReactDependency(rootPackageJson)) {
-			const name = rootPackageJson.name ?? path.basename(rootDirectory);
-			packages.push({
-				name,
-				directory: rootDirectory
-			});
-		}
-	}
-	const entries = fs.readdirSync(rootDirectory, { withFileTypes: true });
-	for (const entry of entries) {
-		if (!entry.isDirectory() || entry.name.startsWith(".") || entry.name === "node_modules") continue;
-		const subdirectory = path.join(rootDirectory, entry.name);
-		const packageJsonPath = path.join(subdirectory, "package.json");
+	for (const directory of directories) {
+		const packageJsonPath = path.join(directory, "package.json");
 		if (!isFile(packageJsonPath)) continue;
 		const packageJson = readPackageJson(packageJsonPath);
 		if (!hasReactDependency(packageJson)) continue;
-		const name = packageJson.name ?? entry.name;
+		const name = packageJson.name ?? path.basename(directory);
 		packages.push({
 			name,
-			directory: subdirectory
+			directory
 		});
 	}
 	return packages;
 };
+const listManifestWorkspacePackages = (rootDirectory) => {
+	if (isFile(path.join(rootDirectory, "package.json"))) return listWorkspacePackages(rootDirectory);
+	const patterns = parsePnpmWorkspacePatterns(rootDirectory);
+	const nxPatterns = patterns.length > 0 ? [] : getNxWorkspaceDirectories(rootDirectory);
+	return toReactWorkspacePackages((patterns.length > 0 ? patterns : nxPatterns).flatMap((pattern) => resolveWorkspaceDirectories(rootDirectory, pattern)));
+};
+const discoverReactSubprojectsByFilesystem = (rootDirectory) => {
+	const packages = [];
+	const pendingDirectories = [rootDirectory];
+	while (pendingDirectories.length > 0) {
+		const currentDirectory = pendingDirectories.shift();
+		if (!currentDirectory) continue;
+		const packageJsonPath = path.join(currentDirectory, "package.json");
+		if (isFile(packageJsonPath)) {
+			const packageJson = readPackageJson(packageJsonPath);
+			if (hasReactDependency(packageJson)) {
+				const name = packageJson.name ?? path.basename(currentDirectory);
+				packages.push({
+					name,
+					directory: currentDirectory
+				});
+			}
+		}
+		const entries = fs.readdirSync(currentDirectory, { withFileTypes: true }).toSorted((firstEntry, secondEntry) => firstEntry.name.localeCompare(secondEntry.name));
+		for (const entry of entries) {
+			if (!entry.isDirectory() || entry.name.startsWith(".") || IGNORED_DIRECTORIES.has(entry.name)) continue;
+			pendingDirectories.push(path.join(currentDirectory, entry.name));
+		}
+	}
+	return packages;
+};
+const discoverReactSubprojects = (rootDirectory) => {
+	if (!fs.existsSync(rootDirectory) || !fs.statSync(rootDirectory).isDirectory()) return [];
+	const manifestPackages = listManifestWorkspacePackages(rootDirectory);
+	if (manifestPackages.length > 0) return manifestPackages;
+	return discoverReactSubprojectsByFilesystem(rootDirectory);
+};
+const listWorkspacePackages = (rootDirectory) => {
+	const packageJsonPath = path.join(rootDirectory, "package.json");
+	if (!isFile(packageJsonPath)) return [];
+	const packageJson = readPackageJson(packageJsonPath);
+	const patterns = getWorkspacePatterns(rootDirectory, packageJson);
+	if (patterns.length === 0) return [];
+	const packages = [];
+	if (hasReactDependency(packageJson)) {
+		const rootName = packageJson.name ?? path.basename(rootDirectory);
+		packages.push({
+			name: rootName,
+			directory: rootDirectory
+		});
+	}
+	for (const pattern of patterns) {
+		const directories = resolveWorkspaceDirectories(rootDirectory, pattern);
+		for (const workspaceDirectory of directories) {
+			const workspacePackageJson = readPackageJson(path.join(workspaceDirectory, "package.json"));
+			if (!hasReactDependency(workspacePackageJson)) continue;
+			const name = workspacePackageJson.name ?? path.basename(workspaceDirectory);
+			packages.push({
+				name,
+				directory: workspaceDirectory
+			});
+		}
+	}
+	return packages;
+};
 const hasCompilerPackage = (packageJson) => {
 	const allDependencies = collectAllDependencies(packageJson);
 	return Object.keys(allDependencies).some((packageName) => REACT_COMPILER_PACKAGES.has(packageName));
@@ -1660,7 +1718,7 @@ const resolveDiagnoseTarget = (directory) => {
 	const reactSubprojects = discoverReactSubprojects(directory);
 	if (reactSubprojects.length === 0) return null;
 	if (reactSubprojects.length === 1) return reactSubprojects[0].directory;
-	throw new AmbiguousProjectError(directory, reactSubprojects.map((subproject) => path.relative(directory, subproject.directory)));
+	throw new AmbiguousProjectError(directory, reactSubprojects.map((subproject) => path.relative(directory, subproject.directory)).toSorted());
 };
 //#endregion
 //#region src/utils/resolve-lint-include-paths.ts

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-doctor",
-  "version": "0.1.5",
+  "version": "0.1.6",
   "description": "Diagnose and fix React codebases for security, performance, correctness, accessibility, bundle-size, and architecture issues",
   "keywords": [
     "accessibility",