react-doctor 0.0.6 → 0.0.7

package/dist/cli.js

@@ -5,8 +5,8 @@ import path, { join } from "node:path";
 import { Command } from "commander";
 import pc from "picocolors";
 import { randomUUID } from "node:crypto";
-import fs, { mkdirSync, writeFileSync } from "node:fs";
-import os, { tmpdir } from "node:os";
+import fs, { existsSync, mkdirSync, readFileSync, writeFileSync } from "node:fs";
+import os, { homedir, tmpdir } from "node:os";
 import { performance } from "node:perf_hooks";
 import { main } from "knip";
 import { createOptions } from "knip/session";
@@ -493,7 +493,8 @@ const NEXTJS_RULES = {
 	"react-doctor/nextjs-no-font-link": "warn",
 	"react-doctor/nextjs-no-css-link": "warn",
 	"react-doctor/nextjs-no-polyfill-script": "warn",
-	"react-doctor/nextjs-no-head-import": "error"
+	"react-doctor/nextjs-no-head-import": "error",
+	"react-doctor/nextjs-no-side-effect-in-get-handler": "error"
 };
 const REACT_COMPILER_RULES = {
 	"react-hooks-js/set-state-in-render": "error",
@@ -670,6 +671,7 @@ const RULE_CATEGORY_MAP = {
 	"react-doctor/nextjs-no-css-link": "Next.js",
 	"react-doctor/nextjs-no-polyfill-script": "Next.js",
 	"react-doctor/nextjs-no-head-import": "Next.js",
+	"react-doctor/nextjs-no-side-effect-in-get-handler": "Security",
 	"react-doctor/server-auth-actions": "Server",
 	"react-doctor/server-after-nonblocking": "Server",
 	"react-doctor/client-passive-event-listeners": "Performance",
@@ -725,6 +727,7 @@ const RULE_HELP_MAP = {
 	"nextjs-no-css-link": "Import CSS directly: `import './styles.css'` or use CSS Modules: `import styles from './Button.module.css'`",
 	"nextjs-no-polyfill-script": "Next.js includes polyfills for fetch, Promise, Object.assign, Array.from, and 50+ others automatically",
 	"nextjs-no-head-import": "Use the Metadata API instead: `export const metadata = { title: '...' }` or `export async function generateMetadata()`",
+	"nextjs-no-side-effect-in-get-handler": "Move the side effect to a POST handler and use a <form> or fetch with method POST — GET requests can be triggered by prefetching and are vulnerable to CSRF",
 	"server-auth-actions": "Add `const session = await auth()` at the top and throw/redirect if unauthorized before any data access",
 	"server-after-nonblocking": "`import { after } from 'next/server'` then wrap: `after(() => analytics.track(...))` — response isn't blocked",
 	"client-passive-event-listeners": "Add `{ passive: true }` as the third argument: `addEventListener('scroll', handler, { passive: true })`",
@@ -1125,9 +1128,67 @@ const promptProjectSelection = async (workspacePackages, rootDirectory) => {
 	return selectedDirectories;
 };
 
+//#endregion
+//#region src/utils/skill-prompt.ts
+const CONFIG_DIRECTORY = join(homedir(), ".react-doctor");
+const CONFIG_FILE = join(CONFIG_DIRECTORY, "config.json");
+const SKILL_REPO = "aidenybai/react-doctor";
+const readConfig = () => {
+	try {
+		if (!existsSync(CONFIG_FILE)) return {};
+		return JSON.parse(readFileSync(CONFIG_FILE, "utf-8"));
+	} catch {
+		return {};
+	}
+};
+const writeConfig = (config) => {
+	try {
+		if (!existsSync(CONFIG_DIRECTORY)) mkdirSync(CONFIG_DIRECTORY, { recursive: true });
+		writeFileSync(CONFIG_FILE, JSON.stringify(config, null, 2));
+	} catch {}
+};
+const installSkill = () => {
+	try {
+		execSync(`npx -y skills add ${SKILL_REPO}`, { stdio: "inherit" });
+		return true;
+	} catch {
+		return false;
+	}
+};
+const maybePromptSkillInstall = async (shouldSkipPrompts) => {
+	const config = readConfig();
+	if (config.skillPromptDismissed) return;
+	if (shouldSkipPrompts) return;
+	logger.break();
+	logger.log(`${highlighter.info("💡")} Install the ${highlighter.info("react-doctor")} skill for your coding agent?`);
+	logger.dim("   Adds React best practices to Cursor, Claude Code, Copilot, and more.");
+	logger.break();
+	const { shouldInstall } = await prompts({
+		type: "confirm",
+		name: "shouldInstall",
+		message: "Install skill?",
+		initial: true
+	});
+	if (shouldInstall) {
+		logger.break();
+		if (installSkill()) {
+			logger.break();
+			logger.success("Skill installed!");
+		} else {
+			logger.break();
+			logger.dim("Skill install failed. You can install manually:");
+			logger.dim(`  npx skills add ${SKILL_REPO}`);
+		}
+	}
+	writeConfig({
+		...config,
+		skillPromptDismissed: true
+	});
+};
+
 //#endregion
 //#region src/cli.ts
-const VERSION = "0.0.6";
+const VERSION = "0.0.7";
 process.on("SIGINT", () => process.exit(0));
 process.on("SIGTERM", () => process.exit(0));
 const program = new Command().name("react-doctor").description("Diagnose React codebase health").version(VERSION, "-v, --version", "display the version number").argument("[directory]", "project directory to scan", ".").option("--no-lint", "skip linting").option("--no-dead-code", "skip dead code detection").option("--verbose", "show file details per rule").option("--score", "output only the score").option("-y, --yes", "skip prompts, scan all workspace projects").option("--project <name>", "select workspace project (comma-separated for multiple)").option("--fix", "open Ami to auto-fix all issues").action(async (directory, flags) => {
@@ -1155,6 +1216,7 @@ const program = new Command().name("react-doctor").description("Diagnose React c
 			if (!isScoreOnly) logger.break();
 		}
 		if (flags.fix) openAmiToFix(resolvedDirectory);
+		if (!isScoreOnly) await maybePromptSkillInstall(shouldSkipPrompts);
 	} catch (error) {
 		handleError(error);
 	}
@@ -1164,9 +1226,7 @@ ${highlighter.dim("Learn more:")}
 `);
 const AMI_INSTALL_URL = "https://ami.dev/install.sh";
 const AMI_FIX_PROMPT = "Run npx -y react-doctor@latest . --verbose, read every diagnostic, then fix all issues one by one. After fixing, re-run react-doctor to verify the score improved.";
-const buildAmiDeeplink = (projectDirectory) => {
-	return `ami://new-chat?cwd=${encodeURIComponent(projectDirectory)}&prompt=${encodeURIComponent(AMI_FIX_PROMPT)}&mode=agent`;
-};
+const OPEN_PROJECT_DELAY_S = 2;
 const isAmiInstalled = () => {
 	try {
 		execSync("ls /Applications/Ami.app", { stdio: "ignore" });
@@ -1190,14 +1250,18 @@ const openAmiToFix = (directory) => {
 	const resolvedDirectory = path.resolve(directory);
 	if (!isAmiInstalled()) installAmi();
 	logger.log("Opening Ami to fix react-doctor issues...");
-	const deeplink = buildAmiDeeplink(resolvedDirectory);
+	const encodedDirectory = encodeURIComponent(resolvedDirectory);
+	const encodedPrompt = encodeURIComponent(AMI_FIX_PROMPT);
+	const openProjectDeeplink = `ami://open-project?cwd=${encodedDirectory}`;
+	const newChatDeeplink = `ami://new-chat?prompt=${encodedPrompt}&mode=agent&send=true`;
 	try {
-		execSync(`open "${deeplink}"`, { stdio: "ignore" });
+		execSync(`open "${openProjectDeeplink}" && sleep ${OPEN_PROJECT_DELAY_S} && open "${newChatDeeplink}"`, { stdio: "ignore" });
 		logger.success("Opened Ami with react-doctor fix prompt.");
 	} catch {
 		logger.break();
-		logger.dim("Could not open Ami automatically. Open this URL manually:");
-		logger.info(deeplink);
+		logger.dim("Could not open Ami automatically. Open these URLs manually:");
+		logger.info(openProjectDeeplink);
+		logger.info(newChatDeeplink);
 	}
 };
 const fixAction = (directory) => {