react-doctor 0.0.5 → 0.0.7

package/dist/cli.js

@@ -1,13 +1,13 @@
 #!/usr/bin/env node
 import { createRequire } from "node:module";
+import { execSync, spawn, spawnSync } from "node:child_process";
 import path, { join } from "node:path";
 import { Command } from "commander";
 import pc from "picocolors";
 import { randomUUID } from "node:crypto";
-import fs, { mkdirSync, writeFileSync } from "node:fs";
-import os, { tmpdir } from "node:os";
+import fs, { existsSync, mkdirSync, readFileSync, writeFileSync } from "node:fs";
+import os, { homedir, tmpdir } from "node:os";
 import { performance } from "node:perf_hooks";
-import { execSync, spawn, spawnSync } from "node:child_process";
 import { main } from "knip";
 import { createOptions } from "knip/session";
 import { fileURLToPath } from "node:url";
@@ -493,7 +493,8 @@ const NEXTJS_RULES = {
 	"react-doctor/nextjs-no-font-link": "warn",
 	"react-doctor/nextjs-no-css-link": "warn",
 	"react-doctor/nextjs-no-polyfill-script": "warn",
-	"react-doctor/nextjs-no-head-import": "error"
+	"react-doctor/nextjs-no-head-import": "error",
+	"react-doctor/nextjs-no-side-effect-in-get-handler": "error"
 };
 const REACT_COMPILER_RULES = {
 	"react-hooks-js/set-state-in-render": "error",
@@ -670,6 +671,7 @@ const RULE_CATEGORY_MAP = {
 	"react-doctor/nextjs-no-css-link": "Next.js",
 	"react-doctor/nextjs-no-polyfill-script": "Next.js",
 	"react-doctor/nextjs-no-head-import": "Next.js",
+	"react-doctor/nextjs-no-side-effect-in-get-handler": "Security",
 	"react-doctor/server-auth-actions": "Server",
 	"react-doctor/server-after-nonblocking": "Server",
 	"react-doctor/client-passive-event-listeners": "Performance",
@@ -725,6 +727,7 @@ const RULE_HELP_MAP = {
 	"nextjs-no-css-link": "Import CSS directly: `import './styles.css'` or use CSS Modules: `import styles from './Button.module.css'`",
 	"nextjs-no-polyfill-script": "Next.js includes polyfills for fetch, Promise, Object.assign, Array.from, and 50+ others automatically",
 	"nextjs-no-head-import": "Use the Metadata API instead: `export const metadata = { title: '...' }` or `export async function generateMetadata()`",
+	"nextjs-no-side-effect-in-get-handler": "Move the side effect to a POST handler and use a <form> or fetch with method POST — GET requests can be triggered by prefetching and are vulnerable to CSRF",
 	"server-auth-actions": "Add `const session = await auth()` at the top and throw/redirect if unauthorized before any data access",
 	"server-after-nonblocking": "`import { after } from 'next/server'` then wrap: `after(() => analytics.track(...))` — response isn't blocked",
 	"client-passive-event-listeners": "Add `{ passive: true }` as the third argument: `addEventListener('scroll', handler, { passive: true })`",
@@ -954,6 +957,23 @@ const printScoreGauge = (score, label) => {
 	logger.log(`  ${buildScoreBar(score)}`);
 	logger.break();
 };
+const getDoctorFace = (score) => {
+	if (score >= SCORE_GOOD_THRESHOLD) return ["◠ ◠", " ▽ "];
+	if (score >= SCORE_OK_THRESHOLD) return ["• •", " ─ "];
+	return ["x x", " ▽ "];
+};
+const printBranding = (score) => {
+	if (score !== void 0) {
+		const [eyes, mouth] = getDoctorFace(score);
+		const colorize = (text) => colorizeByScore(text, score);
+		logger.log(colorize("  ┌─────┐"));
+		logger.log(colorize(`  │ ${eyes} │`));
+		logger.log(colorize(`  │ ${mouth} │`));
+		logger.log(colorize("  └─────┘"));
+	}
+	logger.log(`  React Doctor ${highlighter.dim("(www.react.doctor)")}`);
+	logger.break();
+};
 const printSummary = (diagnostics, elapsedMilliseconds, scoreResult) => {
 	const errorCount = diagnostics.filter((diagnostic) => diagnostic.severity === "error").length;
 	const warningCount = diagnostics.filter((diagnostic) => diagnostic.severity === "warning").length;
@@ -961,6 +981,7 @@ const printSummary = (diagnostics, elapsedMilliseconds, scoreResult) => {
 	const elapsed = formatElapsedTime(elapsedMilliseconds);
 	logger.log("─".repeat(SEPARATOR_LENGTH_CHARS));
 	logger.break();
+	printBranding(scoreResult?.score);
 	if (scoreResult) printScoreGauge(scoreResult.score, scoreResult.label);
 	else {
 		logger.dim(`  ${OFFLINE_MESSAGE}`);
@@ -1035,8 +1056,10 @@ const scan = async (directory, options) => {
 	if (diagnostics.length === 0) {
 		logger.success("No issues found!");
 		logger.break();
-		if (scoreResult) printScoreGauge(scoreResult.score, scoreResult.label);
-		else logger.dim(`  ${OFFLINE_MESSAGE}`);
+		if (scoreResult) {
+			printBranding(scoreResult.score);
+			printScoreGauge(scoreResult.score, scoreResult.label);
+		} else logger.dim(`  ${OFFLINE_MESSAGE}`);
 		return;
 	}
 	printDiagnostics(diagnostics, options.verbose);
@@ -1058,8 +1081,8 @@ const prompts = (questions) => {
 //#endregion
 //#region src/utils/select-projects.ts
 const selectProjects = async (rootDirectory, projectFlag, skipPrompts) => {
-	const packages = listWorkspacePackages(rootDirectory);
-	if (packages.length === 0) packages.push(...discoverReactSubprojects(rootDirectory));
+	let packages = listWorkspacePackages(rootDirectory);
+	if (packages.length === 0) packages = discoverReactSubprojects(rootDirectory);
 	if (packages.length === 0) return [rootDirectory];
 	if (projectFlag) return resolveProjectFlag(projectFlag, packages);
 	if (skipPrompts) {
@@ -1087,7 +1110,7 @@ const printDiscoveredProjects = (packages) => {
 	for (const workspacePackage of packages) logger.log(`  ${highlighter.dim("─")} ${workspacePackage.directory}`);
 	logger.break();
 	logger.dim(`Run with a specific path to scan a project:`);
-	logger.dim(`  npx react-doctor@latest <path>`);
+	logger.dim(`  npx -y react-doctor@latest <path>`);
 	logger.break();
 };
 const promptProjectSelection = async (workspacePackages, rootDirectory) => {
@@ -1105,12 +1128,70 @@ const promptProjectSelection = async (workspacePackages, rootDirectory) => {
 	return selectedDirectories;
 };
 
+//#endregion
+//#region src/utils/skill-prompt.ts
+const CONFIG_DIRECTORY = join(homedir(), ".react-doctor");
+const CONFIG_FILE = join(CONFIG_DIRECTORY, "config.json");
+const SKILL_REPO = "aidenybai/react-doctor";
+const readConfig = () => {
+	try {
+		if (!existsSync(CONFIG_FILE)) return {};
+		return JSON.parse(readFileSync(CONFIG_FILE, "utf-8"));
+	} catch {
+		return {};
+	}
+};
+const writeConfig = (config) => {
+	try {
+		if (!existsSync(CONFIG_DIRECTORY)) mkdirSync(CONFIG_DIRECTORY, { recursive: true });
+		writeFileSync(CONFIG_FILE, JSON.stringify(config, null, 2));
+	} catch {}
+};
+const installSkill = () => {
+	try {
+		execSync(`npx -y skills add ${SKILL_REPO}`, { stdio: "inherit" });
+		return true;
+	} catch {
+		return false;
+	}
+};
+const maybePromptSkillInstall = async (shouldSkipPrompts) => {
+	const config = readConfig();
+	if (config.skillPromptDismissed) return;
+	if (shouldSkipPrompts) return;
+	logger.break();
+	logger.log(`${highlighter.info("💡")} Install the ${highlighter.info("react-doctor")} skill for your coding agent?`);
+	logger.dim("   Adds React best practices to Cursor, Claude Code, Copilot, and more.");
+	logger.break();
+	const { shouldInstall } = await prompts({
+		type: "confirm",
+		name: "shouldInstall",
+		message: "Install skill?",
+		initial: true
+	});
+	if (shouldInstall) {
+		logger.break();
+		if (installSkill()) {
+			logger.break();
+			logger.success("Skill installed!");
+		} else {
+			logger.break();
+			logger.dim("Skill install failed. You can install manually:");
+			logger.dim(`  npx skills add ${SKILL_REPO}`);
+		}
+	}
+	writeConfig({
+		...config,
+		skillPromptDismissed: true
+	});
+};
+
 //#endregion
 //#region src/cli.ts
-const VERSION = "0.0.5";
+const VERSION = "0.0.7";
 process.on("SIGINT", () => process.exit(0));
 process.on("SIGTERM", () => process.exit(0));
-const program = new Command().name("react-doctor").description("Diagnose React codebase health").version(VERSION, "-v, --version", "display the version number").argument("[directory]", "project directory to scan", ".").option("--no-lint", "skip linting").option("--no-dead-code", "skip dead code detection").option("--no-verbose", "hide file details per rule").option("--score", "output only the score").option("-y, --yes", "skip prompts, scan all workspace projects").option("--project <name>", "select workspace project (comma-separated for multiple)").action(async (directory, flags) => {
+const program = new Command().name("react-doctor").description("Diagnose React codebase health").version(VERSION, "-v, --version", "display the version number").argument("[directory]", "project directory to scan", ".").option("--no-lint", "skip linting").option("--no-dead-code", "skip dead code detection").option("--verbose", "show file details per rule").option("--score", "output only the score").option("-y, --yes", "skip prompts, scan all workspace projects").option("--project <name>", "select workspace project (comma-separated for multiple)").option("--fix", "open Ami to auto-fix all issues").action(async (directory, flags) => {
 	try {
 		const resolvedDirectory = path.resolve(directory);
 		const isScoreOnly = flags.score;
@@ -1121,7 +1202,7 @@ const program = new Command().name("react-doctor").description("Diagnose React c
 		const scanOptions = {
 			lint: flags.lint,
 			deadCode: flags.deadCode,
-			verbose: flags.verbose,
+			verbose: Boolean(flags.verbose),
 			scoreOnly: isScoreOnly
 		};
 		const shouldSkipPrompts = flags.yes || Boolean(process.env.CI) || Boolean(process.env.CLAUDECODE) || Boolean(process.env.AMI) || !process.stdin.isTTY;
@@ -1134,6 +1215,8 @@ const program = new Command().name("react-doctor").description("Diagnose React c
 			await scan(projectDirectory, scanOptions);
 			if (!isScoreOnly) logger.break();
 		}
+		if (flags.fix) openAmiToFix(resolvedDirectory);
+		if (!isScoreOnly) await maybePromptSkillInstall(shouldSkipPrompts);
 	} catch (error) {
 		handleError(error);
 	}
@@ -1141,6 +1224,57 @@ const program = new Command().name("react-doctor").description("Diagnose React c
 ${highlighter.dim("Learn more:")}
   ${highlighter.info("https://github.com/aidenybai/react-doctor")}
 `);
+const AMI_INSTALL_URL = "https://ami.dev/install.sh";
+const AMI_FIX_PROMPT = "Run npx -y react-doctor@latest . --verbose, read every diagnostic, then fix all issues one by one. After fixing, re-run react-doctor to verify the score improved.";
+const OPEN_PROJECT_DELAY_S = 2;
+const isAmiInstalled = () => {
+	try {
+		execSync("ls /Applications/Ami.app", { stdio: "ignore" });
+		return true;
+	} catch {
+		return false;
+	}
+};
+const installAmi = () => {
+	logger.log("Ami not found. Installing...");
+	logger.break();
+	try {
+		execSync(`curl -fsSL ${AMI_INSTALL_URL} | bash`, { stdio: "inherit" });
+	} catch {
+		logger.error("Failed to install Ami. Visit https://ami.dev to install manually.");
+		process.exit(1);
+	}
+	logger.break();
+};
+const openAmiToFix = (directory) => {
+	const resolvedDirectory = path.resolve(directory);
+	if (!isAmiInstalled()) installAmi();
+	logger.log("Opening Ami to fix react-doctor issues...");
+	const encodedDirectory = encodeURIComponent(resolvedDirectory);
+	const encodedPrompt = encodeURIComponent(AMI_FIX_PROMPT);
+	const openProjectDeeplink = `ami://open-project?cwd=${encodedDirectory}`;
+	const newChatDeeplink = `ami://new-chat?prompt=${encodedPrompt}&mode=agent&send=true`;
+	try {
+		execSync(`open "${openProjectDeeplink}" && sleep ${OPEN_PROJECT_DELAY_S} && open "${newChatDeeplink}"`, { stdio: "ignore" });
+		logger.success("Opened Ami with react-doctor fix prompt.");
+	} catch {
+		logger.break();
+		logger.dim("Could not open Ami automatically. Open these URLs manually:");
+		logger.info(openProjectDeeplink);
+		logger.info(newChatDeeplink);
+	}
+};
+const fixAction = (directory) => {
+	try {
+		openAmiToFix(directory);
+	} catch (error) {
+		handleError(error);
+	}
+};
+const fixCommand = new Command("fix").description("Open Ami to auto-fix react-doctor issues").argument("[directory]", "project directory", ".").action(fixAction);
+const installAmiCommand = new Command("install-ami").description("Open Ami to auto-fix react-doctor issues").argument("[directory]", "project directory", ".").action(fixAction);
+program.addCommand(fixCommand);
+program.addCommand(installAmiCommand);
 const main$1 = async () => {
 	await program.parseAsync();
 };