react-doctor 0.0.33 → 0.0.35

package/dist/cli.js

@@ -414,9 +414,11 @@ const EXPO_APP_CONFIG_FILENAMES = [
 	"app.config.js",
 	"app.config.ts"
 ];
-const REACT_COMPILER_CONFIG_PATTERN = /react-compiler|reactCompiler/;
+const REACT_COMPILER_PACKAGE_REFERENCE_PATTERN = /babel-plugin-react-compiler|react-compiler-runtime|eslint-plugin-react-compiler|["']react-compiler["']/;
+const REACT_COMPILER_ENABLED_FLAG_PATTERN = /["']?reactCompiler["']?\s*:\s*true\b/;
 const FRAMEWORK_PACKAGES = {
 	next: "nextjs",
+	"@tanstack/react-start": "tanstack-start",
 	vite: "vite",
 	"react-scripts": "cra",
 	"@remix-run/react": "remix",
@@ -426,6 +428,7 @@ const FRAMEWORK_PACKAGES = {
 };
 const FRAMEWORK_DISPLAY_NAMES = {
 	nextjs: "Next.js",
+	"tanstack-start": "TanStack Start",
 	vite: "Vite",
 	cra: "Create React App",
 	remix: "Remix",
@@ -740,12 +743,12 @@ const hasCompilerPackage = (packageJson) => {
 	const allDependencies = collectAllDependencies(packageJson);
 	return Object.keys(allDependencies).some((packageName) => REACT_COMPILER_PACKAGES.has(packageName));
 };
-const fileContainsPattern = (filePath, pattern) => {
+const hasCompilerInConfigFile = (filePath) => {
 	if (!isFile(filePath)) return false;
 	const content = fs.readFileSync(filePath, "utf-8");
-	return pattern.test(content);
+	return REACT_COMPILER_ENABLED_FLAG_PATTERN.test(content) || REACT_COMPILER_PACKAGE_REFERENCE_PATTERN.test(content);
 };
-const hasCompilerInConfigFiles = (directory, filenames) => filenames.some((filename) => fileContainsPattern(path.join(directory, filename), REACT_COMPILER_CONFIG_PATTERN));
+const hasCompilerInConfigFiles = (directory, filenames) => filenames.some((filename) => hasCompilerInConfigFile(path.join(directory, filename)));
 const detectReactCompiler = (directory, packageJson) => {
 	if (hasCompilerPackage(packageJson)) return true;
 	if (hasCompilerInConfigFiles(directory, NEXT_CONFIG_FILENAMES)) return true;
@@ -1252,6 +1255,22 @@ const REACT_NATIVE_RULES = {
 	"react-doctor/rn-prefer-reanimated": "warn",
 	"react-doctor/rn-no-single-element-style-array": "warn"
 };
+const TANSTACK_START_RULES = {
+	"react-doctor/tanstack-start-route-property-order": "error",
+	"react-doctor/tanstack-start-no-direct-fetch-in-loader": "warn",
+	"react-doctor/tanstack-start-server-fn-validate-input": "warn",
+	"react-doctor/tanstack-start-no-useeffect-fetch": "warn",
+	"react-doctor/tanstack-start-missing-head-content": "warn",
+	"react-doctor/tanstack-start-no-anchor-element": "warn",
+	"react-doctor/tanstack-start-server-fn-method-order": "error",
+	"react-doctor/tanstack-start-no-navigate-in-render": "warn",
+	"react-doctor/tanstack-start-no-dynamic-server-fn-import": "error",
+	"react-doctor/tanstack-start-no-use-server-in-handler": "error",
+	"react-doctor/tanstack-start-no-secrets-in-loader": "error",
+	"react-doctor/tanstack-start-get-mutation": "warn",
+	"react-doctor/tanstack-start-redirect-in-try-catch": "warn",
+	"react-doctor/tanstack-start-loader-parallel-fetch": "warn"
+};
 const REACT_COMPILER_RULES = {
 	"react-hooks-js/set-state-in-render": "error",
 	"react-hooks-js/immutability": "error",
@@ -1341,12 +1360,14 @@ const createOxlintConfig = ({ pluginPath, framework, hasReactCompiler, customRul
 		"react-doctor/rendering-animate-svg-wrapper": "warn",
 		"react-doctor/no-inline-prop-on-memo-component": "warn",
 		"react-doctor/rendering-hydration-no-flicker": "warn",
+		"react-doctor/rendering-script-defer-async": "warn",
 		"react-doctor/no-transition-all": "warn",
 		"react-doctor/no-global-css-variable-animation": "error",
 		"react-doctor/no-large-animated-blur": "warn",
 		"react-doctor/no-scale-from-zero": "warn",
 		"react-doctor/no-permanent-will-change": "warn",
 		"react-doctor/no-secrets-in-client-code": "error",
+		"react-doctor/js-flatmap-filter": "warn",
 		"react-doctor/no-barrel-import": "warn",
 		"react-doctor/no-full-lodash-import": "warn",
 		"react-doctor/no-moment": "warn",
@@ -1359,9 +1380,16 @@ const createOxlintConfig = ({ pluginPath, framework, hasReactCompiler, customRul
 		"react-doctor/server-auth-actions": "error",
 		"react-doctor/server-after-nonblocking": "warn",
 		"react-doctor/client-passive-event-listeners": "warn",
+		"react-doctor/query-stable-query-client": "error",
+		"react-doctor/query-no-rest-destructuring": "warn",
+		"react-doctor/query-no-void-query-fn": "warn",
+		"react-doctor/query-no-query-in-effect": "warn",
+		"react-doctor/query-mutation-missing-invalidation": "warn",
+		"react-doctor/query-no-usequery-for-mutation": "warn",
 		"react-doctor/async-parallel": "warn",
 		...framework === "nextjs" ? NEXTJS_RULES : {},
-		...framework === "expo" || framework === "react-native" ? REACT_NATIVE_RULES : {}
+		...framework === "expo" || framework === "react-native" ? REACT_NATIVE_RULES : {},
+		...framework === "tanstack-start" ? TANSTACK_START_RULES : {}
 	}
 });
 
@@ -1438,6 +1466,7 @@ const RULE_CATEGORY_MAP = {
 	"react-doctor/rendering-animate-svg-wrapper": "Performance",
 	"react-doctor/rendering-usetransition-loading": "Performance",
 	"react-doctor/rendering-hydration-no-flicker": "Performance",
+	"react-doctor/rendering-script-defer-async": "Performance",
 	"react-doctor/no-transition-all": "Performance",
 	"react-doctor/no-global-css-variable-animation": "Performance",
 	"react-doctor/no-large-animated-blur": "Performance",
@@ -1472,6 +1501,13 @@ const RULE_CATEGORY_MAP = {
 	"react-doctor/server-auth-actions": "Server",
 	"react-doctor/server-after-nonblocking": "Server",
 	"react-doctor/client-passive-event-listeners": "Performance",
+	"react-doctor/query-stable-query-client": "TanStack Query",
+	"react-doctor/query-no-rest-destructuring": "TanStack Query",
+	"react-doctor/query-no-void-query-fn": "TanStack Query",
+	"react-doctor/query-no-query-in-effect": "TanStack Query",
+	"react-doctor/query-mutation-missing-invalidation": "TanStack Query",
+	"react-doctor/query-no-usequery-for-mutation": "TanStack Query",
+	"react-doctor/js-flatmap-filter": "Performance",
 	"react-doctor/async-parallel": "Performance",
 	"react-doctor/rn-no-raw-text": "React Native",
 	"react-doctor/rn-no-deprecated-modules": "React Native",
@@ -1480,7 +1516,21 @@ const RULE_CATEGORY_MAP = {
 	"react-doctor/rn-no-inline-flatlist-renderitem": "React Native",
 	"react-doctor/rn-no-legacy-shadow-styles": "React Native",
 	"react-doctor/rn-prefer-reanimated": "React Native",
-	"react-doctor/rn-no-single-element-style-array": "React Native"
+	"react-doctor/rn-no-single-element-style-array": "React Native",
+	"react-doctor/tanstack-start-route-property-order": "TanStack Start",
+	"react-doctor/tanstack-start-no-direct-fetch-in-loader": "TanStack Start",
+	"react-doctor/tanstack-start-server-fn-validate-input": "TanStack Start",
+	"react-doctor/tanstack-start-no-useeffect-fetch": "TanStack Start",
+	"react-doctor/tanstack-start-missing-head-content": "TanStack Start",
+	"react-doctor/tanstack-start-no-anchor-element": "TanStack Start",
+	"react-doctor/tanstack-start-server-fn-method-order": "TanStack Start",
+	"react-doctor/tanstack-start-no-navigate-in-render": "TanStack Start",
+	"react-doctor/tanstack-start-no-dynamic-server-fn-import": "TanStack Start",
+	"react-doctor/tanstack-start-no-use-server-in-handler": "TanStack Start",
+	"react-doctor/tanstack-start-no-secrets-in-loader": "Security",
+	"react-doctor/tanstack-start-get-mutation": "Security",
+	"react-doctor/tanstack-start-redirect-in-try-catch": "TanStack Start",
+	"react-doctor/tanstack-start-loader-parallel-fetch": "Performance"
 };
 const RULE_HELP_MAP = {
 	"no-derived-state-effect": "For derived state, compute inline: `const x = fn(dep)`. For state resets on prop change, use a key prop: `<Component key={prop} />`. See https://react.dev/learn/you-might-not-need-an-effect",
@@ -1502,6 +1552,7 @@ const RULE_HELP_MAP = {
 	"rendering-animate-svg-wrapper": "Wrap the SVG: `<motion.div animate={...}><svg>...</svg></motion.div>`",
 	"rendering-usetransition-loading": "Replace with `const [isPending, startTransition] = useTransition()` — avoids a re-render for the loading state",
 	"rendering-hydration-no-flicker": "Use `useSyncExternalStore(subscribe, getSnapshot, getServerSnapshot)` or add `suppressHydrationWarning` to the element",
+	"rendering-script-defer-async": "Add `defer` for DOM-dependent scripts or `async` for independent ones (analytics). In Next.js, use `<Script strategy=\"afterInteractive\" />` instead",
 	"no-transition-all": "List specific properties: `transition: \"opacity 200ms, transform 200ms\"` — or in Tailwind use `transition-colors`, `transition-opacity`, or `transition-transform`",
 	"no-global-css-variable-animation": "Set the variable on the nearest element instead of a parent, or use `@property` with `inherits: false` to prevent cascade. Better yet, use targeted `element.style.transform` updates",
 	"no-large-animated-blur": "Keep blur radius under 10px, or apply blur to a smaller element. Large blurs multiply GPU memory usage with layer size",
@@ -1523,7 +1574,7 @@ const RULE_HELP_MAP = {
 	"nextjs-no-use-search-params-without-suspense": "Wrap the component using useSearchParams: `<Suspense fallback={<Skeleton />}><SearchComponent /></Suspense>`",
 	"nextjs-no-client-fetch-for-server-data": "Remove 'use client' and fetch directly in the Server Component — no API round-trip, secrets stay on server",
 	"nextjs-missing-metadata": "Add `export const metadata = { title: '...', description: '...' }` or `export async function generateMetadata()`",
-	"nextjs-no-client-side-redirect": "Use `redirect('/path')` from 'next/navigation' directly (works in both server and client components), or handle in middleware",
+	"nextjs-no-client-side-redirect": "Avoid redirects inside useEffect. Use an event handler, middleware, or server-side redirect (App Router: redirect() from next/navigation; Pages Router: getServerSideProps redirect)",
 	"nextjs-no-redirect-in-try-catch": "Move the redirect/notFound call outside the try block, or add `unstable_rethrow(error)` in the catch",
 	"nextjs-image-missing-sizes": "Add sizes for responsive behavior: `sizes=\"(max-width: 768px) 100vw, 50vw\"` matching your layout breakpoints",
 	"nextjs-no-native-script": "`import Script from \"next/script\"` — use `strategy=\"afterInteractive\"` for analytics or `\"lazyOnload\"` for widgets",
@@ -1536,6 +1587,13 @@ const RULE_HELP_MAP = {
 	"server-auth-actions": "Add `const session = await auth()` at the top and throw/redirect if unauthorized before any data access",
 	"server-after-nonblocking": "`import { after } from 'next/server'` then wrap: `after(() => analytics.track(...))` — response isn't blocked",
 	"client-passive-event-listeners": "Add `{ passive: true }` as the third argument: `addEventListener('scroll', handler, { passive: true })`",
+	"query-stable-query-client": "Move `new QueryClient()` to module scope or wrap in `useState(() => new QueryClient())` — recreating it on every render resets the entire cache",
+	"query-no-rest-destructuring": "Destructure only the fields you need: `const { data, isLoading } = useQuery(...)` — rest destructuring subscribes to all fields and causes extra re-renders",
+	"query-no-void-query-fn": "queryFn must return a value for the cache. Use the `enabled` option to conditionally disable the query instead of returning undefined",
+	"query-no-query-in-effect": "React Query manages refetching automatically via queryKey dependencies and the `enabled` option — manual refetch() in useEffect is usually unnecessary",
+	"query-mutation-missing-invalidation": "Add `onSuccess: () => queryClient.invalidateQueries({ queryKey: ['...'] })` so cached data stays in sync after the mutation",
+	"query-no-usequery-for-mutation": "Use `useMutation()` for POST/PUT/DELETE — it provides onSuccess/onError callbacks, doesn't auto-refetch, and correctly models write operations",
+	"js-flatmap-filter": "Use `.flatMap(item => condition ? [value] : [])` — transforms and filters in a single pass instead of creating an intermediate array",
 	"async-parallel": "Use `const [a, b] = await Promise.all([fetchA(), fetchB()])` to run independent operations concurrently",
 	"rn-no-raw-text": "Wrap text in a `<Text>` component: `<Text>{value}</Text>` — raw strings outside `<Text>` crash on React Native",
 	"rn-no-deprecated-modules": "Import from the community package instead — deprecated modules were removed from the react-native core",
@@ -1544,7 +1602,21 @@ const RULE_HELP_MAP = {
 	"rn-no-inline-flatlist-renderitem": "Extract renderItem to a named function or wrap in useCallback to avoid re-creating on every render",
 	"rn-no-legacy-shadow-styles": "Use `boxShadow` for cross-platform shadows on the new architecture instead of platform-specific shadow properties",
 	"rn-prefer-reanimated": "Use `import Animated from 'react-native-reanimated'` — animations run on the UI thread instead of the JS thread",
-	"rn-no-single-element-style-array": "Use `style={value}` instead of `style={[value]}` — single-element arrays add unnecessary allocation"
+	"rn-no-single-element-style-array": "Use `style={value}` instead of `style={[value]}` — single-element arrays add unnecessary allocation",
+	"tanstack-start-route-property-order": "Follow the order: params/validateSearch → loaderDeps → context → beforeLoad → loader → head. See https://tanstack.com/router/latest/docs/eslint/create-route-property-order",
+	"tanstack-start-no-direct-fetch-in-loader": "Use `createServerFn()` from @tanstack/react-start — provides type-safe RPC, input validation, and proper server/client code splitting",
+	"tanstack-start-server-fn-validate-input": "Add `.inputValidator(schema)` before `.handler()` — data crosses a network boundary and must be validated at runtime",
+	"tanstack-start-no-useeffect-fetch": "Fetch data in the route `loader` instead — the router coordinates loading before rendering to avoid waterfalls",
+	"tanstack-start-missing-head-content": "Add `<HeadContent />` inside `<head>` in your __root route — without it, route `head()` meta tags are silently dropped",
+	"tanstack-start-no-anchor-element": "`import { Link } from '@tanstack/react-router'` — enables type-safe routes, preloading via `preload=\"intent\"`, and client-side navigation",
+	"tanstack-start-server-fn-method-order": "Chain methods in order: .middleware() → .inputValidator() → .client() → .server() → .handler() — types depend on this sequence",
+	"tanstack-start-no-navigate-in-render": "Use `throw redirect({ to: '/path' })` in `beforeLoad` or `loader` instead — navigate() during render causes hydration issues",
+	"tanstack-start-no-dynamic-server-fn-import": "Use `import { myFn } from '~/utils/my.functions'` — the bundler replaces server code with RPC stubs only for static imports",
+	"tanstack-start-no-use-server-in-handler": "TanStack Start handles server boundaries automatically via the Vite plugin — \"use server\" inside createServerFn causes compilation errors",
+	"tanstack-start-no-secrets-in-loader": "Loaders are isomorphic (run on both server and client). Wrap secret access in `createServerFn()` so it stays server-only",
+	"tanstack-start-get-mutation": "Use `createServerFn({ method: 'POST' })` for data modifications — GET requests can be triggered by prefetching and are vulnerable to CSRF",
+	"tanstack-start-redirect-in-try-catch": "TanStack Router's `redirect()` and `notFound()` throw special errors caught by the router. Move them outside the try block or re-throw in the catch",
+	"tanstack-start-loader-parallel-fetch": "Use `const [a, b] = await Promise.all([fetchA(), fetchB()])` to avoid request waterfalls in route loaders"
 };
 const FILEPATH_WITH_LOCATION_PATTERN = /\S+\.\w+:\d+:\d+[\s\S]*$/;
 const REACT_COMPILER_MESSAGE = "React Compiler can't optimize this code";
@@ -2280,7 +2352,7 @@ const promptProjectSelection = async (workspacePackages, rootDirectory) => {
 
 //#endregion
 //#region src/cli.ts
-const VERSION = "0.0.33";
+const VERSION = "0.0.35";
 const VALID_FAIL_ON_LEVELS = new Set([
 	"error",
 	"warning",