react-doctor 0.0.29 → 0.0.31

package/dist/react-doctor-plugin.js

@@ -252,6 +252,14 @@ const BLUR_VALUE_PATTERN = /blur\((\d+(?:\.\d+)?)px\)/;
 const ANIMATION_CALLBACK_NAMES = new Set(["requestAnimationFrame", "setInterval"]);
 const RAW_TEXT_PREVIEW_MAX_CHARS = 30;
 const REACT_NATIVE_TEXT_COMPONENTS = new Set(["Text", "TextInput"]);
+const REACT_NATIVE_TEXT_COMPONENT_SUFFIXES = new Set([
+	"Text",
+	"Title",
+	"Label",
+	"Heading",
+	"Caption",
+	"Subtitle"
+]);
 const DEPRECATED_RN_MODULE_REPLACEMENTS = {
 	AsyncStorage: "@react-native-async-storage/async-storage",
 	Picker: "@react-native-picker/picker",
@@ -273,7 +281,7 @@ const DEPRECATED_RN_MODULE_REPLACEMENTS = {
 const LEGACY_EXPO_PACKAGE_REPLACEMENTS = {
 	"expo-av": "expo-audio for audio and expo-video for video",
 	"expo-permissions": "the permissions API in each module (e.g. Camera.requestPermissionsAsync())",
-	"@expo/vector-icons": "expo-image with sf: source URIs"
+	"@expo/vector-icons": "expo-symbols or expo-image (see https://docs.expo.dev/versions/latest/sdk/symbols/)"
 };
 const REACT_NATIVE_LIST_COMPONENTS = new Set([
 	"FlatList",
@@ -853,26 +861,29 @@ const nextjsMissingMetadata = { create: (context) => ({ Program(programNode) {
 		message: "Page without metadata or generateMetadata export — hurts SEO"
 	});
 } }) };
-const isClientSideRedirect = (node) => {
+const describeClientSideNavigation = (node) => {
 	if (node.type === "CallExpression" && node.callee?.type === "MemberExpression") {
-		if ((node.callee.object?.type === "Identifier" ? node.callee.object.name : null) === "router" && (isMemberProperty(node.callee, "push") || isMemberProperty(node.callee, "replace"))) return true;
+		const objectName = node.callee.object?.type === "Identifier" ? node.callee.object.name : null;
+		const methodName = node.callee.property?.type === "Identifier" ? node.callee.property.name : null;
+		if (objectName === "router" && (methodName === "push" || methodName === "replace")) return `router.${methodName}() in useEffect — use redirect() from next/navigation or handle navigation in an event handler`;
 	}
 	if (node.type === "AssignmentExpression" && node.left?.type === "MemberExpression") {
 		const objectName = node.left.object?.type === "Identifier" ? node.left.object.name : null;
 		const propertyName = node.left.property?.type === "Identifier" ? node.left.property.name : null;
-		if (objectName === "window" && propertyName === "location") return true;
-		if (objectName === "location" && propertyName === "href") return true;
+		if (objectName === "window" && propertyName === "location") return "window.location assignment in useEffect — use redirect() from next/navigation or handle in middleware instead";
+		if (objectName === "location" && propertyName === "href") return "location.href assignment in useEffect — use redirect() from next/navigation or handle in middleware instead";
 	}
-	return false;
+	return null;
 };
 const nextjsNoClientSideRedirect = { create: (context) => ({ CallExpression(node) {
 	if (!isHookCall(node, EFFECT_HOOK_NAMES)) return;
 	const callback = getEffectCallback(node);
 	if (!callback) return;
 	walkAst(callback, (child) => {
-		if (isClientSideRedirect(child)) context.report({
+		const navigationDescription = describeClientSideNavigation(child);
+		if (navigationDescription) context.report({
 			node: child,
-			message: "Client-side redirect in useEffect — use redirect() in a server component or middleware instead"
+			message: navigationDescription
 		});
 	});
 } }) };
@@ -1249,6 +1260,10 @@ const getRawTextDescription = (child) => {
 	}
 	return "text content";
 };
+const isTextHandlingComponent = (elementName) => {
+	if (REACT_NATIVE_TEXT_COMPONENTS.has(elementName)) return true;
+	return [...REACT_NATIVE_TEXT_COMPONENT_SUFFIXES].some((suffix) => elementName.endsWith(suffix));
+};
 const rnNoRawText = { create: (context) => {
 	let isDomComponentFile = false;
 	return {
@@ -1258,7 +1273,7 @@ const rnNoRawText = { create: (context) => {
 		JSXElement(node) {
 			if (isDomComponentFile) return;
 			const elementName = resolveJsxElementName(node.openingElement);
-			if (elementName && REACT_NATIVE_TEXT_COMPONENTS.has(elementName)) return;
+			if (elementName && isTextHandlingComponent(elementName)) return;
 			for (const child of node.children ?? []) {
 				if (!isRawTextContent(child)) continue;
 				context.report({