react-doctor 0.0.27 → 0.0.28

package/dist/cli.js

@@ -1,18 +1,18 @@
 #!/usr/bin/env node
 import { createRequire } from "node:module";
 import { execSync, spawn, spawnSync } from "node:child_process";
-import fs, { appendFileSync, existsSync, mkdirSync, readFileSync, writeFileSync } from "node:fs";
+import fs, { appendFileSync, existsSync, mkdirSync, readFileSync, readdirSync, writeFileSync } from "node:fs";
 import os, { homedir, tmpdir } from "node:os";
 import path, { join } from "node:path";
 import { Command } from "commander";
 import { randomUUID } from "node:crypto";
 import { performance } from "node:perf_hooks";
 import pc from "picocolors";
+import basePrompts from "prompts";
 import { main } from "knip";
 import { createOptions } from "knip/session";
 import { fileURLToPath } from "node:url";
 import ora from "ora";
-import basePrompts from "prompts";
 
 //#region src/constants.ts
 const SOURCE_FILE_PATTERN = /\.(tsx?|jsx?)$/;
@@ -40,6 +40,8 @@ const WARNING_RULE_PENALTY = .75;
 const ERROR_ESTIMATED_FIX_RATE = .85;
 const WARNING_ESTIMATED_FIX_RATE = .8;
 const MAX_KNIP_RETRIES = 5;
+const OXLINT_NODE_REQUIREMENT = "^20.19.0 || >=22.12.0";
+const OXLINT_RECOMMENDED_NODE_MAJOR = 24;
 const AMI_WEBSITE_URL = "https://ami.dev";
 const AMI_INSTALL_URL = `${AMI_WEBSITE_URL}/install.sh`;
 const AMI_RELEASES_URL = "https://github.com/millionco/ami-releases/releases";
@@ -641,6 +643,167 @@ const loadConfig = (rootDirectory) => {
 	return null;
 };
 
+//#endregion
+//#region src/utils/should-auto-select-current-choice.ts
+const shouldAutoSelectCurrentChoice = (choiceStates, cursor) => {
+	if (choiceStates.some((choiceState) => choiceState.selected)) return false;
+	const currentChoice = choiceStates[cursor];
+	return Boolean(currentChoice) && !currentChoice.disabled;
+};
+
+//#endregion
+//#region src/utils/should-select-all-choices.ts
+const shouldSelectAllChoices = (choiceStates) => {
+	return choiceStates.filter((choiceState) => !choiceState.disabled).some((choiceState) => choiceState.selected !== true);
+};
+
+//#endregion
+//#region src/utils/prompts.ts
+const require = createRequire(import.meta.url);
+const PROMPTS_MULTISELECT_MODULE_PATH = "prompts/lib/elements/multiselect";
+const PROMPTS_SELECT_MODULE_PATH = "prompts/lib/elements/select";
+let didPatchMultiselectToggleAll = false;
+let didPatchMultiselectSubmit = false;
+let didPatchSelectBanner = false;
+const selectBannerMap = /* @__PURE__ */ new Map();
+const setSelectBanner = (banner, targetIndex) => {
+	selectBannerMap.set(targetIndex, banner);
+};
+const clearSelectBanner = () => {
+	selectBannerMap.clear();
+};
+const onCancel = () => {
+	logger.break();
+	logger.log("Cancelled.");
+	logger.dim("Run `npx react-doctor@latest --fix` to fix issues.");
+	logger.break();
+	process.exit(0);
+};
+const patchMultiselectToggleAll = () => {
+	if (didPatchMultiselectToggleAll) return;
+	didPatchMultiselectToggleAll = true;
+	const multiselectPromptConstructor = require(PROMPTS_MULTISELECT_MODULE_PATH);
+	multiselectPromptConstructor.prototype.toggleAll = function() {
+		const isCurrentChoiceDisabled = Boolean(this.value[this.cursor]?.disabled);
+		if (this.maxChoices !== void 0 || isCurrentChoiceDisabled) {
+			this.bell();
+			return;
+		}
+		const shouldSelectAllEnabledChoices = shouldSelectAllChoices(this.value);
+		for (const choiceState of this.value) {
+			if (choiceState.disabled) continue;
+			choiceState.selected = shouldSelectAllEnabledChoices;
+		}
+		this.render();
+	};
+};
+const patchMultiselectSubmit = () => {
+	if (didPatchMultiselectSubmit) return;
+	didPatchMultiselectSubmit = true;
+	const multiselectPromptConstructor = require(PROMPTS_MULTISELECT_MODULE_PATH);
+	const originalSubmit = multiselectPromptConstructor.prototype.submit;
+	multiselectPromptConstructor.prototype.submit = function() {
+		if (shouldAutoSelectCurrentChoice(this.value, this.cursor)) this.value[this.cursor].selected = true;
+		originalSubmit.call(this);
+	};
+};
+const patchSelectBanner = () => {
+	if (didPatchSelectBanner) return;
+	didPatchSelectBanner = true;
+	const selectConstructor = require(PROMPTS_SELECT_MODULE_PATH);
+	const promptsClear = require("prompts/lib/util/clear");
+	const originalRender = selectConstructor.prototype.render;
+	selectConstructor.prototype.render = function() {
+		originalRender.call(this);
+		const banner = selectBannerMap.get(this.cursor);
+		if (!banner || this.closed || this.done) return;
+		this.out.write(promptsClear(this.outputText, this.out.columns));
+		this.outputText = `${banner}\n\n${this.outputText}`;
+		this.out.write(this.outputText);
+	};
+};
+const prompts = (questions) => {
+	patchMultiselectToggleAll();
+	patchMultiselectSubmit();
+	patchSelectBanner();
+	return basePrompts(questions, { onCancel });
+};
+
+//#endregion
+//#region src/utils/resolve-compatible-node.ts
+const parseNodeVersion = (versionString) => {
+	const [major = 0, minor = 0, patch = 0] = versionString.replace(/^v/, "").trim().split(".").map(Number);
+	return {
+		major,
+		minor,
+		patch
+	};
+};
+const isNodeVersionCompatibleWithOxlint = ({ major, minor }) => {
+	if (major === 20 && minor >= 19) return true;
+	if (major === 22 && minor >= 12) return true;
+	if (major > 22) return true;
+	return false;
+};
+const isCurrentNodeCompatibleWithOxlint = () => isNodeVersionCompatibleWithOxlint(parseNodeVersion(process.version));
+const getNvmDirectory = () => {
+	const envNvmDirectory = process.env.NVM_DIR;
+	if (envNvmDirectory && existsSync(envNvmDirectory)) return envNvmDirectory;
+	const defaultNvmDirectory = path.join(os.homedir(), ".nvm");
+	if (existsSync(defaultNvmDirectory)) return defaultNvmDirectory;
+	return null;
+};
+const isNvmInstalled = () => getNvmDirectory() !== null;
+const findCompatibleNvmBinary = () => {
+	const nvmDirectory = getNvmDirectory();
+	if (!nvmDirectory) return null;
+	const versionsDirectory = path.join(nvmDirectory, "versions", "node");
+	if (!existsSync(versionsDirectory)) return null;
+	const compatibleVersions = readdirSync(versionsDirectory).filter((directoryName) => directoryName.startsWith("v")).map((directoryName) => ({
+		directoryName,
+		...parseNodeVersion(directoryName)
+	})).filter((version) => isNodeVersionCompatibleWithOxlint(version)).sort((versionA, versionB) => versionB.major - versionA.major || versionB.minor - versionA.minor || versionB.patch - versionA.patch);
+	if (compatibleVersions.length === 0) return null;
+	const bestVersion = compatibleVersions[0];
+	const binaryPath = path.join(versionsDirectory, bestVersion.directoryName, "bin", "node");
+	return existsSync(binaryPath) ? binaryPath : null;
+};
+const getNodeVersionFromBinary = (binaryPath) => {
+	try {
+		return execSync(`"${binaryPath}" --version`, { encoding: "utf-8" }).trim();
+	} catch {
+		return null;
+	}
+};
+const installNodeViaNvm = () => {
+	const nvmDirectory = getNvmDirectory();
+	if (!nvmDirectory) return false;
+	const nvmScript = path.join(nvmDirectory, "nvm.sh");
+	if (!existsSync(nvmScript)) return false;
+	try {
+		execSync(`bash -c ". '${nvmScript}' && nvm install ${OXLINT_RECOMMENDED_NODE_MAJOR}"`, { stdio: "inherit" });
+		return findCompatibleNvmBinary() !== null;
+	} catch {
+		return false;
+	}
+};
+const resolveNodeForOxlint = () => {
+	if (isCurrentNodeCompatibleWithOxlint()) return {
+		binaryPath: process.execPath,
+		isCurrentNode: true,
+		version: process.version
+	};
+	const nvmBinaryPath = findCompatibleNvmBinary();
+	if (!nvmBinaryPath) return null;
+	const version = getNodeVersionFromBinary(nvmBinaryPath);
+	if (!version) return null;
+	return {
+		binaryPath: nvmBinaryPath,
+		isCurrentNode: false,
+		version
+	};
+};
+
 //#endregion
 //#region src/utils/run-knip.ts
 const KNIP_CATEGORY_MAP = {
@@ -1102,8 +1265,8 @@ const batchIncludePaths = (baseArgs, includePaths) => {
 	if (currentBatch.length > 0) batches.push(currentBatch);
 	return batches;
 };
-const spawnOxlint = (args, rootDirectory) => new Promise((resolve, reject) => {
-	const child = spawn(process.execPath, args, { cwd: rootDirectory });
+const spawnOxlint = (args, rootDirectory, nodeBinaryPath) => new Promise((resolve, reject) => {
+	const child = spawn(nodeBinaryPath, args, { cwd: rootDirectory });
 	const stdoutBuffers = [];
 	const stderrBuffers = [];
 	child.stdout.on("data", (buffer) => stdoutBuffers.push(buffer));
@@ -1146,7 +1309,7 @@ const parseOxlintOutput = (stdout) => {
 		};
 	});
 };
-const runOxlint = async (rootDirectory, hasTypeScript, framework, hasReactCompiler, includePaths) => {
+const runOxlint = async (rootDirectory, hasTypeScript, framework, hasReactCompiler, includePaths, nodeBinaryPath = process.execPath) => {
 	if (includePaths !== void 0 && includePaths.length === 0) return [];
 	const configPath = path.join(os.tmpdir(), `react-doctor-oxlintrc-${process.pid}.json`);
 	const config = createOxlintConfig({
@@ -1168,7 +1331,7 @@ const runOxlint = async (rootDirectory, hasTypeScript, framework, hasReactCompil
 		const fileBatches = includePaths !== void 0 ? batchIncludePaths(baseArgs, includePaths) : [["."]];
 		const allDiagnostics = [];
 		for (const batch of fileBatches) {
-			const stdout = await spawnOxlint([...baseArgs, ...batch], rootDirectory);
+			const stdout = await spawnOxlint([...baseArgs, ...batch], rootDirectory, nodeBinaryPath);
 			allDiagnostics.push(...parseOxlintOutput(stdout));
 		}
 		return allDiagnostics;
@@ -1393,6 +1556,44 @@ const printSummary = (diagnostics, elapsedMilliseconds, scoreResult, projectName
 	logger.break();
 	logger.dim(`  Share your results: ${highlighter.info(shareUrl)}`);
 };
+const resolveOxlintNode = async (isLintEnabled, isScoreOnly) => {
+	if (!isLintEnabled) return null;
+	const nodeResolution = resolveNodeForOxlint();
+	if (nodeResolution) {
+		if (!nodeResolution.isCurrentNode && !isScoreOnly) {
+			logger.warn(`Node ${process.version} is unsupported by oxlint. Using Node ${nodeResolution.version} from nvm.`);
+			logger.break();
+		}
+		return nodeResolution.binaryPath;
+	}
+	if (isScoreOnly) return null;
+	logger.warn(`Node ${process.version} is not compatible with oxlint (requires ${OXLINT_NODE_REQUIREMENT}). Lint checks will be skipped.`);
+	if (isNvmInstalled() && process.stdin.isTTY) {
+		const { shouldInstallNode } = await prompts({
+			type: "confirm",
+			name: "shouldInstallNode",
+			message: `Install Node ${OXLINT_RECOMMENDED_NODE_MAJOR} via nvm to enable lint checks?`,
+			initial: true
+		});
+		if (shouldInstallNode) {
+			logger.break();
+			const freshResolution = installNodeViaNvm() ? resolveNodeForOxlint() : null;
+			if (freshResolution) {
+				logger.break();
+				logger.success(`Node ${freshResolution.version} installed. Using it for lint checks.`);
+				logger.break();
+				return freshResolution.binaryPath;
+			}
+			logger.break();
+			logger.warn("Failed to install Node via nvm. Skipping lint checks.");
+			logger.break();
+			return null;
+		}
+	} else if (isNvmInstalled()) logger.dim(`  Run: nvm install ${OXLINT_RECOMMENDED_NODE_MAJOR}`);
+	else logger.dim(`  Install nvm (https://github.com/nvm-sh/nvm) and run: nvm install ${OXLINT_RECOMMENDED_NODE_MAJOR}`);
+	logger.break();
+	return null;
+};
 const mergeScanOptions = (inputOptions, userConfig) => ({
 	lint: inputOptions.lint ?? userConfig?.lint ?? true,
 	deadCode: inputOptions.deadCode ?? userConfig?.deadCode ?? true,
@@ -1428,19 +1629,24 @@ const scan = async (directory, inputOptions = {}) => {
 	const jsxIncludePaths = computeJsxIncludePaths(includePaths);
 	let didLintFail = false;
 	let didDeadCodeFail = false;
-	const lintPromise = options.lint ? (async () => {
+	const resolvedNodeBinaryPath = await resolveOxlintNode(options.lint, options.scoreOnly);
+	if (options.lint && !resolvedNodeBinaryPath) didLintFail = true;
+	const lintPromise = resolvedNodeBinaryPath ? (async () => {
 		const lintSpinner = options.scoreOnly ? null : spinner("Running lint checks...").start();
 		try {
-			const lintDiagnostics = await runOxlint(directory, projectInfo.hasTypeScript, projectInfo.framework, projectInfo.hasReactCompiler, jsxIncludePaths);
+			const lintDiagnostics = await runOxlint(directory, projectInfo.hasTypeScript, projectInfo.framework, projectInfo.hasReactCompiler, jsxIncludePaths, resolvedNodeBinaryPath);
 			lintSpinner?.succeed("Running lint checks.");
 			return lintDiagnostics;
 		} catch (error) {
 			didLintFail = true;
-			lintSpinner?.fail("Lint checks failed (non-fatal, skipping).");
-			if (error instanceof Error) {
-				logger.error(error.message);
-				if (error.stack) logger.dim(error.stack);
-			} else logger.error(String(error));
+			const errorMessage = error instanceof Error ? error.message : String(error);
+			if (errorMessage.includes("native binding")) {
+				lintSpinner?.fail(`Lint checks failed — oxlint native binding not found (Node ${process.version}).`);
+				logger.dim(`  Upgrade to Node ${OXLINT_NODE_REQUIREMENT} or run: npx -p oxlint@latest react-doctor@latest`);
+			} else {
+				lintSpinner?.fail("Lint checks failed (non-fatal, skipping).");
+				logger.error(errorMessage);
+			}
 			return [];
 		}
 	})() : Promise.resolve([]);
@@ -1603,92 +1809,6 @@ const handleError = (error, options = DEFAULT_HANDLE_ERROR_OPTIONS) => {
 	process.exitCode = 1;
 };
 
-//#endregion
-//#region src/utils/should-auto-select-current-choice.ts
-const shouldAutoSelectCurrentChoice = (choiceStates, cursor) => {
-	if (choiceStates.some((choiceState) => choiceState.selected)) return false;
-	const currentChoice = choiceStates[cursor];
-	return Boolean(currentChoice) && !currentChoice.disabled;
-};
-
-//#endregion
-//#region src/utils/should-select-all-choices.ts
-const shouldSelectAllChoices = (choiceStates) => {
-	return choiceStates.filter((choiceState) => !choiceState.disabled).some((choiceState) => choiceState.selected !== true);
-};
-
-//#endregion
-//#region src/utils/prompts.ts
-const require = createRequire(import.meta.url);
-const PROMPTS_MULTISELECT_MODULE_PATH = "prompts/lib/elements/multiselect";
-const PROMPTS_SELECT_MODULE_PATH = "prompts/lib/elements/select";
-let didPatchMultiselectToggleAll = false;
-let didPatchMultiselectSubmit = false;
-let didPatchSelectBanner = false;
-const selectBannerMap = /* @__PURE__ */ new Map();
-const setSelectBanner = (banner, targetIndex) => {
-	selectBannerMap.set(targetIndex, banner);
-};
-const clearSelectBanner = () => {
-	selectBannerMap.clear();
-};
-const onCancel = () => {
-	logger.break();
-	logger.log("Cancelled.");
-	logger.dim("Run `npx react-doctor@latest --fix` to fix issues.");
-	logger.break();
-	process.exit(0);
-};
-const patchMultiselectToggleAll = () => {
-	if (didPatchMultiselectToggleAll) return;
-	didPatchMultiselectToggleAll = true;
-	const multiselectPromptConstructor = require(PROMPTS_MULTISELECT_MODULE_PATH);
-	multiselectPromptConstructor.prototype.toggleAll = function() {
-		const isCurrentChoiceDisabled = Boolean(this.value[this.cursor]?.disabled);
-		if (this.maxChoices !== void 0 || isCurrentChoiceDisabled) {
-			this.bell();
-			return;
-		}
-		const shouldSelectAllEnabledChoices = shouldSelectAllChoices(this.value);
-		for (const choiceState of this.value) {
-			if (choiceState.disabled) continue;
-			choiceState.selected = shouldSelectAllEnabledChoices;
-		}
-		this.render();
-	};
-};
-const patchMultiselectSubmit = () => {
-	if (didPatchMultiselectSubmit) return;
-	didPatchMultiselectSubmit = true;
-	const multiselectPromptConstructor = require(PROMPTS_MULTISELECT_MODULE_PATH);
-	const originalSubmit = multiselectPromptConstructor.prototype.submit;
-	multiselectPromptConstructor.prototype.submit = function() {
-		if (shouldAutoSelectCurrentChoice(this.value, this.cursor)) this.value[this.cursor].selected = true;
-		originalSubmit.call(this);
-	};
-};
-const patchSelectBanner = () => {
-	if (didPatchSelectBanner) return;
-	didPatchSelectBanner = true;
-	const selectConstructor = require(PROMPTS_SELECT_MODULE_PATH);
-	const promptsClear = require("prompts/lib/util/clear");
-	const originalRender = selectConstructor.prototype.render;
-	selectConstructor.prototype.render = function() {
-		originalRender.call(this);
-		const banner = selectBannerMap.get(this.cursor);
-		if (!banner || this.closed || this.done) return;
-		this.out.write(promptsClear(this.outputText, this.out.columns));
-		this.outputText = `${banner}\n\n${this.outputText}`;
-		this.out.write(this.outputText);
-	};
-};
-const prompts = (questions) => {
-	patchMultiselectToggleAll();
-	patchMultiselectSubmit();
-	patchSelectBanner();
-	return basePrompts(questions, { onCancel });
-};
-
 //#endregion
 //#region src/utils/select-projects.ts
 const selectProjects = async (rootDirectory, projectFlag, skipPrompts) => {
@@ -1909,7 +2029,7 @@ const maybePromptSkillInstall = async (shouldSkipPrompts) => {
 
 //#endregion
 //#region src/cli.ts
-const VERSION = "0.0.27";
+const VERSION = "0.0.28";
 const exitWithFixHint = () => {
 	logger.break();
 	logger.log("Cancelled.");