react-doctor 0.0.16 → 0.0.18

package/dist/cli.js

@@ -242,23 +242,34 @@ const resolveWorkspaceDirectories = (rootDirectory, pattern) => {
 	if (!fs.existsSync(baseDirectory) || !fs.statSync(baseDirectory).isDirectory()) return [];
 	return fs.readdirSync(baseDirectory).map((entry) => path.join(baseDirectory, entry)).filter((entryPath) => fs.statSync(entryPath).isDirectory() && fs.existsSync(path.join(entryPath, "package.json")));
 };
-const findDependencyInfoFromAncestors = (startDirectory) => {
+const isMonorepoRoot = (directory) => {
+	if (fs.existsSync(path.join(directory, "pnpm-workspace.yaml"))) return true;
+	const packageJsonPath = path.join(directory, "package.json");
+	if (!fs.existsSync(packageJsonPath)) return false;
+	const packageJson = readPackageJson(packageJsonPath);
+	return Array.isArray(packageJson.workspaces) || Boolean(packageJson.workspaces?.packages);
+};
+const findMonorepoRoot$1 = (startDirectory) => {
 	let currentDirectory = path.dirname(startDirectory);
-	const result = {
-		reactVersion: null,
-		framework: "unknown"
-	};
 	while (currentDirectory !== path.dirname(currentDirectory)) {
-		const packageJsonPath = path.join(currentDirectory, "package.json");
-		if (fs.existsSync(packageJsonPath)) {
-			const info = extractDependencyInfo(readPackageJson(packageJsonPath));
-			if (!result.reactVersion && info.reactVersion) result.reactVersion = info.reactVersion;
-			if (result.framework === "unknown" && info.framework !== "unknown") result.framework = info.framework;
-			if (result.reactVersion && result.framework !== "unknown") return result;
-		}
+		if (isMonorepoRoot(currentDirectory)) return currentDirectory;
 		currentDirectory = path.dirname(currentDirectory);
 	}
-	return result;
+	return null;
+};
+const findDependencyInfoFromMonorepoRoot = (directory) => {
+	const monorepoRoot = findMonorepoRoot$1(directory);
+	if (!monorepoRoot) return {
+		reactVersion: null,
+		framework: "unknown"
+	};
+	const rootPackageJson = readPackageJson(path.join(monorepoRoot, "package.json"));
+	const rootInfo = extractDependencyInfo(rootPackageJson);
+	const workspaceInfo = findReactInWorkspaces(monorepoRoot, rootPackageJson);
+	return {
+		reactVersion: rootInfo.reactVersion ?? workspaceInfo.reactVersion,
+		framework: rootInfo.framework !== "unknown" ? rootInfo.framework : workspaceInfo.framework
+	};
 };
 const findReactInWorkspaces = (rootDirectory, packageJson) => {
 	const patterns = getWorkspacePatterns(rootDirectory, packageJson);
@@ -355,10 +366,10 @@ const discoverProject = (directory) => {
 		if (!reactVersion && workspaceInfo.reactVersion) reactVersion = workspaceInfo.reactVersion;
 		if (framework === "unknown" && workspaceInfo.framework !== "unknown") framework = workspaceInfo.framework;
 	}
-	if (!reactVersion || framework === "unknown") {
-		const ancestorInfo = findDependencyInfoFromAncestors(directory);
-		if (!reactVersion) reactVersion = ancestorInfo.reactVersion;
-		if (framework === "unknown") framework = ancestorInfo.framework;
+	if ((!reactVersion || framework === "unknown") && !isMonorepoRoot(directory)) {
+		const monorepoInfo = findDependencyInfoFromMonorepoRoot(directory);
+		if (!reactVersion) reactVersion = monorepoInfo.reactVersion;
+		if (framework === "unknown") framework = monorepoInfo.framework;
 	}
 	const projectName = packageJson.name ?? path.basename(directory);
 	const hasTypeScript = fs.existsSync(path.join(directory, "tsconfig.json"));
@@ -474,15 +485,18 @@ const silenced = async (fn) => {
 	const originalLog = console.log;
 	const originalInfo = console.info;
 	const originalWarn = console.warn;
+	const originalError = console.error;
 	console.log = () => {};
 	console.info = () => {};
 	console.warn = () => {};
+	console.error = () => {};
 	try {
 		return await fn();
 	} finally {
 		console.log = originalLog;
 		console.info = originalInfo;
 		console.warn = originalWarn;
+		console.error = originalError;
 	}
 };
 const findMonorepoRoot = (directory) => {
@@ -498,13 +512,26 @@ const findMonorepoRoot = (directory) => {
 	}
 	return null;
 };
+const CONFIG_LOADING_ERROR_PATTERN = /Error loading .*\/([a-z-]+)\.config\./;
+const extractFailedPluginName = (error) => {
+	return String(error).match(CONFIG_LOADING_ERROR_PATTERN)?.[1] ?? null;
+};
+const MAX_KNIP_RETRIES = 5;
 const runKnipWithOptions = async (knipCwd, workspaceName) => {
 	const options = await silenced(() => createOptions({
 		cwd: knipCwd,
 		isShowProgress: false,
 		...workspaceName ? { workspace: workspaceName } : {}
 	}));
-	return await silenced(() => main(options));
+	const parsedConfig = options.parsedConfig;
+	for (let attempt = 0; attempt <= MAX_KNIP_RETRIES; attempt++) try {
+		return await silenced(() => main(options));
+	} catch (error) {
+		const failedPlugin = extractFailedPluginName(error);
+		if (!failedPlugin || attempt === MAX_KNIP_RETRIES) throw error;
+		parsedConfig[failedPlugin] = false;
+	}
+	throw new Error("Unreachable");
 };
 const hasNodeModules = (directory) => {
 	const nodeModulesPath = path.join(directory, "node_modules");
@@ -1161,8 +1188,9 @@ const scan = async (directory, options) => {
 			const lintDiagnostics = await runOxlint(directory, projectInfo.hasTypeScript, projectInfo.framework, projectInfo.hasReactCompiler);
 			lintSpinner?.succeed("Running lint checks.");
 			return lintDiagnostics;
-		} catch {
+		} catch (error) {
 			lintSpinner?.fail("Lint checks failed (non-fatal, skipping).");
+			logger.error(String(error));
 			return [];
 		}
 	})() : Promise.resolve([]);
@@ -1172,8 +1200,9 @@ const scan = async (directory, options) => {
 			const knipDiagnostics = await runKnip(directory);
 			deadCodeSpinner?.succeed("Detecting dead code.");
 			return knipDiagnostics;
-		} catch {
+		} catch (error) {
 			deadCodeSpinner?.fail("Dead code detection failed (non-fatal, skipping).");
+			logger.error(String(error));
 			return [];
 		}
 	})() : Promise.resolve([]);
@@ -1203,6 +1232,14 @@ const scan = async (directory, options) => {
 	printSummary(diagnostics, elapsedMilliseconds, scoreResult, projectInfo.projectName, projectInfo.sourceFileCount);
 };
 
+//#endregion
+//#region src/utils/should-auto-select-current-choice.ts
+const shouldAutoSelectCurrentChoice = (choiceStates, cursor) => {
+	if (choiceStates.some((choiceState) => choiceState.selected)) return false;
+	const currentChoice = choiceStates[cursor];
+	return Boolean(currentChoice) && !currentChoice.disabled;
+};
+
 //#endregion
 //#region src/utils/should-select-all-choices.ts
 const shouldSelectAllChoices = (choiceStates) => {
@@ -1214,6 +1251,7 @@ const shouldSelectAllChoices = (choiceStates) => {
 const require = createRequire(import.meta.url);
 const PROMPTS_MULTISELECT_MODULE_PATH = "prompts/lib/elements/multiselect";
 let didPatchMultiselectToggleAll = false;
+let didPatchMultiselectSubmit = false;
 const onCancel = () => {
 	logger.break();
 	logger.log("Cancelled.");
@@ -1238,8 +1276,19 @@ const patchMultiselectToggleAll = () => {
 		this.render();
 	};
 };
+const patchMultiselectSubmit = () => {
+	if (didPatchMultiselectSubmit) return;
+	didPatchMultiselectSubmit = true;
+	const multiselectPromptConstructor = require(PROMPTS_MULTISELECT_MODULE_PATH);
+	const originalSubmit = multiselectPromptConstructor.prototype.submit;
+	multiselectPromptConstructor.prototype.submit = function() {
+		if (shouldAutoSelectCurrentChoice(this.value, this.cursor)) this.value[this.cursor].selected = true;
+		originalSubmit.call(this);
+	};
+};
 const prompts = (questions) => {
 	patchMultiselectToggleAll();
+	patchMultiselectSubmit();
 	return basePrompts(questions, { onCancel });
 };
 
@@ -1414,7 +1463,7 @@ const copyToClipboard = (text) => {
 
 //#endregion
 //#region src/cli.ts
-const VERSION = "0.0.16";
+const VERSION = "0.0.18";
 process.on("SIGINT", () => process.exit(0));
 process.on("SIGTERM", () => process.exit(0));
 const program = new Command().name("react-doctor").description("Diagnose React codebase health").version(VERSION, "-v, --version", "display the version number").argument("[directory]", "project directory to scan", ".").option("--no-lint", "skip linting").option("--no-dead-code", "skip dead code detection").option("--verbose", "show file details per rule").option("--score", "output only the score").option("-y, --yes", "skip prompts, scan all workspace projects").option("--project <name>", "select workspace project (comma-separated for multiple)").option("--fix", "open Ami to auto-fix all issues").option("--prompt", "copy latest scan output to clipboard").action(async (directory, flags) => {