react-code-smell-detector 1.2.0 → 1.3.1

package/src/detectors/nestedTernary.ts

@@ -1,75 +0,0 @@
-import * as t from '@babel/types';
-import { NodePath } from '@babel/traverse';
-import { ParsedComponent, getCodeSnippet } from '../parser/index.js';
-import { CodeSmell, DetectorConfig, DEFAULT_CONFIG } from '../types/index.js';
-
-/**
- * Detects deeply nested ternary expressions (complex conditional rendering)
- */
-export function detectNestedTernaries(
-  component: ParsedComponent,
-  filePath: string,
-  sourceCode: string,
-  config: DetectorConfig = DEFAULT_CONFIG
-): CodeSmell[] {
-  const smells: CodeSmell[] = [];
-  const maxDepth = config.maxTernaryDepth;
-
-  component.path.traverse({
-    ConditionalExpression(path) {
-      // Only check the outermost ternary
-      if (isNestedInTernary(path)) return;
-
-      const depth = getTernaryDepth(path.node);
-      
-      if (depth > maxDepth) {
-        const loc = path.node.loc;
-        smells.push({
-          type: 'nested-ternary',
-          severity: depth > maxDepth + 1 ? 'warning' : 'info',
-          message: `Nested ternary expression (depth: ${depth}) in "${component.name}"`,
-          file: filePath,
-          line: loc?.start.line || 0,
-          column: loc?.start.column || 0,
-          suggestion: `Refactor to use if/else, switch, or extract into separate components. Max recommended depth: ${maxDepth}`,
-          codeSnippet: getCodeSnippet(sourceCode, loc?.start.line || 0),
-        });
-      }
-    },
-  });
-
-  return smells;
-}
-
-/**
- * Check if a ternary is nested inside another ternary
- */
-function isNestedInTernary(path: NodePath): boolean {
-  let current: NodePath | null = path.parentPath;
-  
-  while (current) {
-    if (t.isConditionalExpression(current.node)) {
-      return true;
-    }
-    current = current.parentPath;
-  }
-  
-  return false;
-}
-
-/**
- * Calculate the depth of nested ternary expressions
- */
-function getTernaryDepth(node: t.ConditionalExpression): number {
-  let maxChildDepth = 0;
-
-  if (t.isConditionalExpression(node.consequent)) {
-    maxChildDepth = Math.max(maxChildDepth, getTernaryDepth(node.consequent));
-  }
-
-  if (t.isConditionalExpression(node.alternate)) {
-    maxChildDepth = Math.max(maxChildDepth, getTernaryDepth(node.alternate));
-  }
-
-  return 1 + maxChildDepth;
-}

package/src/detectors/nextjs.ts

@@ -1,124 +0,0 @@
-import * as t from '@babel/types';
-import { ParsedComponent, getCodeSnippet } from '../parser/index.js';
-import { CodeSmell, DetectorConfig, DEFAULT_CONFIG } from '../types/index.js';
-
-/**
- * Detects Next.js-specific code smells:
- * - Missing 'use client' / 'use server' directives
- * - Unoptimized images (using <img> instead of next/image)
- * - Router misuse patterns
- * - Missing metadata exports
- */
-export function detectNextjsIssues(
-  component: ParsedComponent,
-  filePath: string,
-  sourceCode: string,
-  config: DetectorConfig = DEFAULT_CONFIG,
-  imports: string[] = []
-): CodeSmell[] {
-  if (!config.checkNextjs) return [];
-  
-  // Only run on Next.js projects (check for next imports)
-  const isNextProject = imports.some(imp => 
-    imp.includes('next/') || imp.includes('next')
-  );
-  
-  // Also check file path patterns
-  const isAppRouter = filePath.includes('/app/') && 
-    (filePath.endsWith('page.tsx') || filePath.endsWith('page.jsx') ||
-     filePath.endsWith('layout.tsx') || filePath.endsWith('layout.jsx'));
-
-  const smells: CodeSmell[] = [];
-
-  // Check for unoptimized images (using <img> instead of next/image)
-  component.path.traverse({
-    JSXOpeningElement(path) {
-      if (t.isJSXIdentifier(path.node.name) && path.node.name.name === 'img') {
-        const loc = path.node.loc;
-        smells.push({
-          type: 'nextjs-image-unoptimized',
-          severity: 'warning',
-          message: `Using native <img> instead of next/image in "${component.name}"`,
-          file: filePath,
-          line: loc?.start.line || 0,
-          column: loc?.start.column || 0,
-          suggestion: 'Use next/image for automatic image optimization: import Image from "next/image"',
-          codeSnippet: getCodeSnippet(sourceCode, loc?.start.line || 0),
-        });
-      }
-    },
-  });
-
-  // Check for client-side hooks in server components (App Router)
-  if (isAppRouter && !sourceCode.includes("'use client'") && !sourceCode.includes('"use client"')) {
-    const clientHooks = ['useState', 'useEffect', 'useContext', 'useReducer', 'useRef'];
-    const usedClientHooks: string[] = [];
-
-    component.path.traverse({
-      CallExpression(path) {
-        if (t.isIdentifier(path.node.callee) && clientHooks.includes(path.node.callee.name)) {
-          usedClientHooks.push(path.node.callee.name);
-        }
-      },
-    });
-
-    if (usedClientHooks.length > 0) {
-      const loc = component.node.loc;
-      smells.push({
-        type: 'nextjs-client-server-boundary',
-        severity: 'error',
-        message: `Client hooks (${usedClientHooks.join(', ')}) used without 'use client' directive in "${component.name}"`,
-        file: filePath,
-        line: loc?.start.line || 1,
-        column: 0,
-        suggestion: "Add 'use client' at the top of the file, or move client logic to a separate component",
-        codeSnippet: getCodeSnippet(sourceCode, 1),
-      });
-    }
-  }
-
-  // Check for missing metadata in page/layout files
-  if (isAppRouter && filePath.includes('page.')) {
-    // This would require checking exports, which needs file-level analysis
-    const hasMetadata = sourceCode.includes('export const metadata') || 
-                        sourceCode.includes('export function generateMetadata');
-    
-    if (!hasMetadata && component.name === 'default') {
-      smells.push({
-        type: 'nextjs-missing-metadata',
-        severity: 'info',
-        message: 'Page component missing metadata export',
-        file: filePath,
-        line: 1,
-        column: 0,
-        suggestion: 'Add metadata for SEO: export const metadata = { title: "...", description: "..." }',
-      });
-    }
-  }
-
-  // Check for router misuse (using window.location instead of next/router)
-  component.path.traverse({
-    MemberExpression(path) {
-      if (
-        t.isIdentifier(path.node.object) &&
-        path.node.object.name === 'window' &&
-        t.isIdentifier(path.node.property) &&
-        path.node.property.name === 'location'
-      ) {
-        const loc = path.node.loc;
-        smells.push({
-          type: 'nextjs-router-misuse',
-          severity: 'warning',
-          message: `Using window.location instead of Next.js router in "${component.name}"`,
-          file: filePath,
-          line: loc?.start.line || 0,
-          column: loc?.start.column || 0,
-          suggestion: 'Use next/navigation: import { useRouter } from "next/navigation"',
-          codeSnippet: getCodeSnippet(sourceCode, loc?.start.line || 0),
-        });
-      }
-    },
-  });
-
-  return smells;
-}

package/src/detectors/nodejs.ts

@@ -1,199 +0,0 @@
-import * as t from '@babel/types';
-import { NodePath } from '@babel/traverse';
-import { ParsedComponent, getCodeSnippet } from '../parser/index.js';
-import { CodeSmell, DetectorConfig, DEFAULT_CONFIG } from '../types/index.js';
-
-/**
- * Detects Node.js-specific code smells:
- * - Callback hell (deeply nested callbacks)
- * - Unhandled promise rejections
- * - Synchronous I/O operations
- * - Missing error handling
- */
-export function detectNodejsIssues(
-  component: ParsedComponent,
-  filePath: string,
-  sourceCode: string,
-  config: DetectorConfig = DEFAULT_CONFIG,
-  imports: string[] = []
-): CodeSmell[] {
-  if (!config.checkNodejs) return [];
-  
-  // Check if this looks like a Node.js file
-  const isNodeFile = imports.some(imp => 
-    imp.includes('fs') || imp.includes('path') || imp.includes('http') ||
-    imp.includes('express') || imp.includes('child_process') ||
-    imp.includes('crypto') || imp.includes('os') || imp.includes('stream')
-  ) || filePath.includes('.server.') || filePath.includes('/api/');
-
-  if (!isNodeFile) return [];
-
-  const smells: CodeSmell[] = [];
-
-  // Detect callback hell (nested callbacks > maxCallbackDepth)
-  component.path.traverse({
-    CallExpression(path) {
-      const depth = getCallbackDepth(path);
-      
-      if (depth > config.maxCallbackDepth) {
-        const loc = path.node.loc;
-        smells.push({
-          type: 'nodejs-callback-hell',
-          severity: 'warning',
-          message: `Callback hell detected (depth: ${depth}) in "${component.name}"`,
-          file: filePath,
-          line: loc?.start.line || 0,
-          column: loc?.start.column || 0,
-          suggestion: 'Refactor to async/await or use Promise.all() for parallel operations',
-          codeSnippet: getCodeSnippet(sourceCode, loc?.start.line || 0),
-        });
-      }
-    },
-  });
-
-  // Detect unhandled promise rejections (Promise without .catch or try/catch)
-  component.path.traverse({
-    CallExpression(path) {
-      // Check for .then() without .catch()
-      if (t.isMemberExpression(path.node.callee) && 
-          t.isIdentifier(path.node.callee.property) &&
-          path.node.callee.property.name === 'then') {
-        
-        // Check if followed by .catch() in chain
-        const parent = path.parent;
-        let hasCatch = false;
-        
-        if (t.isMemberExpression(parent)) {
-          const prop = (parent as t.MemberExpression).property;
-          if (t.isIdentifier(prop) && prop.name === 'catch') {
-            hasCatch = true;
-          }
-        }
-        
-        // Check if inside try block
-        let current: NodePath | null = path;
-        while (current) {
-          if (t.isTryStatement(current.node)) {
-            hasCatch = true;
-            break;
-          }
-          current = current.parentPath;
-        }
-        
-        if (!hasCatch) {
-          const loc = path.node.loc;
-          smells.push({
-            type: 'nodejs-unhandled-promise',
-            severity: 'warning',
-            message: `.then() without .catch() in "${component.name}"`,
-            file: filePath,
-            line: loc?.start.line || 0,
-            column: loc?.start.column || 0,
-            suggestion: 'Add .catch() to handle rejections, or use try/catch with async/await',
-            codeSnippet: getCodeSnippet(sourceCode, loc?.start.line || 0),
-          });
-        }
-      }
-    },
-  });
-
-  // Detect synchronous file operations
-  const syncMethods = ['readFileSync', 'writeFileSync', 'appendFileSync', 'readdirSync', 
-                       'statSync', 'mkdirSync', 'rmdirSync', 'unlinkSync', 'existsSync'];
-  
-  component.path.traverse({
-    CallExpression(path) {
-      const callee = path.node.callee;
-      
-      if (t.isMemberExpression(callee) && t.isIdentifier(callee.property)) {
-        if (syncMethods.includes(callee.property.name)) {
-          const loc = path.node.loc;
-          smells.push({
-            type: 'nodejs-sync-io',
-            severity: 'warning',
-            message: `Synchronous file operation "${callee.property.name}" blocks event loop`,
-            file: filePath,
-            line: loc?.start.line || 0,
-            column: loc?.start.column || 0,
-            suggestion: `Use async version: ${callee.property.name.replace('Sync', '')} with await or promises`,
-            codeSnippet: getCodeSnippet(sourceCode, loc?.start.line || 0),
-          });
-        }
-      }
-      
-      // Direct function call
-      if (t.isIdentifier(callee) && syncMethods.includes(callee.name)) {
-        const loc = path.node.loc;
-        smells.push({
-          type: 'nodejs-sync-io',
-          severity: 'warning',
-          message: `Synchronous file operation "${callee.name}" blocks event loop`,
-          file: filePath,
-          line: loc?.start.line || 0,
-          column: loc?.start.column || 0,
-          suggestion: `Use async version: ${callee.name.replace('Sync', '')} with await or promises`,
-          codeSnippet: getCodeSnippet(sourceCode, loc?.start.line || 0),
-        });
-      }
-    },
-  });
-
-  // Detect missing error handling in async functions
-  component.path.traverse({
-    AwaitExpression(path) {
-      // Check if inside try block
-      let insideTry = false;
-      let current: NodePath | null = path;
-      
-      while (current) {
-        if (t.isTryStatement(current.node)) {
-          insideTry = true;
-          break;
-        }
-        // Stop at function boundary
-        if (t.isFunction(current.node)) break;
-        current = current.parentPath;
-      }
-      
-      if (!insideTry) {
-        // Check if the parent function has error handling at call site
-        // This is a simplified check - in practice you'd want more context
-        const loc = path.node.loc;
-        smells.push({
-          type: 'nodejs-missing-error-handling',
-          severity: 'info',
-          message: `await without try/catch may cause unhandled rejections`,
-          file: filePath,
-          line: loc?.start.line || 0,
-          column: loc?.start.column || 0,
-          suggestion: 'Wrap await in try/catch or handle errors at the call site',
-          codeSnippet: getCodeSnippet(sourceCode, loc?.start.line || 0),
-        });
-      }
-    },
-  });
-
-  return smells;
-}
-
-/**
- * Calculate the depth of nested callbacks
- */
-function getCallbackDepth(path: NodePath): number {
-  let depth = 0;
-  let current: NodePath | null = path;
-  
-  while (current) {
-    const node = current.node;
-    
-    // Count function expressions that are arguments to calls
-    if ((t.isFunctionExpression(node) || t.isArrowFunctionExpression(node)) &&
-        t.isCallExpression(current.parent)) {
-      depth++;
-    }
-    
-    current = current.parentPath;
-  }
-  
-  return depth;
-}

package/src/detectors/propDrilling.ts

@@ -1,103 +0,0 @@
-import { ParsedComponent, getCodeSnippet } from '../parser/index.js';
-import { CodeSmell, DetectorConfig, DEFAULT_CONFIG } from '../types/index.js';
-
-export function detectPropDrilling(
-  component: ParsedComponent,
-  filePath: string,
-  sourceCode: string,
-  config: DetectorConfig = DEFAULT_CONFIG
-): CodeSmell[] {
-  const smells: CodeSmell[] = [];
-
-  // Check for too many props
-  if (component.props.length > config.maxPropsCount) {
-    smells.push({
-      type: 'prop-drilling',
-      severity: 'warning',
-      message: `Component "${component.name}" receives ${component.props.length} props (max recommended: ${config.maxPropsCount})`,
-      file: filePath,
-      line: component.startLine,
-      column: 0,
-      suggestion: 'Consider using Context, a state management library, or component composition',
-      codeSnippet: getCodeSnippet(sourceCode, component.startLine),
-    });
-  }
-
-  // Check for props that are just passed through (prop drilling indicators)
-  const passThroughProps = component.props.filter(prop => {
-    // Common patterns that indicate prop drilling
-    const drillingPatterns = ['data', 'config', 'settings', 'options', 'state', 'handlers', 'callbacks'];
-    return drillingPatterns.some(pattern => prop.toLowerCase().includes(pattern));
-  });
-
-  if (passThroughProps.length >= 3) {
-    smells.push({
-      type: 'prop-drilling',
-      severity: 'info',
-      message: `Component "${component.name}" may be experiencing prop drilling: ${passThroughProps.join(', ')}`,
-      file: filePath,
-      line: component.startLine,
-      column: 0,
-      suggestion: 'Consider using React Context or a state management solution to avoid passing data through intermediate components',
-      codeSnippet: getCodeSnippet(sourceCode, component.startLine),
-    });
-  }
-
-  // Check for spread props (often indicates forwarding)
-  const spreadProps = component.props.filter(p => p.startsWith('...'));
-  if (spreadProps.length > 0 && component.props.length > 5) {
-    smells.push({
-      type: 'prop-drilling',
-      severity: 'info',
-      message: `Component "${component.name}" uses spread props with many other props - potential prop drilling`,
-      file: filePath,
-      line: component.startLine,
-      column: 0,
-      suggestion: 'Consider composing components differently or using Context for shared state',
-      codeSnippet: getCodeSnippet(sourceCode, component.startLine),
-    });
-  }
-
-  return smells;
-}
-
-export function analyzePropDrillingDepth(
-  components: ParsedComponent[],
-  filePath: string,
-  sourceCode: string,
-  config: DetectorConfig = DEFAULT_CONFIG
-): CodeSmell[] {
-  const smells: CodeSmell[] = [];
-
-  // Track props that appear in multiple components
-  const propUsage = new Map<string, string[]>();
-
-  components.forEach(comp => {
-    comp.props.forEach(prop => {
-      if (!prop.startsWith('...')) {
-        const existing = propUsage.get(prop) || [];
-        existing.push(comp.name);
-        propUsage.set(prop, existing);
-      }
-    });
-  });
-
-  // Find props used in more than maxPropDrillingDepth components
-  propUsage.forEach((componentNames, propName) => {
-    if (componentNames.length > config.maxPropDrillingDepth) {
-      const firstComp = components.find(c => c.name === componentNames[0]);
-      smells.push({
-        type: 'prop-drilling',
-        severity: 'warning',
-        message: `Prop "${propName}" is passed through ${componentNames.length} components: ${componentNames.join(' → ')}`,
-        file: filePath,
-        line: firstComp?.startLine || 1,
-        column: 0,
-        suggestion: `Move "${propName}" to Context or a state management solution`,
-        codeSnippet: firstComp ? getCodeSnippet(sourceCode, firstComp.startLine) : undefined,
-      });
-    }
-  });
-
-  return smells;
-}

package/src/detectors/reactNative.ts

@@ -1,154 +0,0 @@
-import * as t from '@babel/types';
-import { NodePath } from '@babel/traverse';
-import { ParsedComponent, getCodeSnippet } from '../parser/index.js';
-import { CodeSmell, DetectorConfig, DEFAULT_CONFIG } from '../types/index.js';
-
-/**
- * Detects React Native-specific code smells:
- * - Inline styles instead of StyleSheet
- * - Missing accessibility props
- * - Performance anti-patterns
- */
-export function detectReactNativeIssues(
-  component: ParsedComponent,
-  filePath: string,
-  sourceCode: string,
-  config: DetectorConfig = DEFAULT_CONFIG,
-  imports: string[] = []
-): CodeSmell[] {
-  if (!config.checkReactNative) return [];
-  
-  // Only run on React Native projects
-  const isRNProject = imports.some(imp => 
-    imp.includes('react-native') || imp.includes('@react-native')
-  );
-  
-  if (!isRNProject) return [];
-
-  const smells: CodeSmell[] = [];
-  const inlineStyleLines = new Set<number>();
-
-  // Check for inline styles instead of StyleSheet
-  component.path.traverse({
-    JSXAttribute(path) {
-      if (!t.isJSXIdentifier(path.node.name)) return;
-      if (path.node.name.name !== 'style') return;
-      
-      const value = path.node.value;
-      if (!t.isJSXExpressionContainer(value)) return;
-      
-      // Check if it's an inline object (not a StyleSheet reference)
-      if (t.isObjectExpression(value.expression)) {
-        const loc = path.node.loc;
-        const line = loc?.start.line || 0;
-        
-        if (!inlineStyleLines.has(line)) {
-          inlineStyleLines.add(line);
-          smells.push({
-            type: 'rn-inline-style',
-            severity: 'warning',
-            message: `Inline style object in "${component.name}" - prefer StyleSheet.create()`,
-            file: filePath,
-            line,
-            column: loc?.start.column || 0,
-            suggestion: 'Use StyleSheet.create() for better performance: const styles = StyleSheet.create({ ... })',
-            codeSnippet: getCodeSnippet(sourceCode, line),
-          });
-        }
-      }
-    },
-  });
-
-  // Check for missing accessibility props on interactive elements
-  const interactiveComponents = ['TouchableOpacity', 'TouchableHighlight', 'Pressable', 'Button', 'TouchableWithoutFeedback'];
-  
-  component.path.traverse({
-    JSXOpeningElement(path) {
-      if (!t.isJSXIdentifier(path.node.name)) return;
-      
-      const componentName = path.node.name.name;
-      if (!interactiveComponents.includes(componentName)) return;
-
-      // Check for accessibility props
-      const hasAccessibilityLabel = path.node.attributes.some(attr => {
-        if (t.isJSXAttribute(attr) && t.isJSXIdentifier(attr.name)) {
-          return ['accessibilityLabel', 'accessible', 'accessibilityRole', 'accessibilityHint'].includes(attr.name.name);
-        }
-        return false;
-      });
-
-      if (!hasAccessibilityLabel) {
-        const loc = path.node.loc;
-        smells.push({
-          type: 'rn-missing-accessibility',
-          severity: 'info',
-          message: `${componentName} missing accessibility props in "${component.name}"`,
-          file: filePath,
-          line: loc?.start.line || 0,
-          column: loc?.start.column || 0,
-          suggestion: 'Add accessibilityLabel and accessibilityRole for screen readers',
-          codeSnippet: getCodeSnippet(sourceCode, loc?.start.line || 0),
-        });
-      }
-    },
-  });
-
-  // Check for performance anti-patterns
-  component.path.traverse({
-    // Detect creating anonymous functions in render (for onPress, etc.)
-    JSXAttribute(path) {
-      if (!t.isJSXIdentifier(path.node.name)) return;
-      
-      const propName = path.node.name.name;
-      if (!['onPress', 'onPressIn', 'onPressOut', 'onLongPress'].includes(propName)) return;
-      
-      const value = path.node.value;
-      if (!t.isJSXExpressionContainer(value)) return;
-      
-      // Check for arrow functions or function expressions
-      if (t.isArrowFunctionExpression(value.expression) || t.isFunctionExpression(value.expression)) {
-        const loc = path.node.loc;
-        smells.push({
-          type: 'rn-performance-issue',
-          severity: 'info',
-          message: `Inline function for ${propName} in "${component.name}" creates new reference each render`,
-          file: filePath,
-          line: loc?.start.line || 0,
-          column: loc?.start.column || 0,
-          suggestion: 'Extract to useCallback or class method to prevent unnecessary re-renders',
-          codeSnippet: getCodeSnippet(sourceCode, loc?.start.line || 0),
-        });
-      }
-    },
-
-    // Detect array spreads in render that could be memoized
-    SpreadElement(path) {
-      const loc = path.node.loc;
-      // Only flag if inside JSX or return statement
-      let inJSX = false;
-      let current: NodePath | null = path.parentPath;
-      while (current) {
-        if (t.isJSXElement(current.node) || t.isJSXFragment(current.node)) {
-          inJSX = true;
-          break;
-        }
-        current = current.parentPath;
-      }
-      
-      if (inJSX && t.isArrayExpression(path.parent)) {
-        smells.push({
-          type: 'rn-performance-issue',
-          severity: 'info',
-          message: `Array spread in render may cause performance issues in "${component.name}"`,
-          file: filePath,
-          line: loc?.start.line || 0,
-          column: loc?.start.column || 0,
-          suggestion: 'Consider memoizing with useMemo if this array is passed as a prop',
-          codeSnippet: getCodeSnippet(sourceCode, loc?.start.line || 0),
-        });
-      }
-    },
-  });
-
-  return smells;
-}