react-asc 25.0.1 → 25.0.2

package/components/Form/validators/MaxValidator.d.ts

@@ -1 +1 @@
-export declare const MaxValidator: (valueA: number, valueB: number) => boolean;
+export declare const MaxValidator: (val: string, valueB: number) => boolean;

package/components/Form/validators/MinValidator.d.ts

@@ -1 +1 @@
-export declare const MinValidator: (valueA: number, valueB: number) => boolean;
+export declare const MinValidator: (val: string, minLength: number) => boolean;

package/index.es.js

@@ -1233,9 +1233,9 @@ const EmailValidator = (value) => {
 
 const IsEqualValidator = (valueA, valueB) => valueA === valueB;
 
-const MaxValidator = (valueA, valueB) => valueA <= valueB;
+const MaxValidator = (val, valueB) => val.length <= valueB;
 
-const MinValidator = (valueA, valueB) => valueA >= valueB;
+const MinValidator = (val, minLength) => val.length >= minLength;
 
 // values, isSubmitting, handleChange, handleBlur, handleSubmit
 class Form extends Component {
@@ -1288,12 +1288,12 @@ class Form extends Component {
                         break;
                     case 'min':
                         if (!MinValidator(fieldValue, parseInt(validatorParam))) {
-                            errors.push({ validator: validatorName, message: `Number is less than ${validatorParam}` });
+                            errors.push({ validator: validatorName, message: `Minimum number of ${validatorParam} characters not met` });
                         }
                         break;
                     case 'max':
                         if (!MaxValidator(fieldValue, parseInt(validatorParam))) {
-                            errors.push({ validator: validatorName, message: `Number is greater than ${validatorParam}` });
+                            errors.push({ validator: validatorName, message: `Maximum number of ${validatorParam} characters exceeded` });
                         }
                         break;
                     case 'match':
@@ -1968,10 +1968,10 @@ const GlobalModal = ({ title, description, formControls, onOk, onChange, onCance
         }
         button.handler && button.handler();
     };
-    return (React.createElement(Modal, { size: size, fullScreen: fullScreen, header: title, onHeaderCloseClick: onCancel, onBackdropClick: onBackdropClick, isDismissable: isDismissable, footer: React.createElement(Fragment, null, buttons.map((button, index) => (React.createElement(Button, { key: index, variant: button.variant, color: button.color, autoFocus: button.autoFocus, shadow: button.shadow, onClick: () => handleClickButton(button) }, button.label)))) },
+    return (React.createElement(Modal, { size: size, fullScreen: fullScreen, header: title, onHeaderCloseClick: onCancel, onBackdropClick: onBackdropClick, isDismissable: isDismissable, footer: React.createElement(React.Fragment, null, buttons.map((button, index) => (React.createElement(Button, { key: index, variant: button.variant, color: button.color, autoFocus: button.autoFocus, shadow: button.shadow, onClick: () => handleClickButton(button) }, button.label)))) },
         description && React.createElement("div", null, description),
         modalType === MODALTYPE.FORM &&
-            React.createElement(Fragment, null,
+            React.createElement(React.Fragment, null,
                 React.createElement(Form, { ref: myForm, controls: myControls, validateOnBlur: true, onSubmit: onSubmit, onChange: onChange }))));
 };
 
@@ -1998,7 +1998,7 @@ class ModalService {
         return new Promise((resolve, reject) => {
             if (!this.container) {
                 this.container = document.createElement('div');
-                document.body.appendChild(this.container);
+                this.container.classList.add('modal-container');
                 const handleOk = (values) => {
                     resolve(values);
                     this.hide();
@@ -2020,7 +2020,7 @@ class ModalService {
         var _a;
         if (this.container) {
             (_a = this.root) === null || _a === void 0 ? void 0 : _a.unmount();
-            document.body.removeChild(this.container);
+            // document.body.removeChild(this.container);
             this.container = undefined;
         }
     }
@@ -2704,6 +2704,7 @@ const Tabs = (props) => {
     });
     const prevSelectedValueRef = useRef();
     useEffect(() => {
+        // TODO - check if prev needs to be set
         if (value !== undefined && value !== prevSelectedValueRef.current) {
             setSelectedValue(value);
         }

package/index.js

@@ -1242,9 +1242,9 @@ const EmailValidator = (value) => {
 
 const IsEqualValidator = (valueA, valueB) => valueA === valueB;
 
-const MaxValidator = (valueA, valueB) => valueA <= valueB;
+const MaxValidator = (val, valueB) => val.length <= valueB;
 
-const MinValidator = (valueA, valueB) => valueA >= valueB;
+const MinValidator = (val, minLength) => val.length >= minLength;
 
 // values, isSubmitting, handleChange, handleBlur, handleSubmit
 class Form extends React.Component {
@@ -1297,12 +1297,12 @@ class Form extends React.Component {
                         break;
                     case 'min':
                         if (!MinValidator(fieldValue, parseInt(validatorParam))) {
-                            errors.push({ validator: validatorName, message: `Number is less than ${validatorParam}` });
+                            errors.push({ validator: validatorName, message: `Minimum number of ${validatorParam} characters not met` });
                         }
                         break;
                     case 'max':
                         if (!MaxValidator(fieldValue, parseInt(validatorParam))) {
-                            errors.push({ validator: validatorName, message: `Number is greater than ${validatorParam}` });
+                            errors.push({ validator: validatorName, message: `Maximum number of ${validatorParam} characters exceeded` });
                         }
                         break;
                     case 'match':
@@ -1977,10 +1977,10 @@ const GlobalModal = ({ title, description, formControls, onOk, onChange, onCance
         }
         button.handler && button.handler();
     };
-    return (React__default["default"].createElement(Modal, { size: size, fullScreen: fullScreen, header: title, onHeaderCloseClick: onCancel, onBackdropClick: onBackdropClick, isDismissable: isDismissable, footer: React__default["default"].createElement(React.Fragment, null, buttons.map((button, index) => (React__default["default"].createElement(Button, { key: index, variant: button.variant, color: button.color, autoFocus: button.autoFocus, shadow: button.shadow, onClick: () => handleClickButton(button) }, button.label)))) },
+    return (React__default["default"].createElement(Modal, { size: size, fullScreen: fullScreen, header: title, onHeaderCloseClick: onCancel, onBackdropClick: onBackdropClick, isDismissable: isDismissable, footer: React__default["default"].createElement(React__default["default"].Fragment, null, buttons.map((button, index) => (React__default["default"].createElement(Button, { key: index, variant: button.variant, color: button.color, autoFocus: button.autoFocus, shadow: button.shadow, onClick: () => handleClickButton(button) }, button.label)))) },
         description && React__default["default"].createElement("div", null, description),
         modalType === exports.MODALTYPE.FORM &&
-            React__default["default"].createElement(React.Fragment, null,
+            React__default["default"].createElement(React__default["default"].Fragment, null,
                 React__default["default"].createElement(Form, { ref: myForm, controls: myControls, validateOnBlur: true, onSubmit: onSubmit, onChange: onChange }))));
 };
 
@@ -2007,7 +2007,7 @@ class ModalService {
         return new Promise((resolve, reject) => {
             if (!this.container) {
                 this.container = document.createElement('div');
-                document.body.appendChild(this.container);
+                this.container.classList.add('modal-container');
                 const handleOk = (values) => {
                     resolve(values);
                     this.hide();
@@ -2029,7 +2029,7 @@ class ModalService {
         var _a;
         if (this.container) {
             (_a = this.root) === null || _a === void 0 ? void 0 : _a.unmount();
-            document.body.removeChild(this.container);
+            // document.body.removeChild(this.container);
             this.container = undefined;
         }
     }
@@ -2713,6 +2713,7 @@ const Tabs = (props) => {
     });
     const prevSelectedValueRef = React.useRef();
     React.useEffect(() => {
+        // TODO - check if prev needs to be set
         if (value !== undefined && value !== prevSelectedValueRef.current) {
             setSelectedValue(value);
         }

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "react-asc",
-	"version": "25.0.1",
+	"version": "25.0.2",
 	"description": "handcrafted react components",
 	"main": "index.js",
 	"module": "index.es.js",