react-arborist 3.6.0 → 3.6.1

package/dist/main/components/provider.js

@@ -29,7 +29,14 @@ function TreeProvider({ treeProps, imperativeHandle, children, }) {
     (0, react_1.useMemo)(() => {
         updateCount.current += 1;
         api.update(treeProps);
-    }, [...Object.values(treeProps), state.nodes.open]);
+    }, [...Object.values(treeProps)]);
+    /* Rebuild visible nodes when open state changes, without clobbering
+       props set imperatively via api.update(). Bumping updateCount keeps
+       DataUpdates consumers (e.g. DefaultContainer) in sync. */
+    (0, react_1.useMemo)(() => {
+        updateCount.current += 1;
+        api.update(api.props);
+    }, [state.nodes.open]);
     /* Expose the tree api */
     (0, react_1.useImperativeHandle)(imperativeHandle, () => api);
     /* Change selection based on props */

package/dist/main/components/provider.test.d.ts

@@ -0,0 +1 @@
+export {};

package/dist/main/components/provider.test.js

@@ -0,0 +1,33 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+const jsx_runtime_1 = require("react/jsx-runtime");
+const react_1 = require("react");
+const react_2 = require("@testing-library/react");
+const tree_1 = require("./tree");
+const data = [
+    {
+        id: "1",
+        name: "root",
+        children: [
+            { id: "2", name: "a" },
+            { id: "3", name: "b", children: [{ id: "4", name: "c" }] },
+        ],
+    },
+];
+test("imperative tree.update() props survive node toggles (#228)", () => {
+    const ref = (0, react_1.createRef)();
+    (0, react_2.render)((0, jsx_runtime_1.jsx)(tree_1.Tree, { data: data, ref: ref, rowHeight: 24, openByDefault: false }));
+    const api = ref.current;
+    expect(api.rowHeight).toBe(24);
+    (0, react_2.act)(() => {
+        api.update(Object.assign(Object.assign({}, api.props), { rowHeight: 48 }));
+    });
+    expect(api.rowHeight).toBe(48);
+    /* Opening a node dispatches a redux action that changes state.nodes.open.
+       Before #337, the open-state effect re-ran api.update(treeProps), reverting
+       rowHeight to 24. */
+    (0, react_2.act)(() => {
+        api.open("1");
+    });
+    expect(api.rowHeight).toBe(48);
+});

package/dist/module/components/provider.js

@@ -26,7 +26,14 @@ export function TreeProvider({ treeProps, imperativeHandle, children, }) {
     useMemo(() => {
         updateCount.current += 1;
         api.update(treeProps);
-    }, [...Object.values(treeProps), state.nodes.open]);
+    }, [...Object.values(treeProps)]);
+    /* Rebuild visible nodes when open state changes, without clobbering
+       props set imperatively via api.update(). Bumping updateCount keeps
+       DataUpdates consumers (e.g. DefaultContainer) in sync. */
+    useMemo(() => {
+        updateCount.current += 1;
+        api.update(api.props);
+    }, [state.nodes.open]);
     /* Expose the tree api */
     useImperativeHandle(imperativeHandle, () => api);
     /* Change selection based on props */

package/dist/module/components/provider.test.d.ts

@@ -0,0 +1 @@
+export {};

package/dist/module/components/provider.test.js

@@ -0,0 +1,31 @@
+import { jsx as _jsx } from "react/jsx-runtime";
+import { createRef } from "react";
+import { act, render } from "@testing-library/react";
+import { Tree } from "./tree";
+const data = [
+    {
+        id: "1",
+        name: "root",
+        children: [
+            { id: "2", name: "a" },
+            { id: "3", name: "b", children: [{ id: "4", name: "c" }] },
+        ],
+    },
+];
+test("imperative tree.update() props survive node toggles (#228)", () => {
+    const ref = createRef();
+    render(_jsx(Tree, { data: data, ref: ref, rowHeight: 24, openByDefault: false }));
+    const api = ref.current;
+    expect(api.rowHeight).toBe(24);
+    act(() => {
+        api.update(Object.assign(Object.assign({}, api.props), { rowHeight: 48 }));
+    });
+    expect(api.rowHeight).toBe(48);
+    /* Opening a node dispatches a redux action that changes state.nodes.open.
+       Before #337, the open-state effect re-ran api.update(treeProps), reverting
+       rowHeight to 24. */
+    act(() => {
+        api.open("1");
+    });
+    expect(api.rowHeight).toBe(48);
+});

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-arborist",
-  "version": "3.6.0",
+  "version": "3.6.1",
   "license": "MIT",
   "source": "src/index.ts",
   "main": "dist/main/index.js",
@@ -49,12 +49,18 @@
     "react-dom": ">= 16.14"
   },
   "devDependencies": {
+    "@testing-library/dom": "^9.3.0",
+    "@testing-library/react": "^14.0.0",
     "@types/jest": "^29.5.11",
     "@types/react": "^18.2.43",
+    "@types/react-dom": "^18.2.0",
     "@types/react-window": "^1.8.8",
     "@types/use-sync-external-store": "^0.0.6",
     "jest": "^29.7.0",
+    "jest-environment-jsdom": "^29.7.0",
     "npm-run-all": "^4.1.5",
+    "react": "^18.2.0",
+    "react-dom": "^18.2.0",
     "rimraf": "^5.0.5",
     "ts-jest": "^29.1.1",
     "typescript": "^5.6.0"

package/src/components/provider.test.tsx

@@ -0,0 +1,44 @@
+import { createRef } from "react";
+import { act, render } from "@testing-library/react";
+import { Tree } from "./tree";
+import { TreeApi } from "../interfaces/tree-api";
+
+type Datum = { id: string; name: string; children?: Datum[] };
+
+const data: Datum[] = [
+  {
+    id: "1",
+    name: "root",
+    children: [
+      { id: "2", name: "a" },
+      { id: "3", name: "b", children: [{ id: "4", name: "c" }] },
+    ],
+  },
+];
+
+test("imperative tree.update() props survive node toggles (#228)", () => {
+  const ref = createRef<TreeApi<Datum> | undefined>();
+  render(
+    <Tree<Datum>
+      data={data}
+      ref={ref}
+      rowHeight={24}
+      openByDefault={false}
+    />
+  );
+  const api = ref.current!;
+  expect(api.rowHeight).toBe(24);
+
+  act(() => {
+    api.update({ ...api.props, rowHeight: 48 });
+  });
+  expect(api.rowHeight).toBe(48);
+
+  /* Opening a node dispatches a redux action that changes state.nodes.open.
+     Before #337, the open-state effect re-ran api.update(treeProps), reverting
+     rowHeight to 24. */
+  act(() => {
+    api.open("1");
+  });
+  expect(api.rowHeight).toBe(48);
+});

package/src/components/provider.tsx

@@ -57,7 +57,15 @@ export function TreeProvider<T>({
   useMemo(() => {
     updateCount.current += 1;
     api.update(treeProps);
-  }, [...Object.values(treeProps), state.nodes.open]);
+  }, [...Object.values(treeProps)]);
+
+  /* Rebuild visible nodes when open state changes, without clobbering
+     props set imperatively via api.update(). Bumping updateCount keeps
+     DataUpdates consumers (e.g. DefaultContainer) in sync. */
+  useMemo(() => {
+    updateCount.current += 1;
+    api.update(api.props);
+  }, [state.nodes.open]);
 
   /* Expose the tree api */
   useImperativeHandle(imperativeHandle, () => api);