rcf-lite 0.28.0 → 0.28.2

package/src/view/doc-renderers/helpers.js

@@ -77,6 +77,43 @@ export function fieldList(label, items) {
   return `<section class="field-list"><h4>${escapeHtml(label)}</h4><ul>${li}</ul></section>`;
 }
 
+/**
+ * 0.28.2 (issue #235): render an array-of-object field as a HTML
+ * table with the schema-known columns. Empty columns are suppressed so
+ * schema-optional fields do not surface as blank columns. Every cell
+ * is escaped. Used by the TAD renderer for the three structured
+ * fields the TAD schema names (dataStores, coreEntities,
+ * externalSystems) so a review-surface reader sees a legible table
+ * instead of a single-line `JSON.stringify` dump.
+ *
+ * @param {string} label       section heading
+ * @param {object[]} rows       array of row objects (dropped when empty)
+ * @param {Array<{ key: string, label?: string }>} columns
+ * @returns {string}
+ */
+export function fieldObjectTable(label, rows, columns) {
+  if (!Array.isArray(rows) || rows.length === 0) return '';
+  if (!Array.isArray(columns) || columns.length === 0) return '';
+  // Drop columns that are empty across every row so a schema-optional
+  // field (`purpose`, `description`, `protocol`) does not surface as
+  // a blank column.
+  const usedColumns = columns.filter((col) => rows.some((r) => {
+    const v = r?.[col.key];
+    return v !== undefined && v !== null && String(v).length > 0;
+  }));
+  if (usedColumns.length === 0) return '';
+  const thead = usedColumns.map((c) => `<th>${escapeHtml(c.label ?? c.key)}</th>`).join('');
+  const tbody = rows.map((r) => {
+    const cells = usedColumns.map((c) => {
+      const v = r?.[c.key];
+      const text = v === undefined || v === null ? '' : String(v);
+      return `<td>${escapeHtml(text)}</td>`;
+    }).join('');
+    return `<tr>${cells}</tr>`;
+  }).join('');
+  return `<section class="field-list"><h4>${escapeHtml(label)}</h4><table class="field-table"><thead><tr>${thead}</tr></thead><tbody>${tbody}</tbody></table></section>`;
+}
+
 /**
  * Render the "Show raw JSON" disclosure block for a document.
  *

package/src/view/doc-renderers/tad.js

@@ -9,10 +9,34 @@ import {
   docLinkList,
   escapeHtml,
   fieldList,
+  fieldObjectTable,
   fieldPara,
   rawJsonDisclosure,
 } from './helpers.js';
 
+// 0.28.2 (issue #235): structured fields the TAD schema explicitly
+// types as arrays of objects. Each entry maps a field-key to the
+// schema-documented column layout so `renderOptionalSections` can
+// pick a table renderer over the raw-JSON dump the pre-fix code
+// emitted. Columns follow @stravica-ai/rcf-schemas@0.6.3
+// schemas/tad.schema.json.
+const TAD_STRUCTURED_FIELDS = {
+  dataStores: [
+    { key: 'name', label: 'Name' },
+    { key: 'kind', label: 'Kind' },
+    { key: 'purpose', label: 'Purpose' },
+  ],
+  coreEntities: [
+    { key: 'name', label: 'Name' },
+    { key: 'description', label: 'Description' },
+  ],
+  externalSystems: [
+    { key: 'name', label: 'Name' },
+    { key: 'purpose', label: 'Purpose' },
+    { key: 'protocol', label: 'Protocol' },
+  ],
+};
+
 /**
  * @param {object} tad
  * @param {object} ctx
@@ -63,12 +87,49 @@ function renderOptionalSections(tad) {
   for (const [key, label] of Object.entries(named)) {
     const section = tad[key];
     if (!section || typeof section !== 'object') continue;
-    const rows = Object.entries(section).map(([k, v]) => {
-      if (typeof v === 'string') return `<dt>${escapeHtml(k)}</dt><dd>${escapeHtml(v)}</dd>`;
-      if (Array.isArray(v)) return `<dt>${escapeHtml(k)}</dt><dd>${v.map((x) => `<code>${escapeHtml(typeof x === 'object' ? JSON.stringify(x) : x)}</code>`).join(', ')}</dd>`;
-      return `<dt>${escapeHtml(k)}</dt><dd><pre>${escapeHtml(JSON.stringify(v, null, 2))}</pre></dd>`;
-    }).join('\n');
-    out.push(`<section class="field-list"><h4>${escapeHtml(label)}</h4><dl>${rows}</dl></section>`);
+    // 0.28.2 (issue #235): pull the schema-known structured fields
+    // (dataStores, coreEntities, externalSystems) out of the generic
+    // dl loop and render them as tables. The remaining scalar and
+    // array-of-string fields keep their dl treatment.
+    const structuredBlocks = [];
+    const dlEntries = [];
+    for (const [k, v] of Object.entries(section)) {
+      if (TAD_STRUCTURED_FIELDS[k] && Array.isArray(v) && v.length > 0 && v.every((x) => x && typeof x === 'object')) {
+        const table = fieldObjectTable(prettyStructuredLabel(k), v, TAD_STRUCTURED_FIELDS[k]);
+        if (table) structuredBlocks.push(table);
+        continue;
+      }
+      if (typeof v === 'string') {
+        dlEntries.push(`<dt>${escapeHtml(k)}</dt><dd>${escapeHtml(v)}</dd>`);
+        continue;
+      }
+      if (Array.isArray(v)) {
+        // Array-of-string keeps the existing inline shape. An
+        // unknown array-of-object surface falls through to a nested
+        // disclosure so it stays legible even when the schema grows
+        // a new field before this renderer knows about it.
+        if (v.every((x) => typeof x !== 'object' || x === null)) {
+          dlEntries.push(`<dt>${escapeHtml(k)}</dt><dd>${v.map((x) => `<code>${escapeHtml(typeof x === 'object' ? JSON.stringify(x) : x)}</code>`).join(', ')}</dd>`);
+        } else {
+          const items = v.map((x) => `<li><pre>${escapeHtml(JSON.stringify(x, null, 2))}</pre></li>`).join('');
+          dlEntries.push(`<dt>${escapeHtml(k)}</dt><dd><ul>${items}</ul></dd>`);
+        }
+        continue;
+      }
+      dlEntries.push(`<dt>${escapeHtml(k)}</dt><dd><pre>${escapeHtml(JSON.stringify(v, null, 2))}</pre></dd>`);
+    }
+    const dl = dlEntries.length > 0 ? `<dl>${dlEntries.join('\n')}</dl>` : '';
+    const structured = structuredBlocks.join('\n');
+    out.push(`<section class="field-list"><h4>${escapeHtml(label)}</h4>${dl}${structured}</section>`);
   }
   return out.join('\n');
 }
+
+function prettyStructuredLabel(key) {
+  const map = {
+    dataStores: 'Data stores',
+    coreEntities: 'Core entities',
+    externalSystems: 'External systems',
+  };
+  return map[key] ?? key;
+}

package/src/view/style.css

@@ -294,6 +294,11 @@ article.doc h5 { margin: 0.6rem 0 0.3rem; font-size: 0.925rem; font-weight: 600;
 .field-list ul li { margin: 0.2rem 0; }
 .field-list dl dt { font-weight: 600; margin-top: 0.5rem; color: var(--colour-heading); }
 .field-list dl dd { margin-left: 0; margin-bottom: 0.35rem; }
+/* 0.28.2 (issue #235): structured TAD fields render as a table. */
+.field-list table.field-table { border-collapse: collapse; width: 100%; margin: 0.35rem 0 0.85rem; font-size: 0.95em; }
+.field-list table.field-table th, .field-list table.field-table td { text-align: left; padding: 0.35rem 0.55rem; border-bottom: 1px solid var(--colour-rule, rgba(0,0,0,0.12)); vertical-align: top; }
+.field-list table.field-table th { font-weight: 600; color: var(--colour-heading); background: var(--colour-tint, rgba(0,0,0,0.03)); }
+.field-list table.field-table tr:last-child td { border-bottom: 0; }
 
 /* --------------------------------------------------------------------
  * Acceptance criteria list (inside a US)