rayzee 8.7.0 → 8.8.1

package/src/managers/LightManager.js

@@ -17,6 +17,7 @@ export class LightManager extends EventDispatcher {
 	 * @param {import('../Stages/PathTracer.js').PathTracer} pathTracer
 	 * @param {Object} [options]
 	 * @param {Function} [options.onReset] - Callback to reset accumulation after light changes
+	 * @param {Function} [options.onLightRemoved] - Called with each light before it leaves the scene
 	 */
 	constructor( scene, sceneHelpers, pathTracer, options = {} ) {
 
@@ -26,6 +27,7 @@ export class LightManager extends EventDispatcher {
 		this.sceneHelpers = sceneHelpers;
 		this.pathTracer = pathTracer;
 		this._onReset = options.onReset || null;
+		this._onLightRemoved = options.onLightRemoved || null;
 
 	}
 
@@ -108,6 +110,7 @@ export class LightManager extends EventDispatcher {
 		const light = this.scene.getObjectByProperty( 'uuid', uuid );
 		if ( ! light || ! light.isLight ) return false;
 
+		this._onLightRemoved?.( light );
 		this.sceneHelpers.remove( light );
 		if ( light.target ) light.target.removeFromParent();
 		light.removeFromParent();
@@ -277,6 +280,7 @@ export class LightManager extends EventDispatcher {
 
 		if ( this._disposed ) return;
 		this._disposed = true;
+		this._onLightRemoved = null;
 
 		this.sceneHelpers?.clear();
 		this._removeAllLights();
@@ -296,6 +300,7 @@ export class LightManager extends EventDispatcher {
 
 		this.scene.getObjectsByProperty( 'isLight', true ).forEach( light => {
 
+			this._onLightRemoved?.( light );
 			if ( light.target ) this.scene.remove( light.target );
 			this.scene.remove( light );
 

package/src/managers/TransformManager.js

@@ -77,20 +77,7 @@ export class TransformManager {
 		// rotate mode starts from the true current direction instead of identity.
 		if ( object.isLight && object.target ) {
 
-			const forward = object.target.position.clone().sub( object.position );
-			const distance = forward.length();
-
-			if ( distance > 1e-4 ) {
-
-				object.quaternion.setFromUnitVectors( FORWARD, forward.normalize() );
-				this._lightTargetDistance = distance;
-
-			} else {
-
-				this._lightTargetDistance = 1;
-
-			}
-
+			this._syncLightAim( object );
 			this._lastLightPosition = object.position.clone();
 
 		}
@@ -233,9 +220,11 @@ export class TransformManager {
 
 	/**
 	 * Called every gizmo move while a light is attached. Translate mode carries
-	 * `.target` along by the same delta (so moving a light doesn't silently
-	 * swing its aim); rotate mode recomputes `.target` from the light's
-	 * quaternion at a fixed distance (so rotating actually steers the beam/sun).
+	 * a spot light's `.target` along by the same delta (so moving it doesn't
+	 * silently swing its aim) but leaves a sun's in place: a sun is only a
+	 * direction, so moving it must swing that, as the Lights panel's Position
+	 * does. Rotate mode recomputes `.target` from the light's quaternion at a
+	 * fixed distance (so rotating actually steers the beam/sun).
 	 * Also resyncs GPU light buffers + the visible SceneHelpers gizmo live.
 	 */
 	_syncLightDuringDrag() {
@@ -246,7 +235,7 @@ export class TransformManager {
 
 			const mode = this._controls.mode;
 
-			if ( mode === 'translate' && this._lastLightPosition ) {
+			if ( mode === 'translate' && this._lastLightPosition && ! light.isDirectionalLight ) {
 
 				const delta = this._tempForward.copy( light.position ).sub( this._lastLightPosition );
 				light.target.position.add( delta );
@@ -271,13 +260,20 @@ export class TransformManager {
 	/**
 	 * Called once on drag end while a light is attached. Bakes RectAreaLight
 	 * scale into width/height (the serializer also reads scale live, but the
-	 * Lights panel sliders are the source of truth for size) and does a final
-	 * GPU/helper resync.
+	 * Lights panel sliders are the source of truth for size), re-aims a moved
+	 * sun's quaternion so rotate mode starts from its new direction, and does a
+	 * final GPU/helper resync.
 	 */
 	_finalizeLightTransform() {
 
 		const light = this._attached;
 
+		if ( light.isDirectionalLight && light.target && this._controls.mode === 'translate' ) {
+
+			this._syncLightAim( light );
+
+		}
+
 		if ( light.isRectAreaLight && ( light.scale.x !== 1 || light.scale.y !== 1 ) ) {
 
 			light.width *= light.scale.x;
@@ -290,6 +286,28 @@ export class TransformManager {
 
 	}
 
+	/**
+	 * Point the light's quaternion at its `.target` and record the distance, so
+	 * rotate mode steers from the true current direction instead of identity.
+	 */
+	_syncLightAim( light ) {
+
+		const forward = this._tempForward.copy( light.target.position ).sub( light.position );
+		const distance = forward.length();
+
+		if ( distance > 1e-4 ) {
+
+			light.quaternion.setFromUnitVectors( FORWARD, forward.normalize() );
+			this._lightTargetDistance = distance;
+
+		} else {
+
+			this._lightTargetDistance = 1;
+
+		}
+
+	}
+
 	// ── Position Extraction & BVH Refit ──
 
 	/**