rayzee 7.20.3 → 7.21.0

package/src/Stages/EdgeFilter.js

@@ -73,6 +73,8 @@ export class EdgeFilter extends RenderStage {
 
 		this.stepSizeU = uniform( 1, 'int' );
 		this.isLastIterationU = uniform( 0, 'int' );
+		// 1 on pass 0 → seed variance from variance:output; later passes read the carried value.
+		this.isFirstIterationU = uniform( 1, 'int' );
 		this.resW = uniform( options.width || 1 );
 		this.resH = uniform( options.height || 1 );
 
@@ -202,6 +204,7 @@ export class EdgeFilter extends RenderStage {
 		const phiDepth = this.phiDepth;
 		const stepSize = this.stepSizeU;
 		const isLastIterationU = this.isLastIterationU;
+		const isFirstIterationU = this.isFirstIterationU;
 		const resW = this.resW;
 		const resH = this.resH;
 
@@ -216,7 +219,8 @@ export class EdgeFilter extends RenderStage {
 
 				const coord = ivec2( gx, gy );
 
-				const centerLighting = textureLoad( readTex, coord ).xyz;
+				const centerSample = textureLoad( readTex, coord );
+				const centerLighting = centerSample.xyz;
 				const centerLum = luminance( centerLighting );
 				const centerND = textureLoad( ndTex, coord );
 				const centerDepth = centerND.w;
@@ -233,13 +237,30 @@ export class EdgeFilter extends RenderStage {
 				// max() falls back to the spatial estimate as temporal collapses on a
 				// converging accumulation buffer. Dividing by albedoLum rescales the
 				// modulated-space variance into demodulated space (std ∝ 1/albedo).
-				const vSample = textureLoad( varTex, coord );
-				const variance = max( vSample.z, vSample.w );
-				const sigmaL = phiLuminance.mul( sqrt( max( variance, float( 0.0 ) ) ) )
+				//
+				// Filtered alongside colour and carried between passes as √variance in the
+				// ping-pong's spare alpha, so sigma_l tightens as the signal smooths. Stored as
+				// the root because converged variance (~1e-6) is a half-float subnormal.
+				const isFirst = isFirstIterationU.equal( int( 1 ) );
+				const seedVariance = ( at ) => {
+
+					const v = textureLoad( varTex, at );
+					return max( v.z, v.w );
+
+				};
+
+				const centerVariance = isFirst.select(
+					seedVariance( coord ),
+					centerSample.w.mul( centerSample.w )
+				).toVar();
+
+				const sigmaL = phiLuminance.mul( sqrt( max( centerVariance, float( 0.0 ) ) ) )
 					.div( centerAlbedoLum ).add( float( 0.0001 ) );
 
 				const colorSum = vec3( 0.0 ).toVar();
 				const weightSum = float( 0.0 ).toVar();
+				// Squared weights, normalised by weightSum² — the variance of a weighted mean.
+				const varianceSum = float( 0.0 ).toVar();
 
 				for ( let iy = 0; iy < 5; iy ++ ) {
 
@@ -253,7 +274,8 @@ export class EdgeFilter extends RenderStage {
 						const sy = gy.add( stepSize.mul( dy ) ).clamp( int( 0 ), int( resH ).sub( 1 ) );
 						const sCoord = ivec2( sx, sy );
 
-						const sLighting = textureLoad( readTex, sCoord ).xyz;
+						const sSample = textureLoad( readTex, sCoord );
+						const sLighting = sSample.xyz;
 						const sLum = luminance( sLighting );
 						const sND = textureLoad( ndTex, sCoord );
 						const sDepth = sND.w;
@@ -276,14 +298,22 @@ export class EdgeFilter extends RenderStage {
 						const geomW = mix( float( 1.0 ), normW.mul( depW ), bothHit );
 						const w = float( kw ).mul( lumW ).mul( geomW ).mul( sameKind );
 
+						const sVariance = isFirst.select(
+							seedVariance( sCoord ),
+							sSample.w.mul( sSample.w )
+						);
+
 						colorSum.addAssign( sLighting.mul( w ) );
 						weightSum.addAssign( w );
+						varianceSum.addAssign( w.mul( w ).mul( max( sVariance, float( 0.0 ) ) ) );
 
 					}
 
 				}
 
 				const filtered = colorSum.div( max( weightSum, float( 0.0001 ) ) );
+				const filteredVariance = varianceSum
+					.div( max( weightSum.mul( weightSum ), float( 1e-8 ) ) );
 
 				// Final pass: remodulate by albedo and blend against the raw color by
 				// filterStrength. Inner passes stay in demodulated space.
@@ -293,7 +323,14 @@ export class EdgeFilter extends RenderStage {
 				const finalModulated = mix( rawColor, remodded, filterStrength );
 				const output = isLast.select( finalModulated, filtered );
 
-				textureStore( writeStorageTex, uvec2( uint( gx ), uint( gy ) ), vec4( output, 1.0 ) ).toWriteOnly();
+				// The last pass restores the path tracer's coverage — Compositor reads .w as
+				// image alpha when transparentBackground is on.
+				const carriedAlpha = isLast.select(
+					textureLoad( colorTex, coord ).w,
+					sqrt( max( filteredVariance, float( 0.0 ) ) )
+				);
+
+				textureStore( writeStorageTex, uvec2( uint( gx ), uint( gy ) ), vec4( output, carriedAlpha ) ).toWriteOnly();
 
 			} );
 
@@ -378,6 +415,7 @@ export class EdgeFilter extends RenderStage {
 
 			this.stepSizeU.value = 1 << i;
 			this.isLastIterationU.value = ( i === this.iterations - 1 ) ? 1 : 0;
+			this.isFirstIterationU.value = i === 0 ? 1 : 0;
 			this._readTexNode.value = readTex;
 
 			this.renderer.compute( writeNode );

package/src/Stages/NormalDepth.js

@@ -122,8 +122,11 @@ export class NormalDepth extends RenderStage {
 
 		this.on( 'pipeline:reset', () => {
 
+			// _hasHistory is deliberately NOT cleared, mirroring MotionVector.reset(): the
+			// prev-frame G-buffer tracks camera motion, not accumulation, and a camera move
+			// resets accumulation every frame of a drag. Clearing it made render() overwrite
+			// prevRT with the current frame, so ASVGF's temporal gate could never reject.
 			this._dirty = true;
-			this._hasHistory = false;
 
 		} );
 
@@ -149,6 +152,8 @@ export class NormalDepth extends RenderStage {
 			this._bvhStorageNode = null;
 			this._matStorageNode = null;
 			this._dirty = true;
+			// New geometry — the previous frame describes a scene that is no longer there.
+			this._hasHistory = false;
 
 		}
 
@@ -367,13 +372,16 @@ export class NormalDepth extends RenderStage {
 		this._outputStorageTex?.dispose();
 		this._shadingStorageTex?.dispose();
 		this.reset();
+		// The textures backing the ping-pong are gone, so the prev-frame G-buffer is too.
+		this._hasHistory = false;
 
 	}
 
+	// Accumulation reset only — _hasHistory survives on purpose (see the pipeline:reset
+	// listener). It is invalidated by setSize(), a geometry swap, and releaseGPUMemory().
 	reset() {
 
 		this._dirty = true;
-		this._hasHistory = false;
 
 	}
 

package/src/Stages/PathTracer.js

@@ -272,6 +272,7 @@ export class PathTracer extends PathTracerStage {
 
 		this._updateAccumulationUniforms( frameValue, renderMode );
 		this.frame.value = frameValue;
+		this.seedFrame.value = this._seedTick ++;
 
 		this._setWfDispatch();
 
@@ -942,7 +943,9 @@ export class PathTracer extends PathTracerStage {
 			rngBufferRW: pb.rngBuffer.rw,
 			gBufferRW,
 			resolution: this.resolution,
-			frame: this.frame,
+			// RNG axis only (baseSeed + stratified jitter) — takes the seed counter, not the
+			// accumulation index. FinalWrite keeps `frame`.
+			frame: this.seedFrame,
 			cameraWorldMatrix: this.cameraWorldMatrix,
 			cameraProjectionMatrixInverse: this.cameraProjectionMatrixInverse,
 			enableDOF: this.enableDOF,
@@ -1180,7 +1183,6 @@ export class PathTracer extends PathTracerStage {
 			environmentIntensity: this.environmentIntensity,
 			envMatrix: this.environmentMatrix,
 			enableEnvironmentLight: this.enableEnvironment,
-			useEnvMapIS: this.useEnvMapIS,
 			groundProjectionEnabled: this.groundProjectionEnabled,
 			groundProjectionRadius: this.groundProjectionRadius,
 			groundProjectionHeight: this.groundProjectionHeight,
@@ -1210,7 +1212,9 @@ export class PathTracer extends PathTracerStage {
 			cameraProjectionMatrix: this.cameraProjectionMatrix,
 			cameraViewMatrix: this.cameraViewMatrix,
 			fireflyThreshold: this.fireflyThreshold,
-			frame: this.frame,
+			// RNG axis only (keys STBN via frame & 63).
+			frame: this.seedFrame,
+			accumFrame: this.frame,
 			resolution: this.resolution,
 			emissiveTriangleCount: this.emissiveTriangleCount,
 			emissiveVec4Offset: this.emissiveVec4Offset,

package/src/Stages/PathTracerStage.js

@@ -51,7 +51,6 @@ const BVH_VEC4_PER_NODE = 4;
  * - camera:moved - When camera position/orientation changes
  * - asvgf:reset - Request ASVGF to reset temporal data
  * - asvgf:updateParameters - Update ASVGF parameters
- * - asvgf:setTemporal - Enable/disable ASVGF temporal accumulation
  *
  * Textures published to context:
  * - pathtracer:color - Main color output
@@ -143,6 +142,11 @@ export class PathTracerStage extends RenderStage {
 		this.lastCameraMatrix = new Matrix4();
 		this.lastProjectionMatrix = new Matrix4();
 
+		// Sampler seed axis — advances per rendered frame, survives accumulation resets.
+		// Pinned back to the accumulation index in deterministic mode.
+		this._seedTick = 0;
+		this._pinSeedToFrame = false;
+
 		// Denoising management state
 		this.lastRenderMode = - 1;
 		this.renderModeChangeTimeout = null;
@@ -293,18 +297,6 @@ export class PathTracerStage extends RenderStage {
 
 					}
 				},
-				useEnvMapIS: {
-					get value() {
-
-						return self.useEnvMapIS.value;
-
-					},
-					set value( v ) {
-
-						self.useEnvMapIS.value = v;
-
-					}
-				},
 				enableAccumulation: {
 					get value() {
 
@@ -348,7 +340,6 @@ export class PathTracerStage extends RenderStage {
 			enabled: DEFAULT_STATE.interactionModeEnabled,
 			qualitySettings: {
 				maxBounceCount: 1,
-				useEnvMapIS: false,
 				enableAccumulation: false,
 				enableEmissiveTriangleSampling: false,
 			},
@@ -651,10 +642,14 @@ export class PathTracerStage extends RenderStage {
 		this.isComplete = false;
 		this.performanceMonitor?.reset();
 
-		this.lastRenderMode = - 1;
-
+		// lastRenderMode is deliberately NOT invalidated here — clearing it made
+		// manageASVGFForRenderMode see a phantom mode change 50 ms after every reset, wiping
+		// ASVGF's history. A real mode change is still caught by the renderMode comparison.
 		this.lastInteractionModeState = false;
 
+		// Only deterministic mode rewinds the seed axis; see _pinSeedToFrame.
+		if ( this._pinSeedToFrame ) this._seedTick = 0;
+
 	}
 
 	/**
@@ -1238,7 +1233,10 @@ export class PathTracerStage extends RenderStage {
 				if ( this.pendingRenderMode !== null && this.pendingRenderMode !== this.lastRenderMode ) {
 
 					this.lastRenderMode = this.pendingRenderMode;
-					this._onRenderModeChanged( this.pendingRenderMode );
+					// History from the previous mode is not comparable. temporalAlpha is NOT
+					// touched here — it is owned by ASVGF_QUALITY_PRESETS, and overwriting it
+					// with a hardcoded value meant `medium` and `high` never took effect.
+					this.emit( 'asvgf:reset' );
 
 				}
 
@@ -1249,35 +1247,6 @@ export class PathTracerStage extends RenderStage {
 
 		}
 
-		this._handleFullQuadASVGF();
-
-	}
-
-	_onRenderModeChanged( newMode ) {
-
-		if ( newMode === 1 ) {
-
-			this.emit( 'asvgf:updateParameters', {
-				enableDebug: false,
-				temporalAlpha: 0.15
-			} );
-
-		} else {
-
-			this.emit( 'asvgf:updateParameters', {
-				temporalAlpha: 0.1,
-			} );
-
-		}
-
-		this.emit( 'asvgf:reset' );
-
-	}
-
-	_handleFullQuadASVGF() {
-
-		this.emit( 'asvgf:setTemporal', { enabled: true } );
-
 	}
 
 	// ===== UNIFORM & DATA SETTERS =====

package/src/TSL/Common.js

@@ -1,10 +1,9 @@
-import { Fn, wgslFn, float, vec2, vec3, vec4, int, mat3, If, max, dot, clamp, bool as tslBool } from 'three/tsl';
+import { Fn, wgslFn, float, vec2, vec3, vec4, int, mat3, If, max, dot, clamp } from 'three/tsl';
 
 import {
 	AnisoFrame,
 	DotProducts,
 	MaterialClassification,
-	MISStrategy,
 	RayTracingMaterial,
 	ShadowMaterial,
 } from './Struct.js';
@@ -299,51 +298,6 @@ export const classifyMaterial = Fn( ( [ metalness, roughness, transmission, clea
 
 } );
 
-// Dynamic MIS strategy based on material properties
-export const selectOptimalMISStrategy = Fn( ( [ roughness, metalness, bounceIndex, throughput ] ) => {
-
-	const throughputStrength = maxComponent( { v: throughput } ).toVar();
-
-	// Environment is now handled via deterministic NEE — not part of stochastic selection.
-	// Only lights and BRDF are stochastically selected.
-	const brdfWeight = float( 0.5 ).toVar();
-	const lightWeight = float( 0.5 ).toVar();
-	const useBRDFSampling = tslBool( true );
-	const useLightSampling = throughputStrength.greaterThan( 0.01 );
-
-	If( roughness.lessThan( 0.1 ).and( metalness.greaterThan( 0.8 ) ), () => {
-
-		// Highly specular materials — favor BRDF
-		brdfWeight.assign( 0.7 );
-		lightWeight.assign( 0.3 );
-
-	} ).ElseIf( roughness.greaterThan( 0.7 ), () => {
-
-		// Diffuse materials — favor light sampling
-		brdfWeight.assign( 0.4 );
-		lightWeight.assign( 0.6 );
-
-	} );
-
-	// Gentle adjustment for very deep bounces — shift toward BRDF
-	If( bounceIndex.greaterThan( int( 5 ) ), () => {
-
-		brdfWeight.assign( 0.6 );
-		lightWeight.assign( 0.4 );
-
-	} );
-
-	return MISStrategy( {
-		brdfWeight,
-		lightWeight,
-		envWeight: float( 0.0 ),
-		useBRDFSampling,
-		useLightSampling,
-		useEnvSampling: tslBool( false ),
-	} );
-
-} );
-
 // Storage buffer access — flat 1D indexing (WebGPU native)
 // No 2D coordinate math needed: directly indexes into the buffer
 export const getDatafromStorageBuffer = Fn( ( [ buffer, stride, sampleIndex, dataOffset ] ) => {

package/src/TSL/EmissiveSampling.js

@@ -545,61 +545,57 @@ export const calculateEmissiveTriangleContributionDebug = Fn( ( [
 		distance: float( 0.0 ),
 	} ).toVar();
 
-	// Skip for very rough diffuse surfaces on secondary bounces
-	const skip = bounceIndex.greaterThan( int( 1 ) ).and( material.roughness.greaterThan( 0.9 ) ).and( material.metalness.lessThan( 0.1 ) );
+	// No rough-diffuse secondary-bounce skip: dropping NEE while the emissive-hit MIS still
+	// down-weights BSDF hits deletes emitter energy from deep GI.
 
-	If( skip.not(), () => {
-
-		// Sample emissive triangle (CDF importance-weighted)
-		const emissiveSample = EmissiveSample.wrap( sampleEmissiveTriangle(
-			hitPoint, normal, rngState,
-			pixelCoord, resolution, frame, dimBase,
-			emissiveTriangleBuffer, emissiveVec4Offset, emissiveTriangleCount, emissiveTotalPower,
-			triangleBuffer,
-		) );
-
-		If( emissiveSample.valid.and( emissiveSample.pdf.greaterThan( 0.0 ) ), () => {
+	// Sample emissive triangle (CDF importance-weighted)
+	const emissiveSample = EmissiveSample.wrap( sampleEmissiveTriangle(
+		hitPoint, normal, rngState,
+		pixelCoord, resolution, frame, dimBase,
+		emissiveTriangleBuffer, emissiveVec4Offset, emissiveTriangleCount, emissiveTotalPower,
+		triangleBuffer,
+	) );
 
-			result.hasEmissive.assign( true );
-			result.emissionOnly.assign( emissiveSample.emission );
-			result.distance.assign( emissiveSample.distance );
+	If( emissiveSample.valid.and( emissiveSample.pdf.greaterThan( 0.0 ) ), () => {
 
-			// Check geometric validity
-			const NoL = max( float( 0.0 ), dot( normal, emissiveSample.direction ) );
+		result.hasEmissive.assign( true );
+		result.emissionOnly.assign( emissiveSample.emission );
+		result.distance.assign( emissiveSample.distance );
 
-			If( NoL.greaterThan( 0.0 ), () => {
+		// Check geometric validity
+		const NoL = max( float( 0.0 ), dot( normal, emissiveSample.direction ) );
 
-				// Calculate ray offset for shadow ray
-				const rayOffset = calculateRayOffsetFn( hitPoint, normal, material );
-				const rayOrigin = hitPoint.add( rayOffset );
+		If( NoL.greaterThan( 0.0 ), () => {
 
-				// Trace shadow ray
-				const shadowDist = emissiveSample.distance.sub( 0.001 );
-				const visibility = traceShadowRayFn( rayOrigin, emissiveSample.direction, shadowDist );
+			// Calculate ray offset for shadow ray
+			const rayOffset = calculateRayOffsetFn( hitPoint, normal, material );
+			const rayOrigin = hitPoint.add( rayOffset );
 
-				If( visibility.greaterThan( 0.0 ), () => {
+			// Trace shadow ray
+			const shadowDist = emissiveSample.distance.sub( 0.001 );
+			const visibility = traceShadowRayFn( rayOrigin, emissiveSample.direction, shadowDist );
 
-					// Share H + dot products between BRDF eval and PDF (computeDotProducts
-					// would otherwise run twice with identical inputs).
-					const dots = DotProducts.wrap( computeDotProductsAniso( normal, viewDir, emissiveSample.direction, material ) );
-					const brdfValue = evaluateMaterialResponseFromDots( material, dots );
-					const brdfPdf = calculateMaterialPDFFromDots( material, dots );
+			If( visibility.greaterThan( 0.0 ), () => {
 
-					// MIS weight: balance light sampling vs BRDF sampling
-					const misWeight = select(
-						brdfPdf.greaterThan( 0.0 ),
-						powerHeuristic( { pdf1: emissiveSample.pdf, pdf2: brdfPdf } ),
-						float( 1.0 )
-					);
+				// Share H + dot products between BRDF eval and PDF (computeDotProducts
+				// would otherwise run twice with identical inputs).
+				const dots = DotProducts.wrap( computeDotProductsAniso( normal, viewDir, emissiveSample.direction, material ) );
+				const brdfValue = evaluateMaterialResponseFromDots( material, dots );
+				const brdfPdf = calculateMaterialPDFFromDots( material, dots );
 
-					// MC estimator: Le * brdf * cos_surface / pdf_solidAngle
-					// emissiveBoost is an additional user-controlled intensity multiplier
-					result.contribution.assign(
-						emissiveSample.emission.mul( brdfValue ).mul( NoL )
-							.div( emissiveSample.pdf ).mul( visibility ).mul( emissiveBoost ).mul( misWeight )
-					);
+				// MIS weight: balance light sampling vs BRDF sampling
+				const misWeight = select(
+					brdfPdf.greaterThan( 0.0 ),
+					powerHeuristic( { pdf1: emissiveSample.pdf, pdf2: brdfPdf } ),
+					float( 1.0 )
+				);
 
-				} );
+				// MC estimator: Le * brdf * cos_surface / pdf_solidAngle
+				// emissiveBoost is an additional user-controlled intensity multiplier
+				result.contribution.assign(
+					emissiveSample.emission.mul( brdfValue ).mul( NoL )
+						.div( emissiveSample.pdf ).mul( visibility ).mul( emissiveBoost ).mul( misWeight )
+				);
 
 			} );
 

package/src/TSL/LightsCore.js

@@ -83,6 +83,9 @@ export const LightSample = struct( {
 	distance: 'float',
 	lightType: 'int',
 	valid: 'bool',
+	// Reservoir denominator, carried out so the BSDF-hit MIS partner can rebuild the
+	// selection pdf without walking every light buffer a second time.
+	selectionTotalWeight: 'float',
 } );
 
 export const IndirectLightingResult = struct( {

package/src/TSL/LightsDirect.js

@@ -74,7 +74,7 @@ export const traceShadowRay = Fn( ( [
 	const rayOrigin = origin.toVar();
 	const remainingDist = float( maxDist ).toVar();
 
-	const MAX_SHADOW_TRANSMISSIONS = 8;
+	const MAX_SHADOW_TRANSMISSIONS = 16;
 
 	Loop( { start: int( 0 ), end: int( MAX_SHADOW_TRANSMISSIONS ) }, () => {
 
@@ -160,7 +160,7 @@ export const traceShadowRay = Fn( ( [
 				const blendAlpha = clamp( shadowMaterial.color.a.mul( shadowMaterial.opacity ).mul( texAlpha ), 0.0, 1.0 );
 				transmittance.mulAssign( float( 1.0 ).sub( blendAlpha ) );
 
-				If( transmittance.lessThan( 0.005 ), () => {
+				If( transmittance.lessThan( 1e-4 ), () => {
 
 					transmittance.assign( 0.0 );
 					Break();
@@ -221,7 +221,7 @@ export const traceShadowRay = Fn( ( [
 			transmittance.mulAssign( matTransmittance );
 
 			// Early exit if almost no light passes through
-			If( transmittance.lessThan( 0.005 ), () => {
+			If( transmittance.lessThan( 1e-4 ), () => {
 
 				transmittance.assign( 0.0 );
 				Break();
@@ -237,7 +237,7 @@ export const traceShadowRay = Fn( ( [
 			// Handle transparent materials
 			transmittance.mulAssign( float( 1.0 ).sub( shadowMaterial.opacity ) );
 
-			If( transmittance.lessThan( 0.005 ), () => {
+			If( transmittance.lessThan( 1e-4 ), () => {
 
 				transmittance.assign( 0.0 );
 				Break();