rawsql-ts 0.29.0 → 0.30.1

package/dist/esm/transformers/StaticPredicatePlacementOptimizer.js

@@ -1,80 +1,12 @@
-import { DistinctOn, JoinOnClause, SubQuerySource, TableSource, WhereClause } from "../models/Clause";
+import { DistinctOn, JoinOnClause, SubQuerySource, TableSource } from "../models/Clause";
 import { BinarySelectQuery, SimpleSelectQuery } from "../models/SelectQuery";
-import { ArrayExpression, ArrayQueryExpression, BetweenExpression, BinaryExpression, CaseExpression, CastExpression, ColumnReference, FunctionCall, InlineQuery, JsonPredicateExpression, ParameterExpression, ParenExpression, TupleExpression, TypeValue, UnaryExpression, ValueList } from "../models/ValueComponent";
+import { ArrayExpression, ArrayQueryExpression, BetweenExpression, BinaryExpression, CaseExpression, CastExpression, ColumnReference, FunctionCall, InlineQuery, JsonPredicateExpression, ParameterExpression, TupleExpression, TypeValue, UnaryExpression, ValueList } from "../models/ValueComponent";
 import { SelectQueryParser } from "../parsers/SelectQueryParser";
-import { ValueParser } from "../parsers/ValueParser";
 import { formatSqlComponent, hasSqlComponentFormatOverride } from "./SqlComponentFormatter";
 import { SelectOutputCollector } from "./SelectOutputCollector";
 import { dedupeTopLevelAndConditions, dedupeWhereTopLevelAndConditions } from "./TopLevelAndConditionDeduper";
+import { appendUnique, cloneColumnReference, cloneValueComponent, collectTopLevelAndTerms, columnReferenceText, identifiersEqual, normalizeIdentifier, rebuildWhereWithoutTerms, sameColumnReference, unwrapParens } from "./PredicateExpressionUtils";
 const VOLATILE_OR_UNSUPPORTED_FUNCTION_REASON = "Predicate contains a function call; volatile and expression predicates are not moved in the safe-only implementation.";
-const normalizeIdentifier = (value) => value.trim().toLowerCase();
-const isCaseSensitiveIdentifier = (value) => /[A-Z]/.test(value.trim());
-const identifiersEqual = (left, right) => {
-    const trimmedLeft = left.trim();
-    const trimmedRight = right.trim();
-    return isCaseSensitiveIdentifier(trimmedLeft) || isCaseSensitiveIdentifier(trimmedRight)
-        ? trimmedLeft === trimmedRight
-        : trimmedLeft.toLowerCase() === trimmedRight.toLowerCase();
-};
-const unwrapParens = (expression) => {
-    let candidate = expression;
-    while (candidate instanceof ParenExpression) {
-        candidate = candidate.expression;
-    }
-    return candidate;
-};
-const isBinaryOperator = (expression, operator) => {
-    const candidate = unwrapParens(expression);
-    return candidate instanceof BinaryExpression
-        && candidate.operator.value.trim().toLowerCase() === operator;
-};
-const collectTopLevelAndTerms = (expression) => {
-    const candidate = unwrapParens(expression);
-    if (!isBinaryOperator(candidate, "and")) {
-        return [expression];
-    }
-    return [
-        ...collectTopLevelAndTerms(candidate.left),
-        ...collectTopLevelAndTerms(candidate.right)
-    ];
-};
-const rebuildWhereWithoutTerms = (query, termsToRemove) => {
-    if (!query.whereClause || termsToRemove.size === 0) {
-        return;
-    }
-    const remaining = collectTopLevelAndTerms(query.whereClause.condition)
-        .filter(term => !termsToRemove.has(term));
-    if (remaining.length === 0) {
-        query.whereClause = null;
-        return;
-    }
-    let rebuilt = remaining[0];
-    for (let index = 1; index < remaining.length; index += 1) {
-        rebuilt = new BinaryExpression(rebuilt, "and", remaining[index]);
-    }
-    query.whereClause = new WhereClause(rebuilt);
-};
-const cloneValueComponent = (expression, options) => {
-    return ValueParser.parse(formatSqlComponent(expression, options));
-};
-const cloneColumnReference = (reference) => {
-    var _a, _b;
-    const namespaces = (_b = (_a = reference.namespaces) === null || _a === void 0 ? void 0 : _a.map(namespace => namespace.name)) !== null && _b !== void 0 ? _b : null;
-    return new ColumnReference(namespaces, reference.column.name);
-};
-const columnReferenceText = (reference) => {
-    const namespace = reference.getNamespace();
-    return namespace ? `${namespace}.${reference.column.name}` : reference.column.name;
-};
-const sameColumnReference = (left, right) => {
-    return identifiersEqual(left.column.name, right.column.name)
-        && identifiersEqual(left.getNamespace(), right.getNamespace());
-};
-const appendUnique = (items, value) => {
-    if (!items.includes(value)) {
-        items.push(value);
-    }
-};
 export class StaticPredicatePlacementOptimizer {
     plan(input, options = {}) {
         var _a, _b, _c;
@@ -112,77 +44,8 @@ export class StaticPredicatePlacementOptimizer {
         const query = parsed.query;
         const applied = [];
         const skipped = [];
-        const movedTerms = [];
-        for (const term of query.whereClause ? collectTopLevelAndTerms(query.whereClause.condition) : []) {
-            const candidate = this.analyzeCandidate(query, term, options);
-            if (!candidate) {
-                continue;
-            }
-            if ("code" in candidate) {
-                skipped.push(this.makeSkipped(term, candidate, options));
-                continue;
-            }
-            const target = this.resolveTarget(query, candidate);
-            if ("code" in target) {
-                skipped.push(this.makeSkipped(term, target, options));
-                continue;
-            }
-            let appliedReason = "";
-            if (target.kind === "join_on") {
-                this.appendJoinOnPredicate(target.join, candidate.expression, options);
-                appliedReason = target.reason;
-            }
-            else if (target.kind === "simple") {
-                const targetColumns = this.resolveTargetColumns(query, target.query, candidate.references);
-                if ("code" in targetColumns) {
-                    skipped.push(this.makeSkipped(term, targetColumns, options));
-                    continue;
-                }
-                const placement = this.resolveTargetPlacement(target.query, targetColumns);
-                if ("code" in placement) {
-                    skipped.push(this.makeSkipped(term, placement, options));
-                    continue;
-                }
-                const movedPredicate = this.rebasePredicate(candidate.expression, targetColumns, options);
-                target.query.appendWhere(movedPredicate);
-                dedupeWhereTopLevelAndConditions(target.query, options);
-                appliedReason = placement.reason;
-            }
-            else {
-                const placements = [];
-                let skip = null;
-                for (const branch of target.branches) {
-                    const placement = this.resolveTargetPlacement(branch.query, branch.targetColumns);
-                    if ("code" in placement) {
-                        skip = placement;
-                        break;
-                    }
-                    placements.push(placement);
-                }
-                if (skip) {
-                    skipped.push(this.makeSkipped(term, skip, options));
-                    continue;
-                }
-                for (const branch of target.branches) {
-                    const movedPredicate = this.rebasePredicate(candidate.expression, branch.targetColumns, options);
-                    branch.query.appendWhere(movedPredicate);
-                    dedupeWhereTopLevelAndConditions(branch.query, options);
-                }
-                appliedReason = placements.some(item => /group by/i.test(item.reason))
-                    ? "Predicate is distributed to every UNION branch by output column position; grouped branches only receive GROUP BY-key predicates."
-                    : "Predicate is distributed to every UNION branch by output column position before unsafe query boundaries.";
-            }
-            movedTerms.push(term);
-            applied.push({
-                kind: "move_static_predicate",
-                predicateSql: candidate.predicateSql,
-                fromScopeId: "scope:root",
-                toScopeId: target.scopeId,
-                reason: appliedReason,
-                columnReferences: candidate.references.map(columnReferenceText)
-            });
-        }
-        rebuildWhereWithoutTerms(query, new Set(movedTerms));
+        this.placePredicatesInScopes(query, options, applied, skipped);
+        // API output shape review: keep result.sql/result.query compatibility while expanding scope-aware placement.
         const sql = applied.length > 0 || hasSqlComponentFormatOverride(options)
             ? formatSqlComponent(query, options)
             : parsed.sql;
@@ -197,6 +60,121 @@ export class StaticPredicatePlacementOptimizer {
             formatterGeneratedSource: parsed.formatterGeneratedSource
         });
     }
+    placePredicatesInScopes(contextRoot, options, applied, skipped) {
+        var _a;
+        const queue = [{ query: contextRoot, scopeId: "scope:root" }];
+        let processed = 0;
+        while (queue.length > 0) {
+            processed += 1;
+            if (processed > 1000) {
+                skipped.push({
+                    predicateSql: "",
+                    scopeId: "scope:root",
+                    code: "RECURSIVE_PLACEMENT_LIMIT",
+                    reason: "Static predicate recursive placement stopped after reaching the safety iteration limit."
+                });
+                return;
+            }
+            const work = queue.shift();
+            const movedTerms = [];
+            const reportSkipped = work.pendingTerms === undefined;
+            const terms = (_a = work.pendingTerms) !== null && _a !== void 0 ? _a : (work.query.whereClause
+                ? collectTopLevelAndTerms(work.query.whereClause.condition)
+                : []);
+            for (const term of terms) {
+                const candidate = this.analyzeCandidate(work.query, term, options);
+                if (!candidate) {
+                    continue;
+                }
+                if ("code" in candidate) {
+                    if (reportSkipped) {
+                        skipped.push(this.makeSkipped(term, work.scopeId, candidate, options));
+                    }
+                    continue;
+                }
+                const target = this.resolveTarget(contextRoot, work.query, candidate);
+                if ("code" in target) {
+                    if (reportSkipped) {
+                        skipped.push(this.makeSkipped(term, work.scopeId, target, options));
+                    }
+                    continue;
+                }
+                let appliedReason = "";
+                if (target.kind === "join_on") {
+                    this.appendJoinOnPredicate(target.join, candidate.expression, options);
+                    appliedReason = target.reason;
+                }
+                else if (target.kind === "simple") {
+                    const targetColumns = this.resolveTargetColumns(contextRoot, target.query, candidate.references);
+                    if ("code" in targetColumns) {
+                        if (reportSkipped) {
+                            skipped.push(this.makeSkipped(term, work.scopeId, targetColumns, options));
+                        }
+                        continue;
+                    }
+                    const placement = this.resolveTargetPlacement(contextRoot, target.query, targetColumns);
+                    if ("code" in placement) {
+                        if (reportSkipped) {
+                            skipped.push(this.makeSkipped(term, work.scopeId, placement, options));
+                        }
+                        continue;
+                    }
+                    const movedPredicate = this.rebasePredicate(candidate.expression, targetColumns, options);
+                    target.query.appendWhere(movedPredicate);
+                    dedupeWhereTopLevelAndConditions(target.query, options);
+                    appliedReason = work.scopeId === "scope:root"
+                        ? placement.reason
+                        : `${placement.reason} Predicate was safely rebased from a previously moved predicate.`;
+                    const retainedTerms = target.query.whereClause
+                        ? collectTopLevelAndTerms(target.query.whereClause.condition)
+                        : [];
+                    if (retainedTerms.includes(movedPredicate)) {
+                        queue.push({
+                            query: target.query,
+                            scopeId: target.scopeId,
+                            pendingTerms: [movedPredicate]
+                        });
+                    }
+                }
+                else {
+                    const placements = [];
+                    let skip = null;
+                    for (const branch of target.branches) {
+                        const placement = this.resolveTargetPlacement(contextRoot, branch.query, branch.targetColumns);
+                        if ("code" in placement) {
+                            skip = placement;
+                            break;
+                        }
+                        placements.push(placement);
+                    }
+                    if (skip) {
+                        if (reportSkipped) {
+                            skipped.push(this.makeSkipped(term, work.scopeId, skip, options));
+                        }
+                        continue;
+                    }
+                    for (const branch of target.branches) {
+                        const movedPredicate = this.rebasePredicate(candidate.expression, branch.targetColumns, options);
+                        branch.query.appendWhere(movedPredicate);
+                        dedupeWhereTopLevelAndConditions(branch.query, options);
+                    }
+                    appliedReason = placements.some(item => /group by/i.test(item.reason))
+                        ? "Predicate is distributed to every UNION branch by output column position; grouped branches only receive GROUP BY-key predicates."
+                        : "Predicate is distributed to every UNION branch by output column position before unsafe query boundaries.";
+                }
+                movedTerms.push(term);
+                applied.push({
+                    kind: "move_static_predicate",
+                    predicateSql: candidate.predicateSql,
+                    fromScopeId: work.scopeId,
+                    toScopeId: target.scopeId,
+                    reason: appliedReason,
+                    columnReferences: candidate.references.map(columnReferenceText)
+                });
+            }
+            rebuildWhereWithoutTerms(work.query, new Set(movedTerms));
+        }
+    }
     optimize(input, options = {}) {
         var _a;
         return this.plan(input, Object.assign(Object.assign({}, options), { dryRun: (_a = options.dryRun) !== null && _a !== void 0 ? _a : false }));
@@ -392,13 +370,13 @@ export class StaticPredicatePlacementOptimizer {
         visit(expression);
         return found;
     }
-    resolveTarget(root, candidate) {
+    resolveTarget(contextRoot, currentQuery, candidate) {
         var _a;
-        const boundary = this.findRootQueryBoundary(root);
+        const boundary = this.findRootQueryBoundary(currentQuery);
         if (boundary) {
             return boundary;
         }
-        if (!root.fromClause) {
+        if (!currentQuery.fromClause) {
             return {
                 code: "NO_FROM_CLAUSE",
                 reason: "Predicate has no FROM source that can receive it safely."
@@ -406,7 +384,7 @@ export class StaticPredicatePlacementOptimizer {
         }
         const bindings = [];
         for (const reference of candidate.references) {
-            const binding = this.resolveSourceBinding(root, root, reference);
+            const binding = this.resolveSourceBinding(contextRoot, currentQuery, reference);
             if ("code" in binding) {
                 return binding;
             }
@@ -427,14 +405,14 @@ export class StaticPredicatePlacementOptimizer {
                 reason: "Predicate crosses a LATERAL JOIN boundary; moving it may change semantics."
             };
         }
-        const nullableSide = this.findNullableSideBoundary(root.fromClause, binding);
+        const nullableSide = this.findNullableSideBoundary(currentQuery.fromClause, binding);
         if (nullableSide) {
             return nullableSide;
         }
-        const upstream = this.resolveUpstreamQuery(root, binding, candidate.references);
+        const upstream = this.resolveUpstreamQuery(contextRoot, binding, candidate.references);
         if ("code" in upstream) {
             if (upstream.code === "NO_SAFE_UPSTREAM_QUERY") {
-                const joinOnTarget = this.resolveBaseTableJoinOnTarget(root, binding);
+                const joinOnTarget = this.resolveBaseTableJoinOnTarget(contextRoot, currentQuery, binding);
                 if (!("code" in joinOnTarget)) {
                     return joinOnTarget;
                 }
@@ -459,7 +437,7 @@ export class StaticPredicatePlacementOptimizer {
         }
         return null;
     }
-    resolveTargetPlacement(query, targetColumns) {
+    resolveTargetPlacement(contextRoot, query, targetColumns) {
         const hasOrdinaryDistinct = this.hasOrdinaryDistinct(query);
         if (this.hasDistinctOnBoundary(query)) {
             return {
@@ -479,11 +457,11 @@ export class StaticPredicatePlacementOptimizer {
                 reason: "Predicate crosses LIMIT/OFFSET/FETCH boundary; moving it may change row selection semantics."
             };
         }
-        if (query.fromClause && this.hasOuterJoin(query.fromClause)) {
-            return {
-                code: "OUTER_JOIN_BOUNDARY",
-                reason: "Target query contains an OUTER JOIN boundary that is not moved across in the safe-only implementation."
-            };
+        if (query.fromClause) {
+            const nullableSide = this.findNullableSideBoundaryForTargetColumns(contextRoot, query, targetColumns);
+            if (nullableSide) {
+                return nullableSide;
+            }
         }
         if (query.groupByClause) {
             const allReferencesAreGroupKeys = targetColumns.every(item => this.isGroupKeyColumn(query, item.targetColumn));
@@ -512,6 +490,22 @@ export class StaticPredicatePlacementOptimizer {
             reason: "All outer references resolve to direct upstream outputs before unsafe query boundaries."
         };
     }
+    findNullableSideBoundaryForTargetColumns(contextRoot, query, targetColumns) {
+        if (!query.fromClause) {
+            return null;
+        }
+        for (const item of targetColumns) {
+            const binding = this.resolveSourceBinding(contextRoot, query, item.targetColumn);
+            if ("code" in binding) {
+                return binding;
+            }
+            const nullableSide = this.findNullableSideBoundary(query.fromClause, binding);
+            if (nullableSide) {
+                return nullableSide;
+            }
+        }
+        return null;
+    }
     resolveSourceBinding(contextRoot, query, column) {
         const fromClause = query.fromClause;
         if (!fromClause) {
@@ -690,22 +684,22 @@ export class StaticPredicatePlacementOptimizer {
         }
         return resolved;
     }
-    resolveBaseTableJoinOnTarget(root, binding) {
+    resolveBaseTableJoinOnTarget(contextRoot, currentQuery, binding) {
         var _a, _b, _c;
-        if (!root.fromClause || !this.isBaseTableBinding(root, binding)) {
+        if (!currentQuery.fromClause || !this.isBaseTableBinding(contextRoot, binding)) {
             return {
                 code: "NO_SAFE_UPSTREAM_QUERY",
                 reason: "The referenced source is a base table, so there is no upstream query block to move into."
             };
         }
-        if (this.hasOuterJoin(root.fromClause)) {
+        if (this.hasOuterJoin(currentQuery.fromClause)) {
             return {
                 code: "OUTER_JOIN_BOUNDARY",
                 reason: "Predicate crosses an OUTER JOIN boundary; moving it into JOIN ON may change semantics."
             };
         }
         const join = binding.isPrimary
-            ? (_b = (_a = root.fromClause.joins) === null || _a === void 0 ? void 0 : _a[0]) !== null && _b !== void 0 ? _b : null
+            ? (_b = (_a = currentQuery.fromClause.joins) === null || _a === void 0 ? void 0 : _a[0]) !== null && _b !== void 0 ? _b : null
             : binding.join;
         if (join === null || join === void 0 ? void 0 : join.lateral) {
             return {
@@ -778,7 +772,7 @@ export class StaticPredicatePlacementOptimizer {
         if ("code" in upstreamColumns) {
             return { query, targetColumns: [...targetColumns] };
         }
-        const placement = this.resolveTargetPlacement(upstream.query, upstreamColumns);
+        const placement = this.resolveTargetPlacement(contextRoot, upstream.query, upstreamColumns);
         if ("code" in placement) {
             return { query, targetColumns: [...targetColumns] };
         }
@@ -1597,8 +1591,8 @@ export class StaticPredicatePlacementOptimizer {
         visit(expression);
         return names;
     }
-    makeSkipped(expression, draft, options) {
-        return Object.assign({ predicateSql: formatSqlComponent(expression, options), scopeId: "scope:root" }, draft);
+    makeSkipped(expression, scopeId, draft, options) {
+        return Object.assign({ predicateSql: formatSqlComponent(expression, options), scopeId }, draft);
     }
     buildResult(params) {
         return {