ravensight-playtest 0.7.0 → 0.7.5

package/src/run/gameRefusal.js

@@ -0,0 +1,57 @@
+/**
+ * Which failed actions are the game's state and which are the runner's.
+ *
+ * A web page that shows a control as disabled, hidden or not editable has
+ * refused the action itself: the click failing is what a player would see.
+ * In a real Lab Ledger run the "Run repeat panel" button stayed disabled
+ * after the page said it was ready, and the blocker the persona filed was
+ * dropped as "driver errors only" because Playwright's click timed out on
+ * a button it had found and that said `disabled`. That is evidence.
+ *
+ * A failure where the runner itself broke stays a driver error: a target
+ * that never resolved (a selector or ref problem), a browser or page that
+ * closed or crashed under the runner.
+ */
+
+/** Playwright's actionability waits that name the game's state. */
+const NOT_ACTIONABLE = /element is not (enabled|editable|visible)/i;
+
+/** The element a locator resolved to, from Playwright's call log. */
+const RESOLVED = /locator resolved to (<[^\n]*)/i;
+
+/** A resolved element whose own markup says it is disabled. */
+const RESOLVED_DISABLED = /locator resolved to <[^>]*\s(?:disabled(?:[\s=>/]|$)|aria-disabled="true")/i;
+
+/** The runner's browser, context or page went away under it. */
+const RUNNER_GONE = /Target (?:page, context or browser has been closed|crashed)|browser has (?:been )?disconnected|Browser closed|Page crashed/i;
+
+const STATE_WORDS = { enabled: 'disabled', editable: 'not editable', visible: 'hidden' };
+
+/**
+ * The game's refusal named in a failed action's error, or null when the
+ * failure is not one.
+ *
+ * @param {string} text the driver's error text (a call log may be cut short)
+ * @returns {{state: string, element: string|null}|null}
+ */
+export function gameRefusal(text) {
+  const value = String(text || '');
+  if (!value || RUNNER_GONE.test(value)) return null;
+  const resolved = value.match(RESOLVED);
+  if (!resolved) return null;
+  const element = resolved[1].trim().slice(0, 160);
+  const waited = value.match(NOT_ACTIONABLE);
+  if (waited) return { state: STATE_WORDS[waited[1].toLowerCase()], element };
+  if (RESOLVED_DISABLED.test(value)) return { state: 'disabled', element };
+  return null;
+}
+
+/**
+ * True when the error says the runner's browser or page went away.
+ *
+ * @param {string} text
+ * @returns {boolean}
+ */
+export function runnerGone(text) {
+  return RUNNER_GONE.test(String(text || ''));
+}

package/src/run/model.js

@@ -170,7 +170,24 @@ export function toProxyError(error) {
       if (key !== 'type' && key !== 'message') figures[key] = value;
     }
   }
-  return new ProxyError({ status, code, message, retryAfter, figures });
+  return new ProxyError({ status, code, message: withProviderReason(message, figures), retryAfter, figures });
+}
+
+/**
+ * The provider's own reason, when the proxy passed one on (a 400
+ * `upstream_rejected` carries `provider_type` and a cleaned
+ * `provider_message`), added to the message the developer is shown. Without
+ * it a refused body reads only "The model provider rejected this request."
+ *
+ * @param {string} message
+ * @param {Object} figures
+ * @returns {string}
+ */
+export function withProviderReason(message, figures = {}) {
+  const type = typeof figures.provider_type === 'string' ? figures.provider_type : '';
+  const reason = typeof figures.provider_message === 'string' ? figures.provider_message : '';
+  if (!type && !reason) return message;
+  return `${message} Provider said: ${[type, reason].filter(Boolean).join(': ')}`;
 }
 
 /**

package/src/run/openPr.js

@@ -85,7 +85,14 @@ export async function openPullRequest({ repoRoot, branch, paths, title: rawTitle
     ...paths.map(file => `  ${plainTitle(file)}`)
   ].join('\n');
   // `yes: false` on purpose: --yes agreed to the price, not to publishing.
-  const go = await confirm(question, { yes: false });
+  let go;
+  try { go = await confirm(question, { yes: false }); }
+  catch (error) {
+    // --yes cannot agree to publishing, so with no terminal the answer is a
+    // plain refusal, never a piped "y".
+    if (error?.code === 'no_terminal') return refuse('--open-pr asks before it pushes, and there is no terminal to ask in.');
+    throw error;
+  }
   if (!go) return refuse('Not confirmed.');
 
   const added = await call('git', ['add', '--', ...paths]);