rasti 4.1.2 → 4.1.3-alpha.0

package/README.md

@@ -1,7 +1,7 @@
 <p align="center">
     <picture>
-        <source media="(prefers-color-scheme: dark)" srcset="https://cdn.jsdelivr.net/gh/8tentaculos/rasti@v4.1.2/docs/logo-dark.svg">
-        <img alt="Rasti.js" src="https://cdn.jsdelivr.net/gh/8tentaculos/rasti@v4.1.2/docs/logo.svg" height="120">
+        <source media="(prefers-color-scheme: dark)" srcset="https://cdn.jsdelivr.net/gh/8tentaculos/rasti@v4.1.3-alpha.0/docs/logo-dark.svg">
+        <img alt="Rasti.js" src="https://cdn.jsdelivr.net/gh/8tentaculos/rasti@v4.1.3-alpha.0/docs/logo.svg" height="120">
     </picture>
 </p>
 

package/dist/rasti.js

@@ -754,6 +754,21 @@
      */
     Model.attributePrefix = '';
 
+    /**
+     * Define `key` on `target` as an own data property. Unlike an assignment, it does not go
+     * through an accessor declared on the prototype, so it shadows a getter with no setter
+     * instead of throwing.
+     * @param {object} target Object to define the property on.
+     * @param {string} key Property name.
+     * @param {any} value Property value.
+     * @return {object} The target object.
+     * @module
+     * @private
+     */
+    const defineOwn = (target, key, value) => Object.defineProperty(target, key, {
+        value, writable : true, enumerable : true, configurable : true
+    });
+
     /*
      * These option keys will be extended on the view instance.
      */
@@ -823,10 +838,11 @@
             // Mutable array to store handlers to be called on destroy.
             this.destroyQueue = [];
             this.viewOptions = [];
-            // Extend "this" with options.
+            // Extend "this" with options, as own properties so an option overrides
+            // a getter declared by a subclass instead of being assigned through it.
             viewOptions.forEach(key => {
                 if (key in options) {
-                    this[key] = options[key];
+                    defineOwn(this, key, options[key]);
                     this.viewOptions.push(key);
                 }
             });
@@ -1699,6 +1715,10 @@
 
     /**
      * Parse HTML string to a DocumentFragment.
+     *
+     * The string is parsed as written. A component's markup already reaches here
+     * without surrounding whitespace, and the content of an interpolation is the
+     * rendered value itself, whose leading and trailing whitespace is significant.
      * @param {string} html The HTML string to parse.
      * @return {DocumentFragment} The parsed DocumentFragment.
      * @module
@@ -1706,7 +1726,7 @@
      */
     function parseHTML(html) {
         const fragment = document.createElement('template');
-        fragment.innerHTML = `${html}`.trim();
+        fragment.innerHTML = `${html}`;
         return fragment.content;
     }
 
@@ -2404,10 +2424,11 @@
         constructor(options = {}) {
             super(...arguments);
             this.componentOptions = [];
-            // Extend "this" with options.
+            // Extend "this" with options, as own properties so an option overrides
+            // a getter declared by a subclass instead of being assigned through it.
             componentOptions.forEach(key => {
                 if (key in options) {
-                    this[key] = options[key];
+                    defineOwn(this, key, options[key]);
                     this.componentOptions.push(key);
                 }
             });