rascal 14.4.3 → 15.0.0

package/.eslintrc.json

@@ -0,0 +1,25 @@
+{
+  "extends": ["eslint-config-airbnb-base", "prettier"],
+  "env": {
+    "node": true
+  },
+  "parserOptions": {
+    "ecmaVersion": "2015"
+  },
+  "rules": {
+    "arrow-body-style": 0,
+    "consistent-return": 0,
+    "func-names": 0,
+    "no-param-reassign": 0,
+    "no-plusplus": 0,
+    "no-restricted-properties": 0,
+    "no-shadow": ["error", { "allow": ["cb", "err"] }],
+    "no-underscore-dangle": 0,
+    "no-unused-expressions": 0,
+    "no-unused-vars": ["error", { "varsIgnorePattern": "^debug$", "argsIgnorePattern": "^_\\w+" }],
+    "no-use-before-define": 0,
+    "prefer-destructuring": 0,
+    "prefer-exponentiation-operator": 0,
+    "prefer-rest-params": 0
+  }
+}

package/CHANGELOG.md

@@ -1,5 +1,18 @@
 # Change Log
 
+## 15.0.0
+
+- Drop support for Node 10
+- Introduce eslint-config-airbnb-base
+
+## 14.4.5
+
+- Fixed issue where a partial password could be logged in debug - See https://github.com/guidesmiths/rascal/issues/200 - thanks @matt1097
+
+## 14.4.4
+
+- Fixed issue where channels were not returned to the pool after publishing a large messag - See https://github.com/guidesmiths/rascal/issues/199
+
 ## 14.4.3
 
 - Bump dependencies

package/README.md

@@ -40,7 +40,7 @@ Rascal seeks to either solve these problems, make them easier to deal with or br
 
 ## Concepts
 
-Rascal extends the existing [RabbitMQ Concepts](https://www.rabbitmq.com/tutorials/amqp-concepts.html) of Brokers, Vhosts, Exchanges, Queues, Channels and Connections with with two new ones
+Rascal extends the existing [RabbitMQ Concepts](https://www.rabbitmq.com/tutorials/amqp-concepts.html) of Brokers, Vhosts, Exchanges, Queues, Channels and Connections with two new ones
 
 1. Publications
 1. Subscriptions

package/index.js

@@ -3,6 +3,7 @@ const defaultConfig = require('./lib/config/defaults');
 const testConfig = require('./lib/config/tests');
 const Broker = require('./lib/amqp/Broker');
 const BrokerAsPromised = require('./lib/amqp/BrokerAsPromised');
+const counters = require('./lib/counters');
 
 module.exports = (function () {
   return {
@@ -18,6 +19,6 @@ module.exports = (function () {
     withTestConfig(config) {
       return _.defaultsDeep({}, config, testConfig);
     },
-    counters: require('./lib/counters'),
+    counters,
   };
 })();

package/lib/amqp/Broker.js

@@ -8,11 +8,12 @@ const tasks = require('./tasks');
 const configure = require('../config/configure');
 const validate = require('../config/validate');
 const fqn = require('../config/fqn');
+
 const preflight = async.compose(validate, configure);
 const stub = require('../counters/stub');
 const inMemory = require('../counters/inMemory');
 const inMemoryCluster = require('../counters/inMemoryCluster').worker;
-const setTimeoutUnref = require('../utils/setTimeoutUnref');
+
 const maxInterval = 2147483647;
 
 module.exports = {
@@ -25,9 +26,9 @@ module.exports = {
       inMemoryCluster,
     });
 
-    preflight(_.cloneDeep(config), (err, config) => {
+    preflight(_.cloneDeep(config), (err, augmentedConfig) => {
       if (err) return next(err);
-      new Broker(config, _.assign({}, components, { counters }))._init(next);
+      new Broker(augmentedConfig, _.assign({}, components, { counters }))._init(next);
     });
   },
 };
@@ -141,7 +142,9 @@ function Broker(config, components) {
         },
         (err) => {
           if (err) return next(err);
-          vhosts = publications = subscriptions = {};
+          vhosts = {};
+          publications = {};
+          subscriptions = {};
           clearInterval(self.keepActive);
           debug('Finished nuking broker');
           next();
@@ -209,6 +212,7 @@ function Broker(config, components) {
     });
   };
 
+  /* eslint-disable-next-line no-multi-assign */
   this.getFullyQualifiedName = this.qualify = function (vhost, name) {
     return fqn.qualify(name, config.vhosts[vhost].namespace);
   };

package/lib/amqp/BrokerAsPromised.js

@@ -15,7 +15,7 @@ module.exports = {
           broker.promises = true;
           const brokerAsPromised = new BrokerAsPromised(broker);
           if (!err) return resolve(brokerAsPromised);
-          err.broker = Symbol();
+          err.broker = Symbol('broker-as-promised');
           Object.defineProperty(err, err.broker, {
             enumerable: false,
             value: brokerAsPromised,
@@ -80,6 +80,7 @@ function BrokerAsPromised(broker) {
     });
   };
 
+  /* eslint-disable-next-line no-multi-assign */
   this.getFullyQualifiedName = this.qualify = function (vhost, name) {
     return broker.qualify(vhost, name);
   };

package/lib/amqp/Publication.js

@@ -169,6 +169,7 @@ function addListeners(channel, errorHandler, returnHandler) {
 }
 
 function removeListeners(channel, errorHandler, returnHandler) {
+  channel.removeAllListeners('drain');
   channel.removeListener('error', errorHandler);
   channel.removeListener('return', returnHandler);
   channel.connection.removeListener('error', errorHandler);
@@ -177,37 +178,65 @@ function removeListeners(channel, errorHandler, returnHandler) {
 
 function publishToExchange(channel, content, config, next) {
   debug('Publishing %d bytes to exchange: %s with routingKeys: %s', content.length, config.exchange, _.compact([].concat(config.routingKey, config.options.CC, config.options.BCC)).join(', '));
-  const ok = channel.publish(config.destination, config.routingKey, content, config.options);
-  next(null, ok);
+
+  const fn = () => {
+    return channel.publish(config.destination, config.routingKey, content, config.options);
+  };
+
+  publishNoConfirm(fn, channel, next);
 }
 
 function publishToConfirmExchange(channel, content, config, next) {
   debug('Publishing %d bytes to confirm exchange: %s with routingKeys: %s', content.length, config.exchange, _.compact([].concat(config.routingKey, config.options.CC, config.options.BCC)).join(', '));
 
-  const once = _.once(next);
-  const timeout = config.timeout ? setConfirmationTimeout(config.timeout, config.destination, once) : null;
+  const fn = (cb) => {
+    return channel.publish(config.destination, config.routingKey, content, config.options, cb);
+  };
 
-  const ok = channel.publish(config.destination, config.routingKey, content, config.options, (err) => {
-    clearTimeout(timeout);
-    once(err, ok);
-  });
+  publishAndConfirm(fn, channel, config, next);
 }
 
 function sendToQueue(channel, content, config, next) {
   debug('Publishing %d bytes to queue: %s', content.length, config.queue);
-  const ok = channel.sendToQueue(config.destination, content, config.options);
-  next(null, ok);
+
+  const fn = () => {
+    return channel.sendToQueue(config.destination, content, config.options);
+  };
+
+  publishNoConfirm(fn, channel, next);
 }
 
 function sendToConfirmQueue(channel, content, config, next) {
   debug('Publishing %d bytes to queue: %s', content.length, config.queue);
 
+  const fn = (cb) => {
+    return channel.sendToQueue(config.destination, content, config.options, cb);
+  };
+
+  publishAndConfirm(fn, channel, config, next);
+}
+
+function publishNoConfirm(fn, channel, next) {
+  let drained = false;
+  channel.once('drain', () => {
+    drained = true;
+  });
+
+  const ok = fn();
+  next(null, ok || drained);
+}
+
+function publishAndConfirm(fn, channel, config, next) {
   const once = _.once(next);
   const timeout = config.timeout ? setConfirmationTimeout(config.timeout, config.destination, once) : null;
+  let drained = false;
+  channel.once('drain', () => {
+    drained = true;
+  });
 
-  const ok = channel.sendToQueue(config.destination, content, config.options, (err) => {
+  const ok = fn((err) => {
     clearTimeout(timeout);
-    next(err, ok);
+    next(err, ok || drained);
   });
 }
 

package/lib/amqp/SubscriberError.js

@@ -87,7 +87,7 @@ module.exports = function SubscriptionRecovery(broker, vhost) {
 
           vhost.getConfirmChannel((err, publisherChannel) => {
             const nackMessage = (err) => {
-              session._nack(message, (nackErr) => {
+              session._nack(message, (_nackErr) => {
                 // nackError just means the channel was already closed meaning the original message would have been rolled back
                 once(err);
               });
@@ -140,7 +140,7 @@ module.exports = function SubscriptionRecovery(broker, vhost) {
           _.set(forwardOverrides, 'options.headers.rascal.error.code', err.code);
 
           const nackMessage = (err) => {
-            session._nack(message, (nackErr) => {
+            session._nack(message, (_nackErr) => {
               // nackError just means the channel was already closed meaning the original message would have been rolled back
               once(err);
             });

package/lib/amqp/SubscriberSession.js

@@ -133,7 +133,7 @@ function SubscriberSession(sequentialChannelOperations, config) {
   function withCurrentChannel(fn, altFn) {
     const entry = _.chain(channels)
       .values()
-      .filter((entry) => !entry.doomed)
+      .filter((e) => !e.doomed)
       .sortBy('index')
       .last()
       .value();

package/lib/amqp/Subscription.js

@@ -1,12 +1,12 @@
 const debug = require('debug')('rascal:Subscription');
 const _ = require('lodash');
+const format = require('util').format;
+const crypto = require('crypto');
+const async = require('async');
 const safeParse = require('safe-json-parse/callback');
 const SubscriberSession = require('./SubscriberSession');
 const SubscriberError = require('./SubscriberError');
-const format = require('util').format;
 const backoff = require('../backoff');
-const crypto = require('crypto');
-const async = require('async');
 const setTimeoutUnref = require('../utils/setTimeoutUnref');
 
 module.exports = {
@@ -15,24 +15,24 @@ module.exports = {
   },
 };
 
-function Subscription(broker, vhost, config, counter) {
-  const timer = backoff(config.retry);
+function Subscription(broker, vhost, subscriptionConfig, counter) {
+  const timer = backoff(subscriptionConfig.retry);
   const subscriberError = new SubscriberError(broker, vhost);
   const sequentialChannelOperations = async.queue((task, next) => {
     task(next);
   }, 1);
   const self = this;
 
-  this.name = config.name;
+  this.name = subscriptionConfig.name;
 
   this.init = function (next) {
-    debug('Initialising subscription: %s', config.name);
+    debug('Initialising subscription: %s', subscriptionConfig.name);
     return next(null, self);
   };
 
   this.subscribe = function (overrides, next) {
-    const session = new SubscriberSession(sequentialChannelOperations, config);
-    subscribeLater(session, _.defaultsDeep(overrides, config));
+    const session = new SubscriberSession(sequentialChannelOperations, subscriptionConfig);
+    subscribeLater(session, _.defaultsDeep(overrides, subscriptionConfig));
     return next(null, session);
   };
 
@@ -141,7 +141,7 @@ function Subscription(broker, vhost, config, counter) {
   }
 
   function redeliveriesExceeded(message) {
-    return message.properties.headers.rascal.redeliveries > config.redeliveries.limit;
+    return message.properties.headers.rascal.redeliveries > subscriptionConfig.redeliveries.limit;
   }
 
   function handleRedeliveriesError(err, session, message) {
@@ -152,7 +152,7 @@ function Subscription(broker, vhost, config, counter) {
   }
 
   function handleRedeliveriesExceeded(session, message) {
-    const err = new Error(format('Message %s has exceeded %d redeliveries', message.properties.messageId, config.redeliveries.limit));
+    const err = new Error(format('Message %s has exceeded %d redeliveries', message.properties.messageId, subscriptionConfig.redeliveries.limit));
     debug(err.message);
     if (session.emit('redeliveries_exceeded', err, message, getAckOrNack(session, message))) return;
     if (session.emit('redeliveries_error', err, message, getAckOrNack(session, message))) return;
@@ -170,7 +170,7 @@ function Subscription(broker, vhost, config, counter) {
   function decorateWithRoutingHeaders(message) {
     message.properties.headers = message.properties.headers || {};
     message.properties.headers.rascal = message.properties.headers.rascal || {};
-    message.properties.headers.rascal.originalQueue = config.source;
+    message.properties.headers.rascal.originalQueue = subscriptionConfig.source;
     message.properties.headers.rascal.originalVhost = vhost.name;
 
     if (!message.properties.headers.rascal.restoreRoutingHeaders) return;
@@ -181,8 +181,8 @@ function Subscription(broker, vhost, config, counter) {
   function decorateWithRedeliveries(message, next) {
     const once = _.once(next);
     const timeout = setTimeoutUnref(() => {
-      once(new Error(format('Redeliveries timed out after %dms', config.redeliveries.timeout)));
-    }, config.redeliveries.timeout);
+      once(new Error(format('Redeliveries timed out after %dms', subscriptionConfig.redeliveries.timeout)));
+    }, subscriptionConfig.redeliveries.timeout);
     countRedeliveries(message, (err, redeliveries) => {
       clearTimeout(timeout);
       if (err) return once(err);
@@ -194,7 +194,7 @@ function Subscription(broker, vhost, config, counter) {
   function countRedeliveries(message, next) {
     if (!message.fields.redelivered) return next(null, 0);
     if (!message.properties.messageId) return next(null, 0);
-    counter.incrementAndGet(config.name + '/' + message.properties.messageId, next);
+    counter.incrementAndGet(`${subscriptionConfig.name}/${message.properties.messageId}`, next);
   }
 
   function immediateNack(message) {
@@ -203,8 +203,8 @@ function Subscription(broker, vhost, config, counter) {
   }
 
   function getAckOrNack(session, message) {
-    if (!broker.promises || config.promisifyAckOrNack === false) return ackOrNack.bind(null, session, message);
-    if (config.promisifyAckOrNack) return ackOrNackP.bind(null, session, message);
+    if (!broker.promises || subscriptionConfig.promisifyAckOrNack === false) return ackOrNack.bind(null, session, message);
+    if (subscriptionConfig.promisifyAckOrNack) return ackOrNackP.bind(null, session, message);
     return ackOrNack.bind(null, session, message);
   }
 

package/lib/amqp/Vhost.js

@@ -4,9 +4,9 @@ const inherits = require('util').inherits;
 const EventEmitter = require('events').EventEmitter;
 const async = require('async');
 const genericPool = require('generic-pool');
-const tasks = require('./tasks');
 const uuid = require('uuid').v4;
 const _ = require('lodash');
+const tasks = require('./tasks');
 const backoff = require('../backoff');
 const setTimeoutUnref = require('../utils/setTimeoutUnref');
 
@@ -18,7 +18,7 @@ module.exports = {
 
 inherits(Vhost, EventEmitter);
 
-function Vhost(config, components) {
+function Vhost(vhostConfig, components) {
   const self = this;
   let connection;
   let connectionConfig;
@@ -35,7 +35,7 @@ function Vhost(config, components) {
   let shuttingDown = false;
   let reconnectTimeout;
 
-  this.name = config.name;
+  this.name = vhostConfig.name;
   this.connectionIndex = 0;
 
   pauseChannelAllocation();
@@ -49,7 +49,7 @@ function Vhost(config, components) {
     debug('Initialising vhost: %s', self.name);
     pauseChannelAllocation();
 
-    init(config, { connectionIndex: self.connectionIndex, components }, (err, config, ctx) => {
+    init(vhostConfig, { connectionIndex: self.connectionIndex, components }, (err, config, ctx) => {
       if (err) return next(err);
 
       connection = ctx.connection;
@@ -95,7 +95,7 @@ function Vhost(config, components) {
     pauseChannelAllocation();
     drainChannelPools((err) => {
       if (err) return next(err);
-      nuke(config, { connectionIndex: self.connectionIndex }, (err) => {
+      nuke(vhostConfig, { connectionIndex: self.connectionIndex }, (err) => {
         if (err) return next(err);
         debug('Finished nuking vhost: %s', self.name);
         setImmediate(next);
@@ -105,7 +105,7 @@ function Vhost(config, components) {
 
   this.purge = function (next) {
     debug('Purging vhost: %s', self.name);
-    purge(config, { purge: true, connectionIndex: self.connectionIndex }, (err) => {
+    purge(vhostConfig, { purge: true, connectionIndex: self.connectionIndex }, (err) => {
       if (err) return next(err);
       debug('Finished purging vhost: %s', self.name);
       setImmediate(next);
@@ -122,7 +122,7 @@ function Vhost(config, components) {
 
   this.connect = function (next) {
     debug('Connecting to vhost: %s', self.name);
-    connect(config, { connectionIndex: self.connectionIndex }, (err, config, ctx) => {
+    connect(vhostConfig, { connectionIndex: self.connectionIndex }, (err, config, ctx) => {
       return next(err, ctx.connection);
     });
   };
@@ -190,23 +190,23 @@ function Vhost(config, components) {
 
   function createChannelPool(options) {
     const mode = getChannelMode(options.confirm);
-    // eslint-disable-next-line prefer-const
-    let pool, poolQueue;
+    let pool;
+    let poolQueue;
     let busy = false;
 
     const factory = {
       create() {
         return new Promise((resolve, reject) => {
-          debug('Creating pooled %s channel for vhost: %s', mode, config.name);
+          debug('Creating pooled %s channel for vhost: %s', mode, vhostConfig.name);
           createChannelWhenInitialised(options.confirm, (err, channel) => {
             if (err) return deferRejection(reject, err);
             if (!channel) return deferRejection(reject, new Error('Vhost is shutting down'));
             const destroyChannel = _.once(() => {
-              debug('Destroying %s channel: %s for vhost: %s due to error or close event', mode, channel._rascal_id, config.name);
+              debug('Destroying %s channel: %s for vhost: %s due to error or close event', mode, channel._rascal_id, vhostConfig.name);
               channel._rascal_closed = true;
               if (pool.isBorrowedResource(channel)) {
                 pool.destroy(channel).catch((err) => {
-                  debug('Error destroying %s channel: %s for vhost: %s. %s', mode, channel._rascal_id, config.name, err.message);
+                  debug('Error destroying %s channel: %s for vhost: %s. %s', mode, channel._rascal_id, vhostConfig.name, err.message);
                 });
               }
             });
@@ -218,8 +218,11 @@ function Vhost(config, components) {
       },
       destroy(channel) {
         return new Promise((resolve, reject) => {
-          debug('Destroying %s channel: %s for vhost: %s', mode, channel._rascal_id, config.name);
-          if (channel._rascal_closed) return resolve();
+          debug('Destroying %s channel: %s for vhost: %s', mode, channel._rascal_id, vhostConfig.name);
+          if (channel._rascal_closed) {
+            resolve();
+            return;
+          }
           channel.removeAllListeners();
           channel.on('error', reject);
           const closeChannelCb = (err) => {
@@ -232,7 +235,7 @@ function Vhost(config, components) {
           // will never receive a response from the broker, and the callback will never yield.
           const once = _.once(closeChannelCb);
           setTimeoutUnref(() => {
-            once(new Error(format('Timeout after %dms closing %s channel: %s for vhost: %s', options.pool.destroyTimeoutMillis, mode, channel._rascal_id, config.name)));
+            once(new Error(format('Timeout after %dms closing %s channel: %s for vhost: %s', options.pool.destroyTimeoutMillis, mode, channel._rascal_id, vhostConfig.name)));
           }, 1000);
           channel.close(once);
         });
@@ -448,13 +451,13 @@ function Vhost(config, components) {
       regularChannelPool ||
       createChannelPool({
         confirm: false,
-        pool: config.publicationChannelPools.regularPool,
+        pool: vhostConfig.publicationChannelPools.regularPool,
       });
     confirmChannelPool =
       confirmChannelPool ||
       createChannelPool({
         confirm: true,
-        pool: config.publicationChannelPools.confirmPool,
+        pool: vhostConfig.publicationChannelPools.confirmPool,
       });
   }
 

package/lib/amqp/tasks/index.js

@@ -1,25 +1,25 @@
-exports.applyBindings = require('./applyBindings.js');
-exports.assertExchanges = require('./assertExchanges.js');
-exports.assertQueues = require('./assertQueues.js');
-exports.assertVhost = require('./assertVhost.js');
-exports.bounceVhost = require('./bounceVhost.js');
-exports.checkExchanges = require('./checkExchanges.js');
-exports.checkQueues = require('./checkQueues.js');
-exports.checkVhost = require('./checkVhost.js');
-exports.closeChannel = require('./closeChannel.js');
-exports.closeConnection = require('./closeConnection.js');
-exports.createChannel = require('./createChannel.js');
-exports.createConnection = require('./createConnection.js');
-exports.deleteExchanges = require('./deleteExchanges.js');
-exports.deleteQueues = require('./deleteQueues.js');
-exports.deleteVhost = require('./deleteVhost.js');
-exports.initCounters = require('./initCounters.js');
-exports.initPublications = require('./initPublications.js');
-exports.initShovels = require('./initShovels.js');
-exports.initSubscriptions = require('./initSubscriptions.js');
-exports.initVhosts = require('./initVhosts.js');
-exports.nukeVhost = require('./nukeVhost.js');
-exports.purgeQueues = require('./purgeQueues.js');
-exports.purgeVhost = require('./purgeVhost.js');
-exports.forewarnVhost = require('./forewarnVhost.js');
-exports.shutdownVhost = require('./shutdownVhost.js');
+exports.applyBindings = require('./applyBindings');
+exports.assertExchanges = require('./assertExchanges');
+exports.assertQueues = require('./assertQueues');
+exports.assertVhost = require('./assertVhost');
+exports.bounceVhost = require('./bounceVhost');
+exports.checkExchanges = require('./checkExchanges');
+exports.checkQueues = require('./checkQueues');
+exports.checkVhost = require('./checkVhost');
+exports.closeChannel = require('./closeChannel');
+exports.closeConnection = require('./closeConnection');
+exports.createChannel = require('./createChannel');
+exports.createConnection = require('./createConnection');
+exports.deleteExchanges = require('./deleteExchanges');
+exports.deleteQueues = require('./deleteQueues');
+exports.deleteVhost = require('./deleteVhost');
+exports.initCounters = require('./initCounters');
+exports.initPublications = require('./initPublications');
+exports.initShovels = require('./initShovels');
+exports.initSubscriptions = require('./initSubscriptions');
+exports.initVhosts = require('./initVhosts');
+exports.nukeVhost = require('./nukeVhost');
+exports.purgeQueues = require('./purgeQueues');
+exports.purgeVhost = require('./purgeVhost');
+exports.forewarnVhost = require('./forewarnVhost');
+exports.shutdownVhost = require('./shutdownVhost');

package/lib/backoff/index.js

@@ -1,6 +1,9 @@
+const exponential = require('./exponential');
+const linear = require('./linear');
+
 const strategies = {
-  exponential: require('./exponential'),
-  linear: require('./linear'),
+  exponential,
+  linear,
 };
 
 module.exports = function (options) {

package/lib/config/configure.js

@@ -3,9 +3,9 @@ const format = require('util').format;
 const url = require('url');
 const _ = require('lodash');
 const uuid = require('uuid').v4;
+const XRegExp = require('xregexp');
 const baseline = require('./baseline');
 const fqn = require('./fqn');
-const XRegExp = require('xregexp');
 
 module.exports = _.curry((rascalConfig, next) => {
   rascalConfig = _.defaultsDeep(rascalConfig, baseline);
@@ -76,7 +76,7 @@ module.exports = _.curry((rascalConfig, next) => {
     connection.pathname = connection.vhost === '/' ? '' : connection.vhost;
     connection.query = connection.options;
     connection.url = connection.url || url.format(connection);
-    connection.loggableUrl = connection.url.replace(/:[^:]*?@/, ':***@');
+    connection.loggableUrl = connection.url.replace(/:[^:]*@/, ':***@');
     connection.index = getConnectionIndex(vhostConfig.connectionStrategy, connection, index);
     configureManagementConnection(vhostConfig, vhostName, connection);
   }
@@ -89,7 +89,7 @@ module.exports = _.curry((rascalConfig, next) => {
   }
 
   function getAuth(user, password) {
-    return user && password ? user + ':' + password : undefined;
+    return user && password ? `${user}:${password}` : undefined;
   }
 
   function getConnectionIndex(strategy, connection, index) {
@@ -111,6 +111,7 @@ module.exports = _.curry((rascalConfig, next) => {
   function configurePublications(publications, vhosts) {
     const defaultPublications = _.reduce(
       vhosts,
+      /* eslint-disable-next-line no-shadow */
       (publications, vhost) => {
         _.each(vhost.exchanges, (exchange) => {
           const name = vhost.name === '/' ? format('/%s', exchange.name) : format('%s/%s', vhost.name, exchange.name);
@@ -160,6 +161,7 @@ module.exports = _.curry((rascalConfig, next) => {
   function configureSubscriptions(subscriptions, vhosts) {
     const defaultSubscriptions = _.reduce(
       vhosts,
+      /* eslint-disable-next-line no-shadow */
       (subscriptions, vhost) => {
         _.each(vhost.queues, (queue) => {
           const name = vhost.name === '/' ? format('/%s', queue.name) : format('%s/%s', vhost.name, queue.name);
@@ -216,7 +218,7 @@ module.exports = _.curry((rascalConfig, next) => {
   function configureCounter(counterConfig, name) {
     debug('Configuring counter: %s', name);
     const counterType = counterConfig.type || name;
-    const counterDefaultConfigPath = 'defaults.redeliveries.counters.' + counterType;
+    const counterDefaultConfigPath = `defaults.redeliveries.counters.${counterType}`;
     const counterDefaults = _.get(rascalConfig, counterDefaultConfigPath);
     rascalConfig.redeliveries.counters[name] = _.defaultsDeep(counterConfig, { name, type: name }, counterDefaults);
   }
@@ -309,7 +311,7 @@ module.exports = _.curry((rascalConfig, next) => {
     if (!_.isArray(collection)) return collection;
     return _.chain(collection)
       .map((item) => {
-        return _.isString(item) ? { name: item } : _.defaults(item, { name: 'unnamed-' + uuid() });
+        return _.isString(item) ? { name: item } : _.defaults(item, { name: `unnamed-${uuid()}` });
       })
       .keyBy('name')
       .value();

package/lib/config/fqn.js

@@ -11,10 +11,10 @@ function qualify(name, namespace, unique) {
   return name;
 }
 
-function prefix(prefix, name, separator) {
-  return prefix ? prefix + (separator || ':') + name : name;
+function prefix(text, name, separator) {
+  return text ? text + (separator || ':') + name : name;
 }
 
-function suffix(suffix, name, separator) {
-  return suffix ? name + (separator || ':') + suffix : name;
+function suffix(text, name, separator) {
+  return text ? name + (separator || ':') + text : name;
 }

package/lib/counters/inMemoryCluster.js

@@ -1,7 +1,8 @@
 const cluster = require('cluster');
-const inMemory = require('./inMemory');
 const uuid = require('uuid').v4;
 const Stashback = require('stashback');
+const inMemory = require('./inMemory');
+
 const debug = 'rascal:counters:inMemoryCluster';
 
 module.exports = {

package/lib/counters/index.js

@@ -1,5 +1,9 @@
+const stub = require('./stub');
+const inMemory = require('./inMemory');
+const inMemoryCluster = require('./inMemoryCluster');
+
 module.exports = {
-  stub: require('./stub'),
-  inMemory: require('./inMemory'),
-  inMemoryCluster: require('./inMemoryCluster'),
+  stub,
+  inMemory,
+  inMemoryCluster,
 };

package/package.json

@@ -1,10 +1,10 @@
 {
   "name": "rascal",
-  "version": "14.4.3",
+  "version": "15.0.0",
   "description": "A config driven wrapper for amqplib supporting multi-host connections, automatic error recovery, redelivery flood protection, transparent encryption / decryption,  channel pooling and publication timeouts",
   "main": "index.js",
   "dependencies": {
-    "async": "^3.2.3",
+    "async": "^3.2.4",
     "debug": "^4.3.4",
     "forward-emitter": "^0.1.1",
     "generic-pool": "^3.8.2",
@@ -17,13 +17,14 @@
     "xregexp": "^5.1.0"
   },
   "devDependencies": {
-    "amqplib": "^0.9.1",
+    "amqplib": "^0.10.2",
     "chalk": "^4.1.2",
     "chance": "^1.1.8",
-    "eslint": "^7.32.0",
+    "eslint": "^8.21.0",
+    "eslint-config-airbnb-base": "^15.0.0",
     "eslint-config-prettier": "^8.3.0",
-    "eslint-plugin-prettier": "^4.0.0",
-    "husky": "^6.0.0",
+    "eslint-plugin-import": "^2.26.0",
+    "husky": "^8.0.1",
     "lint-staged": "^11.2.4",
     "nyc": "^15.1.0",
     "prettier": "^2.4.1",
@@ -35,19 +36,22 @@
     "amqplib": ">=0.5.5"
   },
   "engines": {
-    "node": ">=10.0.0"
+    "node": ">=12.0.0"
   },
   "scripts": {
     "test": "zUnit",
     "prettier": "prettier --check .",
+    "prettier:fix": "prettier --write .",
     "lint": "eslint .",
+    "lint:fix": "eslint --fix .",
     "lint-staged": "lint-staged",
     "coverage": "nyc --report html --reporter lcov --reporter text-summary zUnit",
     "docker": "docker run -d --name rascal-rabbitmq -p 5672:5672 -p 15672:15672 rabbitmq:3-management",
     "prepare": "husky install"
   },
   "lint-staged": {
-    "**/*": "prettier --write --ignore-unknown"
+    "**/*": "prettier --write --ignore-unknown",
+    "**/*.js": "eslint --fix"
   },
   "keywords": [
     "amqplib",