ralph-review 0.2.2 → 0.2.3

package/src/lib/tui/sessions/review-summary-parser.ts

@@ -1,72 +1,6 @@
+import { extractBalancedJsonObjectSlices } from "@/lib/structured-output";
 import { isReviewSummary, type ReviewSummary } from "@/lib/types";
 
-interface JsonObjectSlice {
-  start: number;
-  end: number;
-  value: string;
-}
-
-function extractBalancedJsonObjects(text: string): JsonObjectSlice[] {
-  const results: JsonObjectSlice[] = [];
-  let depth = 0;
-  let startIndex = -1;
-  let inString = false;
-  let isEscaped = false;
-
-  for (let index = 0; index < text.length; index += 1) {
-    const char = text[index];
-
-    if (inString) {
-      if (isEscaped) {
-        isEscaped = false;
-        continue;
-      }
-
-      if (char === "\\") {
-        isEscaped = true;
-        continue;
-      }
-
-      if (char === '"') {
-        inString = false;
-      }
-      continue;
-    }
-
-    if (char === '"') {
-      inString = true;
-      continue;
-    }
-
-    if (char === "{") {
-      if (depth === 0) {
-        startIndex = index;
-      }
-      depth += 1;
-      continue;
-    }
-
-    if (char === "}") {
-      if (depth === 0) {
-        continue;
-      }
-
-      depth -= 1;
-      if (depth === 0 && startIndex >= 0) {
-        const endIndex = index + 1;
-        results.push({
-          start: startIndex,
-          end: endIndex,
-          value: text.slice(startIndex, endIndex),
-        });
-        startIndex = -1;
-      }
-    }
-  }
-
-  return results;
-}
-
 export function extractLatestReviewSummary(
   text: string,
   minIndex: number = 0
@@ -75,7 +9,7 @@ export function extractLatestReviewSummary(
     return null;
   }
 
-  const objects = extractBalancedJsonObjects(text);
+  const objects = extractBalancedJsonObjectSlices(text);
   for (let index = objects.length - 1; index >= 0; index -= 1) {
     const candidate = objects[index];
     if (!candidate) {

package/src/lib/tui/shared/CenteredModal.tsx

@@ -0,0 +1,44 @@
+import type { ReactNode } from "react";
+
+interface CenteredModalProps {
+  title: string;
+  width: number;
+  height?: number;
+  padding?: number;
+  backgroundColor?: string;
+  children: ReactNode;
+}
+
+export function CenteredModal({
+  title,
+  width,
+  height,
+  padding = 2,
+  backgroundColor = "#1a1a2e",
+  children,
+}: CenteredModalProps) {
+  return (
+    <box
+      position="absolute"
+      left={0}
+      top={0}
+      width="100%"
+      height="100%"
+      justifyContent="center"
+      alignItems="center"
+    >
+      <box
+        border
+        borderStyle="double"
+        title={title}
+        titleAlignment="left"
+        padding={padding}
+        width={width}
+        height={height}
+        backgroundColor={backgroundColor}
+      >
+        {children}
+      </box>
+    </box>
+  );
+}

package/src/lib/tui/shared/KeyboardShortcutsModal.tsx

@@ -0,0 +1,14 @@
+import { CenteredModal } from "@/lib/tui/shared/CenteredModal";
+import { ShortcutHintList } from "@/lib/tui/shared/ShortcutHint";
+
+interface KeyboardShortcutsModalProps {
+  shortcuts: readonly { keys: string; label: string }[];
+}
+
+export function KeyboardShortcutsModal({ shortcuts }: KeyboardShortcutsModalProps) {
+  return (
+    <CenteredModal title="Keyboard Shortcuts" width={44}>
+      <ShortcutHintList shortcuts={shortcuts} />
+    </CenteredModal>
+  );
+}

package/src/lib/tui/shared/ShortcutHint.tsx

@@ -0,0 +1,33 @@
+import { TUI_COLORS } from "@/lib/tui/shared/colors";
+
+interface ShortcutHintProps {
+  keys: string;
+  label: string;
+}
+
+interface ShortcutHintListProps {
+  shortcuts: readonly ShortcutHintProps[];
+}
+
+export function ShortcutHint({ keys, label }: ShortcutHintProps) {
+  return (
+    <text>
+      <span fg={TUI_COLORS.accent.key}>{keys}</span>
+      <span fg={TUI_COLORS.text.muted}> {label}</span>
+    </text>
+  );
+}
+
+export function ShortcutHintList({ shortcuts }: ShortcutHintListProps) {
+  return (
+    <box flexDirection="column" gap={1}>
+      {shortcuts.map((shortcut, index) => (
+        <ShortcutHint
+          key={`${shortcut.keys}-${index}`}
+          keys={shortcut.keys}
+          label={shortcut.label}
+        />
+      ))}
+    </box>
+  );
+}

package/src/lib/tui/workspace/Workspace.tsx

@@ -1,51 +1,13 @@
-import type {
-  FindingFixResult,
-  FindingId,
-  StoredFinding,
-} from "@/lib/review-workflow/findings/types";
-import type { SessionState } from "@/lib/session-state";
-import type { DashboardStartupMode } from "@/lib/tui/dashboard/use-dashboard-run-control";
+import type { DetailPaneProps } from "@/lib/tui/sessions/detail/DetailPane";
 import { DetailPane } from "@/lib/tui/sessions/detail/DetailPane";
 import { SessionSidebar } from "@/lib/tui/sessions/sidebar/SessionSidebar";
 import { OutputDrawer } from "@/lib/tui/shared/OutputDrawer";
-import type {
-  AgentRole,
-  Finding,
-  FixEntry,
-  ProjectStats,
-  ReviewOptions,
-  SessionStats,
-  SkippedEntry,
-} from "@/lib/types";
 import { resolveWorkspaceFocusState } from "./workspace-focus";
 import type { FocusedPane, SessionGroupData } from "./workspace-types";
 
-interface WorkspaceProps {
+interface WorkspaceProps extends DetailPaneProps {
   sessionGroups: SessionGroupData[];
   selectedSessionId: string | null;
-  session: SessionState | null;
-  fixes: FixEntry[];
-  skipped: SkippedEntry[];
-  findings: Finding[];
-  storedFindings: StoredFinding[];
-  selectedFindingIds: FindingId[];
-  fixResults: FindingFixResult[];
-  unresolvedSelectedFindings: StoredFinding[];
-  auditRegressionFindings: StoredFinding[];
-  latestReviewIteration: number | null;
-  codexReviewText: string | null;
-  tmuxOutput: string;
-  maxIterations: number;
-  isLoading: boolean;
-  lastSessionStats: SessionStats | null;
-  projectStats: ProjectStats | null;
-  isGitRepo: boolean;
-  currentAgent: AgentRole | null;
-  reviewOptions: ReviewOptions | undefined;
-  startupMode: DashboardStartupMode;
-  isStopping: boolean;
-  activeSessionCount: number;
-  canFixPendingSession: boolean;
   outputVisible: boolean;
   focusedPane: FocusedPane;
   overlayBlocked?: boolean;
@@ -54,32 +16,10 @@ interface WorkspaceProps {
 export function Workspace({
   sessionGroups,
   selectedSessionId,
-  session,
-  fixes,
-  skipped,
-  findings,
-  storedFindings,
-  selectedFindingIds,
-  fixResults,
-  unresolvedSelectedFindings,
-  auditRegressionFindings,
-  latestReviewIteration,
-  codexReviewText,
-  tmuxOutput,
-  maxIterations,
-  isLoading,
-  lastSessionStats,
-  projectStats,
-  isGitRepo,
-  currentAgent,
-  reviewOptions,
-  startupMode,
-  isStopping,
-  activeSessionCount,
-  canFixPendingSession,
   outputVisible,
   focusedPane,
   overlayBlocked = false,
+  ...detailPaneProps
 }: WorkspaceProps) {
   const { sidebarFocused, detailFocused, outputFocused } = resolveWorkspaceFocusState(
     focusedPane,
@@ -94,36 +34,11 @@ export function Workspace({
           selectedSessionId={selectedSessionId}
           focused={sidebarFocused}
         />
-        <DetailPane
-          session={session}
-          fixes={fixes}
-          skipped={skipped}
-          findings={findings}
-          storedFindings={storedFindings}
-          selectedFindingIds={selectedFindingIds}
-          fixResults={fixResults}
-          unresolvedSelectedFindings={unresolvedSelectedFindings}
-          auditRegressionFindings={auditRegressionFindings}
-          latestReviewIteration={latestReviewIteration}
-          codexReviewText={codexReviewText}
-          tmuxOutput={tmuxOutput}
-          maxIterations={maxIterations}
-          isLoading={isLoading}
-          lastSessionStats={lastSessionStats}
-          projectStats={projectStats}
-          isGitRepo={isGitRepo}
-          currentAgent={currentAgent}
-          reviewOptions={reviewOptions}
-          startupMode={startupMode}
-          isStopping={isStopping}
-          activeSessionCount={activeSessionCount}
-          canFixPendingSession={canFixPendingSession}
-          focused={detailFocused}
-        />
+        <DetailPane {...detailPaneProps} focused={detailFocused} />
       </box>
       <OutputDrawer
-        output={tmuxOutput}
-        sessionName={session?.sessionName ?? null}
+        output={detailPaneProps.tmuxOutput}
+        sessionName={detailPaneProps.session?.sessionName ?? null}
         visible={outputVisible}
         focused={outputFocused}
       />

package/src/lib/tui/workspace/use-workspace-state.ts

@@ -37,6 +37,49 @@ import type { SessionGroupData, WorkspaceState } from "./workspace-types";
 const DEFAULT_REFRESH_INTERVAL = 1000;
 const LIVE_REFRESH_INTERVAL = TMUX_CAPTURE_MIN_INTERVAL_MS;
 
+export function createInitialWorkspaceState(
+  overrides: Partial<WorkspaceState> = {}
+): WorkspaceState {
+  return {
+    sessionGroups: [],
+    allSessions: [],
+    projectSessions: [],
+    selectedSessionId: null,
+    currentSession: null,
+    logEntries: [],
+    fixes: [],
+    skipped: [],
+    findings: [],
+    storedFindings: [],
+    selectedFindingIds: [],
+    selectedFindings: [],
+    unselectedFindings: [],
+    fixResults: [],
+    unresolvedSelectedFindings: [],
+    auditRegressionFindings: [],
+    iterationFixes: [],
+    iterationSkipped: [],
+    iterationFindings: [],
+    latestReviewIteration: null,
+    codexReviewText: null,
+    tmuxOutput: "",
+    elapsed: 0,
+    maxIterations: 0,
+    error: null,
+    liveRefreshError: null,
+    isLoading: true,
+    lastSessionStats: null,
+    projectStats: null,
+    config: null,
+    configWarning: null,
+    isGitRepo: true,
+    currentAgent: null,
+    reviewOptions: undefined,
+    outputVisible: false,
+    ...overrides,
+  };
+}
+
 function buildSessionGroups(
   allSessions: ActiveSession[],
   currentProjectPath: string
@@ -80,43 +123,7 @@ export function useWorkspaceState(
   _branch?: string,
   refreshInterval: number = DEFAULT_REFRESH_INTERVAL
 ): WorkspaceState {
-  const [state, setState] = useState<WorkspaceState>({
-    sessionGroups: [],
-    allSessions: [],
-    projectSessions: [],
-    selectedSessionId: null,
-    currentSession: null,
-    logEntries: [],
-    fixes: [],
-    skipped: [],
-    findings: [],
-    storedFindings: [],
-    selectedFindingIds: [],
-    selectedFindings: [],
-    unselectedFindings: [],
-    fixResults: [],
-    unresolvedSelectedFindings: [],
-    auditRegressionFindings: [],
-    iterationFixes: [],
-    iterationSkipped: [],
-    iterationFindings: [],
-    latestReviewIteration: null,
-    codexReviewText: null,
-    tmuxOutput: "",
-    elapsed: 0,
-    maxIterations: 0,
-    error: null,
-    liveRefreshError: null,
-    isLoading: true,
-    lastSessionStats: null,
-    projectStats: null,
-    config: null,
-    configWarning: null,
-    isGitRepo: true,
-    currentAgent: null,
-    reviewOptions: undefined,
-    outputVisible: false,
-  });
+  const [state, setState] = useState<WorkspaceState>(() => createInitialWorkspaceState());
 
   const stateRef = useRef(state);
   stateRef.current = state;

package/src/lib/types/fix.ts

@@ -1,5 +1,6 @@
 import type { FixDecision, Priority } from "./domain";
 import { VALID_FIX_DECISIONS, VALID_PRIORITIES } from "./domain";
+import { asRecord, isCodeLocation } from "./guards";
 import type { CodeLocation } from "./review";
 
 export interface FixEntry {
@@ -26,53 +27,27 @@ export interface FixSummary {
   skipped: SkippedEntry[];
 }
 
-function isLineRange(value: unknown): value is CodeLocation["line_range"] {
-  if (typeof value !== "object" || value === null) {
-    return false;
-  }
-
-  const obj = value as Record<string, unknown>;
-
+function hasFixEntryHeader(obj: Record<string, unknown>): boolean {
   return (
-    typeof obj.start === "number" &&
-    Number.isInteger(obj.start) &&
-    obj.start > 0 &&
-    typeof obj.end === "number" &&
-    Number.isInteger(obj.end) &&
-    obj.end >= obj.start
+    typeof obj.id === "number" &&
+    typeof obj.title === "string" &&
+    typeof obj.priority === "string" &&
+    VALID_PRIORITIES.includes(obj.priority as Priority)
   );
 }
 
-function isCodeLocation(value: unknown): value is CodeLocation {
-  if (typeof value !== "object" || value === null) {
-    return false;
-  }
-
-  const obj = value as Record<string, unknown>;
-
-  if (typeof obj.absolute_file_path !== "string") {
-    return false;
-  }
-
-  return isLineRange(obj.line_range);
-}
-
 function isFixEntry(value: unknown): value is FixEntry {
-  if (typeof value !== "object" || value === null) {
+  const obj = asRecord(value);
+  if (obj === null) {
     return false;
   }
 
-  const obj = value as Record<string, unknown>;
-
   return (
-    typeof obj.id === "number" &&
-    typeof obj.title === "string" &&
-    typeof obj.priority === "string" &&
-    VALID_PRIORITIES.includes(obj.priority as Priority) &&
+    hasFixEntryHeader(obj) &&
     (obj.file === undefined || obj.file === null || typeof obj.file === "string") &&
     (obj.code_location === undefined ||
       obj.code_location === null ||
-      isCodeLocation(obj.code_location)) &&
+      isCodeLocation(obj.code_location, { requirePositive: true })) &&
     typeof obj.claim === "string" &&
     typeof obj.evidence === "string" &&
     typeof obj.fix === "string"
@@ -80,28 +55,20 @@ function isFixEntry(value: unknown): value is FixEntry {
 }
 
 function isSkippedEntry(value: unknown): value is SkippedEntry {
-  if (typeof value !== "object" || value === null) {
+  const obj = asRecord(value);
+  if (obj === null) {
     return false;
   }
 
-  const obj = value as Record<string, unknown>;
-
-  return (
-    typeof obj.id === "number" &&
-    typeof obj.title === "string" &&
-    typeof obj.priority === "string" &&
-    VALID_PRIORITIES.includes(obj.priority as Priority) &&
-    typeof obj.reason === "string"
-  );
+  return hasFixEntryHeader(obj) && typeof obj.reason === "string";
 }
 
 export function isFixSummary(value: unknown): value is FixSummary {
-  if (typeof value !== "object" || value === null) {
+  const obj = asRecord(value);
+  if (obj === null) {
     return false;
   }
 
-  const obj = value as Record<string, unknown>;
-
   // Check decision field
   if (
     typeof obj.decision !== "string" ||

package/src/lib/types/guards.ts

@@ -0,0 +1,47 @@
+export function asRecord(value: unknown): Record<string, unknown> | null {
+  if (typeof value !== "object" || value === null) {
+    return null;
+  }
+
+  return value as Record<string, unknown>;
+}
+
+function isInteger(value: unknown): value is number {
+  return typeof value === "number" && Number.isInteger(value);
+}
+
+function asRecordWithStringField(value: unknown, field: string): Record<string, unknown> | null {
+  const obj = asRecord(value);
+  if (obj === null || typeof obj[field] !== "string") {
+    return null;
+  }
+
+  return obj;
+}
+
+function isLineRange(
+  value: unknown,
+  options: { requirePositive?: boolean } = {}
+): value is { start: number; end: number } {
+  const obj = asRecord(value);
+  if (obj === null || !isInteger(obj.start) || !isInteger(obj.end) || obj.end < obj.start) {
+    return false;
+  }
+
+  if (options.requirePositive && (obj.start <= 0 || obj.end <= 0)) {
+    return false;
+  }
+
+  return true;
+}
+
+export function isCodeLocation(
+  value: unknown,
+  options: { requirePositive?: boolean } = {}
+): value is {
+  absolute_file_path: string;
+  line_range: { start: number; end: number };
+} {
+  const obj = asRecordWithStringField(value, "absolute_file_path");
+  return obj !== null && isLineRange(obj.line_range, options);
+}

package/src/lib/types/review.ts

@@ -1,5 +1,6 @@
 import type { OverallCorrectness } from "./domain";
 import { VALID_OVERALL_CORRECTNESS } from "./domain";
+import { asRecord, isCodeLocation } from "./guards";
 
 export interface LineRange {
   start: number;
@@ -32,46 +33,12 @@ export interface CodexReviewSummary {
 
 const DEFAULT_CODEX_CONFIDENCE = 0.69;
 
-function isLineRange(value: unknown): value is LineRange {
-  if (typeof value !== "object" || value === null) {
-    return false;
-  }
-
-  const obj = value as Record<string, unknown>;
-
-  return (
-    typeof obj.start === "number" &&
-    Number.isInteger(obj.start) &&
-    typeof obj.end === "number" &&
-    Number.isInteger(obj.end)
-  );
-}
-
-function isCodeLocation(value: unknown): value is CodeLocation {
-  if (typeof value !== "object" || value === null) {
-    return false;
-  }
-
-  const obj = value as Record<string, unknown>;
-
-  if (typeof obj.absolute_file_path !== "string") {
-    return false;
-  }
-
-  if (!isLineRange(obj.line_range)) {
-    return false;
-  }
-
-  return true;
-}
-
 function isFinding(value: unknown): value is Finding {
-  if (typeof value !== "object" || value === null) {
+  const obj = asRecord(value);
+  if (obj === null) {
     return false;
   }
 
-  const obj = value as Record<string, unknown>;
-
   if (typeof obj.title !== "string" || typeof obj.body !== "string") {
     return false;
   }
@@ -99,12 +66,11 @@ function isFinding(value: unknown): value is Finding {
 }
 
 export function isReviewSummary(value: unknown): value is ReviewSummary {
-  if (typeof value !== "object" || value === null) {
+  const obj = asRecord(value);
+  if (obj === null) {
     return false;
   }
 
-  const obj = value as Record<string, unknown>;
-
   if (!Array.isArray(obj.findings)) {
     return false;
   }