ralph-review 0.2.1 → 0.2.3

package/src/lib/tui/sessions/detail/session-detail-parts.tsx

@@ -19,6 +19,56 @@ function formatConfidenceScore(value: number): string {
   return `${Math.round(value * 100)}%`;
 }
 
+function EmptyListMessage() {
+  return (
+    <text fg={TUI_COLORS.text.dim} paddingLeft={2}>
+      None yet
+    </text>
+  );
+}
+
+function ScrollableList({
+  content,
+  focused,
+  height,
+  scrollable,
+}: {
+  content: React.ReactNode;
+  focused: boolean;
+  height: BoxHeight;
+  scrollable: boolean;
+}) {
+  if (!scrollable) {
+    return <box paddingLeft={2}>{content}</box>;
+  }
+
+  return (
+    <scrollbox paddingLeft={2} height={height} focused={focused}>
+      {content}
+    </scrollbox>
+  );
+}
+
+function PriorityTitleRow({
+  priority,
+  title,
+}: {
+  priority: Finding["priority"] | FixEntry["priority"];
+  title: string;
+}) {
+  return (
+    <box flexDirection="row">
+      <text>
+        <PriorityText priority={priority} />
+      </text>
+      <text fg={TUI_COLORS.text.dim}> ▸ </text>
+      <text fg={TUI_COLORS.text.secondary} wrapMode="none">
+        {toSingleLine(title)}
+      </text>
+    </box>
+  );
+}
+
 export function SectionHeader({
   title,
   count,
@@ -55,11 +105,7 @@ export function FindingsList({
   showConfidence?: boolean;
 }) {
   if (findings.length === 0) {
-    return (
-      <text fg={TUI_COLORS.text.dim} paddingLeft={2}>
-        None yet
-      </text>
-    );
+    return <EmptyListMessage />;
   }
 
   const content = findings.map((finding, index) => {
@@ -70,15 +116,10 @@ export function FindingsList({
     return (
       <box key={key} flexDirection="column">
         {showBody && index > 0 && <text> </text>}
-        <box flexDirection="row">
-          <text>
-            <PriorityText priority={finding.priority} />
-          </text>
-          <text fg={TUI_COLORS.text.dim}> ▸ </text>
-          <text fg={TUI_COLORS.text.secondary} wrapMode="none">
-            {toSingleLine(formatFindingTitleForDisplay(finding.title))}
-          </text>
-        </box>
+        <PriorityTitleRow
+          priority={finding.priority}
+          title={formatFindingTitleForDisplay(finding.title)}
+        />
         {showBody && (
           <>
             <text> </text>
@@ -99,14 +140,8 @@ export function FindingsList({
     );
   });
 
-  if (!scrollable) {
-    return <box paddingLeft={2}>{content}</box>;
-  }
-
   return (
-    <scrollbox paddingLeft={2} height={height} focused={focused}>
-      {content}
-    </scrollbox>
+    <ScrollableList content={content} focused={focused} height={height} scrollable={scrollable} />
   );
 }
 
@@ -153,11 +188,7 @@ export function SelectableStoredFindingsList({
   selectedFirst?: boolean;
 }) {
   if (findings.length === 0) {
-    return (
-      <text fg={TUI_COLORS.text.dim} paddingLeft={2}>
-        None yet
-      </text>
-    );
+    return <EmptyListMessage />;
   }
 
   const selectedIdSet = new Set(selectedFindingIds);
@@ -193,14 +224,8 @@ export function SelectableStoredFindingsList({
     );
   });
 
-  if (!scrollable) {
-    return <box paddingLeft={2}>{content}</box>;
-  }
-
   return (
-    <scrollbox paddingLeft={2} height={height} focused={focused}>
-      {content}
-    </scrollbox>
+    <ScrollableList content={content} focused={focused} height={height} scrollable={scrollable} />
   );
 }
 
@@ -218,24 +243,12 @@ export function FixList({
   scrollable?: boolean;
 }) {
   if (fixes.length === 0) {
-    return (
-      <text fg={TUI_COLORS.text.dim} paddingLeft={2}>
-        None yet
-      </text>
-    );
+    return <EmptyListMessage />;
   }
 
   const content = fixes.map((fix, index) => (
     <box key={`${index}-${fix.id}`} flexDirection="column">
-      <box flexDirection="row">
-        <text>
-          <PriorityText priority={fix.priority} />
-        </text>
-        <text fg={TUI_COLORS.text.dim}> ▸ </text>
-        <text fg={TUI_COLORS.text.secondary} wrapMode="none">
-          {toSingleLine(fix.title)}
-        </text>
-      </box>
+      <PriorityTitleRow priority={fix.priority} title={fix.title} />
       {showFiles && fix.file && (
         <text fg={TUI_COLORS.text.dim} paddingLeft={5} wrapMode="none">
           {toSingleLine(fix.file)}
@@ -244,14 +257,8 @@ export function FixList({
     </box>
   ));
 
-  if (!scrollable) {
-    return <box paddingLeft={2}>{content}</box>;
-  }
-
   return (
-    <scrollbox paddingLeft={2} height={height} focused={focused}>
-      {content}
-    </scrollbox>
+    <ScrollableList content={content} focused={focused} height={height} scrollable={scrollable} />
   );
 }
 
@@ -267,38 +274,20 @@ export function SkippedList({
   scrollable?: boolean;
 }) {
   if (skipped.length === 0) {
-    return (
-      <text fg={TUI_COLORS.text.dim} paddingLeft={2}>
-        None yet
-      </text>
-    );
+    return <EmptyListMessage />;
   }
 
   const content = skipped.map((entry, index) => (
     <box key={`${index}-${entry.id}`} flexDirection="column">
-      <box flexDirection="row">
-        <text>
-          <PriorityText priority={entry.priority} />
-        </text>
-        <text fg={TUI_COLORS.text.dim}> ▸ </text>
-        <text fg={TUI_COLORS.text.secondary} wrapMode="none">
-          {toSingleLine(entry.title)}
-        </text>
-      </box>
+      <PriorityTitleRow priority={entry.priority} title={entry.title} />
       <text fg={TUI_COLORS.text.dim} paddingLeft={5} wrapMode="none">
         {toSingleLine(entry.reason)}
       </text>
     </box>
   ));
 
-  if (!scrollable) {
-    return <box paddingLeft={2}>{content}</box>;
-  }
-
   return (
-    <scrollbox paddingLeft={2} height={height} focused={focused}>
-      {content}
-    </scrollbox>
+    <ScrollableList content={content} focused={focused} height={height} scrollable={scrollable} />
   );
 }
 
@@ -327,11 +316,7 @@ export function FindingFixResultList({
   scrollable?: boolean;
 }) {
   if (results.length === 0) {
-    return (
-      <text fg={TUI_COLORS.text.dim} paddingLeft={2}>
-        None yet
-      </text>
-    );
+    return <EmptyListMessage />;
   }
 
   const content = results.map((result) => {
@@ -359,13 +344,7 @@ export function FindingFixResultList({
     );
   });
 
-  if (!scrollable) {
-    return <box paddingLeft={2}>{content}</box>;
-  }
-
   return (
-    <scrollbox paddingLeft={2} height={height} focused={focused}>
-      {content}
-    </scrollbox>
+    <ScrollableList content={content} focused={focused} height={height} scrollable={scrollable} />
   );
 }

package/src/lib/tui/sessions/history/SessionListOverlay.tsx

@@ -2,7 +2,10 @@ import { useKeyboard, useTerminalDimensions } from "@opentui/react";
 import { useCallback, useMemo, useState } from "react";
 import type { LogSession } from "@/lib/logger";
 import { formatProjectNameForDisplay } from "@/lib/tui/sessions/session-display";
+import { CenteredModal } from "@/lib/tui/shared/CenteredModal";
 import { TUI_COLORS } from "@/lib/tui/shared/colors";
+import { KeyboardShortcutsModal } from "@/lib/tui/shared/KeyboardShortcutsModal";
+import { ShortcutHint } from "@/lib/tui/shared/ShortcutHint";
 import { SessionDetailPane } from "./SessionListDetailPane";
 import {
   buildSessionOverlayOptions,
@@ -27,48 +30,16 @@ function SessionHelpModal({ onClose }: { onClose: () => void }) {
     }
   });
 
-  return (
-    <box
-      position="absolute"
-      left={0}
-      top={0}
-      width="100%"
-      height="100%"
-      justifyContent="center"
-      alignItems="center"
-    >
-      <box
-        border
-        borderStyle="double"
-        title="Keyboard Shortcuts"
-        titleAlignment="left"
-        padding={2}
-        width={44}
-        backgroundColor="#1a1a2e"
-      >
-        <box flexDirection="column" gap={1}>
-          <text>
-            <span fg={TUI_COLORS.accent.key}>[Tab ←/→]</span>
-            <span fg={TUI_COLORS.text.muted}> Switch pane focus</span>
-          </text>
-          <text>
-            <span fg={TUI_COLORS.accent.key}>[↑/↓ j/k]</span>
-            <span fg={TUI_COLORS.text.muted}> Navigate / Scroll</span>
-          </text>
-          <text>
-            <span fg={TUI_COLORS.accent.key}>[d]</span>
-            <span fg={TUI_COLORS.text.muted}> Delete selected log</span>
-          </text>
-          <text>
-            <span fg={TUI_COLORS.accent.key}>[h/?]</span>
-            <span fg={TUI_COLORS.text.muted}> Toggle help</span>
-          </text>
-        </box>
-      </box>
-    </box>
-  );
+  return <KeyboardShortcutsModal shortcuts={SESSION_OVERLAY_SHORTCUTS} />;
 }
 
+const SESSION_OVERLAY_SHORTCUTS = [
+  { keys: "[Tab ←/→]", label: "Switch pane focus" },
+  { keys: "[↑/↓ j/k]", label: "Navigate / Scroll" },
+  { keys: "[d]", label: "Delete selected log" },
+  { keys: "[h/?]", label: "Toggle help" },
+] as const;
+
 interface SessionDeleteModalProps {
   sessionName: string;
   error: string | null;
@@ -77,26 +48,8 @@ interface SessionDeleteModalProps {
 
 function SessionDeleteModal({ sessionName, error, isDeleting }: SessionDeleteModalProps) {
   return (
-    <box
-      position="absolute"
-      left={0}
-      top={0}
-      width="100%"
-      height="100%"
-      justifyContent="center"
-      alignItems="center"
-    >
-      <box
-        border
-        borderStyle="double"
-        title="Delete Session Log"
-        titleAlignment="left"
-        padding={2}
-        width={58}
-        backgroundColor="#1a1a2e"
-        flexDirection="column"
-        gap={1}
-      >
+    <CenteredModal title="Delete Session Log" width={58}>
+      <box flexDirection="column" gap={1}>
         <text fg={TUI_COLORS.text.primary}>{sessionName}</text>
         <text fg={TUI_COLORS.status.error}>This cannot be undone.</text>
         <text>
@@ -109,7 +62,7 @@ function SessionDeleteModal({ sessionName, error, isDeleting }: SessionDeleteMod
         {isDeleting && <text fg={TUI_COLORS.text.muted}>Deleting...</text>}
         {error && <text fg={TUI_COLORS.status.error}>{error}</text>}
       </box>
-    </box>
+    </CenteredModal>
   );
 }
 
@@ -339,20 +292,9 @@ export function SessionOverlay({ onClose }: SessionOverlayProps) {
         paddingBottom={1}
       >
         <box flexDirection="row" gap={2}>
-          {isNarrow && (
-            <text>
-              <span fg={TUI_COLORS.accent.key}>[Tab]</span>
-              <span fg={TUI_COLORS.text.muted}> Switch</span>
-            </text>
-          )}
-          <text>
-            <span fg={TUI_COLORS.accent.key}>[d]</span>
-            <span fg={TUI_COLORS.text.muted}> Delete</span>
-          </text>
-          <text>
-            <span fg={TUI_COLORS.accent.key}>[h]</span>
-            <span fg={TUI_COLORS.text.muted}> Help</span>
-          </text>
+          {isNarrow && <ShortcutHint keys="[Tab]" label="Switch" />}
+          <ShortcutHint keys="[d]" label="Delete" />
+          <ShortcutHint keys="[h]" label="Help" />
         </box>
         <text fg={TUI_COLORS.text.dim}>Focus: {focusedPane === "list" ? "List" : "Detail"}</text>
       </box>

package/src/lib/tui/sessions/review-summary-parser.ts

@@ -1,72 +1,6 @@
+import { extractBalancedJsonObjectSlices } from "@/lib/structured-output";
 import { isReviewSummary, type ReviewSummary } from "@/lib/types";
 
-interface JsonObjectSlice {
-  start: number;
-  end: number;
-  value: string;
-}
-
-function extractBalancedJsonObjects(text: string): JsonObjectSlice[] {
-  const results: JsonObjectSlice[] = [];
-  let depth = 0;
-  let startIndex = -1;
-  let inString = false;
-  let isEscaped = false;
-
-  for (let index = 0; index < text.length; index += 1) {
-    const char = text[index];
-
-    if (inString) {
-      if (isEscaped) {
-        isEscaped = false;
-        continue;
-      }
-
-      if (char === "\\") {
-        isEscaped = true;
-        continue;
-      }
-
-      if (char === '"') {
-        inString = false;
-      }
-      continue;
-    }
-
-    if (char === '"') {
-      inString = true;
-      continue;
-    }
-
-    if (char === "{") {
-      if (depth === 0) {
-        startIndex = index;
-      }
-      depth += 1;
-      continue;
-    }
-
-    if (char === "}") {
-      if (depth === 0) {
-        continue;
-      }
-
-      depth -= 1;
-      if (depth === 0 && startIndex >= 0) {
-        const endIndex = index + 1;
-        results.push({
-          start: startIndex,
-          end: endIndex,
-          value: text.slice(startIndex, endIndex),
-        });
-        startIndex = -1;
-      }
-    }
-  }
-
-  return results;
-}
-
 export function extractLatestReviewSummary(
   text: string,
   minIndex: number = 0
@@ -75,7 +9,7 @@ export function extractLatestReviewSummary(
     return null;
   }
 
-  const objects = extractBalancedJsonObjects(text);
+  const objects = extractBalancedJsonObjectSlices(text);
   for (let index = objects.length - 1; index >= 0; index -= 1) {
     const candidate = objects[index];
     if (!candidate) {

package/src/lib/tui/shared/CenteredModal.tsx

@@ -0,0 +1,44 @@
+import type { ReactNode } from "react";
+
+interface CenteredModalProps {
+  title: string;
+  width: number;
+  height?: number;
+  padding?: number;
+  backgroundColor?: string;
+  children: ReactNode;
+}
+
+export function CenteredModal({
+  title,
+  width,
+  height,
+  padding = 2,
+  backgroundColor = "#1a1a2e",
+  children,
+}: CenteredModalProps) {
+  return (
+    <box
+      position="absolute"
+      left={0}
+      top={0}
+      width="100%"
+      height="100%"
+      justifyContent="center"
+      alignItems="center"
+    >
+      <box
+        border
+        borderStyle="double"
+        title={title}
+        titleAlignment="left"
+        padding={padding}
+        width={width}
+        height={height}
+        backgroundColor={backgroundColor}
+      >
+        {children}
+      </box>
+    </box>
+  );
+}

package/src/lib/tui/shared/KeyboardShortcutsModal.tsx

@@ -0,0 +1,14 @@
+import { CenteredModal } from "@/lib/tui/shared/CenteredModal";
+import { ShortcutHintList } from "@/lib/tui/shared/ShortcutHint";
+
+interface KeyboardShortcutsModalProps {
+  shortcuts: readonly { keys: string; label: string }[];
+}
+
+export function KeyboardShortcutsModal({ shortcuts }: KeyboardShortcutsModalProps) {
+  return (
+    <CenteredModal title="Keyboard Shortcuts" width={44}>
+      <ShortcutHintList shortcuts={shortcuts} />
+    </CenteredModal>
+  );
+}

package/src/lib/tui/shared/ShortcutHint.tsx

@@ -0,0 +1,33 @@
+import { TUI_COLORS } from "@/lib/tui/shared/colors";
+
+interface ShortcutHintProps {
+  keys: string;
+  label: string;
+}
+
+interface ShortcutHintListProps {
+  shortcuts: readonly ShortcutHintProps[];
+}
+
+export function ShortcutHint({ keys, label }: ShortcutHintProps) {
+  return (
+    <text>
+      <span fg={TUI_COLORS.accent.key}>{keys}</span>
+      <span fg={TUI_COLORS.text.muted}> {label}</span>
+    </text>
+  );
+}
+
+export function ShortcutHintList({ shortcuts }: ShortcutHintListProps) {
+  return (
+    <box flexDirection="column" gap={1}>
+      {shortcuts.map((shortcut, index) => (
+        <ShortcutHint
+          key={`${shortcut.keys}-${index}`}
+          keys={shortcut.keys}
+          label={shortcut.label}
+        />
+      ))}
+    </box>
+  );
+}

package/src/lib/tui/workspace/Workspace.tsx

@@ -1,51 +1,13 @@
-import type {
-  FindingFixResult,
-  FindingId,
-  StoredFinding,
-} from "@/lib/review-workflow/findings/types";
-import type { SessionState } from "@/lib/session-state";
-import type { DashboardStartupMode } from "@/lib/tui/dashboard/use-dashboard-run-control";
+import type { DetailPaneProps } from "@/lib/tui/sessions/detail/DetailPane";
 import { DetailPane } from "@/lib/tui/sessions/detail/DetailPane";
 import { SessionSidebar } from "@/lib/tui/sessions/sidebar/SessionSidebar";
 import { OutputDrawer } from "@/lib/tui/shared/OutputDrawer";
-import type {
-  AgentRole,
-  Finding,
-  FixEntry,
-  ProjectStats,
-  ReviewOptions,
-  SessionStats,
-  SkippedEntry,
-} from "@/lib/types";
 import { resolveWorkspaceFocusState } from "./workspace-focus";
 import type { FocusedPane, SessionGroupData } from "./workspace-types";
 
-interface WorkspaceProps {
+interface WorkspaceProps extends DetailPaneProps {
   sessionGroups: SessionGroupData[];
   selectedSessionId: string | null;
-  session: SessionState | null;
-  fixes: FixEntry[];
-  skipped: SkippedEntry[];
-  findings: Finding[];
-  storedFindings: StoredFinding[];
-  selectedFindingIds: FindingId[];
-  fixResults: FindingFixResult[];
-  unresolvedSelectedFindings: StoredFinding[];
-  auditRegressionFindings: StoredFinding[];
-  latestReviewIteration: number | null;
-  codexReviewText: string | null;
-  tmuxOutput: string;
-  maxIterations: number;
-  isLoading: boolean;
-  lastSessionStats: SessionStats | null;
-  projectStats: ProjectStats | null;
-  isGitRepo: boolean;
-  currentAgent: AgentRole | null;
-  reviewOptions: ReviewOptions | undefined;
-  startupMode: DashboardStartupMode;
-  isStopping: boolean;
-  activeSessionCount: number;
-  canFixPendingSession: boolean;
   outputVisible: boolean;
   focusedPane: FocusedPane;
   overlayBlocked?: boolean;
@@ -54,32 +16,10 @@ interface WorkspaceProps {
 export function Workspace({
   sessionGroups,
   selectedSessionId,
-  session,
-  fixes,
-  skipped,
-  findings,
-  storedFindings,
-  selectedFindingIds,
-  fixResults,
-  unresolvedSelectedFindings,
-  auditRegressionFindings,
-  latestReviewIteration,
-  codexReviewText,
-  tmuxOutput,
-  maxIterations,
-  isLoading,
-  lastSessionStats,
-  projectStats,
-  isGitRepo,
-  currentAgent,
-  reviewOptions,
-  startupMode,
-  isStopping,
-  activeSessionCount,
-  canFixPendingSession,
   outputVisible,
   focusedPane,
   overlayBlocked = false,
+  ...detailPaneProps
 }: WorkspaceProps) {
   const { sidebarFocused, detailFocused, outputFocused } = resolveWorkspaceFocusState(
     focusedPane,
@@ -94,36 +34,11 @@ export function Workspace({
           selectedSessionId={selectedSessionId}
           focused={sidebarFocused}
         />
-        <DetailPane
-          session={session}
-          fixes={fixes}
-          skipped={skipped}
-          findings={findings}
-          storedFindings={storedFindings}
-          selectedFindingIds={selectedFindingIds}
-          fixResults={fixResults}
-          unresolvedSelectedFindings={unresolvedSelectedFindings}
-          auditRegressionFindings={auditRegressionFindings}
-          latestReviewIteration={latestReviewIteration}
-          codexReviewText={codexReviewText}
-          tmuxOutput={tmuxOutput}
-          maxIterations={maxIterations}
-          isLoading={isLoading}
-          lastSessionStats={lastSessionStats}
-          projectStats={projectStats}
-          isGitRepo={isGitRepo}
-          currentAgent={currentAgent}
-          reviewOptions={reviewOptions}
-          startupMode={startupMode}
-          isStopping={isStopping}
-          activeSessionCount={activeSessionCount}
-          canFixPendingSession={canFixPendingSession}
-          focused={detailFocused}
-        />
+        <DetailPane {...detailPaneProps} focused={detailFocused} />
       </box>
       <OutputDrawer
-        output={tmuxOutput}
-        sessionName={session?.sessionName ?? null}
+        output={detailPaneProps.tmuxOutput}
+        sessionName={detailPaneProps.session?.sessionName ?? null}
         visible={outputVisible}
         focused={outputFocused}
       />