ralph-review 0.2.0 → 0.2.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ralph-review",
-  "version": "0.2.0",
+  "version": "0.2.1",
   "description": "Orchestrating coding agents for code review, verification and fixing via the ralph loop.",
   "license": "MIT",
   "type": "module",

package/src/lib/tui/dashboard/Dashboard.tsx

@@ -240,7 +240,6 @@ export function Dashboard({ projectPath, branch, refreshInterval = 1000 }: Dashb
             findings={state.findings}
             storedFindings={state.storedFindings}
             selectedFindingIds={state.selectedFindingIds}
-            selectedFindings={state.selectedFindings}
             fixResults={state.fixResults}
             unresolvedSelectedFindings={state.unresolvedSelectedFindings}
             auditRegressionFindings={state.auditRegressionFindings}

package/src/lib/tui/sessions/detail/DetailPane.tsx

@@ -25,7 +25,6 @@ interface DetailPaneProps {
   findings: Finding[];
   storedFindings: StoredFinding[];
   selectedFindingIds: FindingId[];
-  selectedFindings: StoredFinding[];
   fixResults: FindingFixResult[];
   unresolvedSelectedFindings: StoredFinding[];
   auditRegressionFindings: StoredFinding[];
@@ -53,7 +52,6 @@ export function DetailPane({
   findings,
   storedFindings,
   selectedFindingIds,
-  selectedFindings,
   fixResults,
   unresolvedSelectedFindings,
   auditRegressionFindings,
@@ -112,7 +110,6 @@ export function DetailPane({
             findings={findings}
             storedFindings={storedFindings}
             selectedFindingIds={selectedFindingIds}
-            selectedFindings={selectedFindings}
             fixResults={fixResults}
             unresolvedSelectedFindings={unresolvedSelectedFindings}
             auditRegressionFindings={auditRegressionFindings}

package/src/lib/tui/sessions/detail/SessionDetailView.tsx

@@ -30,6 +30,7 @@ import {
   FindingsList,
   FixList,
   SectionHeader,
+  SelectableStoredFindingsList,
   SkippedList,
   StoredFindingsList,
   toSingleLine,
@@ -42,7 +43,6 @@ interface SessionDetailViewProps {
   findings: Finding[];
   storedFindings: StoredFinding[];
   selectedFindingIds: FindingId[];
-  selectedFindings: StoredFinding[];
   fixResults: FindingFixResult[];
   unresolvedSelectedFindings: StoredFinding[];
   auditRegressionFindings: StoredFinding[];
@@ -157,7 +157,6 @@ export function SessionDetailView({
   findings,
   storedFindings,
   selectedFindingIds,
-  selectedFindings,
   fixResults,
   unresolvedSelectedFindings,
   auditRegressionFindings,
@@ -255,12 +254,6 @@ export function SessionDetailView({
     session.selectedFindingIds && session.selectedFindingIds.length > 0
       ? session.selectedFindingIds
       : selectedFindingIds;
-  const workflowSelectedFindings =
-    selectedFindings.length > 0
-      ? selectedFindings
-      : workflowSelectedIds
-          .map((findingId) => workflowFindingsById.get(findingId))
-          .filter((finding): finding is StoredFinding => finding !== undefined);
   const workflowUnresolvedFindings =
     unresolvedSelectedFindings.length > 0
       ? unresolvedSelectedFindings
@@ -334,10 +327,24 @@ export function SessionDetailView({
       {batchFirstMode ? (
         <>
           <box flexDirection="column" flexBasis={0} flexGrow={5} minHeight={0}>
-            <SectionHeader title="Findings inventory" count={batchDisplayFindings.length} />
+            <SectionHeader
+              title="Findings"
+              count={batchDisplayFindings.length}
+              suffix={
+                workflowSelectedIds.length > 0 ? (
+                  <span fg={TUI_COLORS.text.dim}> · {workflowSelectedIds.length} selected</span>
+                ) : undefined
+              }
+            />
             <box flexGrow={1} minHeight={0}>
               {inventoryFindings.length > 0 ? (
-                <StoredFindingsList findings={inventoryFindings} height="100%" focused={focused} />
+                <SelectableStoredFindingsList
+                  findings={inventoryFindings}
+                  selectedFindingIds={workflowSelectedIds}
+                  height="100%"
+                  focused={focused}
+                  selectedFirst
+                />
               ) : showingCodex ? (
                 <CodexReviewDisplay text={displayCodexText ?? ""} height="100%" focused={focused} />
               ) : (
@@ -346,15 +353,6 @@ export function SessionDetailView({
             </box>
           </box>
 
-          {workflowSelectedFindings.length > 0 && (
-            <box flexDirection="column" flexBasis={0} flexGrow={2} minHeight={0}>
-              <SectionHeader title="Selected findings" count={workflowSelectedFindings.length} />
-              <box flexGrow={1} minHeight={0}>
-                <StoredFindingsList findings={workflowSelectedFindings} height="100%" />
-              </box>
-            </box>
-          )}
-
           {fixResults.length > 0 && (
             <box flexDirection="column" flexBasis={0} flexGrow={2} minHeight={0}>
               <SectionHeader title="Fix results" count={fixResults.length} />

package/src/lib/tui/sessions/detail/session-detail-parts.tsx

@@ -1,4 +1,8 @@
-import type { FindingFixResult, StoredFinding } from "@/lib/review-workflow/findings/types";
+import type {
+  FindingFixResult,
+  FindingId,
+  StoredFinding,
+} from "@/lib/review-workflow/findings/types";
 import { storedFindingToFinding } from "@/lib/review-workflow/presentation";
 import { formatFindingTitleForDisplay } from "@/lib/tui/sessions/finding-title";
 import { PriorityText } from "@/lib/tui/sessions/priority-text";
@@ -40,12 +44,14 @@ export function FindingsList({
   height = 8,
   focused = false,
   scrollable = true,
+  showBody = false,
   showConfidence = false,
 }: {
   findings: Finding[];
   height?: BoxHeight;
   focused?: boolean;
   scrollable?: boolean;
+  showBody?: boolean;
   showConfidence?: boolean;
 }) {
   if (findings.length === 0) {
@@ -63,6 +69,7 @@ export function FindingsList({
 
     return (
       <box key={key} flexDirection="column">
+        {showBody && index > 0 && <text> </text>}
         <box flexDirection="row">
           <text>
             <PriorityText priority={finding.priority} />
@@ -72,6 +79,14 @@ export function FindingsList({
             {toSingleLine(formatFindingTitleForDisplay(finding.title))}
           </text>
         </box>
+        {showBody && (
+          <>
+            <text> </text>
+            <text fg={TUI_COLORS.text.secondary} paddingLeft={5} wrapMode="word">
+              {finding.body.trim()}
+            </text>
+          </>
+        )}
         {showConfidence && (
           <text fg={TUI_COLORS.text.dim} paddingLeft={5} wrapMode="none">
             Confidence: {formatConfidenceScore(finding.confidence_score)}
@@ -100,12 +115,14 @@ export function StoredFindingsList({
   height = 8,
   focused = false,
   scrollable = true,
+  showBody = false,
   showConfidence = false,
 }: {
   findings: StoredFinding[];
   height?: BoxHeight;
   focused?: boolean;
   scrollable?: boolean;
+  showBody?: boolean;
   showConfidence?: boolean;
 }) {
   return (
@@ -114,11 +131,79 @@ export function StoredFindingsList({
       height={height}
       focused={focused}
       scrollable={scrollable}
+      showBody={showBody}
       showConfidence={showConfidence}
     />
   );
 }
 
+export function SelectableStoredFindingsList({
+  findings,
+  selectedFindingIds,
+  height = 8,
+  focused = false,
+  scrollable = true,
+  selectedFirst = false,
+}: {
+  findings: StoredFinding[];
+  selectedFindingIds: FindingId[];
+  height?: BoxHeight;
+  focused?: boolean;
+  scrollable?: boolean;
+  selectedFirst?: boolean;
+}) {
+  if (findings.length === 0) {
+    return (
+      <text fg={TUI_COLORS.text.dim} paddingLeft={2}>
+        None yet
+      </text>
+    );
+  }
+
+  const selectedIdSet = new Set(selectedFindingIds);
+  const displayFindings = selectedFirst
+    ? [
+        ...findings.filter((finding) => selectedIdSet.has(finding.id)),
+        ...findings.filter((finding) => !selectedIdSet.has(finding.id)),
+      ]
+    : findings;
+
+  const content = displayFindings.map((finding) => {
+    const isSelected = selectedIdSet.has(finding.id);
+    const lineRange = `${finding.startLine}-${finding.endLine}`;
+
+    return (
+      <box key={finding.id} flexDirection="column">
+        <box flexDirection="row" gap={1}>
+          <text fg={isSelected ? TUI_COLORS.status.success : TUI_COLORS.text.dim}>
+            {isSelected ? "◉" : "◎"}
+          </text>
+          <text>
+            <PriorityText priority={finding.priority} />
+          </text>
+          <text fg={TUI_COLORS.text.dim}>▸</text>
+          <text fg={TUI_COLORS.text.secondary} wrapMode="none">
+            {toSingleLine(formatFindingTitleForDisplay(finding.title))}
+          </text>
+        </box>
+        <text fg={TUI_COLORS.text.dim} paddingLeft={7} wrapMode="none">
+          {toSingleLine(finding.filePath)}:{lineRange}
+        </text>
+      </box>
+    );
+  });
+
+  if (!scrollable) {
+    return <box paddingLeft={2}>{content}</box>;
+  }
+
+  return (
+    <scrollbox paddingLeft={2} height={height} focused={focused}>
+      {content}
+    </scrollbox>
+  );
+}
+
 export function FixList({
   fixes,
   showFiles,

package/src/lib/tui/sessions/history/SessionListDetailPane.tsx

@@ -453,7 +453,12 @@ export function SessionDetailPane({
                   <text fg={TUI_COLORS.text.secondary} paddingLeft={2}>
                     {entry.findings.length} issues found
                   </text>
-                  <StoredFindingsList findings={entry.findings} scrollable={false} showConfidence />
+                  <StoredFindingsList
+                    findings={entry.findings}
+                    scrollable={false}
+                    showBody
+                    showConfidence
+                  />
                 </WorkflowSection>
               ))}
 

package/src/lib/tui/workspace/Workspace.tsx

@@ -29,7 +29,6 @@ interface WorkspaceProps {
   findings: Finding[];
   storedFindings: StoredFinding[];
   selectedFindingIds: FindingId[];
-  selectedFindings: StoredFinding[];
   fixResults: FindingFixResult[];
   unresolvedSelectedFindings: StoredFinding[];
   auditRegressionFindings: StoredFinding[];
@@ -61,7 +60,6 @@ export function Workspace({
   findings,
   storedFindings,
   selectedFindingIds,
-  selectedFindings,
   fixResults,
   unresolvedSelectedFindings,
   auditRegressionFindings,
@@ -103,7 +101,6 @@ export function Workspace({
           findings={findings}
           storedFindings={storedFindings}
           selectedFindingIds={selectedFindingIds}
-          selectedFindings={selectedFindings}
           fixResults={fixResults}
           unresolvedSelectedFindings={unresolvedSelectedFindings}
           auditRegressionFindings={auditRegressionFindings}