ralph-review 0.1.10 → 0.1.11

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ralph-review",
-  "version": "0.1.10",
+  "version": "0.1.11",
   "description": "Orchestrating coding agents for code review, verification and fixing via the ralph loop.",
   "license": "MIT",
   "type": "module",

package/src/commands/update.ts

@@ -4,6 +4,7 @@ import { type CommandDef, parseCommand } from "@/lib/cli-parser";
 import {
   getDefaultSelfUpdateDependencies,
   isUpdateManager,
+  managerDisplay,
   performSelfUpdate,
   type SelfUpdateDependencies,
   SelfUpdateError,
@@ -52,34 +53,30 @@ function createUpdateRuntime(overrides: UpdateRuntimeOverrides = {}): UpdateRunt
   };
 }
 
-function managerLabel(manager: SelfUpdateResult["manager"]): string {
-  return manager === "brew" ? "Homebrew" : "npm";
-}
-
 function renderSelfUpdateResult(result: SelfUpdateResult, runtime: UpdateRuntime): void {
   switch (result.status) {
     case "up-to-date":
       runtime.log.success(
-        `ralph-review is already up to date via ${managerLabel(result.manager)} (${result.currentVersion}).`
+        `ralph-review is already up to date via ${managerDisplay(result.manager)} (${result.currentVersion}).`
       );
       return;
 
     case "update-available":
       if (result.latestVersion) {
         runtime.log.info(
-          `Update available via ${managerLabel(result.manager)}: ${result.currentVersion} -> ${result.latestVersion}`
+          `Update available via ${managerDisplay(result.manager)}: ${result.currentVersion} -> ${result.latestVersion}`
         );
         return;
       }
 
       runtime.log.info(
-        `Update available via ${managerLabel(result.manager)}. Current version: ${result.currentVersion}`
+        `Update available via ${managerDisplay(result.manager)}. Current version: ${result.currentVersion}`
       );
       return;
 
     case "updated":
       runtime.log.success(
-        `Updated ralph-review via ${managerLabel(result.manager)}: ${result.previousVersion} -> ${result.finalVersion}`
+        `Updated ralph-review via ${managerDisplay(result.manager)}: ${result.previousVersion} -> ${result.finalVersion}`
       );
       return;
   }
@@ -112,13 +109,33 @@ export async function runUpdate(
   };
 
   const spinner = runtime.spinner();
+  let spinnerActive = false;
+  const stopSpinner = (message: string): void => {
+    if (!spinnerActive) {
+      return;
+    }
+
+    spinner.stop(message);
+    spinnerActive = false;
+  };
+
   spinner.start("Checking for updates...");
+  spinnerActive = true;
   try {
-    const result = await runtime.performSelfUpdate(options, runtime);
-    spinner.stop("Done.");
+    const result = await runtime.performSelfUpdate(
+      {
+        ...options,
+        onBeforeInstall: async ({ manager }) => {
+          stopSpinner("Update check complete.");
+          runtime.log.info(`Installing update via ${managerDisplay(manager)}...`);
+        },
+      },
+      runtime
+    );
+    stopSpinner("Done.");
     renderSelfUpdateResult(result, runtime);
   } catch (error) {
-    spinner.stop("Update failed.");
+    stopSpinner("Update failed.");
     if (error instanceof SelfUpdateError) {
       runtime.log.error(error.message);
       for (const note of error.notes) {

package/src/lib/self-update.ts

@@ -16,9 +16,16 @@ export interface SelfUpdateDependencies {
   runInteractive: (command: string[]) => Promise<number>;
 }
 
+export interface BeforeInstallEvent {
+  manager: UpdateManager;
+  currentVersion: string;
+  latestVersion: string;
+}
+
 export interface SelfUpdateOptions {
   checkOnly: boolean;
   manager?: UpdateManager;
+  onBeforeInstall?: (event: BeforeInstallEvent) => void | Promise<void>;
 }
 
 export type SelfUpdateResult =
@@ -100,7 +107,7 @@ function commandDisplay(command: readonly string[]): string {
   return command.join(" ");
 }
 
-function managerDisplay(manager: UpdateManager): string {
+export function managerDisplay(manager: UpdateManager): string {
   switch (manager) {
     case "brew":
       return "Homebrew";
@@ -504,6 +511,12 @@ async function performNpmSelfUpdate(
     };
   }
 
+  await options.onBeforeInstall?.({
+    manager: "npm",
+    currentVersion,
+    latestVersion,
+  });
+
   const exitCode = await deps.runInteractive([...NPM_INSTALL_COMMAND]);
   if (exitCode !== 0) {
     throw new SelfUpdateError(
@@ -547,6 +560,12 @@ async function performBrewSelfUpdate(
     };
   }
 
+  await options.onBeforeInstall?.({
+    manager: "brew",
+    currentVersion,
+    latestVersion,
+  });
+
   const exitCode = await deps.runInteractive([...BREW_INSTALL_COMMAND]);
   if (exitCode !== 0) {
     throw new SelfUpdateError(