ralph-review 0.1.1 → 0.1.3

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ralph-review",
-  "version": "0.1.1",
+  "version": "0.1.3",
   "description": "A CLI tool that orchestrates agentic review-fix cycles until your code is clean.",
   "license": "MIT",
   "type": "module",

package/src/commands/run.ts

@@ -582,7 +582,26 @@ export async function startReview(
 
   const loadedConfig = await runtime.loadConfig();
 
-  const hasExplicitMode = options.base || options.uncommitted || options.commit || options.custom;
+  if (options.custom !== undefined && options.custom.trim().length === 0) {
+    runtime.prompt.log.error("--custom cannot be empty");
+    runtime.process.exit(1);
+    return;
+  }
+
+  if (options.commit !== undefined) {
+    options.commit = options.commit.trim();
+    if (options.commit.length === 0) {
+      runtime.prompt.log.error("--commit cannot be empty");
+      runtime.process.exit(1);
+      return;
+    }
+  }
+
+  const hasExplicitMode =
+    options.base !== undefined ||
+    options.uncommitted === true ||
+    options.commit !== undefined ||
+    options.custom !== undefined;
   if (!hasExplicitMode) {
     if (loadedConfig?.defaultReview?.type === "base") {
       options.base = loadedConfig.defaultReview.branch;
@@ -590,11 +609,20 @@ export async function startReview(
     // else: defaults to uncommitted behavior (no base flag)
   }
 
+  if (options.base !== undefined) {
+    options.base = options.base.trim();
+    if (options.base.length === 0) {
+      runtime.prompt.log.error("--base cannot be empty");
+      runtime.process.exit(1);
+      return;
+    }
+  }
+
   const modeOptions = [
-    options.base && "--base",
+    options.base !== undefined && "--base",
     options.uncommitted && "--uncommitted",
-    options.commit && "--commit",
-    options.custom && "--custom",
+    options.commit !== undefined && "--commit",
+    options.custom !== undefined && "--custom",
   ].filter(Boolean);
 
   if (modeOptions.length > 1) {
@@ -611,6 +639,7 @@ export async function startReview(
       projectPath: runtime.process.cwd(),
       baseBranch: options.base,
       commitSha: options.commit,
+      customInstructions: options.custom,
       capabilityDiscoveryOptions: {
         probeAgents: getDynamicProbeAgents(loadedConfig),
       },

package/src/lib/agents/models.ts

@@ -25,24 +25,33 @@ export const codexModelOptions = [
 ] as const;
 
 export const droidModelOptions = [
-  { value: "gpt-5.1", label: "GPT-5.1" },
-  { value: "gpt-5.1-codex", label: "GPT-5.1 Codex" },
-  { value: "gpt-5.1-codex-max", label: "GPT-5.1 Codex Max" },
-  { value: "gpt-5.2", label: "GPT-5.2" },
-  { value: "gpt-5.2-codex", label: "GPT-5.2 Codex" },
-  { value: "claude-opus-4-6", label: "Claude Opus 4.6" },
-  { value: "claude-sonnet-4-5-20250929", label: "Claude Sonnet 4.5" },
   { value: "claude-opus-4-5-20251101", label: "Claude Opus 4.5" },
+  { value: "claude-opus-4-6", label: "Claude Opus 4.6 (default)" },
+  { value: "claude-opus-4-6-fast", label: "Claude Opus 4.6 Fast Mode" },
+  { value: "claude-sonnet-4-5-20250929", label: "Claude Sonnet 4.5" },
+  { value: "claude-sonnet-4-6", label: "Claude Sonnet 4.6" },
   { value: "claude-haiku-4-5-20251001", label: "Claude Haiku 4.5" },
+  { value: "gpt-5.1", label: "GPT-5.1" },
+  { value: "gpt-5.1-codex", label: "GPT-5.1-Codex" },
+  { value: "gpt-5.1-codex-max", label: "GPT-5.1-Codex-Max" },
+  { value: "gpt-5.2", label: "GPT-5.2" },
+  { value: "gpt-5.2-codex", label: "GPT-5.2-Codex" },
+  { value: "gpt-5.3-codex", label: "GPT-5.3-Codex" },
   { value: "gemini-3-pro-preview", label: "Gemini 3 Pro" },
+  { value: "gemini-3.1-pro-preview", label: "Gemini 3.1 Pro" },
   { value: "gemini-3-flash-preview", label: "Gemini 3 Flash" },
   { value: "glm-4.7", label: "Droid Core (GLM-4.7)" },
+  { value: "glm-5", label: "Droid Core (GLM-5)" },
   { value: "kimi-k2.5", label: "Droid Core (Kimi K2.5)" },
+  { value: "minimax-m2.5", label: "Droid Core (MiniMax M2.5)" },
 ] as const;
 
 export const geminiModelOptions = [
-  { value: "gemini-3-pro-preview", label: "Gemini 3 Pro" },
+  { value: "gemini-3.1-pro-preview", label: "Gemini 3.1 Pro" },
   { value: "gemini-3-flash-preview", label: "Gemini 3 Flash" },
+  { value: "gemini-2.5-pro", label: "Gemini 2.5 Pro" },
+  { value: "gemini-2.5-flash", label: "Gemini 2.5 Flash" },
+  { value: "gemini-2.5-flash-lite", label: "Gemini 2.5 Flash Lite" },
 ] as const;
 
 const commonReasoningLevels: readonly ReasoningLevel[] = ["low", "medium", "high", "xhigh"];
@@ -53,11 +62,15 @@ const droidReasoningLevelsByModel: Record<string, readonly ReasoningLevel[]> = {
   "gpt-5.1-codex-max": ["low", "medium", "high", "xhigh"],
   "gpt-5.2": ["low", "medium", "high", "xhigh"],
   "gpt-5.2-codex": ["low", "medium", "high", "xhigh"],
+  "gpt-5.3-codex": ["low", "medium", "high", "xhigh"],
   "claude-sonnet-4-5-20250929": ["low", "medium", "high"],
+  "claude-sonnet-4-6": ["low", "medium", "high"],
   "claude-opus-4-5-20251101": ["low", "medium", "high"],
   "claude-haiku-4-5-20251001": ["low", "medium", "high"],
   "claude-opus-4-6": ["low", "medium", "high", "max"],
+  "claude-opus-4-6-fast": ["low", "medium", "high", "max"],
   "gemini-3-pro-preview": ["low", "medium", "high"],
+  "gemini-3.1-pro-preview": ["low", "medium", "high"],
   "gemini-3-flash-preview": ["low", "medium", "high"],
 };
 

package/src/lib/diagnostics/checks.ts

@@ -20,6 +20,7 @@ interface RunDiagnosticsDependencies {
   ) => Promise<AgentCapabilitiesMap>;
   isGitRepository?: (path: string) => Promise<boolean>;
   hasUncommittedChanges?: (path: string) => Promise<boolean>;
+  gitRefExists?: (path: string, ref: string) => Promise<boolean>;
   cleanupStaleLockfile?: typeof cleanupStaleLockfile;
   hasActiveLockfile?: typeof hasActiveLockfile;
   isTmuxInstalled?: () => boolean;
@@ -34,6 +35,7 @@ export interface RunDiagnosticsOptions {
   projectPath?: string;
   baseBranch?: string;
   commitSha?: string;
+  customInstructions?: string;
   capabilitiesByAgent?: AgentCapabilitiesMap;
   capabilityDiscoveryOptions?: CapabilityDiscoveryOptions;
   dependencies?: RunDiagnosticsDependencies;
@@ -136,6 +138,15 @@ async function hasGitUncommittedChanges(path: string): Promise<boolean> {
   return result.stdout.trim().length > 0;
 }
 
+async function hasGitRef(path: string, ref: string): Promise<boolean> {
+  if (ref.trim().length === 0) {
+    return false;
+  }
+
+  const result = await runGitInPath(path, ["rev-parse", "--verify", ref]);
+  return result.exitCode === 0;
+}
+
 function buildReport(
   context: DiagnosticContext,
   items: DiagnosticItem[],
@@ -165,6 +176,7 @@ export async function runDiagnostics(
   const resolveCapabilityDiscovery = deps.discoverAgentCapabilities ?? discoverAgentCapabilities;
   const resolveIsGitRepo = deps.isGitRepository ?? isGitRepository;
   const resolveHasChanges = deps.hasUncommittedChanges ?? hasGitUncommittedChanges;
+  const resolveGitRefExists = deps.gitRefExists ?? hasGitRef;
   const resolveCleanupStaleLockfile = deps.cleanupStaleLockfile ?? cleanupStaleLockfile;
   const resolveHasActiveLockfile = deps.hasActiveLockfile ?? hasActiveLockfile;
   const resolveIsTmuxInstalled = deps.isTmuxInstalled ?? isTmuxInstalled;
@@ -423,7 +435,86 @@ export async function runDiagnostics(
     }
 
     if (context === "run") {
-      if (!options.baseBranch && !options.commitSha && insideGitRepo && !gitRepoError) {
+      if (insideGitRepo && !gitRepoError && options.baseBranch) {
+        let baseRefExists = false;
+        let baseRefError: string | null = null;
+        try {
+          baseRefExists = await resolveGitRefExists(projectPath, options.baseBranch);
+        } catch (error) {
+          baseRefError = `${error}`;
+        }
+
+        if (baseRefError) {
+          items.push({
+            id: "git-base-ref",
+            category: "git",
+            title: "Base ref",
+            severity: "error",
+            summary: `Unable to validate base ref '${options.baseBranch}'.`,
+            details: baseRefError,
+            remediation: [runStep("git branch --all"), thenStep("rr run --base <existing-ref>")],
+          });
+        } else {
+          items.push({
+            id: "git-base-ref",
+            category: "git",
+            title: "Base ref",
+            severity: baseRefExists ? "ok" : "error",
+            summary: baseRefExists
+              ? `Base ref '${options.baseBranch}' exists.`
+              : `Base ref '${options.baseBranch}' was not found.`,
+            remediation: baseRefExists
+              ? []
+              : [runStep("git branch --all"), thenStep("rr run --base <existing-ref>")],
+          });
+        }
+      }
+
+      if (insideGitRepo && !gitRepoError && options.commitSha) {
+        let commitRefExists = false;
+        let commitRefError: string | null = null;
+        try {
+          commitRefExists = await resolveGitRefExists(projectPath, options.commitSha);
+        } catch (error) {
+          commitRefError = `${error}`;
+        }
+
+        if (commitRefError) {
+          items.push({
+            id: "git-commit-ref",
+            category: "git",
+            title: "Commit ref",
+            severity: "error",
+            summary: `Unable to validate commit ref '${options.commitSha}'.`,
+            details: commitRefError,
+            remediation: [
+              runStep("git rev-parse --verify <commit>"),
+              thenStep("rr run --commit <sha>"),
+            ],
+          });
+        } else {
+          items.push({
+            id: "git-commit-ref",
+            category: "git",
+            title: "Commit ref",
+            severity: commitRefExists ? "ok" : "error",
+            summary: commitRefExists
+              ? `Commit ref '${options.commitSha}' exists.`
+              : `Commit ref '${options.commitSha}' was not found.`,
+            remediation: commitRefExists
+              ? []
+              : [runStep("git log --oneline -n 20"), thenStep("rr run --commit <existing-sha>")],
+          });
+        }
+      }
+
+      if (
+        !options.baseBranch &&
+        !options.commitSha &&
+        !options.customInstructions &&
+        insideGitRepo &&
+        !gitRepoError
+      ) {
         let hasChanges = false;
         let hasChangesError: string | null = null;
         try {