ralph-prd 1.0.6 → 1.0.9

package/README.md

@@ -93,8 +93,10 @@ Options:
   --only-phase N     Force re-run phase N (1-based)
   --i-did-this       Skip Claude self-commit; run separate commit step
   --send-it          Push branch + open PR when all phases complete
-  --wait-for-it      Pause before each commit for review
-  --update-skills    Re-fetch skills from tahaJemmali/skills and exit
+  --wait-for-it           Pause before each commit for review
+  --skip-ship-check       Skip the post-commit ship-check step
+  --skip-on-verify-fail   Skip verification and continue instead of hard-stopping when all repair attempts fail
+  --update-skills         Re-fetch skills from tahaJemmali/skills and exit
   --version, -v      Print installed version and exit
 ```
 
@@ -145,6 +147,7 @@ writableDirs:
 flags:
   maxRepairs: 3
   sendIt: false
+  skipOnVerifyFail: false
 
 hooks:
   afterCommit: npm test

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ralph-prd",
-  "version": "1.0.6",
+  "version": "1.0.9",
   "description": "AI-powered phased implementation runner for Claude Code — from PRD to shipped code",
   "bin": {
     "ralph-prd": "./bin/install.mjs"

package/ralph/lib/config.mjs

@@ -29,7 +29,10 @@ function isGitRepo(dirPath) {
  * @property {number}      maxRepairs     - Max repair attempts per phase before hard-stopping (default 3)
  * @property {number|null} onlyPhase      - When set, only this 1-based phase index is run (force re-run)
  * @property {string}      logLevel       - "none" | "necessary" | "dump" (default "necessary")
- * @property {boolean}     skipShipCheck  - Skip the post-commit ship-check step for every phase
+ * @property {boolean}     skipShipCheck          - Skip the post-commit ship-check step for every phase
+ * @property {number}      shipCheckRetries       - Max ship-check attempts per phase before giving up (default 1)
+ * @property {boolean}     skipOnShipCheckFail    - When true, log and continue after all retries fail instead of hard-stopping
+ * @property {boolean}     skipOnVerifyFail       - Skip verification and continue instead of hard-stopping when all repair attempts fail
  */
 
 /**
@@ -60,7 +63,7 @@ function isGitRepo(dirPath) {
 function parseConfigYaml(content) {
   const repos = [];
   const writableDirs = [];
-  const flags = { iDidThis: false, sendIt: false, waitForIt: false, maxRepairs: 3, onlyPhase: null, logLevel: 'necessary', skipShipCheck: false };
+  const flags = { iDidThis: false, sendIt: false, waitForIt: false, maxRepairs: 3, onlyPhase: null, logLevel: 'necessary', skipShipCheck: false, shipCheckRetries: 1, skipOnShipCheckFail: true, skipOnVerifyFail: false };
   const hooks = { afterCommit: null };
   let section = null;
   let current = null;
@@ -115,9 +118,9 @@ function parseConfigYaml(content) {
         const [, key, val] = match;
         if (!(key in flags)) continue;
         const trimmedVal = val.trim();
-        if (key === 'maxRepairs') {
+        if (key === 'maxRepairs' || key === 'shipCheckRetries') {
           const n = parseInt(trimmedVal, 10);
-          if (!isNaN(n) && n > 0) flags.maxRepairs = n;
+          if (!isNaN(n) && n > 0) flags[key] = n;
         } else if (key === 'onlyPhase') {
           const n = parseInt(trimmedVal, 10);
           if (!isNaN(n) && n > 0) flags.onlyPhase = n;
@@ -160,7 +163,7 @@ function parseConfigYaml(content) {
  */
 export function resolveRepos(runnerDir) {
   const configPath = join(runnerDir, CONFIG_FILENAME);
-  const defaultFlags = { iDidThis: false, sendIt: false, waitForIt: false, maxRepairs: 3, onlyPhase: null, skipShipCheck: false };
+  const defaultFlags = { iDidThis: false, sendIt: false, waitForIt: false, maxRepairs: 3, onlyPhase: null, skipShipCheck: false, shipCheckRetries: 1, skipOnShipCheckFail: true, skipOnVerifyFail: false };
   const defaultHooks = { afterCommit: null };
 
   if (!existsSync(configPath)) {

package/ralph/ralph-claude.mjs

@@ -134,6 +134,8 @@ const sendItArg = args.includes('--send-it');
 const waitForItArg = args.includes('--wait-for-it');
 // Skip the post-commit ship-check step. Use when you don't have a ship-check skill.
 const skipShipCheckArg = args.includes('--skip-ship-check');
+// Skip verification and continue (rather than hard-stop) when all repair attempts fail.
+const skipOnVerifyFailArg = args.includes('--skip-on-verify-fail');
 // Run only one specific phase (1-based), force re-run even if already complete.
 const onlyPhaseArg = (() => {
   const idx = args.indexOf('--only-phase');
@@ -154,7 +156,7 @@ const logLevelArg = (() => {
 if (!planArg) {
   console.error(
     'Usage: node ralph-claude.mjs <plan-file.md> ' +
-    '[--reset|--dry-run|--i-did-this|--send-it|--wait-for-it|--skip-ship-check|--only-phase N|--log-level none|necessary|dump|--update-skills|--version]'
+    '[--reset|--dry-run|--i-did-this|--send-it|--wait-for-it|--skip-ship-check|--skip-on-verify-fail|--only-phase N|--log-level none|necessary|dump|--update-skills|--version]'
   );
   process.exit(1);
 }
@@ -349,6 +351,8 @@ async function main() {
   const sendIt = sendItArg || configFlags.sendIt;
   const waitForIt = waitForItArg || configFlags.waitForIt;
   const skipShipCheck = skipShipCheckArg || configFlags.skipShipCheck;
+  const skipOnShipCheckFail = configFlags.skipOnShipCheckFail;
+  const skipOnVerifyFail = skipOnVerifyFailArg || configFlags.skipOnVerifyFail;
   const onlyPhase = onlyPhaseArg ?? configFlags.onlyPhase ?? null;
   const logLevel = logLevelArg ?? configFlags.logLevel ?? 'necessary';
 
@@ -574,19 +578,26 @@ async function main() {
         }));
         console.log('ok');
       } catch (err) {
-        console.log('failed');
-        let errMsg;
-        if (err instanceof VerificationError) {
-          errMsg = `Verification failed for phase "${err.phaseName}"`;
-          console.error(`\n${errMsg}:`);
+        if (err instanceof VerificationError && skipOnVerifyFail) {
+          console.log(`skipped (failed ${configFlags.maxRepairs} time${configFlags.maxRepairs === 1 ? '' : 's'})`);
+          console.error(`\nVerification for "${err.phaseName}" failed ${configFlags.maxRepairs} time${configFlags.maxRepairs === 1 ? '' : 's'} — skipping to avoid token waste.`);
           if (err.failureNotes) console.error(err.failureNotes);
+          console.error(`Logs: ${logsDir}`);
         } else {
-          errMsg = `Unexpected error during verification: ${err.message}`;
-          console.error(`\n${errMsg}`);
+          console.log('failed');
+          let errMsg;
+          if (err instanceof VerificationError) {
+            errMsg = `Verification failed for phase "${err.phaseName}"`;
+            console.error(`\n${errMsg}:`);
+            if (err.failureNotes) console.error(err.failureNotes);
+          } else {
+            errMsg = `Unexpected error during verification: ${err.message}`;
+            console.error(`\n${errMsg}`);
+          }
+          console.error(`Logs: ${logsDir}`);
+          notify('Ralph — failed', errMsg);
+          process.exit(1);
         }
-        console.error(`Logs: ${logsDir}`);
-        notify('Ralph — failed', errMsg);
-        process.exit(1);
       }
 
       // Checkpoint: verification done
@@ -696,33 +707,87 @@ async function main() {
     if (skipShipCheck) {
       console.log(`  [${ts()}] ship-check… skipped`);
     } else {
-      const repoState = gatherRepoState(repos);
-      const shipCheckStart = Date.now();
-      process.stdout.write(`  [${ts()}] ship-check… `);
-      try {
-        ({ nextTaskNum: taskNum } = await runShipCheck({
-          phase,
-          repoState,
-          logWriter,
-          phaseNum,
-          startTaskNum: taskNum,
-          send,
-        }));
-        const dur = ((Date.now() - shipCheckStart) / 1000).toFixed(1);
-        console.log(`VERDICT: APPROVED (${dur}s)`);
-      } catch (err) {
-        const dur = ((Date.now() - shipCheckStart) / 1000).toFixed(1);
-        if (err instanceof ShipCheckError) {
-          console.log(`VERDICT: REMARKS (${dur}s)`);
-          console.error(`\nShip-check failed for phase "${err.phaseName}":`);
-          if (err.findings) console.error(err.findings);
-        } else {
-          console.log('failed');
-          console.error(`\nUnexpected error during ship-check: ${err.message}`);
+      const maxAttempts = configFlags.shipCheckRetries ?? 1;
+      let shipCheckPassed = false;
+
+      for (let attempt = 1; attempt <= maxAttempts; attempt++) {
+        const repoState = gatherRepoState(repos);
+        const shipCheckStart = Date.now();
+        const attemptSuffix = maxAttempts > 1 ? ` (attempt ${attempt}/${maxAttempts})` : '';
+        process.stdout.write(`  [${ts()}] ship-check${attemptSuffix}… `);
+
+        try {
+          ({ nextTaskNum: taskNum } = await runShipCheck({
+            phase,
+            repoState,
+            logWriter,
+            phaseNum,
+            startTaskNum: taskNum,
+            send,
+          }));
+          const dur = ((Date.now() - shipCheckStart) / 1000).toFixed(1);
+          console.log(`VERDICT: APPROVED (${dur}s)`);
+          shipCheckPassed = true;
+
+          // Ship-check repair may have modified files — commit any leftovers.
+          const postShipChanges = await scanChangedRepos(repos);
+          if (postShipChanges.length > 0) {
+            process.stdout.write(`  [${ts()}] post-ship-check commit… `);
+            try {
+              const { nextTaskNum, anyCommitted } = await runCommitStep({
+                phase,
+                repos,
+                safetyHeader,
+                logWriter,
+                phaseNum,
+                taskNum,
+                send,
+              });
+              taskNum = nextTaskNum;
+              console.log(anyCommitted ? 'ok' : 'skipped (no changes)');
+            } catch (err) {
+              console.log('failed');
+              const msg = err instanceof CommitError
+                ? `Phase "${err.phaseName}" post-ship-check commit failed: ${err.message}`
+                : `Unexpected error during post-ship-check commit: ${err.message}`;
+              console.error(`\n${msg}`);
+              console.error(`Logs: ${logsDir}`);
+              notify('Ralph — failed', msg);
+              process.exit(1);
+            }
+          }
+          break;
+        } catch (err) {
+          const dur = ((Date.now() - shipCheckStart) / 1000).toFixed(1);
+          if (err instanceof ShipCheckError) {
+            console.log(`VERDICT: REMARKS (${dur}s)`);
+            console.error(`\nShip-check failed for phase "${err.phaseName}":`);
+            if (err.findings) console.error(err.findings);
+          } else {
+            console.log('failed');
+            console.error(`\nUnexpected error during ship-check: ${err.message}`);
+            console.error(`Logs: ${logsDir}`);
+            notify('Ralph — failed', `Ship-check failed for "${phase.title}"`);
+            process.exit(1);
+          }
+
+          if (attempt < maxAttempts) {
+            console.error(`  Retrying ship-check (${attempt}/${maxAttempts} attempts used)…`);
+          }
         }
+      }
+
+      if (!shipCheckPassed) {
+        const attempts = `${maxAttempts} attempt${maxAttempts === 1 ? '' : 's'}`;
+        console.error(`\nShip-check did not pass after ${attempts} for phase "${phase.title}".`);
         console.error(`Logs: ${logsDir}`);
-        notify('Ralph — failed', `Ship-check failed for "${phase.title}"`);
-        process.exit(1);
+        if (skipOnShipCheckFail) {
+          console.error(`Continuing anyway (skipOnShipCheckFail: true).`);
+          notify('Ralph — ship-check skipped', `"${phase.title}" ship-check failed after ${attempts} — continuing`);
+        } else {
+          notify('Ralph — failed', `Ship-check failed for "${phase.title}" after ${attempts}`);
+          process.exit(1);
+        }
       }
     }
 

package/ralph/ralph.config.sample.yaml

@@ -53,3 +53,10 @@ flags:
   # have not installed a ship-check skill or want to disable the review gate.
   # CLI equivalent: --skip-ship-check
   skipShipCheck: false
+
+  # When all repair attempts are exhausted, skip verification and continue to
+  # the commit step instead of hard-stopping. Useful when the acceptance
+  # criteria require external credentials or manual steps that the agent cannot
+  # perform. Defaults to false (hard stop).
+  # CLI equivalent: --skip-on-verify-fail
+  skipOnVerifyFail: false