ralph-hero-mcp-server 2.5.139 → 2.5.140

package/dist/lib/error-signature.js

@@ -0,0 +1,194 @@
+/**
+ * Error-signature normalization and grouping for Langfuse OTel spans.
+ *
+ * Used by `ralph_hero__collate_debug` to collapse noisy, near-identical
+ * error spans into a small set of "signatures." Each signature is hashed to
+ * an 8-char ID that survives across runs, so Phase 3b's GitHub dedup can
+ * match an incoming group to an existing issue body by the hash marker.
+ *
+ * The normalization rules deliberately strip *dynamic* details (issue
+ * numbers, timestamps, UUIDs, hashes, quoted paths/names) while preserving
+ * the *structural* shape of the message. Two errors that differ only in
+ * which issue number triggered them collapse to the same signature.
+ */
+import { createHash } from "node:crypto";
+// ---------------------------------------------------------------------------
+// Normalization
+// ---------------------------------------------------------------------------
+const ISO_TIMESTAMP_RE = /\b\d{4}-\d{2}-\d{2}[T ]\d{2}:\d{2}:\d{2}(?:\.\d+)?(?:Z|[+-]\d{2}:?\d{2})?\b/g;
+const UUID_RE = /\b[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}\b/gi;
+const HEX_HASH_RE = /\b[0-9a-f]{8,}\b/gi;
+const ISSUE_NUMBER_RE = /#\d+/g;
+// Match runs of digits anywhere — without word boundaries so embedded
+// numbers like "60s" or "v2" collapse too. ISSUE_NUMBER_RE runs first so
+// "#42" becomes "#N" before this fires.
+const BARE_NUMBER_RE = /\d+/g;
+// Match double-quoted or single-quoted strings (non-greedy).
+const QUOTED_STRING_RE = /"[^"\n]*"|'[^'\n]*'/g;
+/**
+ * Normalize an error message into a comparable signature fragment.
+ *
+ * Order of replacements matters:
+ *   1. Quoted strings first (so a quoted ISO timestamp becomes `<STR>` not
+ *      `<TS>`).
+ *   2. ISO timestamps before UUIDs (timestamps can contain colons / dashes).
+ *   3. UUIDs before generic hex hashes (UUID format is stricter).
+ *   4. Issue numbers (`#NNN`) before bare numbers.
+ *   5. Bare numbers last.
+ *   6. Whitespace collapsed and result truncated to 200 chars.
+ */
+export function normalizeErrorMessage(msg) {
+    if (!msg)
+        return "";
+    let out = msg;
+    out = out.replace(QUOTED_STRING_RE, "<STR>");
+    out = out.replace(ISO_TIMESTAMP_RE, "<TS>");
+    out = out.replace(UUID_RE, "<ID>");
+    out = out.replace(HEX_HASH_RE, "<HASH>");
+    out = out.replace(ISSUE_NUMBER_RE, "#N");
+    out = out.replace(BARE_NUMBER_RE, "<N>");
+    out = out.replace(/\s+/g, " ").trim();
+    return out.slice(0, 200);
+}
+/**
+ * Build the signature key (pre-hash). Format:
+ *   `${spanName}:${errorType}:${normalizedMessage}`
+ */
+export function buildSignatureKey(spanName, errorType, normalizedMsg) {
+    return `${spanName}:${errorType}:${normalizedMsg}`;
+}
+/**
+ * SHA256 hash truncated to 8 hex chars. Stable across runs, suitable for
+ * dedup body markers like `**Hash**: \`a1b2c3d4\``.
+ */
+export function hashSignature(key) {
+    return createHash("sha256").update(key).digest("hex").slice(0, 8);
+}
+// ---------------------------------------------------------------------------
+// Span helpers
+// ---------------------------------------------------------------------------
+/**
+ * Extract the `ralph_hero.error_type` attribute from a span's metadata, with
+ * fallback to a hoisted `errorType` field. Returns `"unknown"` if neither is
+ * present.
+ */
+export function getErrorType(span) {
+    if (span.errorType)
+        return span.errorType;
+    const meta = span.metadata ?? {};
+    const fromMeta = meta["ralph_hero.error_type"] ??
+        meta.error_type ??
+        meta.errorType;
+    if (typeof fromMeta === "string" && fromMeta.length > 0)
+        return fromMeta;
+    return "unknown";
+}
+/**
+ * Extract the error message from a span. Prefers `message` (Langfuse
+ * `statusMessage`), then `metadata.exception.message`, then `metadata.error`.
+ */
+export function getErrorMessage(span) {
+    if (span.message)
+        return span.message;
+    const meta = span.metadata ?? {};
+    const exception = meta.exception;
+    if (exception &&
+        typeof exception === "object" &&
+        "message" in exception &&
+        typeof exception.message === "string") {
+        return exception.message;
+    }
+    if (typeof meta.error === "string")
+        return meta.error;
+    if (typeof meta.message === "string")
+        return meta.message;
+    return "";
+}
+/**
+ * Convert a `LangfuseObservation` to a `SignatureSpan`. Hoists the
+ * `ralph_hero.error_type` attribute up to the top level.
+ */
+export function observationToSpan(obs) {
+    const meta = obs.metadata ?? {};
+    const errorType = typeof meta["ralph_hero.error_type"] === "string"
+        ? meta["ralph_hero.error_type"]
+        : undefined;
+    return {
+        name: obs.name,
+        traceId: obs.traceId,
+        startTime: obs.startTime,
+        endTime: obs.endTime,
+        metadata: meta,
+        errorType,
+        message: obs.statusMessage,
+        level: obs.level,
+    };
+}
+// ---------------------------------------------------------------------------
+// Grouping
+// ---------------------------------------------------------------------------
+function buildTraceUrl(langfuseHost, projectId, traceId) {
+    const host = (langfuseHost ?? "http://localhost:3100").replace(/\/+$/, "");
+    const project = projectId ?? "<defaultProjectId>";
+    return `${host}/project/${project}/traces/${traceId}`;
+}
+/**
+ * Group spans by signature. Returns groups sorted by `count` descending.
+ *
+ * Spans below `minOccurrences` (default 3) are filtered out. Each group's
+ * `sampleSpans` contains up to 3 representative spans, most-recent first.
+ */
+export function groupSpansBySignature(spans, opts = {}) {
+    const minOccurrences = opts.minOccurrences ?? 3;
+    const buckets = new Map();
+    for (const span of spans) {
+        const errorType = getErrorType(span);
+        const normalized = normalizeErrorMessage(getErrorMessage(span));
+        const signature = buildSignatureKey(span.name, errorType, normalized);
+        const hash = hashSignature(signature);
+        const existing = buckets.get(hash);
+        if (existing) {
+            existing.count += 1;
+            if (span.startTime > existing.lastSeen) {
+                existing.lastSeen = span.startTime;
+                existing.latestTraceId = span.traceId;
+            }
+            if (span.startTime < existing.firstSeen) {
+                existing.firstSeen = span.startTime;
+            }
+            existing.spans.push(span);
+        }
+        else {
+            buckets.set(hash, {
+                signature,
+                hash,
+                count: 1,
+                firstSeen: span.startTime,
+                lastSeen: span.startTime,
+                latestTraceId: span.traceId,
+                spans: [span],
+            });
+        }
+    }
+    const groups = [];
+    for (const bucket of buckets.values()) {
+        if (bucket.count < minOccurrences)
+            continue;
+        // Sort sample spans by startTime desc, keep up to 3.
+        const sampleSpans = [...bucket.spans]
+            .sort((a, b) => (b.startTime > a.startTime ? 1 : -1))
+            .slice(0, 3);
+        groups.push({
+            signature: bucket.signature,
+            hash: bucket.hash,
+            count: bucket.count,
+            firstSeen: bucket.firstSeen,
+            lastSeen: bucket.lastSeen,
+            exampleTraceUrl: buildTraceUrl(opts.langfuseHost, opts.projectId, bucket.latestTraceId),
+            sampleSpans,
+        });
+    }
+    groups.sort((a, b) => b.count - a.count);
+    return groups;
+}
+//# sourceMappingURL=error-signature.js.map

package/dist/lib/langfuse-client.js

@@ -0,0 +1,95 @@
+/**
+ * Minimal Langfuse HTTP client for querying traces and observations.
+ *
+ * Used by `ralph_hero__collate_debug` to fetch error spans emitted by the
+ * MCP server's OTel pipeline (see `telemetry.ts`). Authenticates via HTTP
+ * basic auth with `LANGFUSE_PUBLIC_KEY` and `LANGFUSE_SECRET_KEY`.
+ *
+ * No SDK dependency — uses Node's native `fetch` (Node 20+).
+ *
+ * Reference: https://langfuse.com/docs/api
+ */
+// ---------------------------------------------------------------------------
+// Factory
+// ---------------------------------------------------------------------------
+const DEFAULT_HOST = "http://localhost:3100";
+function buildAuthHeader(publicKey, secretKey) {
+    const credentials = `${publicKey}:${secretKey}`;
+    // Node 20+ provides global Buffer
+    const encoded = Buffer.from(credentials, "utf-8").toString("base64");
+    return `Basic ${encoded}`;
+}
+function appendQueryParams(url, params) {
+    if (!params)
+        return;
+    for (const [key, value] of Object.entries(params)) {
+        if (value === undefined || value === null)
+            continue;
+        url.searchParams.set(key, String(value));
+    }
+}
+/**
+ * Create a Langfuse HTTP client.
+ *
+ * Throws on construction if `publicKey` or `secretKey` are missing (in args
+ * and in env), because every endpoint requires authentication.
+ */
+export function createLangfuseClient(options = {}) {
+    const host = (options.host ?? process.env.LANGFUSE_HOST ?? DEFAULT_HOST)
+        .replace(/\/+$/, "");
+    const publicKey = options.publicKey ?? process.env.LANGFUSE_PUBLIC_KEY;
+    const secretKey = options.secretKey ?? process.env.LANGFUSE_SECRET_KEY;
+    const fetchImpl = options.fetchImpl ?? fetch;
+    if (!publicKey || !secretKey) {
+        throw new Error("Langfuse credentials missing: set LANGFUSE_PUBLIC_KEY and LANGFUSE_SECRET_KEY (or pass via options).");
+    }
+    const authHeader = buildAuthHeader(publicKey, secretKey);
+    async function request(path, params) {
+        const url = new URL(`${host}${path}`);
+        appendQueryParams(url, params);
+        const response = await fetchImpl(url.toString(), {
+            method: "GET",
+            headers: {
+                Authorization: authHeader,
+                Accept: "application/json",
+            },
+        });
+        if (!response.ok) {
+            const bodyText = await response.text().catch(() => "");
+            throw new Error(`Langfuse request failed: ${response.status} ${response.statusText}` +
+                (bodyText ? ` — ${bodyText.slice(0, 200)}` : ""));
+        }
+        return (await response.json());
+    }
+    async function queryTraces(params = {}) {
+        return request("/api/public/traces", params);
+    }
+    async function queryObservations(params = {}) {
+        return request("/api/public/observations", params);
+    }
+    async function queryAllObservations(params = {}, maxPages = 10) {
+        const all = [];
+        const limit = params.limit ?? 100;
+        let page = params.page ?? 1;
+        for (let i = 0; i < maxPages; i++) {
+            const result = await queryObservations({ ...params, page, limit });
+            if (!result.data || result.data.length === 0)
+                break;
+            all.push(...result.data);
+            const totalPages = result.meta?.totalPages;
+            if (totalPages !== undefined && page >= totalPages)
+                break;
+            if (result.data.length < limit)
+                break;
+            page += 1;
+        }
+        return all;
+    }
+    return {
+        host,
+        queryTraces,
+        queryObservations,
+        queryAllObservations,
+    };
+}
+//# sourceMappingURL=langfuse-client.js.map

package/dist/tools/debug-tools.js

@@ -1,10 +1,15 @@
 /**
  * MCP tools for debug log collation and statistics.
  *
- * Provides `ralph_hero__collate_debug` (error grouping + GitHub issue creation)
- * and `ralph_hero__debug_stats` (tool call aggregation metrics).
+ * Provides:
+ *   - `ralph_hero__collate_debug` (v2 — queries Langfuse for error spans,
+ *     groups by normalized signature, returns the grouped report; GitHub
+ *     issue creation lands in Phase 3b / GH-1100)
+ *   - `ralph_hero__debug_stats` (v1 — aggregates JSONL logs; preserved for
+ *     backward compat, not extended)
  *
- * Only registered when RALPH_DEBUG=true. Reads JSONL logs written by DebugLogger.
+ * Only registered when `RALPH_DEBUG=true`. JSONL helpers below still back
+ * `debug_stats`; the new Langfuse path is fully separate.
  */
 import { readdir, readFile } from "node:fs/promises";
 import { join } from "node:path";
@@ -13,6 +18,8 @@ import { createHash } from "node:crypto";
 import { z } from "zod";
 import { toolSuccess, toolError } from "../types.js";
 import { zBoolish } from "../lib/zod-helpers.js";
+import { createLangfuseClient, } from "../lib/langfuse-client.js";
+import { groupSpansBySignature, observationToSpan, } from "../lib/error-signature.js";
 // ---------------------------------------------------------------------------
 // JSONL Parsing
 // ---------------------------------------------------------------------------
@@ -174,123 +181,97 @@ export function aggregateStats(events, groupBy) {
         groups,
     };
 }
-// ---------------------------------------------------------------------------
-// Register Debug Tools
-// ---------------------------------------------------------------------------
+let langfuseClientFactory = () => createLangfuseClient();
+/**
+ * Override the Langfuse client factory. Returns a disposer that restores the
+ * previous factory (used by tests).
+ */
+export function setLangfuseClientFactory(factory) {
+    const prev = langfuseClientFactory;
+    langfuseClientFactory = factory;
+    return () => {
+        langfuseClientFactory = prev;
+    };
+}
 export function registerDebugTools(server, client) {
     const logDir = join(homedir(), ".ralph-hero", "logs");
+    // `client` is referenced by `debug_stats` (legacy) and reserved for Phase 3b
+    // (GH-1100), which will use it for GitHub dedup + issue creation.
+    void client;
     // -------------------------------------------------------------------------
-    // ralph_hero__collate_debug
+    // ralph_hero__collate_debug (v2 — Langfuse path)
     // -------------------------------------------------------------------------
-    server.tool("ralph_hero__collate_debug", "Collate debug log errors into GitHub issues. Reads JSONL logs, groups errors by normalized signature, deduplicates against existing `debug-auto` labeled issues, and creates/updates issues. Returns: summary of issues created, updated, and total occurrences.", {
+    server.tool("ralph_hero__collate_debug", "Query Langfuse for error spans in a time window, normalize messages, and group by signature. Phase 3a returns the grouped report only (dryRun forced true); Phase 3b (GH-1100) adds GitHub issue dedup + create/comment. Returns: { since, errorGroups, totalOccurrences, dryRun, groups[] }.", {
         since: z
             .string()
             .optional()
-            .describe("ISO date string. Only process events after this time (default: 24h ago)"),
+            .describe("ISO date string. Only spans whose startTime >= this value are considered (default: 24h ago)."),
         dryRun: zBoolish()
             .optional()
-            .default(false)
-            .describe("If true, report what would be created/updated without making changes"),
+            .default(true)
+            .describe("Phase 3a only honors dryRun=true; passing false returns a stub error until Phase 3b lands."),
+        minOccurrences: z
+            .number()
+            .int()
+            .min(1)
+            .optional()
+            .default(3)
+            .describe("Filter out signatures with fewer occurrences (default: 3)."),
         projectNumber: z
             .number()
             .optional()
-            .describe("Project number override (defaults to configured project)"),
+            .describe("Project number override (reserved for Phase 3b)."),
     }, async (args) => {
         try {
+            const dryRun = args.dryRun ?? true;
+            if (!dryRun) {
+                return toolError("dryRun=false requires GH-1100 (Phase 3b) — not yet implemented");
+            }
+            const minOccurrences = args.minOccurrences ?? 3;
             const sinceDate = args.since
                 ? new Date(args.since)
                 : new Date(Date.now() - 24 * 60 * 60 * 1000);
-            const { events, sessionsAnalyzed } = await readLogEvents(logDir, sinceDate);
-            const errorGroups = groupErrors(events);
-            if (errorGroups.length === 0) {
-                return toolSuccess({
-                    message: "No errors found in the specified time window.",
-                    sessionsAnalyzed,
-                    since: sinceDate.toISOString(),
-                });
+            if (Number.isNaN(sinceDate.getTime())) {
+                return toolError(`Invalid 'since' value: ${args.since}`);
             }
-            let issuesCreated = 0;
-            let issuesUpdated = 0;
-            let totalOccurrences = 0;
-            const owner = client.config.owner;
-            const repo = client.config.repo;
-            for (const group of errorGroups) {
-                totalOccurrences += group.count;
-                if (args.dryRun)
-                    continue;
-                if (!owner || !repo) {
-                    return toolError("RALPH_GH_OWNER and RALPH_GH_REPO must be set for issue creation");
-                }
-                // Search for existing issue with this hash
-                const searchQuery = `repo:${owner}/${repo} is:issue is:open label:debug-auto "${group.hash}" in:body`;
-                let existingIssueNumber;
-                try {
-                    const searchResult = await client.query(`query SearchDebugIssues($q: String!) {
-                search(query: $q, type: ISSUE, first: 1) {
-                  nodes {
-                    ... on Issue { number }
-                  }
-                }
-              }`, { q: searchQuery });
-                    existingIssueNumber = searchResult.search.nodes[0]?.number;
-                }
-                catch {
-                    // Search failed, treat as no existing issue
-                }
-                if (existingIssueNumber) {
-                    // Add occurrence comment
-                    await client.mutate(`mutation AddComment($subjectId: ID!, $body: String!) {
-                addComment(input: { subjectId: $subjectId, body: $body }) {
-                  commentEdge { node { id } }
-                }
-              }`, {
-                        subjectId: `issue:${existingIssueNumber}`,
-                        body: `## Occurrence Report\n\n- Count: ${group.count}\n- Period: ${group.firstSeen} — ${group.lastSeen}\n- Signature: \`${group.signature}\``,
-                    }).catch(() => {
-                        // Best-effort comment
-                    });
-                    issuesUpdated++;
-                }
-                else {
-                    // Create new issue
-                    try {
-                        await client.mutate(`mutation CreateIssue($repoId: ID!, $title: String!, $body: String!) {
-                  createIssue(input: { repositoryId: $repoId, title: $title, body: $body }) {
-                    issue { number }
-                  }
-                }`, {
-                            repoId: `placeholder`, // Would need actual repo ID
-                            title: `[debug-auto] ${getEventName(group.sample)} ${getErrorType(group.sample)}`,
-                            body: `## Debug Auto-Report\n\n**Hash**: \`${group.hash}\`\n**Signature**: \`${group.signature}\`\n**Occurrences**: ${group.count}\n**First seen**: ${group.firstSeen}\n**Last seen**: ${group.lastSeen}\n\n### Sample Error\n\n\`\`\`json\n${JSON.stringify(group.sample, null, 2)}\n\`\`\`\n\n---\n_Auto-generated by ralph_hero__collate_debug_`,
-                        }).catch(() => {
-                            // Best-effort issue creation
-                        });
-                        issuesCreated++;
-                    }
-                    catch {
-                        // Skip failed creations
-                    }
-                }
+            let langfuse;
+            try {
+                langfuse = langfuseClientFactory();
             }
+            catch (error) {
+                return toolError(`Langfuse client unavailable: ${error instanceof Error ? error.message : String(error)}`);
+            }
+            const fromStartTime = sinceDate.toISOString();
+            const observations = await langfuse.queryAllObservations({
+                type: "SPAN",
+                level: "ERROR",
+                fromStartTime,
+                limit: 100,
+            });
+            const spans = observations.map(observationToSpan);
+            const groups = groupSpansBySignature(spans, {
+                minOccurrences,
+                langfuseHost: langfuse.host,
+            });
+            const totalOccurrences = groups.reduce((sum, g) => sum + g.count, 0);
             return toolSuccess({
-                since: sinceDate.toISOString(),
-                sessionsAnalyzed,
-                errorGroups: errorGroups.length,
+                since: fromStartTime,
+                errorGroups: groups.length,
                 totalOccurrences,
-                issuesCreated: args.dryRun ? 0 : issuesCreated,
-                issuesUpdated: args.dryRun ? 0 : issuesUpdated,
-                dryRun: args.dryRun,
-                groups: errorGroups.map((g) => ({
-                    hash: g.hash,
+                dryRun: true,
+                groups: groups.map((g) => ({
                     signature: g.signature,
+                    hash: g.hash,
                     count: g.count,
                     firstSeen: g.firstSeen,
                     lastSeen: g.lastSeen,
+                    exampleTraceUrl: g.exampleTraceUrl,
+                    sampleSpans: g.sampleSpans.slice(0, 3),
                 })),
             });
         }
         catch (error) {
-            return toolError(`Failed to collate debug logs: ${error instanceof Error ? error.message : String(error)}`);
+            return toolError(`Failed to collate debug spans: ${error instanceof Error ? error.message : String(error)}`);
         }
     });
     // -------------------------------------------------------------------------

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ralph-hero-mcp-server",
-  "version": "2.5.139",
+  "version": "2.5.140",
   "description": "MCP server for GitHub Projects V2 - Ralph workflow automation",
   "type": "module",
   "main": "dist/index.js",