ralph-cli-sandboxed 0.2.4 → 0.2.6

package/dist/commands/init.js

@@ -14,118 +14,174 @@ const PROMPT_FILE = "prompt.md";
 const PRD_FILE = "prd.json";
 const PROGRESS_FILE = "progress.txt";
 const PRD_GUIDE_FILE = "HOW-TO-WRITE-PRDs.md";
-export async function init(_args) {
+export async function init(args) {
     const cwd = process.cwd();
     const ralphDir = join(cwd, RALPH_DIR);
+    const useDefaults = args.includes("-y") || args.includes("--yes");
     console.log("Initializing ralph in current directory...\n");
     // Check for existing .ralph directory
     if (existsSync(ralphDir)) {
-        const reinit = await promptConfirm(".ralph/ directory already exists. Re-initialize?");
-        if (!reinit) {
-            console.log("Aborted.");
-            return;
+        if (!useDefaults) {
+            const reinit = await promptConfirm(".ralph/ directory already exists. Re-initialize?");
+            if (!reinit) {
+                console.log("Aborted.");
+                return;
+            }
         }
     }
     else {
         mkdirSync(ralphDir, { recursive: true });
         console.log(`Created ${RALPH_DIR}/`);
     }
-    // Step 1: Select CLI provider (first)
     const CLI_PROVIDERS = getCliProviders();
-    const providerKeys = Object.keys(CLI_PROVIDERS);
-    const providerNames = providerKeys.map(k => `${CLI_PROVIDERS[k].name} - ${CLI_PROVIDERS[k].description}`);
-    const selectedProviderName = await promptSelectWithArrows("Select your AI CLI provider:", providerNames);
-    const selectedProviderIndex = providerNames.indexOf(selectedProviderName);
-    const selectedCliProviderKey = providerKeys[selectedProviderIndex];
-    const selectedProvider = CLI_PROVIDERS[selectedCliProviderKey];
+    const LANGUAGES = getLanguages();
+    let selectedCliProviderKey;
     let cliConfig;
-    // Handle custom CLI provider
-    if (selectedCliProviderKey === "custom") {
-        const customCommand = await promptInput("\nEnter your CLI command: ");
-        const customArgsInput = await promptInput("Enter default arguments (space-separated): ");
-        const customArgs = customArgsInput.trim() ? customArgsInput.trim().split(/\s+/) : [];
-        const customYoloArgsInput = await promptInput("Enter yolo/auto-approve arguments (space-separated): ");
-        const customYoloArgs = customYoloArgsInput.trim() ? customYoloArgsInput.trim().split(/\s+/) : [];
-        const customPromptArgsInput = await promptInput("Enter prompt arguments (e.g., -p for flag-based, leave empty for positional): ");
-        const customPromptArgs = customPromptArgsInput.trim() ? customPromptArgsInput.trim().split(/\s+/) : [];
+    let selectedKey;
+    let selectedTechnologies = [];
+    let checkCommand;
+    let testCommand;
+    if (useDefaults) {
+        // Use defaults: Claude CLI + Node.js
+        selectedCliProviderKey = "claude";
+        const provider = CLI_PROVIDERS[selectedCliProviderKey];
         cliConfig = {
-            command: customCommand || "claude",
-            args: customArgs,
-            yoloArgs: customYoloArgs.length > 0 ? customYoloArgs : undefined,
-            promptArgs: customPromptArgs,
+            command: provider.command,
+            args: provider.defaultArgs,
+            yoloArgs: provider.yoloArgs.length > 0 ? provider.yoloArgs : undefined,
+            promptArgs: provider.promptArgs ?? [],
         };
+        selectedKey = "node";
+        const config = LANGUAGES[selectedKey];
+        checkCommand = config.checkCommand;
+        testCommand = config.testCommand;
+        console.log(`Using defaults: ${CLI_PROVIDERS[selectedCliProviderKey].name} + ${LANGUAGES[selectedKey].name}`);
     }
     else {
-        cliConfig = {
-            command: selectedProvider.command,
-            args: selectedProvider.defaultArgs,
-            yoloArgs: selectedProvider.yoloArgs.length > 0 ? selectedProvider.yoloArgs : undefined,
-            promptArgs: selectedProvider.promptArgs ?? [],
-        };
-    }
-    console.log(`\nSelected CLI provider: ${CLI_PROVIDERS[selectedCliProviderKey].name}`);
-    // Step 2: Select language (second)
-    const LANGUAGES = getLanguages();
-    const languageKeys = Object.keys(LANGUAGES);
-    const languageNames = languageKeys.map(k => `${LANGUAGES[k].name} - ${LANGUAGES[k].description}`);
-    const selectedName = await promptSelectWithArrows("Select your project language/runtime:", languageNames);
-    const selectedIndex = languageNames.indexOf(selectedName);
-    const selectedKey = languageKeys[selectedIndex];
-    const config = LANGUAGES[selectedKey];
-    console.log(`\nSelected language: ${config.name}`);
-    // Step 3: Select technology stack if available (third)
-    let selectedTechnologies = [];
-    if (config.technologies && config.technologies.length > 0) {
-        const techOptions = config.technologies.map(t => `${t.name} - ${t.description}`);
-        const techNames = config.technologies.map(t => t.name);
-        selectedTechnologies = await promptMultiSelectWithArrows("Select your technology stack (optional):", techOptions);
-        // Convert display names back to just technology names for predefined options
-        selectedTechnologies = selectedTechnologies.map(sel => {
-            const idx = techOptions.indexOf(sel);
-            return idx >= 0 ? techNames[idx] : sel;
-        });
-        if (selectedTechnologies.length > 0) {
-            console.log(`\nSelected technologies: ${selectedTechnologies.join(", ")}`);
+        // Step 1: Select CLI provider (first)
+        const providerKeys = Object.keys(CLI_PROVIDERS);
+        const providerNames = providerKeys.map(k => `${CLI_PROVIDERS[k].name} - ${CLI_PROVIDERS[k].description}`);
+        const selectedProviderName = await promptSelectWithArrows("Select your AI CLI provider:", providerNames);
+        const selectedProviderIndex = providerNames.indexOf(selectedProviderName);
+        selectedCliProviderKey = providerKeys[selectedProviderIndex];
+        const selectedProvider = CLI_PROVIDERS[selectedCliProviderKey];
+        // Handle custom CLI provider
+        if (selectedCliProviderKey === "custom") {
+            const customCommand = await promptInput("\nEnter your CLI command: ");
+            const customArgsInput = await promptInput("Enter default arguments (space-separated): ");
+            const customArgs = customArgsInput.trim() ? customArgsInput.trim().split(/\s+/) : [];
+            const customYoloArgsInput = await promptInput("Enter yolo/auto-approve arguments (space-separated): ");
+            const customYoloArgs = customYoloArgsInput.trim() ? customYoloArgsInput.trim().split(/\s+/) : [];
+            const customPromptArgsInput = await promptInput("Enter prompt arguments (e.g., -p for flag-based, leave empty for positional): ");
+            const customPromptArgs = customPromptArgsInput.trim() ? customPromptArgsInput.trim().split(/\s+/) : [];
+            cliConfig = {
+                command: customCommand || "claude",
+                args: customArgs,
+                yoloArgs: customYoloArgs.length > 0 ? customYoloArgs : undefined,
+                promptArgs: customPromptArgs,
+            };
         }
         else {
-            console.log("\nNo technologies selected.");
+            cliConfig = {
+                command: selectedProvider.command,
+                args: selectedProvider.defaultArgs,
+                yoloArgs: selectedProvider.yoloArgs.length > 0 ? selectedProvider.yoloArgs : undefined,
+                promptArgs: selectedProvider.promptArgs ?? [],
+            };
+        }
+        console.log(`\nSelected CLI provider: ${CLI_PROVIDERS[selectedCliProviderKey].name}`);
+        // Step 2: Select language (second)
+        const languageKeys = Object.keys(LANGUAGES);
+        const languageNames = languageKeys.map(k => `${LANGUAGES[k].name} - ${LANGUAGES[k].description}`);
+        const selectedName = await promptSelectWithArrows("Select your project language/runtime:", languageNames);
+        const selectedIndex = languageNames.indexOf(selectedName);
+        selectedKey = languageKeys[selectedIndex];
+        const config = LANGUAGES[selectedKey];
+        console.log(`\nSelected language: ${config.name}`);
+        // Step 3: Select technology stack if available (third)
+        if (config.technologies && config.technologies.length > 0) {
+            const techOptions = config.technologies.map(t => `${t.name} - ${t.description}`);
+            const techNames = config.technologies.map(t => t.name);
+            selectedTechnologies = await promptMultiSelectWithArrows("Select your technology stack (optional):", techOptions);
+            // Convert display names back to just technology names for predefined options
+            selectedTechnologies = selectedTechnologies.map(sel => {
+                const idx = techOptions.indexOf(sel);
+                return idx >= 0 ? techNames[idx] : sel;
+            });
+            if (selectedTechnologies.length > 0) {
+                console.log(`\nSelected technologies: ${selectedTechnologies.join(", ")}`);
+            }
+            else {
+                console.log("\nNo technologies selected.");
+            }
+        }
+        // Allow custom commands for "none" language
+        checkCommand = config.checkCommand;
+        testCommand = config.testCommand;
+        if (selectedKey === "none") {
+            checkCommand = await promptInput("\nEnter your type/build check command: ") || checkCommand;
+            testCommand = await promptInput("Enter your test command: ") || testCommand;
         }
-    }
-    // Allow custom commands for "none" language
-    let checkCommand = config.checkCommand;
-    let testCommand = config.testCommand;
-    if (selectedKey === "none") {
-        checkCommand = await promptInput("\nEnter your type/build check command: ") || checkCommand;
-        testCommand = await promptInput("Enter your test command: ") || testCommand;
     }
     const finalConfig = {
-        ...config,
+        ...LANGUAGES[selectedKey],
         checkCommand,
         testCommand,
     };
     // Generate image name from directory name
     const projectName = basename(cwd).toLowerCase().replace(/[^a-z0-9-]/g, "-");
     const imageName = `ralph-${projectName}`;
-    // Write config file
+    // Write config file with all available options (defaults or empty values)
     const configData = {
+        // Required fields
         language: selectedKey,
         checkCommand: finalConfig.checkCommand,
         testCommand: finalConfig.testCommand,
         imageName,
+        // CLI configuration
         cli: cliConfig,
         cliProvider: selectedCliProviderKey,
+        // Optional fields with defaults/empty values for discoverability
+        notifyCommand: "",
+        technologies: selectedTechnologies.length > 0 ? selectedTechnologies : [],
+        javaVersion: selectedKey === "java" ? 21 : null,
+        // Docker configuration options
+        docker: {
+            ports: [],
+            volumes: [],
+            environment: {},
+            git: {
+                name: "",
+                email: "",
+            },
+            packages: [],
+            buildCommands: {
+                root: [],
+                node: [],
+            },
+            startCommand: "",
+            asciinema: {
+                enabled: false,
+                autoRecord: false,
+                outputDir: ".recordings",
+            },
+            firewall: {
+                allowedDomains: [],
+            },
+        },
+        // Claude-specific configuration (MCP servers and skills)
+        claude: {
+            mcpServers: {},
+            skills: [],
+        },
     };
-    // Add technologies if any were selected
-    if (selectedTechnologies.length > 0) {
-        configData.technologies = selectedTechnologies;
-    }
     const configPath = join(ralphDir, CONFIG_FILE);
     writeFileSync(configPath, JSON.stringify(configData, null, 2) + "\n");
     console.log(`\nCreated ${RALPH_DIR}/${CONFIG_FILE}`);
     // Write prompt file (ask if exists) - uses template with $variables
     const prompt = generatePromptTemplate();
     const promptPath = join(ralphDir, PROMPT_FILE);
-    if (existsSync(promptPath)) {
+    if (existsSync(promptPath) && !useDefaults) {
         const overwritePrompt = await promptConfirm(`${RALPH_DIR}/${PROMPT_FILE} already exists. Overwrite?`);
         if (overwritePrompt) {
             writeFileSync(promptPath, prompt + "\n");
@@ -137,7 +193,7 @@ export async function init(_args) {
     }
     else {
         writeFileSync(promptPath, prompt + "\n");
-        console.log(`Created ${RALPH_DIR}/${PROMPT_FILE}`);
+        console.log(`${existsSync(promptPath) ? "Updated" : "Created"} ${RALPH_DIR}/${PROMPT_FILE}`);
     }
     // Create PRD if not exists
     const prdPath = join(ralphDir, PRD_FILE);

package/dist/commands/run.js

@@ -265,8 +265,8 @@ export async function run(args) {
     });
     const paths = getPaths();
     const cliConfig = getCliConfig(config);
-    // Safety margin for iteration limit (recalculated dynamically each iteration)
-    const ITERATION_SAFETY_MARGIN = 3;
+    // Progress tracking: stop only if no tasks complete after N iterations
+    const MAX_ITERATIONS_WITHOUT_PROGRESS = 3;
     // Get requested iteration count (may be adjusted dynamically)
     const requestedIterations = parseInt(filteredArgs[0]) || Infinity;
     // Container is required, so always run with skip-permissions
@@ -294,21 +294,19 @@ export async function run(args) {
     let consecutiveFailures = 0;
     let lastExitCode = 0;
     let iterationCount = 0;
+    // Progress tracking for --all mode
+    // Progress = tasks completed OR new tasks added (allows ralph to expand the PRD)
+    const initialCounts = countPrdItems(paths.prd, category);
+    let lastCompletedCount = initialCounts.complete;
+    let lastTotalCount = initialCounts.total;
+    let iterationsWithoutProgress = 0;
     try {
         while (true) {
             iterationCount++;
-            // Dynamic iteration limit: recalculate based on current incomplete count
-            // This allows the limit to expand if tasks are added during the run
             const currentCounts = countPrdItems(paths.prd, category);
-            const dynamicMaxIterations = currentCounts.incomplete + ITERATION_SAFETY_MARGIN;
             // Check if we should stop (not in loop mode)
-            if (!loopMode) {
-                if (allMode && iterationCount > dynamicMaxIterations) {
-                    console.log(`\nStopping: reached iteration limit (${dynamicMaxIterations}) with ${currentCounts.incomplete} tasks remaining.`);
-                    console.log("This may indicate tasks are not completing. Check the PRD and progress.");
-                    break;
-                }
-                if (!allMode && iterationCount > Math.min(requestedIterations, dynamicMaxIterations)) {
+            if (!loopMode && !allMode) {
+                if (iterationCount > requestedIterations) {
                     break;
                 }
             }
@@ -320,7 +318,7 @@ export async function run(args) {
                 console.log(`Iteration ${iterationCount}`);
             }
             else {
-                console.log(`Iteration ${iterationCount} of ${Math.min(requestedIterations, dynamicMaxIterations)}`);
+                console.log(`Iteration ${iterationCount} of ${requestedIterations}`);
             }
             console.log(`${"=".repeat(50)}\n`);
             // Load a valid copy of the PRD before handing to the LLM
@@ -397,6 +395,29 @@ export async function run(args) {
             filteredPrdPath = null;
             // Validate and recover PRD if the LLM corrupted it
             validateAndRecoverPrd(paths.prd, validPrd);
+            // Track progress for --all mode: stop if no progress after N iterations
+            // Progress = tasks completed OR new tasks added (allows ralph to expand the PRD)
+            if (allMode) {
+                const progressCounts = countPrdItems(paths.prd, category);
+                const tasksCompleted = progressCounts.complete > lastCompletedCount;
+                const tasksAdded = progressCounts.total > lastTotalCount;
+                if (tasksCompleted || tasksAdded) {
+                    // Progress made - reset counter
+                    iterationsWithoutProgress = 0;
+                    lastCompletedCount = progressCounts.complete;
+                    lastTotalCount = progressCounts.total;
+                }
+                else {
+                    iterationsWithoutProgress++;
+                }
+                if (iterationsWithoutProgress >= MAX_ITERATIONS_WITHOUT_PROGRESS) {
+                    console.log(`\nStopping: no progress after ${MAX_ITERATIONS_WITHOUT_PROGRESS} consecutive iterations.`);
+                    console.log(`(No tasks completed and no new tasks added)`);
+                    console.log(`Status: ${progressCounts.complete}/${progressCounts.total} complete, ${progressCounts.incomplete} remaining.`);
+                    console.log("Check the PRD and task definitions for issues.");
+                    break;
+                }
+            }
             if (exitCode !== 0) {
                 console.error(`\n${cliConfig.command} exited with code ${exitCode}`);
                 // Track consecutive failures to detect persistent errors (e.g., missing API key)