quoting-service 17.0.4 → 17.1.0

package/CHANGELOG.md

@@ -2,6 +2,20 @@
 
 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
 
+## [17.1.0](https://github.com/mojaloop/quoting-service/compare/v17.0.5...v17.1.0) (2025-01-30)
+
+
+### Features
+
+* **csi-927:** fixed db error - ER_BAD_FIELD_ERROR: Unknown column 'NaN' in 'field list' ([#390](https://github.com/mojaloop/quoting-service/issues/390)) ([c9fb641](https://github.com/mojaloop/quoting-service/commit/c9fb64148a626890a973ce6b47515c1b61931196))
+
+### [17.0.5](https://github.com/mojaloop/quoting-service/compare/v17.0.4...v17.0.5) (2025-01-29)
+
+
+### Tests
+
+* **csi-1130:** api and db lib tests ([#389](https://github.com/mojaloop/quoting-service/issues/389)) ([d57e428](https://github.com/mojaloop/quoting-service/commit/d57e4284b523def6970d8688ad57280502de9b4a))
+
 ### [17.0.4](https://github.com/mojaloop/quoting-service/compare/v17.0.3...v17.0.4) (2025-01-28)
 
 

package/package.json

@@ -2,7 +2,7 @@
   "name": "quoting-service",
   "description": "Quoting Service hosted by a scheme",
   "license": "Apache-2.0",
-  "version": "17.0.4",
+  "version": "17.1.0",
   "author": "ModusBox",
   "contributors": [
     "Georgi Georgiev <georgi.georgiev@modusbox.com>",
@@ -114,12 +114,12 @@
     "@mojaloop/central-services-health": "15.0.2",
     "@mojaloop/central-services-logger": "11.5.4",
     "@mojaloop/central-services-metrics": "12.4.4",
-    "@mojaloop/central-services-shared": "18.16.2",
+    "@mojaloop/central-services-shared": "18.17.0",
     "@mojaloop/central-services-stream": "11.4.3",
     "@mojaloop/event-sdk": "14.1.3",
     "@mojaloop/inter-scheme-proxy-cache-lib": "2.3.1",
     "@mojaloop/ml-number": "11.2.6",
-    "@mojaloop/ml-schema-transformer-lib": "^2.5.1",
+    "@mojaloop/ml-schema-transformer-lib": "^2.5.2",
     "@mojaloop/sdk-standard-components": "^19.6.4",
     "ajv": "8.17.1",
     "ajv-keywords": "5.1.0",

package/src/data/database.js

@@ -49,11 +49,12 @@ const LOCAL_ENUM = require('../lib/enum')
  * Abstracts operations against the database
  */
 class Database {
-  constructor (config, log) {
+  constructor (config, log, queryBuilder) {
     this.config = config
     this.log = log || logger.child({
       context: this.constructor.name
     })
+    this.queryBuilder = queryBuilder
   }
 
   /**
@@ -62,7 +63,7 @@ class Database {
      * @returns {promise}
      */
   async connect () {
-    this.queryBuilder = new Knex(this.config.database)
+    this.queryBuilder = this.queryBuilder || new Knex(this.config.database)
 
     return this
   }
@@ -72,14 +73,14 @@ class Database {
   }
 
   /**
-     * async utility for getting a transaction object from knex
-     *
-     * @returns {undefined}
-     */
+   * async utility for getting a transaction object from knex
+   *
+   * @returns {undefined}
+   */
   async newTransaction () {
     return new Promise((resolve, reject) => {
       try {
-        this.queryBuilder.transaction(txn => {
+        return this.queryBuilder.transaction(txn => {
           return resolve(txn)
         })
       } catch (err) {

package/src/model/fxQuotes.js

@@ -593,7 +593,7 @@ class FxQuotesModel {
 
         // persist the error
         await this.db.createFxQuoteError(txn, conversionRequestId, {
-          errorCode: Number(error.errorCode),
+          errorCode: Number(error.errorCode) || 2001, // Internal Server Error: https://github.com/mojaloop/central-services-error-handling/blob/master/src/errors.js#L29
           errorDescription: error.errorDescription
         })
 
@@ -607,7 +607,7 @@ class FxQuotesModel {
       histTimer({ success: true, queryName: 'handleFxQuoteError' })
     } catch (err) {
       histTimer({ success: false, queryName: 'handleFxQuoteError' })
-      this.log.error('error in handleFxQuoteError', err)
+      this.log.child({ headers, conversionRequestId, error }).error('error in handleFxQuoteError', err)
       if (txn) {
         await txn.rollback().catch(() => {})
       }