quicklook-pptx-renderer 0.3.0 → 0.3.1

package/README.md

@@ -22,7 +22,7 @@ It happens because Apple uses a private framework called `OfficeImport.framework
 |---|---|
 | **Shapes disappear** — heart, cloud, lightningBolt, sun, moon, and ~120 more | OfficeImport's `CMCanonicalShapeBuilder` only supports ~60 of 187 preset geometries. The rest are silently dropped — no error, no fallback. |
 | **Opaque white blocks cover content** — rounded rectangles with shadows become solid rectangles | Any non-`rect` shape or any shape with effects (drop shadow, glow, reflection) is rendered as an opaque PDF image via `CMDrawingContext.copyPDF`. The PDF has a non-transparent background. |
-| **Table borders missing** — tables appear as plain text without any grid | OfficeImport doesn't resolve `tableStyleId` references. It only reads explicit `<a:lnL>`, `<a:lnR>`, `<a:lnT>`, `<a:lnB>` on each cell. python-pptx and most generators rely on style references. |
+| **Table borders missing** — tables appear as plain text without any grid | OfficeImport doesn't resolve `tableStyleId` references. It emits `border-style:none` per-cell unless borders are explicit in `<a:lnL>`, `<a:lnR>`, `<a:lnT>`, `<a:lnB>`. PowerPoint resolves the style and shows borders; QuickLook doesn't. python-pptx and most generators rely on style references. |
 | **Gradients become flat colors** — gradient fills show as a single solid color | Gradients with 3+ color stops are averaged to one color instead of being rendered as a gradient. |
 | **Fonts shift and text reflows** — text overflows boxes, lines break differently | Calibri → Helvetica Neue, Arial → Helvetica, Segoe UI → Helvetica Neue. Different metrics cause text reflow. |
 | **Charts are blank rectangles** — chart content simply vanishes | Charts without an embedded fallback image render as empty rectangles. |
@@ -153,10 +153,8 @@ for (const issue of result.issues) {
     case "inline-borders":
       // issue.fix.tableStyleId = "{5C22544A-...}"
       // Resolve table style and write explicit borders on each cell
-      break;
-
-    case "add-borders":
-      // Add default 1px solid black borders to all cells
+      // Note: tables without a style AND without borders are intentionally
+      // borderless — both PowerPoint and QuickLook render them the same way.
       break;
 
     case "add-fallback-image":
@@ -185,8 +183,7 @@ Every issue carries a typed `fix` object with machine-readable remediation data
 | `chart-no-fallback` | error | Chart without fallback image — renders as blank rectangle | `add-fallback-image` |
 | `opaque-pdf-block` | warn | Shape with effects rendered as opaque PDF covering content behind it | `strip-effects` |
 | `gradient-flattened` | warn | 3+ gradient stops collapsed to single average color | `reduce-stops` (includes computed 2-stop colors + average) |
-| `table-missing-borders` | warn | Table cells lack explicit borders — will appear borderless | `add-borders` |
-| `table-style-unresolved` | warn | Table style reference that OfficeImport won't resolve | `inline-borders` (includes `tableStyleId`) |
+| `table-style-unresolved` | warn | Table has style but cells lack explicit borders — PowerPoint shows borders, QL won't | `inline-borders` (includes `tableStyleId`) |
 | `font-substitution` | warn/info | Font will be substituted on macOS — includes width delta (warn if ≥10% reflow risk) | `replace-font` (includes macOS target, delta, metrically-closest alternatives) |
 | `group-as-pdf` | warn | Group rendered as single opaque PDF image | `ungroup` (includes child count, whether group contains pictures) |
 | `geometry-forces-pdf` | info | Non-rect geometry renders as PDF — opaque background may cover adjacent content | — |

package/dist/lint.d.ts

@@ -9,7 +9,7 @@
  * re-detecting the problem.
  */
 export type Severity = "error" | "warn" | "info";
-export type RuleId = "unsupported-geometry" | "opaque-pdf-block" | "gradient-flattened" | "font-substitution" | "table-missing-borders" | "table-style-unresolved" | "group-as-pdf" | "chart-no-fallback" | "text-inscription-shift" | "rotation-forces-pdf" | "geometry-forces-pdf" | "vertical-text";
+export type RuleId = "unsupported-geometry" | "opaque-pdf-block" | "gradient-flattened" | "font-substitution" | "table-style-unresolved" | "group-as-pdf" | "chart-no-fallback" | "text-inscription-shift" | "rotation-forces-pdf" | "geometry-forces-pdf" | "vertical-text";
 /** Machine-readable remediation data — one variant per fix strategy. */
 export type LintFix = {
     action: "replace-geometry";
@@ -35,8 +35,6 @@ export type LintFix = {
 } | {
     action: "inline-borders";
     tableStyleId: string;
-} | {
-    action: "add-borders";
 } | {
     action: "add-fallback-image";
 } | {

package/dist/lint.js

@@ -280,7 +280,10 @@ function lintGraphicFrame(frame, slide, issues, ctx) {
     }
 }
 function lintTable(table, slide, element, issues, ctx) {
-    // Check for table style reference without explicit borders
+    // Check for table style reference without explicit borders.
+    // OfficeImport emits `border-style:none` per-cell unless borders are explicit in XML.
+    // It ignores tableStyleId entirely — PowerPoint resolves the style and shows borders,
+    // but QuickLook shows a borderless grid. This is the #1 table issue for python-pptx users.
     if (table.tableStyleId) {
         const hasMissingBorders = table.rows.some(row => row.cells.some(cell => !hasExplicitBorders(cell)));
         if (hasMissingBorders) {
@@ -288,25 +291,15 @@ function lintTable(table, slide, element, issues, ctx) {
                 rule: "table-style-unresolved",
                 severity: "warn",
                 slide, element,
-                message: `Table uses style "${table.tableStyleId}" but some cells lack explicit borders — OfficeImport may not resolve the style`,
-                suggestion: `Inline borders explicitly on each cell`,
+                message: `Table uses style "${table.tableStyleId}" but cells lack explicit borders — PowerPoint shows borders, QuickLook won't`,
+                suggestion: `Inline the style's borders as explicit <a:lnT>/<a:lnB>/<a:lnL>/<a:lnR> on each cell`,
                 fix: { action: "inline-borders", tableStyleId: table.tableStyleId },
             });
         }
     }
-    // Check for cells with no borders at all
-    const noBorderCells = table.rows.reduce((count, row) => count + row.cells.filter(cell => !cell.hMerge && !cell.vMerge && !hasAnyBorder(cell)).length, 0);
-    const totalCells = table.rows.reduce((count, row) => count + row.cells.filter(cell => !cell.hMerge && !cell.vMerge).length, 0);
-    if (noBorderCells > 0 && noBorderCells === totalCells) {
-        issues.push({
-            rule: "table-missing-borders",
-            severity: "warn",
-            slide, element,
-            message: `All ${totalCells} table cells have no explicit borders — table will appear borderless in QuickLook`,
-            suggestion: `Add explicit borders to cells if borders are expected`,
-            fix: { action: "add-borders" },
-        });
-    }
+    // Note: tables without a style AND without explicit borders are intentionally borderless.
+    // OfficeImport correctly renders them with border-style:none. No lint issue needed.
+    // (PowerPoint also shows these as borderless — no divergence.)
     // Lint text in table cells
     for (const row of table.rows) {
         for (const cell of row.cells) {
@@ -322,12 +315,6 @@ function hasExplicitBorders(cell) {
     const b = cell.borders;
     return !!(b.top?.fill || b.bottom?.fill || b.left?.fill || b.right?.fill);
 }
-function hasAnyBorder(cell) {
-    if (!cell.borders)
-        return false;
-    const b = cell.borders;
-    return !!(b.top?.width || b.bottom?.width || b.left?.width || b.right?.width);
-}
 // ── Fill checks ─────────────────────────────────────────────────────
 function lintFill(fill, slide, element, issues, ctx) {
     if (!fill || fill.type !== "gradient")

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "quicklook-pptx-renderer",
-  "version": "0.3.0",
+  "version": "0.3.1",
   "description": "Open-source PPTX rendering engine that replicates Apple's macOS QuickLook and iOS preview — pixel for pixel. Test how PowerPoint files look on Mac/iPhone without a Mac.",
   "type": "module",
   "main": "dist/index.js",