quickbase-js 0.1.0-beta.7 → 0.1.0-beta.9

package/tests/vitest/unit/fields/createField.test.ts

@@ -1,13 +1,12 @@
-// tests/vitest/unit/fields/createField.test.ts
 import { describe, it, expect, beforeEach, vi } from "vitest";
 import {
   createClient,
   mockFetch,
+  QB_TABLE_ID_1,
   QB_REALM,
   QB_USER_TOKEN,
-  QB_TABLE_ID_1,
 } from "@tests/setup.ts";
-import { CreateFieldRequest, CreateField200Response } from "@/generated/models";
+import { CreateFieldRequest } from "@/generated/models";
 
 describe("QuickbaseClient Unit - createField", () => {
   let client: ReturnType<typeof createClient>;
@@ -22,52 +21,43 @@ describe("QuickbaseClient Unit - createField", () => {
     expect(typeof client.createField).toBe("function");
   });
 
-  it("creates a field successfully with user token", async () => {
+  it("creates field successfully with user token", async () => {
     client = createClient(mockFetch, { debug: true });
 
     const request: CreateFieldRequest = {
-      label: "TestField",
+      label: "NewField",
       fieldType: "text",
-      fieldHelp: "A test field",
-      addToForms: true,
-      permissions: [
-        { role: "Viewer", permissionType: "View", roleId: 10 },
-        { role: "Administrator", permissionType: "Modify", roleId: 12 },
-      ],
     };
 
-    const mockResponse: CreateField200Response = {
-      id: 100,
-      label: "TestField",
+    const mockResponse = {
+      id: 101,
+      label: "NewField",
       fieldType: "text",
-      mode: "",
-      noWrap: false,
-      bold: false,
-      required: false,
       appearsByDefault: true,
-      findEnabled: true,
-      unique: false,
-      doesDataCopy: false,
-      fieldHelp: "A test field",
       audited: false,
+      bold: false,
+      doesDataCopy: false,
+      fieldHelp: "",
+      findEnabled: true,
+      mode: "",
+      noWrap: false,
+      permissions: [],
       properties: {
-        primaryKey: false,
-        foreignKey: false,
-        numLines: 1,
-        maxLength: 0,
-        appendOnly: false,
         allowHTML: false,
         allowMentions: false,
-        sortAsGiven: false,
-        carryChoices: true,
         allowNewChoices: false,
-        formula: "",
+        appendOnly: false,
+        carryChoices: true,
         defaultValue: "",
+        foreignKey: false,
+        formula: "",
+        maxLength: 0,
+        numLines: 1,
+        primaryKey: false,
+        sortAsGiven: false,
       },
-      permissions: [
-        { permissionType: "View", role: "Viewer", roleId: 10 },
-        { permissionType: "Modify", role: "Administrator", roleId: 12 },
-      ],
+      required: false,
+      unique: false,
     };
 
     mockFetch.mockResolvedValueOnce({
@@ -82,25 +72,22 @@ describe("QuickbaseClient Unit - createField", () => {
     });
 
     expect(result).toEqual(mockResponse);
-    const callArgs = mockFetch.mock.calls[0];
-    console.log("Raw fetch call (user token):", callArgs); // Debug raw call
-    const receivedBody = JSON.parse(callArgs[1].body as string);
-    expect(receivedBody).toEqual(request); // Expect full body
     expect(mockFetch).toHaveBeenCalledWith(
       `https://api.quickbase.com/v1/fields?tableId=${QB_TABLE_ID_1}`,
-      expect.objectContaining({
+      {
         method: "POST",
-        headers: expect.objectContaining({
+        body: JSON.stringify(request),
+        headers: {
           "QB-Realm-Hostname": `${QB_REALM}.quickbase.com`,
           Authorization: `QB-USER-TOKEN ${QB_USER_TOKEN}`,
           "Content-Type": "application/json",
-        }),
-        body: JSON.stringify(request),
-      })
+        },
+        credentials: "omit",
+      }
     );
   });
 
-  it("creates a field successfully with temp token", async () => {
+  it("creates field successfully with temp token", async () => {
     client = createClient(mockFetch, { useTempTokens: true, debug: true });
 
     const request: CreateFieldRequest = {
@@ -109,35 +96,35 @@ describe("QuickbaseClient Unit - createField", () => {
       addToForms: false,
     };
 
-    const mockResponse: CreateField200Response = {
-      id: 101,
+    const mockResponse = {
+      id: 102,
       label: "TempField",
       fieldType: "numeric",
-      mode: "",
-      noWrap: false,
+      appearsByDefault: false,
+      audited: false,
       bold: false,
-      required: false,
-      appearsByDefault: true,
-      findEnabled: true,
-      unique: false,
       doesDataCopy: false,
       fieldHelp: "",
-      audited: false,
+      findEnabled: true,
+      mode: "",
+      noWrap: false,
+      permissions: [],
       properties: {
-        primaryKey: false,
-        foreignKey: false,
-        numLines: 1,
-        maxLength: 0,
-        appendOnly: false,
         allowHTML: false,
         allowMentions: false,
-        sortAsGiven: false,
-        carryChoices: true,
         allowNewChoices: false,
-        formula: "",
+        appendOnly: false,
+        carryChoices: true,
         defaultValue: "",
+        foreignKey: false,
+        formula: "",
+        maxLength: 0,
+        numLines: 1,
+        primaryKey: false,
+        sortAsGiven: false,
       },
-      permissions: [],
+      required: false,
+      unique: false,
     };
 
     mockFetch
@@ -162,29 +149,21 @@ describe("QuickbaseClient Unit - createField", () => {
     expect(mockFetch).toHaveBeenNthCalledWith(
       1,
       `https://api.quickbase.com/v1/auth/temporary/${QB_TABLE_ID_1}`,
-      expect.objectContaining({
-        method: "GET",
-        headers: expect.objectContaining({
-          "QB-Realm-Hostname": `${QB_REALM}.quickbase.com`,
-          "Content-Type": "application/json",
-        }),
-        credentials: "include",
-      })
+      expect.any(Object)
     );
-    const callArgs = mockFetch.mock.calls[1];
-    console.log("Raw fetch call (temp token):", callArgs); // Debug raw call
     expect(mockFetch).toHaveBeenNthCalledWith(
       2,
       `https://api.quickbase.com/v1/fields?tableId=${QB_TABLE_ID_1}`,
-      expect.objectContaining({
+      {
         method: "POST",
-        headers: expect.objectContaining({
-          "QB-Realm-Hostname": `${QB_REALM}.quickbase.com`,
+        body: JSON.stringify(request),
+        headers: {
           Authorization: "QB-TEMP-TOKEN temp_token",
           "Content-Type": "application/json",
-        }),
-        body: JSON.stringify(request),
-      })
+          "QB-Realm-Hostname": `${QB_REALM}.quickbase.com`,
+        },
+        credentials: "omit",
+      }
     );
   });
 
@@ -196,35 +175,35 @@ describe("QuickbaseClient Unit - createField", () => {
       fieldType: "checkbox",
     };
 
-    const mockResponse: CreateField200Response = {
+    const mockResponse = {
       id: 102,
       label: "RetryField",
       fieldType: "checkbox",
-      mode: "",
-      noWrap: false,
-      bold: false,
-      required: false,
       appearsByDefault: true,
-      findEnabled: true,
-      unique: false,
+      audited: false,
+      bold: false,
       doesDataCopy: false,
       fieldHelp: "",
-      audited: false,
+      findEnabled: true,
+      mode: "",
+      noWrap: false,
+      permissions: [],
       properties: {
-        primaryKey: false,
-        foreignKey: false,
-        numLines: 1,
-        maxLength: 0,
-        appendOnly: false,
         allowHTML: false,
         allowMentions: false,
-        sortAsGiven: false,
-        carryChoices: true,
         allowNewChoices: false,
-        formula: "",
+        appendOnly: false,
+        carryChoices: true,
         defaultValue: "",
+        foreignKey: false,
+        formula: "",
+        maxLength: 0,
+        numLines: 1,
+        primaryKey: false,
+        sortAsGiven: false,
       },
-      permissions: [],
+      required: false,
+      unique: false,
     };
 
     mockFetch
@@ -238,6 +217,7 @@ describe("QuickbaseClient Unit - createField", () => {
         ok: false,
         status: 401,
         json: () => Promise.resolve({ message: "Unauthorized" }),
+        text: () => Promise.resolve("Unauthorized"),
       })
       .mockResolvedValueOnce({
         ok: true,
@@ -266,11 +246,16 @@ describe("QuickbaseClient Unit - createField", () => {
     expect(mockFetch).toHaveBeenNthCalledWith(
       2,
       `https://api.quickbase.com/v1/fields?tableId=${QB_TABLE_ID_1}`,
-      expect.objectContaining({
-        headers: expect.objectContaining({
+      {
+        method: "POST",
+        body: JSON.stringify(request),
+        headers: {
           Authorization: "QB-TEMP-TOKEN initial_token",
-        }),
-      })
+          "Content-Type": "application/json",
+          "QB-Realm-Hostname": `${QB_REALM}.quickbase.com`,
+        },
+        credentials: "omit",
+      }
     );
     expect(mockFetch).toHaveBeenNthCalledWith(
       3,
@@ -280,18 +265,22 @@ describe("QuickbaseClient Unit - createField", () => {
     expect(mockFetch).toHaveBeenNthCalledWith(
       4,
       `https://api.quickbase.com/v1/fields?tableId=${QB_TABLE_ID_1}`,
-      expect.objectContaining({
-        headers: expect.objectContaining({
+      {
+        method: "POST",
+        body: JSON.stringify(request),
+        headers: {
           Authorization: "QB-TEMP-TOKEN new_token",
-        }),
-      })
+          "Content-Type": "application/json",
+          "QB-Realm-Hostname": `${QB_REALM}.quickbase.com`,
+        },
+        credentials: "omit",
+      }
     );
     expect(consoleSpy).toHaveBeenCalledWith(
-      "Authorization error for createField, refreshing token:",
-      expect.any(String)
+      "Authorization error for createField (temp token), refreshing token:"
     );
     expect(consoleSpy).toHaveBeenCalledWith(
-      "Retrying createField with new token"
+      "[createField] Retrying with token: new_token..."
     );
     consoleSpy.mockRestore();
   });
@@ -300,7 +289,7 @@ describe("QuickbaseClient Unit - createField", () => {
     client = createClient(mockFetch, { debug: true });
 
     const request: CreateFieldRequest = {
-      label: "", // Invalid: label is required
+      label: "", // Invalid: empty label
       fieldType: "text",
     };
 
@@ -308,6 +297,7 @@ describe("QuickbaseClient Unit - createField", () => {
       ok: false,
       status: 400,
       json: () => Promise.resolve({ message: "Label is required" }),
+      text: () => Promise.resolve("Label is required"),
     });
 
     await expect(
@@ -316,15 +306,16 @@ describe("QuickbaseClient Unit - createField", () => {
 
     expect(mockFetch).toHaveBeenCalledWith(
       `https://api.quickbase.com/v1/fields?tableId=${QB_TABLE_ID_1}`,
-      expect.objectContaining({
+      {
         method: "POST",
-        headers: expect.objectContaining({
+        body: JSON.stringify(request),
+        headers: {
           "QB-Realm-Hostname": `${QB_REALM}.quickbase.com`,
           Authorization: `QB-USER-TOKEN ${QB_USER_TOKEN}`,
           "Content-Type": "application/json",
-        }),
-        body: JSON.stringify(request),
-      })
+        },
+        credentials: "omit",
+      }
     );
   });
 
@@ -347,22 +338,49 @@ describe("QuickbaseClient Unit - createField", () => {
         ok: false,
         status: 401,
         json: () => Promise.resolve({ message: "Unauthorized" }),
+        text: () => Promise.resolve("Unauthorized"),
+      })
+      .mockResolvedValueOnce({
+        ok: true,
+        status: 200,
+        json: () => Promise.resolve({ temporaryAuthorization: "token_2" }),
       })
       .mockResolvedValueOnce({
         ok: false,
         status: 401,
-        json: () =>
-          Promise.resolve({ message: "Unauthorized in fetchTempToken" }),
+        json: () => Promise.resolve({ message: "Unauthorized again" }),
+        text: () => Promise.resolve("Unauthorized again"),
+      })
+      .mockResolvedValueOnce({
+        ok: true,
+        status: 200,
+        json: () => Promise.resolve({ temporaryAuthorization: "token_3" }),
+      })
+      .mockResolvedValueOnce({
+        ok: false,
+        status: 401,
+        json: () => Promise.resolve({ message: "Unauthorized again" }),
+        text: () => Promise.resolve("Unauthorized again"),
+      })
+      .mockResolvedValueOnce({
+        ok: true,
+        status: 200,
+        json: () => Promise.resolve({ temporaryAuthorization: "token_4" }),
+      })
+      .mockResolvedValueOnce({
+        ok: false,
+        status: 401,
+        json: () => Promise.resolve({ message: "Unauthorized again" }),
+        text: () => Promise.resolve("Unauthorized again"),
       });
 
     const consoleSpy = vi.spyOn(console, "log");
+
     await expect(
       client.createField({ tableId: QB_TABLE_ID_1, body: request })
-    ).rejects.toThrow(
-      "API Error: Unauthorized in fetchTempToken (Status: 401)"
-    );
+    ).rejects.toThrow("API Error: Unauthorized again (Status: 401)");
 
-    expect(mockFetch).toHaveBeenCalledTimes(3);
+    expect(mockFetch).toHaveBeenCalledTimes(8);
     expect(mockFetch).toHaveBeenNthCalledWith(
       1,
       `https://api.quickbase.com/v1/auth/temporary/${QB_TABLE_ID_1}`,
@@ -372,6 +390,7 @@ describe("QuickbaseClient Unit - createField", () => {
       2,
       `https://api.quickbase.com/v1/fields?tableId=${QB_TABLE_ID_1}`,
       expect.objectContaining({
+        method: "POST",
         headers: expect.objectContaining({
           Authorization: "QB-TEMP-TOKEN initial_token",
         }),
@@ -382,10 +401,51 @@ describe("QuickbaseClient Unit - createField", () => {
       `https://api.quickbase.com/v1/auth/temporary/${QB_TABLE_ID_1}`,
       expect.any(Object)
     );
+    expect(mockFetch).toHaveBeenNthCalledWith(
+      4,
+      `https://api.quickbase.com/v1/fields?tableId=${QB_TABLE_ID_1}`,
+      expect.objectContaining({
+        method: "POST",
+        headers: expect.objectContaining({
+          Authorization: "QB-TEMP-TOKEN token_2",
+        }),
+      })
+    );
+    expect(mockFetch).toHaveBeenNthCalledWith(
+      5,
+      `https://api.quickbase.com/v1/auth/temporary/${QB_TABLE_ID_1}`,
+      expect.any(Object)
+    );
+    expect(mockFetch).toHaveBeenNthCalledWith(
+      6,
+      `https://api.quickbase.com/v1/fields?tableId=${QB_TABLE_ID_1}`,
+      expect.objectContaining({
+        method: "POST",
+        headers: expect.objectContaining({
+          Authorization: "QB-TEMP-TOKEN token_3",
+        }),
+      })
+    );
+    expect(mockFetch).toHaveBeenNthCalledWith(
+      7,
+      `https://api.quickbase.com/v1/auth/temporary/${QB_TABLE_ID_1}`,
+      expect.any(Object)
+    );
+    expect(mockFetch).toHaveBeenNthCalledWith(
+      8,
+      `https://api.quickbase.com/v1/fields?tableId=${QB_TABLE_ID_1}`,
+      expect.objectContaining({
+        method: "POST",
+        headers: expect.objectContaining({
+          Authorization: "QB-TEMP-TOKEN token_4",
+        }),
+      })
+    );
+
     expect(consoleSpy).toHaveBeenCalledWith(
-      "Authorization error for createField, refreshing token:",
-      expect.any(String)
+      "Authorization error for createField (temp token), refreshing token:"
     );
+
     consoleSpy.mockRestore();
   });
 });

package/tests/vitest/unit/fields/getFieldUsage.test.ts

@@ -1,4 +1,3 @@
-// tests/vitest/unit/fields/getFieldUsage.test.ts
 import { describe, it, expect, beforeEach } from "vitest";
 import {
   createClient,
@@ -27,7 +26,7 @@ describe("QuickbaseClient Unit - getFieldUsage", () => {
       field: {
         id: 6,
         name: "name",
-        type: "text", // Match QuickBase's lowercase response
+        type: "text",
       },
       usage: {
         actions: { count: 0 },
@@ -50,7 +49,6 @@ describe("QuickbaseClient Unit - getFieldUsage", () => {
       },
     };
 
-    // Mock the response as an array to match the updated API behavior
     mockFetch.mockResolvedValueOnce(
       new Response(JSON.stringify([mockResponse]), {
         status: 200,
@@ -64,7 +62,6 @@ describe("QuickbaseClient Unit - getFieldUsage", () => {
       tableId: QB_TABLE_ID_1,
     });
 
-    // Expect an array and unwrap the first item
     expect(result).toBeInstanceOf(Array);
     expect(result).toHaveLength(1);
     const fieldUsage = result[0];
@@ -115,14 +112,37 @@ describe("QuickbaseClient Unit - getFieldUsage", () => {
     );
   });
 
-  it("handles 401 error and does not retry with user token", async () => {
-    mockFetch.mockResolvedValueOnce(
-      new Response(JSON.stringify({ message: "Unauthorized" }), {
-        status: 401,
-        statusText: "Unauthorized",
-        headers: { "Content-Type": "application/json" },
-      })
-    );
+  it("handles persistent 401 error for field usage retrieval", async () => {
+    // Simulate persistent 401 errors to exhaust retries
+    mockFetch
+      .mockResolvedValueOnce(
+        new Response(JSON.stringify({ message: "Unauthorized" }), {
+          status: 401,
+          statusText: "Unauthorized",
+          headers: { "Content-Type": "application/json" },
+        })
+      )
+      .mockResolvedValueOnce(
+        new Response(JSON.stringify({ message: "Unauthorized" }), {
+          status: 401,
+          statusText: "Unauthorized",
+          headers: { "Content-Type": "application/json" },
+        })
+      )
+      .mockResolvedValueOnce(
+        new Response(JSON.stringify({ message: "Unauthorized" }), {
+          status: 401,
+          statusText: "Unauthorized",
+          headers: { "Content-Type": "application/json" },
+        })
+      )
+      .mockResolvedValueOnce(
+        new Response(JSON.stringify({ message: "Unauthorized" }), {
+          status: 401,
+          statusText: "Unauthorized",
+          headers: { "Content-Type": "application/json" },
+        })
+      );
 
     await expect(
       client.getFieldUsage({
@@ -131,8 +151,21 @@ describe("QuickbaseClient Unit - getFieldUsage", () => {
       })
     ).rejects.toThrow("API Error: Unauthorized (Status: 401)");
 
-    expect(mockFetch).toHaveBeenCalledTimes(1); // No retry with user token
-    expect(mockFetch).toHaveBeenCalledWith(
+    expect(mockFetch).toHaveBeenCalledTimes(4); // Initial + 3 retries
+    expect(mockFetch).toHaveBeenNthCalledWith(
+      1,
+      `https://api.quickbase.com/v1/fields/usage/6?tableId=${QB_TABLE_ID_1}`,
+      expect.objectContaining({
+        method: "GET",
+        headers: expect.objectContaining({
+          "QB-Realm-Hostname": `${QB_REALM}.quickbase.com`,
+          Authorization: `QB-USER-TOKEN ${QB_USER_TOKEN}`,
+          "Content-Type": "application/json",
+        }),
+      })
+    );
+    expect(mockFetch).toHaveBeenNthCalledWith(
+      4,
       `https://api.quickbase.com/v1/fields/usage/6?tableId=${QB_TABLE_ID_1}`,
       expect.objectContaining({
         method: "GET",