quickbase-js 0.1.0-beta.7 → 0.1.0-beta.8

package/tests/vitest/unit/auth/{two401s.test.ts → retryTempTokenTwo401.test.ts}

@@ -1,8 +1,7 @@
-// tests/vitest/unit/auth/two401s.test.ts
 import { describe, it, expect, beforeEach, vi } from "vitest";
 import { createClient, mockFetch } from "@tests/setup.ts";
 
-describe("QuickbaseClient - Two 401s in a Row", () => {
+describe("QuickbaseClient - Two Temp Token 401s in a Row", () => {
   let client: ReturnType<typeof createClient>;
 
   beforeEach(() => {
@@ -28,7 +27,7 @@ describe("QuickbaseClient - Two 401s in a Row", () => {
         return Promise.resolve({
           ok: false,
           status: 401,
-          text: () => Promise.resolve("Unauthorized"),
+          json: () => Promise.resolve({ message: "Unauthorized" }),
         });
       }
       if (url.includes("auth/temporary") && callCount === 3) {
@@ -70,15 +69,11 @@ describe("QuickbaseClient - Two 401s in a Row", () => {
     ]);
 
     expect(consoleSpy).toHaveBeenCalledWith(
-      "Authorization error for getFields, refreshing token:",
+      "Authorization error for getFields (temp token), refreshing token:",
       expect.any(String)
     );
     expect(consoleSpy).toHaveBeenCalledWith(
-      "Retrying getFields with new token"
-    );
-    expect(consoleSpy).toHaveBeenCalledWith(
-      "Error response body for getFields:",
-      { message: "Unauthorized again" }
+      "Retrying getFields with temp token"
     );
 
     consoleSpy.mockRestore();

package/tests/vitest/unit/auth/retryUserToken401.test.ts

@@ -0,0 +1,56 @@
+import { describe, it, vi, expect, beforeEach } from "vitest";
+import { quickbase, QuickbaseClient } from "../../../../src/quickbaseClient";
+import { ResponseError } from "../../../../src/generated/runtime";
+
+describe("QuickbaseClient Integration - User Token Retry on 401", () => {
+  let client: QuickbaseClient;
+  const mockFetch = vi.fn();
+
+  beforeEach(() => {
+    const config = {
+      realm: process.env.QB_REALM || "builderprogram-dbradford6815",
+      userToken: "mock-user-token",
+      debug: true,
+      fetchApi: mockFetch,
+    };
+    console.log("[quickbaseTest] Config:", config);
+    client = quickbase(config);
+  });
+
+  it("retries on transient 401 with user token and succeeds", async () => {
+    const consoleSpy = vi.spyOn(console, "log");
+
+    mockFetch
+      .mockImplementationOnce(() => {
+        const response = new Response(null, {
+          status: 401,
+          statusText: "Unauthorized",
+        });
+        console.log("[mockFetch] Throwing 401 ResponseError");
+        return Promise.reject(new ResponseError(response));
+      })
+      .mockResolvedValueOnce({
+        ok: true,
+        status: 200,
+        json: async () => [{ id: 1, label: "Mock Field", fieldType: "text" }],
+      });
+
+    const fields = await client.getFields({ tableId: "mock-table-id" });
+
+    expect(fields).toBeInstanceOf(Array);
+    expect(fields.length).toBeGreaterThan(0);
+    expect(fields[0]).toHaveProperty("id");
+    expect(fields[0]).toHaveProperty("label");
+
+    expect(consoleSpy).toHaveBeenCalledWith(
+      "Authorization error for getFields (user token), retrying with same token:",
+      "" // Matches empty ResponseError message from mock
+    );
+    expect(consoleSpy).toHaveBeenCalledWith(
+      "Retrying getFields with user token"
+    );
+    expect(mockFetch).toHaveBeenCalledTimes(2);
+
+    consoleSpy.mockRestore();
+  });
+});

package/tests/vitest/unit/fields/createField.test.ts

@@ -1,4 +1,3 @@
-// tests/vitest/unit/fields/createField.test.ts
 import { describe, it, expect, beforeEach, vi } from "vitest";
 import {
   createClient,
@@ -83,9 +82,9 @@ describe("QuickbaseClient Unit - createField", () => {
 
     expect(result).toEqual(mockResponse);
     const callArgs = mockFetch.mock.calls[0];
-    console.log("Raw fetch call (user token):", callArgs); // Debug raw call
+    console.log("Raw fetch call (user token):", callArgs);
     const receivedBody = JSON.parse(callArgs[1].body as string);
-    expect(receivedBody).toEqual(request); // Expect full body
+    expect(receivedBody).toEqual(request);
     expect(mockFetch).toHaveBeenCalledWith(
       `https://api.quickbase.com/v1/fields?tableId=${QB_TABLE_ID_1}`,
       expect.objectContaining({
@@ -172,7 +171,7 @@ describe("QuickbaseClient Unit - createField", () => {
       })
     );
     const callArgs = mockFetch.mock.calls[1];
-    console.log("Raw fetch call (temp token):", callArgs); // Debug raw call
+    console.log("Raw fetch call (temp token):", callArgs);
     expect(mockFetch).toHaveBeenNthCalledWith(
       2,
       `https://api.quickbase.com/v1/fields?tableId=${QB_TABLE_ID_1}`,
@@ -287,11 +286,11 @@ describe("QuickbaseClient Unit - createField", () => {
       })
     );
     expect(consoleSpy).toHaveBeenCalledWith(
-      "Authorization error for createField, refreshing token:",
+      "Authorization error for createField (temp token), refreshing token:",
       expect.any(String)
     );
     expect(consoleSpy).toHaveBeenCalledWith(
-      "Retrying createField with new token"
+      "Retrying createField with temp token"
     );
     consoleSpy.mockRestore();
   });
@@ -351,16 +350,13 @@ describe("QuickbaseClient Unit - createField", () => {
       .mockResolvedValueOnce({
         ok: false,
         status: 401,
-        json: () =>
-          Promise.resolve({ message: "Unauthorized in fetchTempToken" }),
+        json: () => Promise.resolve({ message: "Temp token fetch failed" }),
       });
 
     const consoleSpy = vi.spyOn(console, "log");
     await expect(
       client.createField({ tableId: QB_TABLE_ID_1, body: request })
-    ).rejects.toThrow(
-      "API Error: Unauthorized in fetchTempToken (Status: 401)"
-    );
+    ).rejects.toThrow("API Error: Temp token fetch failed (Status: 401)");
 
     expect(mockFetch).toHaveBeenCalledTimes(3);
     expect(mockFetch).toHaveBeenNthCalledWith(
@@ -383,7 +379,7 @@ describe("QuickbaseClient Unit - createField", () => {
       expect.any(Object)
     );
     expect(consoleSpy).toHaveBeenCalledWith(
-      "Authorization error for createField, refreshing token:",
+      "Authorization error for createField (temp token), refreshing token:",
       expect.any(String)
     );
     consoleSpy.mockRestore();

package/tests/vitest/unit/fields/getFieldUsage.test.ts

@@ -1,4 +1,3 @@
-// tests/vitest/unit/fields/getFieldUsage.test.ts
 import { describe, it, expect, beforeEach } from "vitest";
 import {
   createClient,
@@ -27,7 +26,7 @@ describe("QuickbaseClient Unit - getFieldUsage", () => {
       field: {
         id: 6,
         name: "name",
-        type: "text", // Match QuickBase's lowercase response
+        type: "text",
       },
       usage: {
         actions: { count: 0 },
@@ -50,7 +49,6 @@ describe("QuickbaseClient Unit - getFieldUsage", () => {
       },
     };
 
-    // Mock the response as an array to match the updated API behavior
     mockFetch.mockResolvedValueOnce(
       new Response(JSON.stringify([mockResponse]), {
         status: 200,
@@ -64,7 +62,6 @@ describe("QuickbaseClient Unit - getFieldUsage", () => {
       tableId: QB_TABLE_ID_1,
     });
 
-    // Expect an array and unwrap the first item
     expect(result).toBeInstanceOf(Array);
     expect(result).toHaveLength(1);
     const fieldUsage = result[0];
@@ -115,14 +112,23 @@ describe("QuickbaseClient Unit - getFieldUsage", () => {
     );
   });
 
-  it("handles 401 error and does not retry with user token", async () => {
-    mockFetch.mockResolvedValueOnce(
-      new Response(JSON.stringify({ message: "Unauthorized" }), {
-        status: 401,
-        statusText: "Unauthorized",
-        headers: { "Content-Type": "application/json" },
-      })
-    );
+  it("handles persistent 401 error for field usage retrieval", async () => {
+    // Simulate a persistent 401 error (initial and retry attempts fail)
+    mockFetch
+      .mockResolvedValueOnce(
+        new Response(JSON.stringify({ message: "Unauthorized" }), {
+          status: 401,
+          statusText: "Unauthorized",
+          headers: { "Content-Type": "application/json" },
+        })
+      )
+      .mockResolvedValueOnce(
+        new Response(JSON.stringify({ message: "Unauthorized" }), {
+          status: 401,
+          statusText: "Unauthorized",
+          headers: { "Content-Type": "application/json" },
+        })
+      );
 
     await expect(
       client.getFieldUsage({
@@ -131,8 +137,21 @@ describe("QuickbaseClient Unit - getFieldUsage", () => {
       })
     ).rejects.toThrow("API Error: Unauthorized (Status: 401)");
 
-    expect(mockFetch).toHaveBeenCalledTimes(1); // No retry with user token
-    expect(mockFetch).toHaveBeenCalledWith(
+    expect(mockFetch).toHaveBeenCalledTimes(2); // Initial call + 1 retry
+    expect(mockFetch).toHaveBeenNthCalledWith(
+      1,
+      `https://api.quickbase.com/v1/fields/usage/6?tableId=${QB_TABLE_ID_1}`,
+      expect.objectContaining({
+        method: "GET",
+        headers: expect.objectContaining({
+          "QB-Realm-Hostname": `${QB_REALM}.quickbase.com`,
+          Authorization: `QB-USER-TOKEN ${QB_USER_TOKEN}`,
+          "Content-Type": "application/json",
+        }),
+      })
+    );
+    expect(mockFetch).toHaveBeenNthCalledWith(
+      2,
       `https://api.quickbase.com/v1/fields/usage/6?tableId=${QB_TABLE_ID_1}`,
       expect.objectContaining({
         method: "GET",

package/tests/vitest/unit/fields/updateField.test.ts

@@ -0,0 +1,280 @@
+// tests/vitest/unit/fields/updateField.test.ts
+import { describe, it, expect, beforeEach } from "vitest";
+import {
+  createClient,
+  mockFetch,
+  QB_APP_ID,
+  QB_REALM,
+  QB_USER_TOKEN,
+  QB_TABLE_ID_1,
+} from "@tests/setup.ts";
+import { UpdateFieldRequest, UpdateField200Response } from "@/generated/models";
+
+describe("QuickbaseClient Unit - updateField", () => {
+  let client: ReturnType<typeof createClient>;
+
+  beforeEach(() => {
+    mockFetch.mockClear();
+  });
+
+  it("initializes and has updateField method", () => {
+    client = createClient(mockFetch, { debug: true });
+    expect(client).toBeDefined();
+    expect(typeof client.updateField).toBe("function");
+  });
+
+  it("updates field successfully with user token", async () => {
+    client = createClient(mockFetch, {
+      realm: QB_REALM,
+      userToken: QB_USER_TOKEN,
+      debug: true,
+    });
+
+    const tableId = QB_TABLE_ID_1;
+    const fieldId = 123;
+
+    const request: UpdateFieldRequest = {
+      label: "Field1",
+      // fieldType omitted as it’s not allowed in updates
+      noWrap: false,
+      bold: false,
+      required: true,
+      appearsByDefault: false,
+      findEnabled: false,
+      unique: true,
+      fieldHelp: "field help",
+      addToForms: true,
+      properties: {
+        numLines: 1,
+        maxLength: 50,
+        appendOnly: true,
+        sortAsGiven: false,
+        allowMentions: false,
+        comments: "Updated field settings",
+        doesTotal: false,
+        defaultValue: "Initial text",
+        choices: ["Option1", "Option2"], // Still valid for properties
+      },
+      permissions: [
+        { role: "Viewer", permissionType: "View", roleId: 10 },
+        { role: "Participant", permissionType: "None", roleId: 11 },
+        { role: "Administrator", permissionType: "Modify", roleId: 12 },
+      ],
+    };
+
+    const mockResponse: UpdateField200Response = {
+      id: fieldId,
+      label: "Field1",
+      fieldType: "text", // Returned by API, not updated
+      mode: "",
+      noWrap: false,
+      bold: false,
+      required: true,
+      appearsByDefault: false,
+      findEnabled: false,
+      unique: true,
+      doesDataCopy: false,
+      fieldHelp: "field help",
+      audited: false,
+      properties: {
+        numLines: 1,
+        maxLength: 50,
+        appendOnly: true,
+        sortAsGiven: false,
+        allowMentions: false,
+        comments: "Updated field settings",
+        doesTotal: false,
+        defaultValue: "Initial text",
+        choices: ["Option1", "Option2"],
+        allowHTML: false,
+        carryChoices: true,
+        allowNewChoices: false,
+        formula: "",
+      },
+      permissions: [
+        { permissionType: "View", role: "Viewer", roleId: 10 },
+        { permissionType: "None", role: "Participant", roleId: 11 },
+        { permissionType: "Modify", role: "Administrator", roleId: 12 },
+      ],
+    };
+
+    mockFetch.mockResolvedValueOnce({
+      ok: true,
+      status: 200,
+      json: () => Promise.resolve(mockResponse),
+    });
+
+    const result = await client.updateField({
+      fieldId,
+      tableId,
+      body: request,
+    });
+
+    expect(result).toEqual(mockResponse);
+    expect(mockFetch).toHaveBeenCalledWith(
+      `https://api.quickbase.com/v1/fields/${fieldId}?tableId=${tableId}`,
+      expect.objectContaining({
+        method: "POST",
+        headers: expect.objectContaining({
+          "QB-Realm-Hostname": `${QB_REALM}.quickbase.com`,
+          Authorization: `QB-USER-TOKEN ${QB_USER_TOKEN}`,
+          "Content-Type": "application/json",
+        }),
+        body: JSON.stringify(request),
+        credentials: "omit",
+      })
+    );
+  });
+
+  it("updates field successfully with temp token", async () => {
+    client = createClient(mockFetch, {
+      realm: QB_REALM,
+      useTempTokens: true,
+      debug: true,
+    });
+
+    const tableId = QB_TABLE_ID_1;
+    const fieldId = 123;
+
+    const request: UpdateFieldRequest = {
+      label: "Field1",
+      // fieldType omitted as it’s not allowed in updates
+      required: true,
+      unique: true,
+      properties: {
+        numLines: 1,
+        maxLength: 0,
+        choices: ["Yes", "No"],
+        allowNewChoices: true,
+        defaultValue: "No",
+      },
+    };
+
+    const mockResponse: UpdateField200Response = {
+      id: fieldId,
+      label: "Field1",
+      fieldType: "text-multiple-choice", // Returned by API, not updated
+      mode: "",
+      noWrap: false,
+      bold: false,
+      required: true,
+      appearsByDefault: false,
+      findEnabled: false,
+      unique: true,
+      doesDataCopy: false,
+      fieldHelp: "",
+      audited: false,
+      properties: {
+        numLines: 1,
+        maxLength: 0,
+        choices: ["Yes", "No"],
+        allowNewChoices: true,
+        defaultValue: "No",
+        appendOnly: false,
+        allowHTML: false,
+        allowMentions: false,
+        sortAsGiven: false,
+        carryChoices: true,
+        formula: "",
+      },
+      permissions: [
+        { permissionType: "View", role: "Viewer", roleId: 10 },
+        { permissionType: "None", role: "Participant", roleId: 11 },
+        { permissionType: "Modify", role: "Administrator", roleId: 12 },
+      ],
+    };
+
+    mockFetch
+      .mockResolvedValueOnce({
+        ok: true,
+        status: 200,
+        json: () => Promise.resolve({ temporaryAuthorization: "temp_token" }),
+      })
+      .mockResolvedValueOnce({
+        ok: true,
+        status: 200,
+        json: () => Promise.resolve(mockResponse),
+      });
+
+    const result = await client.updateField({
+      fieldId,
+      tableId,
+      body: request,
+    });
+
+    expect(result).toEqual(mockResponse);
+    expect(mockFetch).toHaveBeenCalledTimes(2);
+    expect(mockFetch).toHaveBeenNthCalledWith(
+      1,
+      `https://api.quickbase.com/v1/auth/temporary/${tableId}`,
+      expect.objectContaining({
+        method: "GET",
+        headers: expect.objectContaining({
+          "QB-Realm-Hostname": `${QB_REALM}.quickbase.com`,
+          "Content-Type": "application/json",
+        }),
+        credentials: "include",
+      })
+    );
+    expect(mockFetch).toHaveBeenNthCalledWith(
+      2,
+      `https://api.quickbase.com/v1/fields/${fieldId}?tableId=${tableId}`,
+      expect.objectContaining({
+        method: "POST",
+        headers: expect.objectContaining({
+          "QB-Realm-Hostname": `${QB_REALM}.quickbase.com`,
+          Authorization: "QB-TEMP-TOKEN temp_token",
+          "Content-Type": "application/json",
+        }),
+        body: JSON.stringify(request),
+        credentials: "omit",
+      })
+    );
+  });
+
+  it("handles 400 error for invalid field update", async () => {
+    client = createClient(mockFetch, {
+      realm: QB_REALM,
+      userToken: QB_USER_TOKEN,
+      debug: true,
+    });
+
+    const tableId = QB_TABLE_ID_1;
+    const fieldId = 999;
+
+    const request: UpdateFieldRequest = {
+      label: "InvalidField",
+      // fieldType omitted as it’s not allowed in updates
+      required: true,
+      properties: {
+        numLines: 1,
+        decimalPlaces: 2,
+        currencySymbol: "$",
+      },
+    };
+
+    mockFetch.mockResolvedValueOnce({
+      ok: false,
+      status: 400,
+      json: () => Promise.resolve({ message: "Invalid field ID" }),
+    });
+
+    await expect(
+      client.updateField({ fieldId, tableId, body: request })
+    ).rejects.toThrow("API Error: Invalid field ID (Status: 400)");
+
+    expect(mockFetch).toHaveBeenCalledWith(
+      `https://api.quickbase.com/v1/fields/${fieldId}?tableId=${tableId}`,
+      expect.objectContaining({
+        method: "POST",
+        headers: expect.objectContaining({
+          "QB-Realm-Hostname": `${QB_REALM}.quickbase.com`,
+          Authorization: `QB-USER-TOKEN ${QB_USER_TOKEN}`,
+          "Content-Type": "application/json",
+        }),
+        body: JSON.stringify(request),
+        credentials: "omit",
+      })
+    );
+  });
+});