querysub 0.610.0 → 0.611.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "querysub",
-  "version": "0.610.0",
+  "version": "0.611.0",
   "main": "index.js",
   "license": "MIT",
   "note1": "note on node-forge fork, see https://github.com/digitalbazaar/forge/issues/744 for details",

package/src/-f-node-discovery/NodeDiscovery.ts

@@ -24,7 +24,7 @@ import { logDisk } from "../diagnostics/logs/diskLogger";
 import { MaybePromise } from "socket-function/src/types";
 import { getPathStr2 } from "../path";
 
-let HEARTBEAT_INTERVAL = timeInMinute * 5;
+let HEARTBEAT_INTERVAL = timeInMinute * 1;
 // Interval which we check other heartbeats
 let CHECK_INTERVAL = HEARTBEAT_INTERVAL;
 // If the heartbeat is older than thing, it fails the dead check
@@ -34,7 +34,7 @@ let DEAD_THRESHOLD = HEARTBEAT_INTERVAL * 2;
 let DEAD_CHECK_COUNT = 4;
 // If we find we are unable to write our heartbeat, we have to kill our own process. Otherwise it may
 //  be too out of sync, and might commit unverified data to the disk.
-let SUICIDE_HEARTBEAT_THRESHOLD = HEARTBEAT_INTERVAL * 4;
+let SUICIDE_HEARTBEAT_THRESHOLD = Math.max(timeInMinute * 10, HEARTBEAT_INTERVAL * 4);
 
 let CLIENTSIDE_POLL_RATE = timeInMinute * 30;
 
@@ -56,6 +56,7 @@ let DEAD_NODE_POLL_COOLDOWN = timeInMinute * 5;
 
 let shutdown = false;
 
+// NOTE: It's not really required to use buffered archives for this. Previously, our heartbeat interval was five minutes and we could raise it again to five minutes. However, keeping it fast means that if our buffered archives has bugs, we'll notice it pretty quickly because if files disappear, for example, if our node discovery file disappears, processes will terminate themselves, which makes it really obvious that there's a problem, and files should never disappear. So it's kind of a canary to say, hey, there's something wrong with our storage, we need to fix it. Even if one node goes away, its writes should have already been propagated. 
 const archives = lazy(() => getArchives2Buffered("nodes/"));
 
 let logging = true;