querysub 0.516.0 → 0.518.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "querysub",
-  "version": "0.516.0",
+  "version": "0.518.0",
   "main": "index.js",
   "license": "MIT",
   "note1": "note on node-forge fork, see https://github.com/digitalbazaar/forge/issues/744 for details",

package/src/4-deploy/edgeBootstrap.ts

@@ -475,6 +475,15 @@ async function edgeNodeFunction(config: {
         // The url override wins over everything (including the IP domain default). If the host isn't in the list, it is ignored.
         {
             let overrideHost = new URL(document.location.href).searchParams.get("edgenode");
+            if (overrideHost) {
+                // The URLParam system rewrites search params JSON encoded (strings get quotation marks), so decode the same way it does
+                try {
+                    let parsed = JSON.parse(overrideHost);
+                    if (typeof parsed === "string") {
+                        overrideHost = parsed;
+                    }
+                } catch { }
+            }
             if (overrideHost) {
                 let overrideNode = edgeNodes.find(x => x.host === overrideHost);
                 if (overrideNode) {

package/src/4-querysub/Querysub.ts

@@ -1083,6 +1083,7 @@ export class Querysub {
         let mountPromise = SocketFunction.mount({
             public: isPublic(),
             port,
+            autoForwardPort: true,
             ...await getThreadKeyCert(getDomain()),
         });
 

package/src/4-querysub/QuerysubController.ts

@@ -556,7 +556,8 @@ export class QuerysubControllerBase {
             throw new Error(`Call has no network, so it would never run (no FunctionRunner would pick it up). Call ${debugCallSpec(call)}`);
         }
         // Networks where every function runner is non-public are only usable by super users (they were never meant to receive public traffic, ex, a dev network).
-        if (!isNetworkPublic(call.network) && !await isManagementUser()) {
+        // ALSO, We have to allow calls on the same machine as us, otherwise developers can't log in!
+        if (!isNetworkPublic(call.network) && !(await isManagementUser() || call.callerIP === "127.0.0.1")) {
             throw new Error(`Caller is not a super user, and so cannot add calls on the non-public network "${call.network}". Call ${debugCallSpec(call)}`);
         }
 

package/src/diagnostics/logs/errorNotifications2/ErrorNotificationPage.tsx

@@ -57,7 +57,7 @@ function TicketButton(props: {
 }
 qreact.inline(TicketButton);
 
-let getMatcher = cacheLimited(100, (pattern: string) =>
+export let getMatcher = cacheLimited(100, (pattern: string) =>
     createMatchesPattern(Buffer.from(pattern), false)
 );
 

package/src/diagnostics/logs/errorNotifications2/ErrorWarning.tsx

@@ -4,8 +4,9 @@ import { css } from "typesafecss";
 import { SocketFunction } from "socket-function/SocketFunction";
 import { ATag } from "../../../library-components/ATag";
 import { managementPageURL, showingManagementURL } from "../../managementPages";
-import { LogDatumRenderer } from "./ErrorNotificationPage";
+import { getMatcher, LogDatumRenderer } from "./ErrorNotificationPage";
 import { getErrorNotificationsManager } from "./errorWatcher";
+import { LogDatum } from "../diskLogger";
 import { TicketsController } from "../errorTickets/tickets";
 import { STATE_HUES, ticketFilterURL } from "../errorTickets/TicketPage";
 import { isTicketFinished, TicketState, TICKET_STATES } from "../errorTickets/ticketTypes";
@@ -49,9 +50,21 @@ export class ErrorWarning extends qreact.Component {
     render() {
         let ticketCounts = this.renderTicketCounts();
 
+        // Errors that already have a ticket in an open (not finished) state are hidden here — there's no point telling the user about a bug that is already under investigation
+        let openTicketPatterns: string[] = [];
+        for (let ticket of TicketsController(SocketFunction.browserNodeId()).getTickets() || []) {
+            if (isTicketFinished(ticket.state)) continue;
+            if (!ticket.suppressionPattern) continue;
+            openTicketPatterns.push(ticket.suppressionPattern);
+        }
+        const isCoveredByOpenTicket = (datum: LogDatum) => {
+            let errorBuffer = Buffer.from(JSON.stringify(datum));
+            return openTicketPatterns.some(pattern => getMatcher(pattern)(errorBuffer));
+        };
+
         let errorWarning: preact.ComponentChild = undefined;
-        if (!this.manager.state.isLoading && this.manager.state.unmatchedErrors.length > 0) {
-            let firstError = this.manager.state.unmatchedErrors[0];
+        let firstError = !this.manager.state.isLoading && this.manager.state.unmatchedErrors.find(x => !isCoveredByOpenTicket(x)) || undefined;
+        if (firstError) {
             errorWarning = <div className={css.hbox(4).alignItems("start").hsl(0, 0, 90).bord2(0, 0, 85).pad2(4, 2).hslcolor(0, 0, 0)}>
                 <ATag className={css.paddingTop(5).flexShrink0} values={[
                     showingManagementURL.getOverride(true),

package/src/diagnostics/managementPages.tsx

@@ -80,6 +80,23 @@ export async function registerManagementPages2(config: {
     let inputPages: typeof config.pages = [];
 
 
+    inputPages.push({
+        title: "Routing Table",
+        componentName: "AuthoritySpecPage",
+        controllerName: "AuthoritySpecPageController",
+        getModule: () => import("./misc-pages/AuthoritySpecPage"),
+    });
+    inputPages.push({
+        title: "LOG VIEWER",
+        componentName: "LogViewer3",
+        getModule: () => import("./logs/IndexedLogs/LogViewer3"),
+    });
+    inputPages.push({
+        title: "Tickets",
+        componentName: "TicketPage",
+        controllerName: "",
+        getModule: () => import("./logs/errorTickets/TicketPage"),
+    });
     // IMPORTANT! The controller name has to be the name of the controller in the file. No human would just randomly put some junk there, but the AI keeps putting random junk there and being surprised when they get an error because that controller doesn't actually exist in that file.
     inputPages.push({
         title: "Machines",
@@ -111,12 +128,6 @@ export async function registerManagementPages2(config: {
         controllerName: "SnapshotViewerController",
         getModule: () => import("./misc-pages/SnapshotViewer"),
     });
-    inputPages.push({
-        title: "Routing Table",
-        componentName: "AuthoritySpecPage",
-        controllerName: "AuthoritySpecPageController",
-        getModule: () => import("./misc-pages/AuthoritySpecPage"),
-    });
     inputPages.push({
         title: "DNS",
         componentName: "DNSPage",
@@ -134,11 +145,6 @@ export async function registerManagementPages2(config: {
         componentName: "FunctionCaptureAnalyzePage",
         getModule: () => import("./misc-pages/FunctionCaptureAnalyzePage"),
     });
-    inputPages.push({
-        title: "LOG VIEWER",
-        componentName: "LogViewer3",
-        getModule: () => import("./logs/IndexedLogs/LogViewer3"),
-    });
     // It's really sad to comment out the life cycles page, but I'm just never going to use it, it's just too slow and too annoying. It's easier to get the AI to search stuff. 
     // inputPages.push({
     //     title: "Life Cycles",
@@ -152,12 +158,7 @@ export async function registerManagementPages2(config: {
         controllerName: "",
         getModule: () => import("./logs/errorNotifications2/ErrorNotificationPage"),
     });
-    inputPages.push({
-        title: "Tickets",
-        componentName: "TicketPage",
-        controllerName: "",
-        getModule: () => import("./logs/errorTickets/TicketPage"),
-    });
+
     // NOTE: Even if we never use this, it is needed if a server or site is bootstrapping. However, they should probably include this in their own header dynamically as well. 
     inputPages.push({
         title: "Security",

package/src/library-components/EdgeNodeSelector.tsx

@@ -11,18 +11,27 @@ const EDGE_NODE_URL_PARAM = "edgenode";
 /** A dropdown showing all the edge nodes the bootstrapper had to pick from (with their probed latencies), which one we booted from, and allowing forcing a specific edge node. Forcing sets a url parameter and refreshes the page, as the edge node is used by the bootstrapper, so it can only apply on a fresh page load. Super users only. */
 export class EdgeNodeSelector extends qreact.Component<{}> {
     render() {
-        if (!isCurrentUserSuperUser()) return undefined;
+        if (!(isCurrentUserSuperUser() || location.hostname.startsWith("127-0-0-1"))) return undefined;
         // The stats are a plain global the bootstrapper updates as its probes finish, so we re-read them every second
         Querysub.nowDelayed(timeInSecond);
         let stats = globalThis.EDGE_NODE_STATS;
         const booted = (globalThis as any).BOOTED_EDGE_NODE as EdgeNodeConfig | undefined;
         if (!booted) return undefined;
+        // The URLParam system rewrites search params JSON encoded (strings get quotation marks), so read/write the same way it does
         let forced = new URL(document.location.href).searchParams.get(EDGE_NODE_URL_PARAM) || "";
+        if (forced) {
+            try {
+                let parsed = JSON.parse(forced);
+                if (typeof parsed === "string") {
+                    forced = parsed;
+                }
+            } catch { }
+        }
 
         const setEdgeNode = (host: string) => {
             let url = new URL(document.location.href);
             if (host) {
-                url.searchParams.set(EDGE_NODE_URL_PARAM, host);
+                url.searchParams.set(EDGE_NODE_URL_PARAM, JSON.stringify(host));
             } else {
                 url.searchParams.delete(EDGE_NODE_URL_PARAM);
             }

package/src/library-components/NetworkSelector.tsx

@@ -7,7 +7,7 @@ import { forcedNetworkURL, getAutoSelectedNetwork, getNetworkSelectionInfos, get
 /** A dropdown showing all the function runner networks, which one our function calls are being put on, and allowing forcing a specific network (and unforcing it, going back to the automatic selection). Super users only. */
 export class NetworkSelector extends qreact.Component<{}> {
     render() {
-        if (!isCurrentUserSuperUser()) return undefined;
+        if (!(isCurrentUserSuperUser() || location.hostname.startsWith("127-0-0-1"))) return undefined;
         let infos = getNetworkSelectionInfos();
         let forced = forcedNetworkURL.value;
         let selected = getSelectedNetwork({ noThrow: true });