querysub 0.463.0 → 0.465.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "querysub",
-  "version": "0.463.0",
+  "version": "0.465.0",
   "main": "index.js",
   "license": "MIT",
   "note1": "note on node-forge fork, see https://github.com/digitalbazaar/forge/issues/744 for details",

package/src/1-path-client/RemoteWatcher.ts

@@ -693,7 +693,8 @@ registerGetSpecForChildPath(path => {
 
         if (!remoteWatcher.hasAnyDirectPathWatches(path)) {
             // NOTE: This might mean that our Path Watcher and remote watcher are out of sync, which is a big problem and will break things. 
-            console.error(`We do not own a path, but also aren't watching it on a remote, but... receive the value? This is weird, and will probably break things (we will likely ignore this value / not trigger parent watches for it).`, { path });
+            // NOTE: Actually... this probably just means the real authority JUST disconnected, and we still had some trailing reads.
+            console.warn(`We do not own a path, but also aren't watching it on a remote, but... we received the value? This is weird, and will probably break things (we will likely ignore this value / not trigger parent watches for it).`, { path });
         }
     }
     return authorityLookup.getOurSpec();

package/src/diagnostics/FunctionCallInfoState.ts

@@ -89,7 +89,7 @@ export let ensureSubscribed = lazy(() => {
         }
         if (data.result.totalInternalLoopCount > 2) {
             statsData.callsWithCascadingRuns++;
-            statsData.totalInternalRerunsForCascading += data.result.totalInternalLoopCount;
+            statsData.totalInternalRerunsForCascading += data.result.totalInternalLoopCount - 1;
             if (data.result.totalInternalLoopCount > statsData.maxInternalReruns) {
                 statsData.maxInternalReruns = data.result.totalInternalLoopCount;
             }
@@ -116,8 +116,8 @@ export let ensureSubscribed = lazy(() => {
 
         let fnStats = statsData.perFunctionStats[data.functionId];
         fnStats.totalCalls++;
-        fnStats.totalInternalReruns += data.result.totalInternalLoopCount;
-        fnStats.totalFullReruns += data.result.outerLoopCount;
+        fnStats.totalInternalReruns += data.result.totalInternalLoopCount - 1;
+        fnStats.totalFullReruns += data.result.outerLoopCount - 1;
         addToStatsValue(fnStats.evalTimeStats, data.result.evalTime);
         addToStatsValue(fnStats.timeTakenStats, data.result.timeTaken);
         addToStatsValue(fnStats.totalTimeStats, data.result.totalTime);
@@ -127,7 +127,7 @@ export let ensureSubscribed = lazy(() => {
         }
         if (data.result.totalInternalLoopCount > 2) {
             fnStats.callsWithCascadingRuns++;
-            fnStats.totalInternalRerunsForCascading += data.result.totalInternalLoopCount;
+            fnStats.totalInternalRerunsForCascading += data.result.totalInternalLoopCount - 1;
             if (data.result.totalInternalLoopCount > fnStats.maxInternalReruns) {
                 fnStats.maxInternalReruns = data.result.totalInternalLoopCount;
             }

package/src/diagnostics/statsDefinitions.tsx

@@ -142,22 +142,22 @@ export function getQuerysubStatsSync(): StatDefinition[] {
             getFnValue: fn => fn.totalCalls,
         }),
         makeCallStatSync({
-            perFn, category: "Calls", title: "Rejected calls (full reruns)", emoji: "⚠️",
+            perFn, category: "Calls", title: "Rejected reruns", emoji: "⚠️",
             threshold: 10,
-            getFnValue: fn => fn.totalFullReruns - fn.totalCalls,
+            getFnValue: fn => fn.totalFullReruns,
         }),
         makeCallStatSync({
-            perFn, category: "Calls", title: "Total internal reruns", emoji: "♻️",
+            perFn, category: "Calls", title: "Rerun to sync data", emoji: "♻️",
             threshold: 10,
-            getFnValue: fn => fn.totalInternalReruns - fn.totalCalls,
+            getFnValue: fn => fn.totalInternalReruns,
         }),
         makeCallStatSync({
-            perFn, category: "Calls", title: "Calls with multiple internal runs", emoji: "🔦",
+            perFn, category: "Calls", title: "Calls with multiple resyncs", emoji: "🔦",
             threshold: 10,
             getFnValue: fn => fn.callsWithMultipleInternalRuns,
         }),
         makeCallStatSync({
-            perFn, category: "Calls", title: "Calls needing cascading syncing", emoji: "📈",
+            perFn, category: "Calls", title: "Calls with multiple rejections", emoji: "📈",
             threshold: 10,
             getFnValue: fn => fn.callsWithCascadingRuns,
         }),