querysub 0.413.0 → 0.415.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "querysub",
-  "version": "0.413.0",
+  "version": "0.415.0",
   "main": "index.js",
   "license": "MIT",
   "note1": "note on node-forge fork, see https://github.com/digitalbazaar/forge/issues/744 for details",

package/src/-c-identity/IdentityController.ts

@@ -19,6 +19,10 @@ import { waitForFirstTimeSync } from "socket-function/time/trueTimeShim";
 import { red } from "socket-function/src/formatting/logColors";
 import { isNode } from "typesafecss";
 import { areNodeIdsEqual, getOwnNodeId, getOwnThreadId } from "../-f-node-discovery/NodeDiscovery";
+import { timeInMinute } from "socket-function/src/misc";
+
+// NOTE: This used to be small, but we cache this, so it would mean a node on startup would time out, and then we would refuse to talk to it ever again. So... this can't be small
+const MAX_CHANGE_IDENTITY_TIMEOUT = timeInMinute * 5;
 
 let callerInfo = new Map<CallerContext, {
     reconnectNodeId: string | undefined;
@@ -130,7 +134,7 @@ class IdentityControllerBase {
         let time = Date.now();
         const caller = SocketFunction.getCaller();
         // Verify it wasn't signed too long ago (to make signature stealing WAY more difficult).
-        const signedThreshold = Date.now() - 1000 * 30;
+        const signedThreshold = Date.now() - MAX_CHANGE_IDENTITY_TIMEOUT;
         if (payload.time < signedThreshold) {
             throw new Error(`Signed payload too old, ${payload.time} < ${signedThreshold} from ${caller.localNodeId} (${caller.nodeId})`);
         }
@@ -235,8 +239,7 @@ const changeIdentityOnce = cacheWeak(async function changeIdentityOnce(connectio
     };
     let signature = sign(threadKeyCert, payload);
     await timeoutToError(
-        // NOTE: This timeout has to be small as if we try to connect to a node to send it something time sensitive such as a PathValue and it takes too long it might result in us having a PathValue which is expired. The threshold is around 60 seconds and so we want to build a timeout calling a few different nodes before the PathValue expires. 
-        10 * 1000,
+        MAX_CHANGE_IDENTITY_TIMEOUT,
         IdentityController.nodes[nodeId].changeIdentity(signature, payload),
         () => new Error(`Timeout calling changeIdentity for ${nodeId}`)
     );

package/tempnotes.txt

@@ -1,5 +1,37 @@
 
-Alright, well, looks like the writes aren't working. It's not sending it to the server at least. Or at least the server isn't receiving it. 
+
+Local CYOA + Local FunctionRunner works
+
+
+Wait... Didn't we restart everything? Why does it seem like the function runner is still watching the same things? 
+    "00020e3a3b543382.a794fbcf7b104c68.querysubtest.com:37381"
+
+
+
+Hmm... we ask to watch it, but the watch doesn't show up on the other side? Fuck...
+
+Hmm, it's still failing in the same way. The function runner just has, like, no watches. It tried to watch I assume the same thing as before. Nothing showed up on the other end. 
+
+
+
+
+So we have the remote watcher, so it looks like we were watching it, but we don't think it's synced, so we clearly didn't get a value back. 
+
+WATCHER FAILED TO SYNC findFunctionsToCall DID NOT RECEIVE PATH VALUES. This means PathValueServer is not responding to watches, either to specific paths, or for all paths [
+  '.,querysubtest._com.,',
+  '.,querysubtest._com.,PathFunctionRunner.,'
+] [ '.,querysubtest._com.,PathFunctionRunner.,' ] [Function: findFunctionsToCall]
+Node list is missing nodes, resyncing node {
+  missingNodes: [ '716181d6570f7b55.a794fbcf7b104c68.querysubtest.com:34689' ],
+
+
+UGH... poking fixed it. WHICH MEANS, we have to break it again, and get into the bad state again!
+    - Ugh...
+
+-1) We got into a bad state where The query sub nodes weren't really listening or it's it th they had zombie watchers that hadn't finished synchronizing, but it wasn't complaining about being able to un to find any any paths. There were no unwatched paths 
+    - It fixed when we poked them. 
+
+0) If it fails after redeploying, disable the server and run everything locally again, as we made a lot of changes, and so it might not even work locally. 
 
 -1) Get a test script that doesn't even use the function runner working. 
 
@@ -12,6 +44,18 @@ Alright, well, looks like the writes aren't working. It's not sending it to the
 1.1) Verify by breaking into our local server that we are receiving values written on the remote server in the local server. 
     - This is extremely important. Without this, we can't run a local server. There's all kinds of issues, but our socket function changes should make this so this just works. 
 
+0) SHARD THE FUNCTION RUNNER!
+    - And secondary sharding for backup...
+    - First shard locally
+    - Test on our sync test page (Otherwise all the writes are going to go to the same function runner anyway, so it's not a good test. 
+
+-2) Errors are not being automatically grouped. 
+    - We are getting notifications though, which is weird. The notifications are supposed to be automatically grouping it. We should probably look at its logs and see why. 
+
+0) We just are constantly "Node list is missing nodes, resyncing node"
+    - We should check the logs. I'm assuming what happened is that at some point some server thought it was the wrong node ID and deleted it?
+    - It's generally the same ones, except new ones get added. 
+
 I think even if we run into some occasional issues, we should just power through and try to fix them later. Because I'm sick of working on the framework...
 
 MONTHLY SUMMARY!